st

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 most recent check-ins

2022-11-11
22:29
90x28 by default Leaf check-in: d60744d617 user: xha tags: trunk, master, origin/split
2022-11-06
17:13
new colorschemes: Qillqaq, Ysgrifennwr, Lex Murphy, Fish & Chips check-in: d29dcbe2a4 user: xha tags: trunk, master, origin/split
15:42
Color switching via <F6>. check-in: 948dc1e7cd user: xha tags: trunk, master, origin/split
14:07
Applied https://st.suckless.org/patches/blinking_cursor/st-blinking_cursor-20211116-2f6e597.diff. check-in: 6aee5f5b37 user: xha tags: trunk, master, origin/split
13:57
Applied https://st.suckless.org/patches/cyclefonts/st-cyclefonts-20220731-baa9357.diff. check-in: da64e29fb9 user: xha tags: trunk, master, origin/split
13:21
ADDED config.h check-in: b2ffdfaca3 user: xha tags: trunk, master, origin/split
13:14
Add an _NET_WM_ICON. check-in: 28090b1ea8 user: xha tags: trunk, master, origin/split
13:05
apply https://st.suckless.org/patches/clipboard/st-clipboard-0.8.3.diff check-in: bd79426670 user: xha tags: trunk, master, origin/split
13:00
Applied patch https://st.suckless.org/patches/bold-is-not-bright/ check-in: 5791c07450 user: xha tags: trunk, master, origin/split
2022-10-25
15:11
fix buffer overflow when handling long composed input To reproduce the issue: " If you already have the multi-key enabled on your system, then add this line to your ~/.XCompose file: [...] <question> <T> <E> <S> <T> <question> : "1234567890123456789012345678901234567890123456789012345678901234567890" " Reported by and an initial patch by Andy Gozas <andy@gozas.me>, thanks! Adapted the patch, for now st (like dmenu) handles a fixed amount of composed characters, or otherwise ignores it. This is done for simplicity sake. check-in: 6da487f9c5 user: hiltjo@codemadness.org tags: trunk, master, origin/split
2022-10-04
17:40
bump version to 0.9 Leaf check-in: 8760a05897 user: hiltjo@codemadness.org tags: trunk, 0.9, origin/split
2022-09-16
21:07
FAQ: document the color emojis crash issue which affected some systems is fixed It is fixed in libXft 2.3.6: https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS check-in: cadd12a7c1 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-08-18
15:14
st: use `void' to indicate an empty parameter list check-in: 02c9d3dec9 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-05-01
16:38
Makefile: add manual path for OpenBSD check-in: e66374e9df user: hiltjo@codemadness.org tags: trunk, origin/split
2022-04-19
09:43
code-golfing: cleanup osc color related code * adds missing function prototype * move xgetcolor() prototype to win.h (that's where all the other x.c func prototype seems to be declared at) * check for snprintf error/truncation * reduces code duplication for osc 10/11/12 * unify osc_color_response() and osc4_color_response() into a single function the latter two was suggested by Quentin Rameau in his patch review on the hackers list. check-in: e7c546d919 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-03-18
11:20
base64_digits: reduce scope, implicit zero, +1 size the array is not accessed outside of base64dec() so it makes sense to limit it's scope to the related function. the static-storage duration of the array is kept intact. this also removes unnecessary explicit zeroing from the start and end of the array. anything that wasn't explicitly zero-ed will now be implicitly zero-ed instead. the validity of the new array can be easily confirmed via running this trivial loop: for (int i = 0; i < 255; ++i) assert(base64_digits[i] == base64_digits_old[i]); lastly, as pointed out by Roberto, the array needs to have 256 elements in order to able access it as any unsigned char as an index; the previous array had 255. however, this array will only be accessed at indexes which are isprint() || '=' (see `base64dec_getc()`), so reducing the size of the array to the highest printable ascii char (127 AFAIK) + 1 might also be a valid strategy. check-in: a89fb5cbc6 user: hiltjo@codemadness.org tags: trunk, origin/split
11:11
avoid potential UB when using isprint() all the ctype.h functions' argument must be representable as an unsigned char or as EOF, otherwise the behavior is undefined. check-in: 07eb388496 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-03-13
09:45
make underlines and strikethroughs respect `chscale` check-in: 28a5207a8d user: hiltjo@codemadness.org tags: trunk, origin/split
2022-02-18
12:03
Delay redrawals on palette changes Build on auto-sync and only mark window dirty on palette changes and let the event handler do the actual draw. check-in: aeb06138d0 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-01-12
08:44
X10/SGR mouse: use alt as meta key instead of super/windows key check-in: 1773de3f93 user: hiltjo@codemadness.org tags: trunk, origin/split
2022-01-10
16:11
LICENSE: bump year check-in: 0d49f07599 user: hiltjo@codemadness.org tags: trunk, origin/split
16:04
Fix mousereport This patch replaces the previous one I sent. The following changes are made in this patch: - Fix tracking of pressed buttons. Previously, pressing two buttons and then releasing one would make st think no buttons are pressed, which in particular broke MODE_MOUSEMOTION. - Always send the lowest-numbered pressed button on motion events; when no button is pressed for a motion event in MODE_MOUSEMANY, then send a release. This matches the behaviour of xterm. (Previously, st sent the most recently pressed button in the motion report.) - Remove UB (?) access to potentially inactive struct member e->xbutton.button of XEvent union. - Fix (unlikely) possibility of overflow for large button numbers. The one discrepancy I found between st and xterm is that xterm sometimes encodes buttons with large numbers (>5) strangely. E.g., xterm reports presses of buttons 8 and 9 as releases, whereas st properly (?) encodes them as presses. check-in: 9e348945bd user: hiltjo@codemadness.org tags: trunk, origin/split
2022-01-07
11:39
bump version to 0.8.5 check-in: fcaa8036e7 user: hiltjo@codemadness.org tags: trunk, origin/split, 0.8.5
2022-01-02
11:16
FAQ: fix a typo, patch -> path check-in: afccc25087 user: hiltjo@codemadness.org tags: trunk, origin/split
2021-12-30
17:37
Fix overtyping wide characters. Overtyping the first half of a wide character with the second half of a wide character results in display garbage. This is because the trailing dummy is not cleaned up. i.e. ATTR_WIDE, ATTR_WDUMMY, ATTR_WDUMMY Here is a short script for demonstrating the behavior: #!/bin/sh alias printf=/usr/bin/printf printf こんにちは!; sleep 2 printf '\x1b[5D'; sleep 2 printf へ; sleep 2 printf ' '; sleep 2 echo check-in: f678fab79e user: hiltjo@codemadness.org tags: trunk, origin/split
2021-12-27
12:07
Fix null pointer access in strhandle According to the spec the argument is optional for 104, so p can be NULL as can be tested with printf '\x1b]104\x07'. This is a regression of 8e31030. check-in: 5ed142b2e9 user: hiltjo@codemadness.org tags: trunk, origin/split
2021-12-26
18:00
follow-up fix for OSC color sequences, return Otherwise the message "erresc: unknown str" is printed. check-in: 824db6c1bf user: hiltjo@codemadness.org tags: trunk, origin/split
17:57
Add support for OSC color sequences check-in: 985c12042d user: hiltjo@codemadness.org tags: trunk, origin/split
2021-08-24
11:44
fix possible rare crash when Xutf8TextPropertyToTextList fails from the XmbTextListToTextProperty(3) man page: "If insufficient memory is available for the new value string, the functions return XNoMemory. If the current locale is not supported, the functions return XLocaleNotSupported. In both of these error cases, the functions do not set text_prop_return." Reported by Steffen Nurpmeso <steffen@sdaoden.eu>, thanks! check-in: 828b3da916 user: hiltjo@codemadness.org tags: trunk, origin/split
11:30
fix a problem that the standard streams are unexpectedly closed In the current implementation, the slave PTY (assigned to the variable `s') is always closed after duplicating it to file descriptors of standard streams (0, 1, and 2). However, when the allocated slave PTY `s' is already one of 0, 1, or 2, this causes unexpected closing of a standard stream. The same problem occurs when the file descriptor of the master PTY (the variable `m') is one of 0, 1, or 2. In this patch, the original master PTY (m) is closed before it would be overwritten by duplicated slave PTYs. The original slave PTY (s) is closed only when it is not one of the stanrad streams. check-in: 4d923a1977 user: hiltjo@codemadness.org tags: trunk, origin/split
2021-07-18
09:44
Add 14th bit to XK_SWITCH_MOD bitmask The bits of uint signal in an XKeyEvent which concern the key group (keyboard layout) are bits 13 and 14, as documented here: https://www.x.org/releases/X11R7.7/doc/libX11/XKB/xkblib.html#Groups_and_Shift_Levels In the older version, only bit 13 was marked as part of XK_SWITCH_MOD, this causes issues for users who have more than two keymaps. the 14th bit is not in ignoremod, key sequences are not caught by match(), if they switch to a third or fourth keyboard. check-in: 7bcdbd7dc4 user: hiltjo@codemadness.org tags: trunk, origin/split
2021-05-06
16:21
Mild const-correctness improvements. Only touch a few things, the main focus is to improve code readability. check-in: a1fa007056 user: hiltjo@codemadness.org tags: trunk, origin/split
2021-03-19
10:58
fix: correctly encode mouse buttons >= 8 in X10 and SGR mode These are typically mapped in X11 to the side-buttons (backward/forwards) on the mouse. A comparison of the button numbers in SGR mode (first field): st old: 0 1 2 64 65 66 67 68 69 70 st new (it is the same as xterm now): 0 1 2 64 65 66 67 128 129 130 A script to test and reproduce it, first argument is "h" (on) or "l" (off): #!/bin/sh printf '\x1b[?1000%s\x1b[?1006%s' "$1" "$1" for n in 1 2 3 4 5 6 7 8 9 10; do printf 'button %d\n' "$n" xdotool click "$n" printf '\n\n' done check-in: 43b2115b40 user: hiltjo@codemadness.org tags: trunk, origin/split
2020-10-18
09:18
remove unused variable from previous patch check-in: c2a2cf047d user: hiltjo@codemadness.org tags: trunk, origin/split
09:17
ST: Add WM_ICON_NAME property support Also added _NET_WM_ICON_NAME. check-in: 7bdcd56431 user: hiltjo@codemadness.org tags: trunk, origin/split
2020-06-19
09:27
bump version to 0.8.4 check-in: 4f8cb4b629 user: hiltjo@codemadness.org tags: trunk, origin/split, 0.8.4
2020-06-17
21:49
config.mk: use PKG_CONFIG in commented OpenBSD section check-in: 8e2f9f3c9b user: hiltjo@codemadness.org tags: trunk, origin/split
21:49
LICENSE: bump years check-in: 7e34023663 user: hiltjo@codemadness.org tags: trunk, origin/split
21:49
remove sixel stub code Remove stub code that was used for an experiment of adding sixel code to st from the commit f7398434. check-in: 4eb6efed09 user: hiltjo@codemadness.org tags: trunk, origin/split
19:35
fix unicode glitch in DCS strings, patch by Tim Allen Reported on the mailinglist: " I discovered recently that if an application running inside st tries to send a DCS string, subsequent Unicode characters get messed up. For example, consider the following test-case: printf '\303\277\033P\033\\\303\277' ...where: - \303\277 is the UTF-8 encoding of U+00FF LATIN SMALL LETTER Y WITH DIAERESIS (ÿ). - \033P is ESC P, the token that begins a DCS string. - \033\\ is ESC \, a token that ends a DCS string. - \303\277 is the same ÿ character again. If I run the above command in a VTE-based terminal, or xterm, or QTerminal, or pterm (PuTTY), I get the output: ÿÿ ...which is to say, the empty DCS string is ignored. However, if I run that command inside st (as of commit 9ba7ecf), I get: ÿÿ ...where those last two characters are \303\277 interpreted as ISO8859-1 characters, instead of UTF-8. I spent some time tracing through the state machines in st.c, and so far as I can tell, this is how it works currently: - ESC P sets the "ESC_DCS" and "ESC_STR" flags, indicating that incoming bytes should be collected into the strescseq buffer, rather than being interpreted. - ESC \ sets the "ESC_STR_END" flag (when ESC is received), and then calls strhandle() (when \ is received) to interpret the collected bytes. - If the collected bytes begin with 'P' (i.e. if this was a DCS string) strhandle() sets the "ESC_DCS" flag again, confusing the state machine. If my understanding is correct, fixing the problem should be as easy as removing the line that sets ESC_DCS from strhandle(): diff --git a/st.c b/st.c index ef8abd5..b5b805a 100644 --- a/st.c +++ b/st.c @@ -1897,7 +1897,6 @@ strhandle(void) xsettitle(strescseq.args[0]); return; case 'P': /* DCS -- Device Control String */ - term.mode |= ESC_DCS; case '_': /* APC -- Application Program Command */ case '^': /* PM -- Privacy Message */ return; I've tried the above patch and it fixes my problem, but I don't know if it introduces any others. " check-in: f68072c721 user: hiltjo@codemadness.org tags: trunk, origin/split
2020-06-01
12:09
FAQ: fix single-buffer patch rebase against master check-in: 468ffcf638 user: hiltjo@codemadness.org tags: trunk, origin/split
2020-05-30
20:06
config.def.h: add an option allowwindowops, by default off (secure) Similar to the xterm AllowWindowOps option, this is an option to allow or disallow certain (non-interactive) operations that can be insecure or exploited. NOTE: xsettitle() is not guarded by this because st does not support printing the window title. Else this could be exploitable (arbitrary code execution). Similar problems have been found in the past in other terminal emulators. The sequence for base64-encoded clipboard copy is now guarded because it allows a sequence written to the terminal to manipulate the clipboard of the running user non-interactively, for example: printf '\x1b]52;0;ZWNobyBoaQ0=\a' check-in: a7ffd00bbf user: hiltjo@codemadness.org tags: trunk, origin/split
20:05
FAQ: add some details about the w3m img hack ... and an example patch to switch from double-buffering to a single buffer. check-in: bb08ef34f7 user: hiltjo@codemadness.org tags: trunk, origin/split
20:05
tiny style fix check-in: 20fe072861 user: hiltjo@codemadness.org tags: trunk, origin/split
20:04
Partially add back in "support REP (repeat) escape sequence" Add the functionality back in for xterm compatibility, but do not expose the capability in st.info (yet). Some notes: It was reverted because it caused some issues with ncurses in some configurations, namely when using BSD padding (--enable-bsdpad, BSD_TPUTS) in ncurses it caused issues with repeating digits. A fix has been upstreamed in ncurses since snapshot 20200523. The fix is also backported to OpenBSD -current. check-in: 1251605abd user: hiltjo@codemadness.org tags: trunk, origin/split
2020-05-24
11:45
Call xsetcursor to set win.cursor in main In xsetcursor, remove "DEFAULT(cursor, 1)" because 0 is a valid value. Increase max allowed value of cursor from 6 to 7 (st extension). check-in: f4b9e3c290 user: hiltjo@codemadness.org tags: trunk, origin/split
2020-05-16
19:06
Revert "support REP (repeat) escape sequence" This reverts commit e8392b282c2eaa28725241a9612804fb55113da4. There is currently a bug in older ncurses versions (like on OpenBSD) where a fix for a bug with REP is not backported yet. Most likely in tty/tty_update.c: Noticed while using lynx (which uses ncurses/curses). To reproduce using lynx: echo "Z0000000" | lynx -stdin or using the program: int main(void) { WINDOW *win; win = initscr(); printw("Z0000000"); refresh(); sleep(5); return 0; } This prints "ZZZZZZZ" (incorrectly). check-in: b6493b97ed user: hiltjo@codemadness.org tags: trunk, origin/split
12:08
support REP (repeat) escape sequence The sequence \e[Nb prints the last printed char N (more) times if it's printable, and it's ignored after newline or other control chars. This is Ecma-048/ANSI-X3.6 sequence and not DEC VT. It's supported by xterm, and ncurses uses it when possible, e.g. when TERM is xterm* (and with this commit also st*). xterm supports only codepoints<=255, possibly due to internal limits. We support any value/codepoint which was placed in a cell. To test: - tput rep 65 4 -> prints 'AAAA' - printf "\342\225\246\033[4b" -> prints U+2566 1+4 times. check-in: 41fd4ee033 user: hiltjo@codemadness.org tags: trunk, origin/split
12:07
Add rin terminfo capability Tianlin Qu discovered that st is missing rin (scroll back #1 lines). check-in: ffee53c6e0 user: hiltjo@codemadness.org tags: trunk, origin/split
10:37
Make shift+wheel behaves as shift+Prev/Next St uses a very good hack where mouse wheel genereates ^Y and ^E, that are the same keys that less and vi uses for backward and fordward scrolling. Scroll, as many terminal emulators, use shift+Prev/Next for scrolling, but it is also using ^E and ^Y for scroling, characters that are reserved in the POSIX shell in emacs mode for end of line and yanking, making scroll unsable in st. This patch adds a new hack, making shift+wheel returning the same sequences than shift+Prev/Next, meaning that scroll or any other similar program will not be able to differentiate between them. check-in: 7df6d552eb user: hiltjo@codemadness.org tags: trunk, origin/split