Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
92 check-ins using file build_MTGProxyPrinter_packages.bat version 5d769b4af5
|
2026-03-25
| ||
| 14:37 | Remove bool() calls where booleans are now automatically converted from int via the registered sqlite converter for BOOLEAN_INTEGER columns. Leaf check-in: 87d375965c user: thomas tags: refactor_card_database_schema | |
|
2026-03-24
| ||
| 22:50 | CardDatabase: Fix is_valid_and_unique_card() and add note that this isn't covered by unit tests check-in: 38da84de54 user: thomas tags: refactor_card_database_schema | |
| 22:33 | CardDatabase: Port get_all_cards_from_image_cache() check-in: 6f1fef792c user: thomas tags: refactor_card_database_schema | |
| 22:17 | Revert fiddling with the row_factory within application code. Put a work-around in helpers.py that avoids using sqlite3.Row in the DatabaseImportWorker. Many simple fixes across the test suite. Most tests pass again. check-in: 2afff5dc1b user: thomas tags: refactor_card_database_schema | |
| 10:11 | DatabaseImportWorker: Reset the row_factory of passed_in databases, because the code is incompatible with Row as the factory. Pattern matching code relies on the db returning tuples. check-in: c5c98531f5 user: thomas tags: refactor_card_database_schema | |
| 07:06 | Re-activate test_updates_changed_value_on_re_import test cases disabled during a debugger session. check-in: 6968dc325c user: thomas tags: refactor_card_database_schema | |
|
2026-03-23
| ||
| 21:45 | Tests: Adjust test for is_removed_printing(). New semantics no longer consider a hidden printing to be "removed". check-in: a6ed184920 user: thomas tags: refactor_card_database_schema | |
| 21:36 | CardDatabase: Remove deprecation note and outdated comments in is_dfc(). The method is used by the document loader before Card instances are constructed. check-in: 651875afc6 user: thomas tags: refactor_card_database_schema | |
| 21:20 | Fixed several additional broken locations. Failing tests are down to 30 check-in: f16b5956fa user: thomas tags: refactor_card_database_schema | |
| 21:04 | Database schema: Add the usage_count column to the printing views check-in: 3b0b955bf6 user: thomas tags: refactor_card_database_schema | |
| 20:38 | CardDatabase: Port translate_card_name() check-in: 33d9e4daa3 user: thomas tags: refactor_card_database_schema | |
| 20:14 | CardDatabase: Port guess_language_from_name() and actually fix _read_optional_scalar_from_db() check-in: 8ac00aaace user: thomas tags: refactor_card_database_schema | |
| 20:04 | CardDatabase: Fix _read_optional_scalar_from_db(), which stopped working with sqlite3.Row row factory. check-in: cb6654f650 user: thomas tags: refactor_card_database_schema | |
| 19:45 | CardDatabase: Ported _translate_card() check-in: e8d9728208 user: thomas tags: refactor_card_database_schema | |
| 19:17 | CardDatabase.find_sets_matching: Also read the set icons of found sets check-in: e41e68b11b user: thomas tags: refactor_card_database_schema | |
| 19:15 | CardDatabase: Use sqlite3.Row as the row factory. This allows indexing via column names and avoids brittle tuple unpacking. check-in: f8c0006a83 user: thomas tags: refactor_card_database_schema | |
| 17:05 | PrintCountUpdater: Fixed _update_image_usage() check-in: fab6b8078c user: thomas tags: refactor_card_database_schema | |
| 13:40 | CardInfoDownloader: Micro-optimization: using () instead of tuple() saves 10 ns per invocation, as determined using timeit. With 500k cards, this saves whopping 5ms. check-in: 904d1eb292 user: thomas tags: refactor_card_database_schema | |
| 13:27 | DatabaseImportWorker: Implement updating Card.is_card column, in case the is_card property needs amendments over time check-in: cfefdd14e3 user: thomas tags: refactor_card_database_schema | |
| 13:26 | CardDatabase: Fix get_basic_land_oracle_ids() to properly handle non-cards named like basic lands, like Art-Series cards for basic land artworks. check-in: 190343352a user: thomas tags: refactor_card_database_schema | |
| 12:45 | Add JSON sample for a basic land art series card check-in: 8077181119 user: thomas tags: refactor_card_database_schema | |
| 08:28 | Removed now-unused SetWackinessScore enum check-in: 85725b85fa user: thomas tags: refactor_card_database_schema | |
| 08:02 | DatabaseImportWorker: Unify SQL statement indention style check-in: 309745b488 user: thomas tags: refactor_card_database_schema | |
| 00:04 | DatabaseImportTask: Shave off ~1s execution time during an import by not explicitly verifying that Scryfall only returns syntactically valid UUIDs in UUID fields. check-in: 8cb6a177ad user: thomas tags: refactor_card_database_schema | |
|
2026-03-22
| ||
| 23:17 | scripts/benchmark_card_data_import.py: Update profiled functions check-in: c0e1b8f407 user: thomas tags: refactor_card_database_schema | |
| 22:50 | DatabaseImportWorker: All remaining tests pass. Importing from a card data stream works again. check-in: e164871b4f user: thomas tags: refactor_card_database_schema | |
| 21:42 | Fixed tests for RelatedCards. Removed test_set_wackiness_score, because the tested column was removed. Updated list of database tables checked in assert_model_is_empty(). check-in: 962044f76d user: thomas tags: refactor_card_database_schema | |
| 21:36 | PrintingFilterUpdater: Fixed flip in boolean condition leading to premature aborting the set filter update. This now works correctly. check-in: 5b789f0589 user: thomas tags: refactor_card_database_schema | |
| 20:50 | Database schema: Fixed wrong reference in table FilterAppliesTo. check-in: 6f835fdef2 user: thomas tags: refactor_card_database_schema | |
| 20:37 | DatabaseImportTask: Refactored _get_card_faces(). Now returns a single card face for cards with only one side, even if it has multiple faces. check-in: 0ce3e59d12 user: thomas tags: refactor_card_database_schema | |
| 20:34 | tests/test_printing_filter_updater.py: Ported tests check-in: 19e60d7a91 user: thomas tags: refactor_card_database_schema | |
| 20:33 | tests/helpers.py: Removed asserts checking that the card data import does not emit Qt error signals. check-in: ceb1370a2d user: thomas tags: refactor_card_database_schema | |
| 19:53 | Tests: Adjust face data name extraction to use "Front // Back" for all non-DFC cards with multiple faces. check-in: e60428c082 user: thomas tags: refactor_card_database_schema | |
| 17:47 | Port _assert_visible_printings_contains. First tests start to pass check-in: 587b464867 user: thomas tags: refactor_card_database_schema | |
| 17:33 | Fixed timezone conversion issues in SQL (unixepoch() needs the 'utc' time zone specified to match the Python datetime semantics) and many failures in assert statements check-in: b7c78832cf user: thomas tags: refactor_card_database_schema | |
| 15:33 | Continue porting the tests check-in: d2828ec3b2 user: thomas tags: refactor_card_database_schema | |
| 14:06 | test_card_info_downloader: Removed validation methods for removed database tables check-in: a8605d92c1 user: thomas tags: refactor_card_database_schema | |
| 13:48 | PrintingFilterUpdater: Fixed remaining runtime errors. With this, the importer no longer crashes immediately. check-in: aa77c6faa8 user: thomas tags: refactor_card_database_schema | |
| 13:41 | DatabaseImportTask: Completed port of _insert_or_update_printing_faces(). Removed _clean_unused_data(). check-in: 6780db68d3 user: thomas tags: refactor_card_database_schema | |
| 12:15 | DatabaseImportTask: Partial port of _insert_printing_faces(). Renamed to _insert_or_update_printing_faces(). Removed obsolete _insert_face_name(). check-in: eb9ca469c4 user: thomas tags: refactor_card_database_schema | |
| 08:50 | Rewrite _read_optional_scalar_from_db() to use a match statement. Also now raise a RuntimeError, if the non-NULL query result is not a scalar value. check-in: 2ed5f7ec41 user: thomas tags: refactor_card_database_schema | |
| 08:36 | DatabaseImportTask:._insert_or_update_printing: Also set Printing.is_dfc, instead of using the default value. is_dfc can be trivially computed from the JSON data. check-in: be0fb492a3 user: thomas tags: refactor_card_database_schema | |
|
2026-03-21
| ||
| 22:15 | DatabaseImportTask: Port _update_card_filters(), and rename to _insert_or_update_card_filters. check-in: 5f1daabb75 user: thomas tags: refactor_card_database_schema | |
| 22:00 | Database schema: Re-ordered CREATE statements to match the v34 order, reducing the diff size with trunk. check-in: dbd631b4e3 user: thomas tags: refactor_card_database_schema | |
| 21:48 | PrintingFilterUpdater: Ported the rest of the logic. check-in: 1aae95d90b user: thomas tags: refactor_card_database_schema | |
| 20:19 | PrintingFilterUpdater: Renamed an internal variable check-in: d79a5a6819 user: thomas tags: refactor_card_database_schema | |
| 19:29 | PrintingFilterUpdater: Replace QCoreApplication.translate() with self.tr(). check-in: e3aaa67056 user: thomas tags: refactor_card_database_schema | |
| 19:26 | Database schema: Add missing default value for MTGSet.set_filter_active check-in: 686adb21c6 user: thomas tags: refactor_card_database_schema | |
| 19:18 | DatabaseImportTask: Fixed SQL syntax error in _insert_card() check-in: 82e33ceaff user: thomas tags: refactor_card_database_schema | |
| 19:10 | DatabaseImportTask: Port and refactor _handle_printing(). Replaced _is_printing_present() content with a single query check-in: 957dfb501e user: thomas tags: refactor_card_database_schema | |
| 14:57 | DatabaseImportWorker: Add helper method _read_optional_scalar_from_db, copied from CardDatabase. Use it to fetch scalar query results. check-in: 7cd4e37dc2 user: thomas tags: refactor_card_database_schema | |
| 14:48 | DatabaseImportWorker: Update _insert_set(). check-in: 0bb0957e3b user: thomas tags: refactor_card_database_schema | |
| 14:38 | DatabaseImportWorker: Handle Card.is_card column in _insert_card(). check-in: 3ba9ecc5d9 user: thomas tags: refactor_card_database_schema | |
| 14:24 | DatabaseImportWorker: Removed obsolete _insert_language() check-in: 2f24030990 user: thomas tags: refactor_card_database_schema | |
| 13:59 | Reinstate the RemovedPrintings table. Its purpose is storing valid printings that are unacceptable for semantic reasons and can't be imported. This is distinct from MigratedPrintings, which tracks printings removed or merged by Scryfall check-in: 23cae27ab4 user: thomas tags: refactor_card_database_schema | |
| 13:22 | tests.helpers: Replace functools.lru_cache with cache, and qtbot.assertNotEmitted with qtbot.assert_not_emitted check-in: ff2d96e16f user: thomas tags: refactor_card_database_schema | |
| 13:19 | DB schema: Fix logic and syntax errors. check-in: 5f6a9aaf19 user: thomas tags: refactor_card_database_schema | |
| 12:47 | CardDatabase: Adjust already ported methods for the switch from is_hidden to is_visible. check-in: e13bf8c540 user: thomas tags: refactor_card_database_schema | |
| 12:47 | v35 migration script: Add the Printing.is_dfc column. Re-formats. check-in: 161227a3c7 user: thomas tags: refactor_card_database_schema | |
| 12:06 | DB schema: Fixed Printing.is_visible default value, which should be TRUE. Updated view EvaluatePrintingFilters to also consider MTGSet.set_filter_active. check-in: 685795574d user: thomas tags: refactor_card_database_schema | |
| 10:42 | Add card database model, to be opened with Navicat Data Modeler. Temporarily add a WIP database migration script. Once the schema v35 is finalized and the migrations completed, the steps will be moved into the carddb_migrations module. check-in: d0ddaf42b9 user: thomas tags: refactor_card_database_schema | |
| 09:56 | DB schema: Rename is_hidden to is_visible. Add Printing.is_dfc boolean cache column. Add views EvaluatePrintingFilters, AllPrintings, VisiblePrintings check-in: ff5f4b5c95 user: thomas tags: refactor_card_database_schema | |
|
2026-03-20
| ||
| 23:27 | CardDatabase: Port get_basic_land_oracle_ids check-in: d26af3c8be user: thomas tags: refactor_card_database_schema | |
| 23:27 | Schema: Re-add forgotten collector_number column to Printing. check-in: 8488e57d38 user: thomas tags: refactor_card_database_schema | |
| 18:10 | CardDatabase: Ported two methods to schema 35 check-in: 663c1a001b user: thomas tags: refactor_card_database_schema | |
| 17:23 | DB schema: Rename DisplayFilters to PrintingFilters, and PrintingDisplayFilter to FilterAppliesTo. Add MTGSet.set_filter_active column check-in: ee12dfffb8 user: thomas tags: refactor_card_database_schema | |
| 14:53 | Update schema to support printing migrations via the Scryfall Migrations API. check-in: 09ee0ee0f4 user: thomas tags: refactor_card_database_schema | |
|
2026-03-19
| ||
| 20:28 | Fixed obviously broken things in the database schema that slipped through. check-in: cc5456a3bd user: thomas tags: refactor_card_database_schema | |
| 20:09 | Packaging: Exclude ijson.dump from built Windows packages. The module includes a CLI module that isn't needed when used purely as a library Leaf check-in: 1b10896536 user: thomas tags: trunk | |
| 19:49 | WIP rework of the card database schema. Reduced complexity. Removed some not well working parts, like he wackiness score, which will be replaced by another concept. Currently missing all views and indices. Indices will come back after evaluating performance issues. check-in: 590dbd5446 user: thomas tags: refactor_card_database_schema | |
|
2026-03-14
| ||
| 22:35 | Import changes from trunk Leaf check-in: 7b6d8909d4 user: thomas tags: pyside6_deploy_support | |
| 15:19 | Fixed SegmentationFault in PageRenderer during unit tests using PySide6 >= 6.10.1 check-in: b1c4d3f48d user: thomas tags: trunk | |
| 14:56 | Updated the build system, integrating both cx_Freeze and tox config into pyproject.toml. Fixed project dependencies. Added tox environments verifying compatibility across dependency versions. check-in: 63142ede17 user: thomas tags: trunk | |
| 14:00 | Dependencies: Do not include the hard cap <= 6.10.0 on PySide6 Closed-Leaf check-in: 202c0f19a6 user: thomas tags: repository_cleanup | |
| 13:48 | Fix dependencies: Tests reveal minimum required versions for Pint and PyHamcrest do not match the recorded values, so adjust the dependencies accordingly. check-in: b6780b446f user: thomas tags: repository_cleanup | |
| 12:57 | tox: Ensure that the generate_development_environment does not hold the tests label, so that it is not executed as a unit tests environment check-in: 62a82b7383 user: thomas tags: repository_cleanup | |
| 12:04 | Fix create_development_environment.bat. Because Windows doesn't allow in-place environment replacement, use a temporary bootstrap environment to create the full one with tox. check-in: 64c3828459 user: thomas tags: repository_cleanup | |
| 09:23 | tox: Also do a version sweep for cx_Freeze, ensuring all versions marked as supported generate working builds. check-in: 2f5d87bc87 user: thomas tags: repository_cleanup | |
| 02:09 | tox: Add environment test_cx_freeze_build to the default environment list check-in: 8e58cf6b61 user: thomas tags: repository_cleanup | |
| 02:04 | Remove the now-unused scripts/rebuild_requirements.py script. check-in: 84680b5225 user: thomas tags: repository_cleanup | |
| 02:03 | tox: Integrate project development venv generation. This replaces most of the logic in the create_development_environment scripts with a tox environment run. check-in: 541711060f user: thomas tags: repository_cleanup | |
| 01:35 | pyproject.toml: Use dependency groups instead of installable "extras" to manage packaging and testing dependencies. Since modern tox can read those, this also drops the requirement for requirements.txt generation, thus also drop use of pip-tools. check-in: 7cf6a4c6ff user: thomas tags: repository_cleanup | |
|
2026-03-13
| ||
| 18:57 | tox: Use label "tests" instead of "test". Update the runner scripts to use the label instead of the default environment list check-in: effaffcce9 user: thomas tags: repository_cleanup | |
| 18:52 | Drop support for ijson 3.2.0. Add tox environments testing oldest supported versions for everyting not thoroughly tested. This ensures that minimum version requirements aren't accidentally violated and can be updated when newer functionality is used in the code. check-in: c836b8b1a1 user: thomas tags: repository_cleanup | |
| 13:35 | tox: Add description to the test_cx_freeze_build environment check-in: ddfdbed3d4 user: thomas tags: repository_cleanup | |
| 13:30 | tox: Fixed Qt factors. Names may not contain dots, so use underscores to separate major and minor Qt versions. check-in: a38fc6e90d user: thomas tags: repository_cleanup | |
| 13:10 | tox: Generate some linear dependency version sweeps. The environments get generated, but aren't yet functional. check-in: 1f26e8413f user: thomas tags: repository_cleanup | |
| 10:10 | Import test fix from trunk check-in: b684e08245 user: thomas tags: repository_cleanup | |
| 08:28 | Pass required environment variables to test environments, to prevent crashes in Qt. check-in: c3360f612d user: thomas tags: repository_cleanup | |
| 08:16 | Set minimum required tox version to 4.41, which added package = "deps-only". All prior versions cannot parse the current tox configuration. check-in: 963aff93ff user: thomas tags: repository_cleanup | |
|
2026-03-12
| ||
| 20:01 | Port the cx_Freeze build test tox environment check-in: cf08f4a7cf user: thomas tags: repository_cleanup | |
| 19:16 | Rename packaging environment, update the packaging scripts to use the new names check-in: 57c5fe4e2a user: thomas tags: repository_cleanup | |