Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
50 most recent check-ins
|
2026-03-23
| ||
| 21:45 | Tests: Adjust test for is_removed_printing(). New semantics no longer consider a hidden printing to be "removed". Leaf check-in: a6ed184920 user: thomas tags: refactor_card_database_schema | |
| 21:36 | CardDatabase: Remove deprecation note and outdated comments in is_dfc(). The method is used by the document loader before Card instances are constructed. check-in: 651875afc6 user: thomas tags: refactor_card_database_schema | |
| 21:20 | Fixed several additional broken locations. Failing tests are down to 30 check-in: f16b5956fa user: thomas tags: refactor_card_database_schema | |
| 21:04 | Database schema: Add the usage_count column to the printing views check-in: 3b0b955bf6 user: thomas tags: refactor_card_database_schema | |
| 20:38 | CardDatabase: Port translate_card_name() check-in: 33d9e4daa3 user: thomas tags: refactor_card_database_schema | |
| 20:14 | CardDatabase: Port guess_language_from_name() and actually fix _read_optional_scalar_from_db() check-in: 8ac00aaace user: thomas tags: refactor_card_database_schema | |
| 20:04 | CardDatabase: Fix _read_optional_scalar_from_db(), which stopped working with sqlite3.Row row factory. check-in: cb6654f650 user: thomas tags: refactor_card_database_schema | |
| 19:45 | CardDatabase: Ported _translate_card() check-in: e8d9728208 user: thomas tags: refactor_card_database_schema | |
| 19:17 | CardDatabase.find_sets_matching: Also read the set icons of found sets check-in: e41e68b11b user: thomas tags: refactor_card_database_schema | |
| 19:15 | CardDatabase: Use sqlite3.Row as the row factory. This allows indexing via column names and avoids brittle tuple unpacking. check-in: f8c0006a83 user: thomas tags: refactor_card_database_schema | |
| 17:05 | PrintCountUpdater: Fixed _update_image_usage() check-in: fab6b8078c user: thomas tags: refactor_card_database_schema | |
| 13:40 | CardInfoDownloader: Micro-optimization: using () instead of tuple() saves 10 ns per invocation, as determined using timeit. With 500k cards, this saves whopping 5ms. check-in: 904d1eb292 user: thomas tags: refactor_card_database_schema | |
| 13:27 | DatabaseImportWorker: Implement updating Card.is_card column, in case the is_card property needs amendments over time check-in: cfefdd14e3 user: thomas tags: refactor_card_database_schema | |
| 13:26 | CardDatabase: Fix get_basic_land_oracle_ids() to properly handle non-cards named like basic lands, like Art-Series cards for basic land artworks. check-in: 190343352a user: thomas tags: refactor_card_database_schema | |
| 12:45 | Add JSON sample for a basic land art series card check-in: 8077181119 user: thomas tags: refactor_card_database_schema | |
| 08:28 | Removed now-unused SetWackinessScore enum check-in: 85725b85fa user: thomas tags: refactor_card_database_schema | |
| 08:02 | DatabaseImportWorker: Unify SQL statement indention style check-in: 309745b488 user: thomas tags: refactor_card_database_schema | |
| 00:04 | DatabaseImportTask: Shave off ~1s execution time during an import by not explicitly verifying that Scryfall only returns syntactically valid UUIDs in UUID fields. check-in: 8cb6a177ad user: thomas tags: refactor_card_database_schema | |
|
2026-03-22
| ||
| 23:17 | scripts/benchmark_card_data_import.py: Update profiled functions check-in: c0e1b8f407 user: thomas tags: refactor_card_database_schema | |
| 22:50 | DatabaseImportWorker: All remaining tests pass. Importing from a card data stream works again. check-in: e164871b4f user: thomas tags: refactor_card_database_schema | |
| 21:42 | Fixed tests for RelatedCards. Removed test_set_wackiness_score, because the tested column was removed. Updated list of database tables checked in assert_model_is_empty(). check-in: 962044f76d user: thomas tags: refactor_card_database_schema | |
| 21:36 | PrintingFilterUpdater: Fixed flip in boolean condition leading to premature aborting the set filter update. This now works correctly. check-in: 5b789f0589 user: thomas tags: refactor_card_database_schema | |
| 20:50 | Database schema: Fixed wrong reference in table FilterAppliesTo. check-in: 6f835fdef2 user: thomas tags: refactor_card_database_schema | |
| 20:37 | DatabaseImportTask: Refactored _get_card_faces(). Now returns a single card face for cards with only one side, even if it has multiple faces. check-in: 0ce3e59d12 user: thomas tags: refactor_card_database_schema | |
| 20:34 | tests/test_printing_filter_updater.py: Ported tests check-in: 19e60d7a91 user: thomas tags: refactor_card_database_schema | |
| 20:33 | tests/helpers.py: Removed asserts checking that the card data import does not emit Qt error signals. check-in: ceb1370a2d user: thomas tags: refactor_card_database_schema | |
| 19:53 | Tests: Adjust face data name extraction to use "Front // Back" for all non-DFC cards with multiple faces. check-in: e60428c082 user: thomas tags: refactor_card_database_schema | |
| 17:47 | Port _assert_visible_printings_contains. First tests start to pass check-in: 587b464867 user: thomas tags: refactor_card_database_schema | |
| 17:33 | Fixed timezone conversion issues in SQL (unixepoch() needs the 'utc' time zone specified to match the Python datetime semantics) and many failures in assert statements check-in: b7c78832cf user: thomas tags: refactor_card_database_schema | |
| 15:33 | Continue porting the tests check-in: d2828ec3b2 user: thomas tags: refactor_card_database_schema | |
| 14:06 | test_card_info_downloader: Removed validation methods for removed database tables check-in: a8605d92c1 user: thomas tags: refactor_card_database_schema | |
| 13:48 | PrintingFilterUpdater: Fixed remaining runtime errors. With this, the importer no longer crashes immediately. check-in: aa77c6faa8 user: thomas tags: refactor_card_database_schema | |
| 13:41 | DatabaseImportTask: Completed port of _insert_or_update_printing_faces(). Removed _clean_unused_data(). check-in: 6780db68d3 user: thomas tags: refactor_card_database_schema | |
| 12:15 | DatabaseImportTask: Partial port of _insert_printing_faces(). Renamed to _insert_or_update_printing_faces(). Removed obsolete _insert_face_name(). check-in: eb9ca469c4 user: thomas tags: refactor_card_database_schema | |
| 08:50 | Rewrite _read_optional_scalar_from_db() to use a match statement. Also now raise a RuntimeError, if the non-NULL query result is not a scalar value. check-in: 2ed5f7ec41 user: thomas tags: refactor_card_database_schema | |
| 08:36 | DatabaseImportTask:._insert_or_update_printing: Also set Printing.is_dfc, instead of using the default value. is_dfc can be trivially computed from the JSON data. check-in: be0fb492a3 user: thomas tags: refactor_card_database_schema | |
|
2026-03-21
| ||
| 22:15 | DatabaseImportTask: Port _update_card_filters(), and rename to _insert_or_update_card_filters. check-in: 5f1daabb75 user: thomas tags: refactor_card_database_schema | |
| 22:00 | Database schema: Re-ordered CREATE statements to match the v34 order, reducing the diff size with trunk. check-in: dbd631b4e3 user: thomas tags: refactor_card_database_schema | |
| 21:48 | PrintingFilterUpdater: Ported the rest of the logic. check-in: 1aae95d90b user: thomas tags: refactor_card_database_schema | |
| 20:19 | PrintingFilterUpdater: Renamed an internal variable check-in: d79a5a6819 user: thomas tags: refactor_card_database_schema | |
| 19:29 | PrintingFilterUpdater: Replace QCoreApplication.translate() with self.tr(). check-in: e3aaa67056 user: thomas tags: refactor_card_database_schema | |
| 19:26 | Database schema: Add missing default value for MTGSet.set_filter_active check-in: 686adb21c6 user: thomas tags: refactor_card_database_schema | |
| 19:18 | DatabaseImportTask: Fixed SQL syntax error in _insert_card() check-in: 82e33ceaff user: thomas tags: refactor_card_database_schema | |
| 19:10 | DatabaseImportTask: Port and refactor _handle_printing(). Replaced _is_printing_present() content with a single query check-in: 957dfb501e user: thomas tags: refactor_card_database_schema | |
| 14:57 | DatabaseImportWorker: Add helper method _read_optional_scalar_from_db, copied from CardDatabase. Use it to fetch scalar query results. check-in: 7cd4e37dc2 user: thomas tags: refactor_card_database_schema | |
| 14:48 | DatabaseImportWorker: Update _insert_set(). check-in: 0bb0957e3b user: thomas tags: refactor_card_database_schema | |
| 14:38 | DatabaseImportWorker: Handle Card.is_card column in _insert_card(). check-in: 3ba9ecc5d9 user: thomas tags: refactor_card_database_schema | |
| 14:24 | DatabaseImportWorker: Removed obsolete _insert_language() check-in: 2f24030990 user: thomas tags: refactor_card_database_schema | |
| 13:59 | Reinstate the RemovedPrintings table. Its purpose is storing valid printings that are unacceptable for semantic reasons and can't be imported. This is distinct from MigratedPrintings, which tracks printings removed or merged by Scryfall check-in: 23cae27ab4 user: thomas tags: refactor_card_database_schema | |
| 13:22 | tests.helpers: Replace functools.lru_cache with cache, and qtbot.assertNotEmitted with qtbot.assert_not_emitted check-in: ff2d96e16f user: thomas tags: refactor_card_database_schema | |