Annotate Patch Unified Diff

Differences From Artifact [71b983d8fd]:

  • File src/DocumentList.cxx — part of check-in [e16a83ab4b] at 2019-05-14 09:00:49 on branch refactor — DocumentList: fix potential detachments of `QVector` (user: fifr size: 4402)

To Artifact [8a81539343]:

  • File src/DocumentList.cxx — part of check-in [78d13e155e] at 2019-05-14 09:09:41 on branch refactor — DocumentList: add reference in for loop to prevent copy (user: fifr size: 4403)
︙︙
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46

    QVector<QSharedPointer<Document>> docs;
};

DocumentList::DocumentList(QObject *parent)
    : QAbstractListModel(parent), d(new Data)
{
    auto dir = getDocumentDirectory();
    for (auto path : QDir(dir).entryList(QDir::AllDirs | QDir::NoDotAndDotDot)) {
        QDir docdir = dir;
        docdir.cd(path);
        if (docdir.exists(QStringLiteral("doc.json"))) {
            auto doc = QSharedPointer<Document>(new Document());
            addDocument(doc);
            doc->loadAsync(docdir.filePath(QStringLiteral("doc.json")));
        }








|








32
33
34
35
36
37
38
39
40
41
42
43
44
45
46

    QVector<QSharedPointer<Document>> docs;
};

DocumentList::DocumentList(QObject *parent)
    : QAbstractListModel(parent), d(new Data)
{
    auto dir = getDocumentDirectory();
    for (auto &path : QDir(dir).entryList(QDir::AllDirs | QDir::NoDotAndDotDot)) {
        QDir docdir = dir;
        docdir.cd(path);
        if (docdir.exists(QStringLiteral("doc.json"))) {
            auto doc = QSharedPointer<Document>(new Document());
            addDocument(doc);
            doc->loadAsync(docdir.filePath(QStringLiteral("doc.json")));
        }
︙︙