Starting with [0a74820b6d|this] commit, there's a memory-leak in tclIOCmd.c. Tcl 8.6 and 9.0 are OK.

> I'm still a bit puzzled why my previous merge from core-8-branch did not pick up the change

That's because fossil is not always smart enough to determine what the 'pivot' of the merge should be. This is one of the corner-cases, not worth to discuss here.

apn, your branch didn't receive the fix because after I merged it into core-8-branch, Jan backed it out again.

I've picked your proposed fix which should bring it in sync with the core-8-branch. I'm still a bit puzzled why my previous merge from core-8-branch did not pick up the change. I suppose it's because the "bouncing" of core-8-branch commits made it lose track?

Thanks for picking up on this. I would not have noticed.

/Ashok

Will take a look.

I'm a bit surprised though. Since I later merged core-8-branch again, should not the latest core-8-branch code (with the fix) have "undone" that previous merge that introduced the memory leak?

/Ashok

This memory leak is still present in the tip-656 branch.

Proposed fix: [ff7923a914012c65]

See issue [b8f575aa2398b0e4], for fix.

After I commented out those lines in that block, I should have added a new line to decrement the reference count. Thank you for catching it :)