Timeline
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

153 check-ins using file win/tclWinSerial.c version 2da853a516

2005-10-05
05:01
* tests/http.test: do not URI encode -._~ according * library/http/http.tcl (init): t... check-in: fb1a06961a user: hobbs tags: core-8-4-branch
04:27
* generic/tclIOUtil.c (TclFSNormalizeAbsolutePath): make static * generic/tclEncoding.c (TclFindEn... check-in: b4a6dcda6b user: hobbs tags: core-8-4-branch
04:23
* unix/tclLoadShl.c (TclpDlopen): use DYNAMIC_PATH on second shl_load only. [Bug 1204237] check-in: 6a93f5abfa user: hobbs tags: core-8-4-branch
2005-10-04
18:16
See file. check-in: 80a9933edf user: vasiljevic tags: core-8-4-branch
18:15
Tcl_ClearChannelHandlers(): now deletes any outstanding timer for the channel. Also, prevents events... check-in: 2c5a4e4496 user: vasiljevic tags: core-8-4-branch
18:14
Tcl_ClearChannelHandlers(): bail out early if passed NULL argument check-in: c5a8af47a7 user: vasiljevic tags: core-8-4-branch
2005-09-30
19:28
* generic/tclMain.c: Separate encoding conversion of command line arguments from ... check-in: 365b1366e3 user: dgp tags: core-8-4-branch
2005-09-27
15:44
Fix [Bug 1116542] check-in: 08a775ad24 user: dkf tags: core-8-4-branch
2005-09-15
23:21
* doc/ParseCmd.3: copy/paste fix [Bug 1292427] check-in: 6e3d5cce85 user: msofer tags: core-8-4-branch
16:29
autoconf-2.13 check-in: ca52262c8f user: dgp tags: core-8-4-branch
15:25
Added yet another corner-case hack, this time for RHEL3. [Bug 1287638] check-in: 3ca7f7f35d user: dkf tags: core-8-4-branch
2005-09-07
14:35
* generic/tclUtf.c (Tcl_UniCharToUtf): Corrected handling of negative * tests/utf.t... check-in: 8d8a47a587 user: dgp tags: core-8-4-branch
2005-08-29
17:56
renumber expr-39.* to expr-46.* check-in: f291388d76 user: kennykb tags: core-8-4-branch
16:38
fix test case numbering check-in: ff06a0c77b user: kennykb tags: core-8-4-branch
16:37
Bug 1275043 check-in: b9f7d2aeda user: kennykb tags: core-8-4-branch
2005-08-25
22:27
Backport of fix for [Bug 1267380] check-in: 2389f54864 user: dkf tags: core-8-4-branch
2005-08-17
17:46
* generic/tclFCmd.c (TclFileMakeDirsCmd): fix to race condition in file mkdir (backport from head ... check-in: 0078c07abe user: hobbs tags: core-8-4-branch
2005-08-16
15:23
backport of 2005-08-10 fix to tclEvent.c check-in: dd9d7470f5 user: kennykb tags: core-8-4-branch
2005-08-05
20:48
Solaris mis-names the cp1251 encoding. check-in: b06e325973 user: dkf tags: core-8-4-branch
19:19
fix abs(MIN_INT) [Bug 1241572] check-in: da72873254 user: kennykb tags: core-8-4-branch
2005-08-04
19:54
silence compiler warning check-in: 863065efb4 user: dgp tags: core-8-4-branch
15:55
* generic/tclObj.c: Simplified routines that manage the typeTable. check-in: 9b0394290c user: dgp tags: core-8-4-branch
2005-08-03
22:23
* generic/tclCompExpr.c: Untangled some dependencies in the * generic/tclEven... check-in: bdbb22fe12 user: dgp tags: core-8-4-branch
2005-07-30
07:58
* unix/configure, unix/tcl.m4: revert 2005-07-28 change. * unix/tclLoadDyld.c (TclpDlopen, TclpLo... check-in: aab38a9d96 user: das tags: core-8-4-branch
2005-07-29
14:57
Take care with globals that have an entry in the var table but "don't exist" check-in: e0c44afdc5 user: dkf tags: core-8-4-branch
03:50
* win/README: Update link to msys_mingw8.zip. Remove old Cygwin + Mingw info, people should just ... check-in: 73b0175c51 user: mdejong tags: core-8-4-branch
2005-07-28
18:39
* unix/configure, unix/tcl.m4: defined TCL_LOAD_FROM_MEMORY on Darwin only for SHARED_BUILD check-in: 0ed358ea9d user: hobbs tags: core-8-4-branch
15:27
Backport of fix for [Bug 1245953] check-in: d4beef2f2f user: dkf tags: core-8-4-branch
2005-07-26
21:39
* doc/tclvars.n: Improved $errorCode documentation. [RFE 776921] check-in: 296a35434b user: dgp tags: core-8-4-branch
20:26
* unix/configure: Regen. * unix/configure.in: Check for a $prefix/share directory and add it the ... check-in: 4a097ea047 user: mdejong tags: core-8-4-branch
17:05
* generic/tclBasic.c (Tcl_CallWhenDeleted): Converted to use per-thread counter,... check-in: 461ce25bd8 user: dgp tags: core-8-4-branch
16:23
typo check-in: d1f1e8a69a user: dgp tags: core-8-4-branch
16:20
* generic/tclNamesp.c (TclTeardownNamespace): Re-ordering so that * tests/trace.te... check-in: 98ddae5f7c user: dgp tags: core-8-4-branch
2005-07-25
01:17
* unix/tcl.m4 (SC_PROG_TCLSH, SC_BUILD_TCLSH): * win/tcl.m4 (SC_PROG_TCLSH, SC_BUILD_TCLSH): Spli... check-in: 9ed6cc87ea user: mdejong tags: core-8-4-branch
2005-07-23
03:31
correction to reversed logic check-in: 2a2953ce33 user: dgp tags: core-8-4-branch
2005-07-22
21:59
* library/auto.tcl: Updates to the Tcl script library to make * library/history.... check-in: 755e2a7f25 user: dgp tags: core-8-4-branch
2005-07-08
01:06
* unix/tcl.m4, unix/configure: Backported [Bug 1095909], removing * unix/tclUnixPort.h: a... check-in: 75375ce555 user: hobbs tags: core-8-4-branch
2005-07-05
21:18
* generic/tclCmdAH.c New "encoding" Tcl_ObjType (not registered) * generic/tclEnc... check-in: 9e0bc07fda user: dgp tags: core-8-4-branch
17:27
* generic/tclNamesp.c: Allow for [namespace import] of a command * tests/namespace.... check-in: 18818ddf02 user: dgp tags: core-8-4-branch
2005-07-01
10:57
Protect against spurious wake-ups while waiting on the condition variable when tearing down the noti... check-in: ae91d8ec01 user: vasiljevic tags: core-8-4-branch
2005-06-27
20:06
formatting check-in: d0ad85eb9f user: dgp tags: core-8-4-11, core-8-4-branch
20:00
typo in date check-in: e4eb7a5314 user: dgp tags: core-8-4-branch
18:19
* library/auto.tcl: Reverted to Revision 1.12.2.3 (Tcl 8.4.9). Restores the (bug... check-in: 9c7df0f603 user: dgp tags: core-8-4-branch
2005-06-24
23:13
* library/auto.tcl: Make file safe to re-[source] without destroying registered ... check-in: c7c57fd3ce user: dgp tags: core-8-4-branch
19:36
release tag/spelling check-in: 2db99ffe24 user: dgp tags: core-8-4-branch
18:21
finalize Tcl_Preserve after exit handlers check-in: 7dafabb1d2 user: kennykb tags: core-8-4-branch
15:02
* library/auto.tcl: Make file safe to re-[source] without destroying registered ... check-in: 9d256cea6d user: dgp tags: core-8-4-branch
2005-06-23
20:25
new 8.4.11 release date: June 28 check-in: c46c8e2d1a user: dgp tags: core-8-4-branch
17:01
* tools/tcltk-man2html.tcl: fixed useversion glob pattern to accept multi-digit patchlevels. check-in: 9aa4d239a6 user: das tags: core-8-4-branch
15:45
release tag / changes updates check-in: 7bffa24ec0 user: dgp tags: core-8-4-branch
15:05
bug #1225957 check-in: edf9a121ee user: kennykb tags: core-8-4-branch
05:59
* unix/Makefile.in (install-private-headers): rewrite tclPort.h when installing private headers to... check-in: ce4b5c969a user: das tags: core-8-4-branch
2005-06-22
21:44
update changes for 8.4.11 check-in: fb14091a89 user: dgp tags: core-8-4-branch
21:30
bug 1225044 check-in: 5a9b823ad8 user: kennykb tags: core-8-4-branch
21:23
* win/tclWinFile.c: Potential buffer overflow. [Bug 1225571] Thanks to Pat Thoy... check-in: a00ac6013b user: dgp tags: core-8-4-branch
20:26
update for 8.4.11 check-in: 025d0d7534 user: dgp tags: core-8-4-branch
20:19
release tag check-in: 4253194837 user: dgp tags: core-8-4-branch
19:35
bug 1225727 check-in: ab109e436a user: kennykb tags: core-8-4-branch
16:49
* generic/tclInt.h: Followup to change made on 2005-06-18 by Daniel Steffen. There are compiler... check-in: 8943140362 user: andreas_kupries tags: core-8-4-branch
16:02
* tests/safe.test: Backport performance improvement from reduced $::auto_path. check-in: c728e339cc user: dgp tags: core-8-4-branch
2005-06-21
22:59
* tests/winDde.test: Added some waits to the dde server script to let event processing run after w... check-in: 241e4d0ec1 user: patthoyts tags: core-8-4-branch
19:38
update changes and release tag check-in: 8691b485e9 user: dgp tags: core-8-4-branch
19:07
bugs 1194458 and 1225044 check-in: 74c4fb693b user: kennykb tags: core-8-4-branch
17:19
* generic/tclBasic.c: Made the walk of the active trace list aware * generic/tclCm... check-in: f5039da571 user: dgp tags: core-8-4-branch
14:47
formatting check-in: 6f8ba9eb4c user: dgp tags: core-8-4-branch
14:44
* generic/tclBasic.c (Tcl_DeleteTrace): Added missing walk of the * tests/trace.test... check-in: f48e2dd7c2 user: dgp tags: core-8-4-branch
2005-06-20
17:12
date fix check-in: 16ba8ae5af user: dgp tags: core-8-4-branch
16:57
* doc/FileSystem.3: added missing Tcl_GlobTypeData documentation [Bug 935853] check-in: 4441d3574e user: dgp tags: core-8-4-branch
2005-06-19
21:51
update release tag check-in: 753573fb3d user: dgp tags: core-8-4-branch
2005-06-18
21:46
*** 8.4.11 TAGGED FOR RELEASE *** * generic/tclInt.h: ensure WORDS_BIGENDIAN is defined correctly... check-in: c197218ee4 user: das tags: core-8-4-branch
20:19
release tag check-in: a851e123bc user: dgp tags: core-8-4-branch
19:52
* changes: Update changes for 8.4.11 release check-in: 7030368141 user: dgp tags: core-8-4-branch
19:24
* README: Bump version number to 8.4.11 * generic/tcl.h: * too... check-in: 433f7421e2 user: dgp tags: core-8-4-branch
2005-06-17
23:26
Fix bug in [format %hx] handling on selected platforms. [Bug 1154163] check-in: 7e05cf3e68 user: dkf tags: core-8-4-branch
2005-06-07
10:26
Backport unix threading fix check-in: 70cf3ac902 user: dkf tags: core-8-4-branch
2005-06-06
21:04
Correct crash in stack.test on gcc/win32 check-in: be4c5ca620 user: kennykb tags: core-8-4-branch
13:04
typo check-in: 8fba048e18 user: das tags: core-8-4-branch
2005-06-04
07:05
* unix/tclLoadDyld.c: fixed header confilict when building this file with USE_TCL_STUBS. check-in: 4459296c01 user: das tags: core-8-4-10, core-8-4-branch
2005-06-03
08:53
* macosx/Makefile: fixed 'embedded' target. check-in: eceaf84eed user: das tags: core-8-4-branch
2005-06-02
23:14
note 8.4.10 tag date check-in: 76f045029e user: hobbs tags: core-8-4-branch
22:52
* unix/Makefile.in (html): add BUILD_HTML_FLAGS optional var * tools/tcltk-man2html.tcl: add a --u... check-in: dc75d1f5ed user: hobbs tags: core-8-4-branch
22:52
minor corrections for 8.4.10 release check-in: 5262509288 user: hobbs tags: core-8-4-branch
16:54
updated changes for 8.4.10 release check-in: 8097495773 user: dgp tags: core-8-4-branch
2005-05-31
08:29
Cosmetic change (fixed identation in Tcl_FinalizeNotifier) check-in: 50492b52cd user: vasiljevic tags: core-8-4-branch
08:25
See file. check-in: 1aee72e12a user: vasiljevic tags: core-8-4-branch
08:18
Notifier thread is created as joinable. Attempt to solve the Tcl Bug #1082283. check-in: 9ba1d28bca user: vasiljevic tags: core-8-4-branch
2005-05-30
18:31
update to patchlevel 8.4.10 check-in: 72ec170d6b user: hobbs tags: core-8-4-branch
01:36
* win/tclWinThrd.c (TclpFinalizeThreadData): move tlsKey defn to top of file and clarify name (was... check-in: df1e9f6aac user: hobbs tags: core-8-4-branch
2005-05-27
18:51
* README: Bumped patchlevel to 8.4.10 * generic/tcl.h: * tools/tcl.wse.in: * unix/tcl.... check-in: 752a5d0521 user: hobbs tags: core-8-4-branch
2005-05-26
11:19
* macosx/Makefile: moved & corrected EMBEDDED_BUILD check. * unix/configure.in: corrected framewo... check-in: 45619dd7d5 user: das tags: core-8-4-branch
2005-05-25
19:25
* generic/tclCmdMZ.c (Tcl_TimeObjCmd): add necessary cast check-in: 176b2864bd user: hobbs tags: core-8-4-branch
18:49
* unix/configure, unix/configure.in: ensure false Tcl.framework is only created with --enable-fram... check-in: e0e2451d61 user: hobbs tags: core-8-4-branch
2005-05-24
04:44
* tests/env.test: added DYLD_FRAMEWORK_PATH to the list of env vars that need to be ... check-in: 499598d874 user: das tags: core-8-4-branch
04:20
* macosx/Makefile: * macosx/README: * macosx/Tcl-Info.plist.in (new file): * unix/Makefile.in: ... check-in: c065af454b user: das tags: core-8-4-branch
04:19
* generic/tclIOUtil.c (TclLoadFile): * generic/tclInt.h: * unix/tcl.m4: * unix/tclLoadDyld.c: ad... check-in: 5c82b72b0a user: das tags: core-8-4-branch
04:18
* generic/tclCmdMZ.c (Tcl_TimeObjCmd): change [time] called with a count > 1 to return a string wi... check-in: f5fb72c5f9 user: das tags: core-8-4-branch
2005-05-20
17:19
Removed unreferenced stack variable check-in: 4233bfd935 user: vasiljevic tags: core-8-4-branch
15:28
* generic/tclParseExpr.c: Corrected parser to recognize all boolean literals a... check-in: eb0b85b5d7 user: dgp tags: core-8-4-branch
02:50
* macosx/tclMacOSXNotify.c (Tcl_InitNotifier): fixed crashing CFRelease of runLoopSource in Tcl_In... check-in: f2036a6572 user: das tags: core-8-4-branch
2005-05-19
13:28
* macosx/tclMacOSXNotify.c (Tcl_InitNotifier): fixed crashing CFRelease of runLoopSource in Tcl_In... check-in: af276e30b1 user: das tags: core-8-4-branch
2005-05-14
20:52
* macosx/tclMacOSXBundle.c: * unix/tclUnixInit.c: * unix/tcl.m4 (Darwin): made use of CoreFoundat... check-in: c4f7ce27bf user: das tags: core-8-4-branch
2005-05-12
16:23
Corrected example that confused [namespace which] and [namespace origin] check-in: 4747c60a4f user: dgp tags: core-8-4-branch
2005-05-11
00:47
* tests/string.test: string-10.[21-30] * generic/tclCmdMZ.c (Tcl_StringObjCmd): add extra checks t... check-in: 8a6c6f6b7d user: hobbs tags: core-8-4-branch
2005-05-07
00:00
* unix/tcl.m4, unix/configure: correct Solaris 10 (5.10) check and add support for x86_64 Solaris ... check-in: 5a2808481b user: hobbs tags: core-8-4-branch
2005-05-03
17:53
documentation improvements. check-in: c73c6b9be6 user: dgp tags: core-8-4-branch
2005-04-29
14:09
Backported doc fix check-in: 83eaf12085 user: dkf tags: core-8-4-branch
2005-04-28
05:34
* library/init.tcl: Corrected flaw in interactive command * tests/main.test: ... check-in: d43f85a9a8 user: dgp tags: core-8-4-branch
2005-04-27
21:07
* tests/unixInit.test (7.1): Alternative fix for the 2005-04-22 commit. check-in: 4104828d14 user: dgp tags: core-8-4-branch
2005-04-26
00:46
* compat/string.h: fixed memchr() protoype for __APPLE__ so that we build on Mac OS X 10.1 again. ... check-in: 74b7355f70 user: das tags: core-8-4-branch
2005-04-22
16:29
* generic/tclCmdMZ.c: Corrected intrep-dependence of * tests/string.test: [stri... check-in: 8c298ec89c user: dgp tags: core-8-4-branch
2005-04-21
23:42
* tests/unixInit.test (7.1): fixed failure when running tests with -tmpdir arg not set to working ... check-in: f5a7d654ed user: das tags: core-8-4-branch
2005-04-20
16:06
* generic/tclGet.c (Tcl_GetInt): Corrected error that did not * generic/tclOb... check-in: 3d004086cf user: dgp tags: core-8-4-branch
00:14
* tests/winPipe.test (winpipe-6.2): remove -blocking 1 as this one can truly block. check-in: f53ee322c3 user: hobbs tags: core-8-4-branch
2005-04-19
16:31
no message check-in: 2920872277 user: davygrvy tags: core-8-4-branch
16:28
* win/tclWinPipe.c: The pipe channel driver now respects the -blocking option when closing. The wi... check-in: 435e6257fb user: davygrvy tags: core-8-4-branch
2005-04-14
07:09
* generic/tclIO.c (Tcl_SetChannelBufferSize): Lowest size limit * tests/io.test: changed from ten b... check-in: 74c27f43eb user: davygrvy tags: core-8-4-branch
2005-04-12
18:28
added definition of NULL to strstr.c for Bug 1175161 check-in: ccf59bad26 user: kennykb tags: core-8-4-branch
2005-04-09
15:39
* macosx/README: updated requirements for OS & developer tool versions + other small fixes/cleanup... check-in: 7342dfd9e9 user: das tags: core-8-4-branch
10:16
* unix/tcl.m4 (Darwin): added -single_module linker flag to TCL_SHLIB_LD_EXTRAS and TK_SHLIB_LD_EX... check-in: 482141dca9 user: das tags: core-8-4-branch
2005-04-07
11:33
See file. check-in: 7769d08b2a user: vasiljevic tags: core-8-4-branch
11:29
Renamed TclWinFreeAllocCache to TclpFreeAllocCache and fixed to recognize when being called with NUL... check-in: f770d9b761 user: vasiljevic tags: core-8-4-branch
11:28
Fixed TclpFreeAllocCache() to recognize when being called with NULL argument. This is a signal for i... check-in: 9e2b7b1539 user: vasiljevic tags: core-8-4-branch
11:27
Modified TclFinalizeThreadAlloc() to explicitly call TclpFreeAllocCache with the NULL-ptr as argumen... check-in: 67acf03916 user: vasiljevic tags: core-8-4-branch
11:24
Added prototypes for TclpFreeAllocCache() and TclFreeAllocCache(). Part of fixing the Tcl Bug #11784... check-in: 4281da6f73 user: vasiljevic tags: core-8-4-branch
2005-04-05
16:39
* generic/tclExecute.c (ExprSrandFunc): Replaced incursions into the * generic/tclUt... check-in: 65c0e11b9e user: dgp tags: core-8-4-branch
2005-03-30
06:17
* win/tcl.m4, win/configure: do not require cygpath in macros to allow msys alone as an alternativ... check-in: 56dd117e68 user: hobbs tags: core-8-4-branch
05:30
* win/tclWinTime.c (TclpGetDate): use time_t for 'time' check-in: 210fcf1532 user: hobbs tags: core-8-4-branch
2005-03-23
21:58
purge outdated comment check-in: e79a41b835 user: dgp tags: core-8-4-branch
2005-03-18
16:33
date typo check-in: 6d93b043d7 user: dgp tags: core-8-4-branch
16:33
* generic/tclBasic.c (Tcl_EvalEx,TclEvalTokensStandard): * generic/tclCmdMZ.c (Tcl_S... check-in: e64996b96b user: dgp tags: core-8-4-branch
15:32
* generic/tclCompCmds.c (TclCompileIncrCmd): Corrected checks for immediate opera... check-in: 81b2571603 user: dgp tags: core-8-4-branch
2005-03-15
22:10
more tests and a fix to bug 1158199 check-in: a716de25ea user: vincentdarley tags: core-8-4-branch
18:41
fix to file norm, file pathtype on windows reserved filenames - ensure build ok on unix check-in: d18606faab user: vincentdarley tags: core-8-4-branch
18:08
fix to file norm, file pathtype on windows reserved filenames check-in: 6ad619ecdd user: vincentdarley tags: core-8-4-branch
16:29
replaced 'long' times with wides, to cope with Win64 check-in: d41af48065 user: kennykb tags: core-8-4-branch
00:15
Make it all work on OpenBSD. Imported patch from ports tree. check-in: 5a7a92a163 user: patthoyts tags: core-8-4-branch
2005-03-10
20:22
* generic/tclCmdMZ.c (TclCheckInterpTraces): Corrected mistaken cast of ClientDat... check-in: 5e6df95dbf user: dgp tags: core-8-4-branch
2005-03-08
21:50
* win/makefile.vc: clarify necessary defined vars that can come from MSVC or the Platform SDK. check-in: fe1380a971 user: hobbs tags: core-8-4-branch
2005-02-25
22:37
backport tcltest test improvements check-in: 400a6cb8c6 user: dgp tags: core-8-4-branch
2005-02-24
18:03
* library/tcltest/tcltest.tcl: Better use of [glob -types] to avoid * tests/tcltest... check-in: 94beca8470 user: dgp tags: core-8-4-branch
2005-02-23
10:27
Formatting typo fix. [Bug 1149605] check-in: 46ddcbd972 user: dkf tags: core-8-4-branch
2005-02-17
18:31
* win/tclWinFCmd.c (TraverseWinTree): use wcslen on wchar, not Tcl_UniCharLen. check-in: 492d51196c user: hobbs tags: core-8-4-branch
2005-02-16
18:52
* /doc/variable.n: fix for [Bug 1124160], variables are detected by [info vars] but not by [info l... check-in: 75f5651679 user: msofer tags: core-8-4-branch
2005-02-10
23:41
correct ChangeLog notes check-in: b1a2080787 user: hobbs tags: core-8-4-branch
23:40
* unix/Makefile.in: remove SHLIB_LD_FLAGS (only for AIX, inlined * unix/tcl.m4: into SHLIB_LD... check-in: abcbb0a278 user: hobbs tags: core-8-4-branch
19:03
added comments check-in: 2d6f460f4f user: msofer tags: core-8-4-branch
18:58
* generic/tclBasic.c (Tcl_EvalObjEx): * tests/basic.test (basic-26.2): preserve the arguments pass... check-in: de2187d047 user: msofer tags: core-8-4-branch
10:28
More consistency. [Bug 1117017] check-in: 48135ca6b1 user: dkf tags: core-8-4-branch
2005-02-01
17:26
* generic/tclExecute.c (TclCompEvalObj): Removed stray statement left behind in prio... check-in: 0cf23b16e1 user: dgp tags: core-8-4-branch
2005-01-29
02:18
correct autoconf generation for sol64-gcc support check-in: 33585e82df user: hobbs tags: core-8-4-branch
2005-01-28
20:53
* unix/configure, unix/tcl.m4: add solaris 64-bit gcc build support. [Bug 1021871] check-in: 384d5ba7b5 user: hobbs tags: core-8-4-branch
01:50
* generic/tclBasic.c (Tcl_ExprBoolean, Tcl_ExprDouble) (Tcl_ExprLong): Fix to recognize Tcl_WideIn... check-in: 7b989119b5 user: hobbs tags: core-8-4-branch
2005-01-27
22:53
TIP#218 IMPLEMENTATION * generic/tclDecls.h: Regenerated from tcl.decls. * generic/tclStubInit.... check-in: 1621430b8b user: andreas_kupries tags: core-8-4-branch