Differences From Artifact [884e4eda43]:

• File generic/tclBinary.c — part of check-in [7992011cd3] at 2019-02-22 17:32:49 on branch core-8-branch — Revert recent commit that breaks the encapsulation interface of TIP 445. That encapsulation was put in place to support feature evolution such as that in the dgp-properbytearry branch, which is now a nightmare of merge conflicts. TIP 445 was approved. Please respect it. Where it needs revision or improvement let's work together to TIP those changes. (user: dgp size: 82589) [more...]

To Artifact [b0053ef8aa]:

• File generic/tclBinary.c — part of check-in [86b1045cc4] at 2019-02-25 19:50:43 on branch core-8-branch — New internal macro TclHasIntRep() to re-encapsulate the typePtr field. (user: dgp size: 82598)

287
288
289
290
291
292
293
294
295
296
297
298
299
300
301

#define SET_BYTEARRAY(irPtr, baPtr) \
		(irPtr)->twoPtrValue.ptr1 = (void *) (baPtr)

int
TclIsPureByteArray(
    Tcl_Obj * objPtr)
{
    return objPtr->typePtr == &properByteArrayType;
}

/*
 *----------------------------------------------------------------------
 *
 * Tcl_NewByteArrayObj --
 *

|

287
288
289
290
291
292
293
294
295
296
297
298
299
300
301

#define SET_BYTEARRAY(irPtr, baPtr) \
		(irPtr)->twoPtrValue.ptr1 = (void *) (baPtr)

int
TclIsPureByteArray(
    Tcl_Obj * objPtr)
{
    return TclHasIntRep(objPtr, &properByteArrayType);
}

/*
 *----------------------------------------------------------------------
 *
 * Tcl_NewByteArrayObj --
 *

559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576

    int improper = 0;
    const char *src, *srcEnd;
    unsigned char *dst;
    Tcl_UniChar ch = 0;
    ByteArray *byteArrayPtr;
    Tcl_ObjIntRep ir;

    if (objPtr->typePtr == &properByteArrayType) {
	return TCL_OK;
    }
    if (objPtr->typePtr == &tclByteArrayType) {
	return TCL_OK;
    }

    src = TclGetString(objPtr);
    length = objPtr->length;
    srcEnd = src + length;

|


|

559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576

    int improper = 0;
    const char *src, *srcEnd;
    unsigned char *dst;
    Tcl_UniChar ch = 0;
    ByteArray *byteArrayPtr;
    Tcl_ObjIntRep ir;

    if (TclHasIntRep(objPtr, &properByteArrayType)) {
	return TCL_OK;
    }
    if (TclHasIntRep(objPtr, &tclByteArrayType)) {
	return TCL_OK;
    }

    src = TclGetString(objPtr);
    length = objPtr->length;
    srcEnd = src + length;