Differences From Artifact [9d8b8d0249]:

• File library/msgcat/tests/event.test — part of check-in [a33431908c] at 2013-01-19 13:36:57 on branch dgp-pkg-migration — merge trunk (user: dgp size: 28241) [more...]
• File pkgs/msgcat/tests/event.test — part of check-in [a33431908c] at 2013-01-19 13:36:57 on branch dgp-pkg-migration — merge trunk (user: dgp size: 28241)
• File tests/event.test — part of check-in [eeed854a7b] at 2012-07-30 18:56:31 on branch trunk — event tests should continue to work with static Tcltest package (user: jan.nijtmans size: 28241)

To Artifact [d88191c453]:

• File tests/event.test — part of check-in [d801822907] at 2013-01-22 19:24:25 on branch contrib-patrick-fradin-code-cleanup — Contribution by Patrick Fradin <patrick.fradin@planar.com> Quoting his mail: <pre> ========================================================== Hi Jeff, I spent some of my time to contribute to the TclTk community ! I'm in late for Christmas gift but like we said in French : "Mieux vaut tard que jamais". ;-) I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and Tk library directories (library, tools and tests) to correct a lot of warnings and few errors. (encapsulate some expr, use 'chan xxx' instead of fconfigure, fileevent...) I've made some improvements too : Examples : - Use 'lassign' instead of many 'lindex' of 'foreach/break' loop. - Use 'in' or 'ni' operators instead of 'lsearch -exact' or to factorise some eq/ne && / || tests. - Use 'eq' or 'ne' to tests strings instead of '==' or '!='. - Use 'unset -nocomplain' to avoid 'catch {unset...}'. - Remove some useless catch around 'destroy' calls. - Use expand {*} instead of 'eval'. Don't touch a lot of code because I don't know all structs and lists. I think it could be a greater improvement to reduce 'eval' calls. Due to previous experience, I dot not change any indentation ! ;-) ========================================================== </pre> (user: andreask size: 28248)

14
15
16
17
18
19
20
21
22
23
24
25
26
27
28

14
15
16
17
18
19
20

21
22
23
24
25
26
27

-

catch {
    ::tcltest::loadTestedCommands
    package require -exact Tcltest [info patchlevel]
    set ::tcltestlib [lindex [package ifneeded Tcltest [info patchlevel]] 1]
}


testConstraint testfilehandler [llength [info commands testfilehandler]]
testConstraint testexithandler [llength [info commands testexithandler]]
testConstraint testfilewait [llength [info commands testfilewait]]
testConstraint exec [llength [info commands exec]]

test event-1.1 {Tcl_CreateFileHandler, reading} -setup {
    testfilehandler close

510
511
512
513
514
515
516
517

518
519
520
521
522
523
524

509
510
511
512
513
514
515

516
517
518
519
520
521
522
523

-
+

test event-11.1 {Tcl_VwaitCmd procedure} -returnCodes error -body {
    vwait
} -result {wrong # args: should be "vwait name"}
test event-11.2 {Tcl_VwaitCmd procedure} -returnCodes error -body {
    vwait a b
} -result {wrong # args: should be "vwait name"}
test event-11.3 {Tcl_VwaitCmd procedure} -setup {
    catch {unset x}
    unset -nocomplain x
} -body {
    set x 1
    vwait x(1)
} -returnCodes error -result {can't trace "x(1)": variable isn't array}
test event-11.4 {Tcl_VwaitCmd procedure} -setup {
    foreach i [after info] {
	after cancel $i

545
546
547
548
549
550
551
552

553
554
555
556
557
558
559

544
545
546
547
548
549
550

551
552
553
554
555
556
557
558

-
+

    set f1 [open $test1file w]
    proc accept {s args} {
	puts $s foobar
	close $s
    }
    set s1 [socket -server accept -myaddr 127.0.0.1 0]
    after 1000
    set s2 [socket 127.0.0.1 [lindex [fconfigure $s1 -sockname] 2]]
    set s2 [socket 127.0.0.1 [lindex [chan configure $s1 -sockname] 2]]
    close $s1
    set x 0
    set y 0
    set z 0
    fileevent $s2 readable {incr z}
    vwait z
    fileevent $f1 writable {incr x; if {$y == 3} {set z done}}