Fossil

Check-in [b594f486ef]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Add reminder hints to the authorizer function header comments about how to test those functions using the "test-db-prepare" command.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | tktschema-allow-drop
Files: files | file ages | folders
SHA3-256: b594f486efdf61b8aa65f73e55ee3e8283a24760ffba01ea1662b2ef0856761c
User & Date: drh 2021-06-14 19:48:44.057
Context
2021-06-14
19:51
Allow DROP INDEX and DROP VIEW through the ticket-schema authorizer. Enhance the test-db-prepare command so that it can use the ticket-schema or report authorizers for testing purposes. ... (check-in: c717f1ef9a user: drh tags: trunk)
19:48
Add reminder hints to the authorizer function header comments about how to test those functions using the "test-db-prepare" command. ... (Closed-Leaf check-in: b594f486ef user: drh tags: tktschema-allow-drop)
19:44
Doc typo fix. ... (check-in: 323e3dfcbd user: stephan tags: tktschema-allow-drop)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/report.c.
159
160
161
162
163
164
165



166
167
168
169
170
171
172
/*********************************************************************/

/*
** This is the SQLite authorizer callback used to make sure that the
** SQL statements entered by users do not try to do anything untoward.
** If anything suspicious is tried, set *(char**)pError to an error
** message obtained from malloc.



*/
static int report_query_authorizer(
  void *pError,
  int code,
  const char *zArg1,
  const char *zArg2,
  const char *zArg3,







>
>
>







159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
/*********************************************************************/

/*
** This is the SQLite authorizer callback used to make sure that the
** SQL statements entered by users do not try to do anything untoward.
** If anything suspicious is tried, set *(char**)pError to an error
** message obtained from malloc.
**
** Use the "fossil test-db-prepare --auth-report SQL" command to perform
** manual testing of this authorizer.
*/
static int report_query_authorizer(
  void *pError,
  int code,
  const char *zArg1,
  const char *zArg2,
  const char *zArg3,
Changes to src/tkt.c.
393
394
395
396
397
398
399



400
401
402
403
404
405
406
** But only for tables in "main" or "repository" whose names
** begin with "ticket", "sqlite_", or "fx_".
**
** Of particular importance for security is that this routine
** disallows data changes on the "config" table, as that could
** allow a malicious server to modify settings in such a way as
** to cause a remote code execution.



*/
static int ticket_schema_auth(
  void *pNErr,
  int eCode,
  const char *z0,
  const char *z1,
  const char *z2,







>
>
>







393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
** But only for tables in "main" or "repository" whose names
** begin with "ticket", "sqlite_", or "fx_".
**
** Of particular importance for security is that this routine
** disallows data changes on the "config" table, as that could
** allow a malicious server to modify settings in such a way as
** to cause a remote code execution.
**
** Use the "fossil test-db-prepare --auth-ticket SQL" command to perform
** manual testing of this authorizer.
*/
static int ticket_schema_auth(
  void *pNErr,
  int eCode,
  const char *z0,
  const char *z1,
  const char *z2,