Fossil: View Ticket

2010-02-13
12:31		• Closed ticket [2245a1e3d0]: rm command mistakingly believes files are directories plus 2 other changes ... (artifact: cedf799154 user: jeremy_c)
12:30		Fixed bug [2245a1e3d0]. rm command now properly checks return value. ... (check-in: 02f638a16f user: jeremy_c tags: trunk, release)
05:38		• New ticket [2245a1e3d0] rm command mistakingly believes files are directories. ... (artifact: a24e6c20d9 user: anonymous)

Ticket Hash:	2245a1e3d058d85ec59c327a932a208109d46d45
Title:	rm command mistakingly believes files are directories
Status:	Closed	Type:	Code_Defect
Severity:	Important	Priority:
Subsystem:		Resolution:	Fixed
Last Modified:	2010-02-13 12:31:25 16.14 years ago	Created:	2010-02-13 05:38:06 16.14 years ago
Version Found In:	95ae79d504

Description:

'fossil rm file' crashes:
(gdb) where
#0  0x91af1e9a in closedir$UNIX2003 ()
#1  0x00002d43 in del_directory_content (zDir=0x202b00 "mdb.mk") at add_.c:223
#2  0x00002de9 in del_cmd () at add_.c:255
#3  0x00022fb7 in main (argc=3, argv=0xbffff49c) at main_.c:258

mdb.mk is a plain file

Suggested patch:
--- src/add.c
+++ src/add.c
@@ -249,11 +249,11 @@
   db_begin_transaction();
   for(i=2; i<g.argc; i++){
     char *zName;

zName = mprintf("%/", g.argv[i]);
-    if( file_isdir(zName) ){
+    if( file_isdir(zName) == 1){
       del_directory_content(zName);
     } else {
       char *zPath;
       Blob pathname;
       file_tree_name(zName, &pathname, 1);

jeremy_c added on 2010-02-13 12:31:25:
Thanks for the patch. It has been applied.