Fossil

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

146 check-ins using file src/allrepo.c version 32cdad222c

2020-08-26
12:44
Merge in trunk (version-2.11.2) check-in: 4f5bda658f user: george tags: wiki-history
2020-08-20
13:24
Version 2.11.2 Leaf check-in: c58877d6f2 user: drh tags: release, branch-2.11, version-2.11.2
2020-06-08
23:37
Add a safety scan of all strings passed into fossil_system(). Fatal error if the input string seems unsafe. check-in: a046f916d3 user: drh tags: trunk
23:11
Fixes and enhancements to SEE integration on Windows. check-in: 57d8a71f42 user: mistachkin tags: trunk
23:03
Fix harmless compiler warning seen with MSVC. check-in: 094fb2ef0c user: mistachkin tags: trunk
22:52
Fix handling of the 'fossil.exe.manifest' file by the MSVC makefile. check-in: 6acb039c81 user: mistachkin tags: trunk
22:08
Make sure the 'fossil.exe' target is honored when using the MSVC makefile. check-in: c89a5a3ad2 user: mistachkin tags: trunk
20:47
Updates to the change log. check-in: 70fc44a199 user: drh tags: trunk
19:48
Version 2.11.1 check-in: 307d94c549 user: drh tags: release, version-2.11.1, branch-2.11
19:47
Make the "fossil git export" command more restrictive about characters that it allows in tag names. check-in: e8c6cd2ced user: drh tags: branch-2.11
19:14
More test cases (based on the SQLite repository) for the merge-riser coalescing logic. check-in: a2930cc091 user: drh tags: trunk
19:05
Avoid drawing multiple copies of cherrypick merge risers. check-in: 146f02f922 user: drh tags: trunk
18:27
Add test cases for the merge-riser coalescing logic. check-in: e4e5b771d2 user: drh tags: trunk
18:13
Minor bug fixes in the new merge-riser coalescing logic of the graph generator. check-in: 7688673a8e user: drh tags: trunk
17:10
Graph improvement: When there are multiple inbound merge arrows, try to combine as many as possible into a single riser. check-in: 1eb9f5a81a user: drh tags: trunk
12:10
Update the built-in SQLite to the latest trunk version for testing. check-in: 3ab64c5a4d user: drh tags: trunk
03:32
Make the "fossil git export" command more restrictive about characters that it allows in tag names. check-in: c9a592dde7 user: drh tags: trunk
2020-06-07
23:07
Robustify error handling. Closed-Leaf check-in: 39c88cff80 user: mistachkin tags: testPid
23:03
Fixes and enhancements to SEE integration on Windows. check-in: 584ac9ffc4 user: mistachkin tags: testPid
18:23
Add the 'test-pid' web page. check-in: d6e900a581 user: mistachkin tags: testPid
18:20
Update custom Makefile for MinGW. check-in: 81960e1faa user: mistachkin tags: trunk
2020-06-06
19:04
Simplify the batch tool changes from [0519493f]. The BUILDDIR environment variable can be set before invoking 'buildmsvc.bat' in order to build out-of-tree. check-in: 7c481db74e user: mistachkin tags: trunk
04:06
Describe how to produce a build with debugging options enabled. check-in: c9690c7356 user: ashepilko tags: trunk
03:56
Support the build from an out of source-tree directory on Windows; allow paths with spaces. check-in: 0519493f46 user: ashepilko tags: trunk
2020-06-05
14:43
Minor branch help doc tweak suggestion from the forum. check-in: f488eaf5ff user: stephan tags: trunk
2020-06-04
21:01
mv-rm.test: On test teardown, delete the manually created dir. check-in: 5da1bd94cc user: ashepilko tags: trunk
20:51
revert: Allow reverting of current changes for the whole directory tree. check-in: a8bb08697a user: ashepilko tags: trunk
18:38
Update the built-in SQLite to the latest trunk version so that the "fossil sql" command can take advantage of the new ".mode box" setting. check-in: 363efffe9e user: drh tags: trunk
14:23
The safe-HTML feature of Markdown rendering now shows the full content of omitted HTML elements, without truncation. check-in: 16d68b0d4c user: drh tags: trunk
14:12
On the /timeline page with the c= query parameter, try harder to capture the full number of events requested by the n= query parameter. check-in: a1af802677 user: drh tags: trunk
14:10
Update the built-in SQLite to the latest trunk version that includes the COMMIT patch for 3.32.2 plus the new ".mode table" and ".mode json" features of the CLI. check-in: 991879177b user: drh tags: trunk
10:43
Fix for "/timeline?c=XXXX" (circa the specified check-in) when the target check-in is at or near the tip of the timeline. See https://fossil-scm.org/forum/forumpost/e3adbfedfd Closed-Leaf check-in: 16a09da8c1 user: graham tags: timeline-circa-fix
2020-06-03
22:43
Squelched a compiler warning reported at [https://fossil-scm.org/forum/forumpost/4215cf68c7]. check-in: 35ce9e3ed9 user: stephan tags: trunk
2020-06-02
22:34
mv: Handle the case of soft-renaming of a managed sub-directory that was already renamed at the file-system level; see [https://fossil-scm.org/forum/forumpost/f5b13591e3|forumpost/f5b13591e3] check-in: 709d2f804f user: ashepilko tags: trunk
20:05
Add the safe-html setting that determines which kinds of documents are allowed to generate unsafe HTML from Markdown. check-in: 89b6dda99c user: drh tags: trunk
18:55
Documentation improvements on the HTML safer. Only apply safe-html to Forum posts for the moment. check-in: 03ce4e70b6 user: drh tags: trunk
17:38
Update the HTML safeing mechanism so that it does the entire Markdown output all at once. In this way it is better able to cope with block markup that spans multiple paragraphs. check-in: 382f3731ee user: drh tags: trunk
16:20
Added a "no changes" messages if no local files are different; report trying to view a non-existent local file. Tidy-up and added config-options and "what I did" block near top of info.c. check-in: a955c80b43 user: graham tags: ui-local-diff
15:14
Only use safe-html markdown rendering for the Forum. This is a temporary measure to get most things working again while we devise improvements to the safe-html mechanism. check-in: f4e6efb2da user: drh tags: trunk
13:52
Merge in Markdown changes from trunk. check-in: bf5a21e036 user: graham tags: ui-local-diff
12:35
Change the callback function names in markdown_html.c so that they match the pointer names in markdown.c. No functional changes. check-in: 485fda60c3 user: drh tags: trunk
12:29
Refactor the safe-html interface names. Improved comments. No functional changes. check-in: 54c1fd6fbb user: drh tags: trunk
11:23
Fix blob_append_safe_html() so that it can handle the case of nHtml==0. check-in: cd0b228de7 user: drh tags: trunk
2020-06-01
22:46
Adjust the webpage-ex.md page due to the fact that <style> is no longer allowed in Markdown, for security. check-in: 9f9fbb4b56 user: drh tags: trunk
22:24
Quick fix to many of the formatting problems associated with the recent attempts at making the Markdown output "safer". More work to be done, but this check-in will at least get most of the website working again. I hope. check-in: c2875cb444 user: drh tags: trunk
22:12
Added ability for "/local" to display files present in the checkout but not managed by Fossil (cf. "fossil extras"). check-in: 07829f371b user: graham tags: ui-local-diff
20:51
Optimization to markdown formatting - faster determination if a line is part of a table for the common case when it is not. check-in: bd2796b10a user: drh tags: trunk
20:22
Give SQLite a hint to help it run faster in symbolic_name_to_rid(). check-in: d45542ccd2 user: drh tags: trunk
20:12
Remove a redundant call to manifest_get(). check-in: 50ed560c6b user: drh tags: trunk
19:31
Further improvements to the end-tag insertion algorithm. check-in: a7ebb8d77f user: drh tags: trunk
19:16
Improvements to automatic end-tags. check-in: a7807a8b9c user: drh tags: trunk
16:10
When HTML markup is sanitized by the blob_append_safe_html() function, instead of removing offending markup, escape it and put it within an error span. check-in: bc2e6fbeb5 user: drh tags: trunk
14:59
Revert the change at [a3ab0c6186b43236]. In its place, add the blob_append_safe_html() routine that stricts HTML generated by Markdown to be in the set of safe elements as defined by Fossil-wiki. Omit any unsafe elements and/or attributes. Omit unmatched close-tags. Insert missing close-tags. check-in: aadf91723a user: drh tags: trunk
13:11
Rename the htmlTagLength() function to html_tag_length(). check-in: 3f99bca912 user: drh tags: trunk
07:01
Enhance the markdown formatter to ignore certain HTML tags such as <style>. check-in: a3ab0c6186 user: drh tags: trunk
01:14
Folded info from forum thread https://www.fossil-scm.org/forum/forumpost/b770d8edc4 into the Debian/nginx service docs. check-in: 4b98322350 user: wyoung tags: trunk
2020-05-31
11:22
Fixed diff of an individual checked-out file (/localdiff) so it compares against the correct artifact when on a branch. check-in: 5cbb78b486 user: graham tags: ui-local-diff
2020-05-30
22:22
Distinguish local-changes from changes from a merge. check-in: db758a3454 user: graham tags: ui-local-diff
19:32
Merged in UUID-renaming changes from trunk. check-in: 1fd9acb97c user: graham tags: ui-local-diff
16:51
Added "& server" to the "native" row in the characterization table at the top of fossil-v-git.wiki. check-in: 6c04e42f76 user: wyoung tags: trunk
16:39
Small adjustments to the terminology in the summary table at the top of fossil-v-git.wiki. check-in: 38850c03f4 user: wyoung tags: trunk
16:15
Make two passes through list of local changes so all "one-line" entries are listed first. check-in: bc56945ea4 user: graham tags: ui-local-diff
2020-05-29
17:57
Correction to the /thisdayinhistory page so that it shows the first day of the project on the anniversary of the project. check-in: 018db17c54 user: drh tags: trunk
16:46
Update the built-in SQLite to the latest trunk code that includes the new ".mode table" command for formatting output from the CLI. check-in: f6a99292c9 user: drh tags: trunk
10:32
Remove an incorrect foreign key from the mlink table. Many of the other foreign keys are syntactically correct, but Fossil uses numeric 0 instead of NULL to mean "no reference", which is semantically wrong. We should try to fix that at some point, perhaps. Or enhance SQLite so that it is able to interpret 0 values on a FK reference to an INTEGER PRIMARY KEY as if it were a NULL, as an option. Maybe. check-in: 1f5af80047 user: drh tags: trunk
08:05
Move default_css.txt to default.css, treat it like a builtin file, and remove mkcss, as the recent style.css reorg obviates the need for mkcss. check-in: 0c19cd0a86 user: stephan tags: default.css
2020-05-28
21:39
Initial implementation to show "local (uncommitted) changes" in Fossil's UI. Not yet tested to destruction, but fails no more errors in the test-suite than trunk. Currently there are no links to the new page: manually navigate to "/local" (a variant of the "/ci" page). check-in: ccebe22576 user: graham tags: ui-local-diff
19:52
Merged uuid-to-hash branch down, causing all public interfaces except for those exceptions now documented in www/hashes.md to use something other than "UUID" to mean "artifact hash" or one of its more specific derivative terms. (e.g. Commit ID) check-in: 8ad5e46908 user: wyoung tags: trunk
19:47
Second-pass edit on www/hashes.md: more definite stances on things now that we have a ruling on the debate, and less flagellation all around. check-in: 3d808c4d0c user: wyoung tags: trunk
17:37
Updates to the doc/hashes.md document. check-in: 364307951c user: drh tags: trunk
17:21
The new blob_reserve() now triggers blob_panic() if asked to allocate more than blob_append_full() internally allows for (not quite 2GB), to avoid a corner case that blob_reserve() could be used to accidentally bypass that internal limit. check-in: e714b8427c user: stephan tags: trunk
15:46
Updates the email-sender TCL script so that it appends a "-f" argument to sendmail which is the "From:" email address. check-in: a52499fdc4 user: drh tags: trunk
14:58
Initial infrastructure for a command-line version of the security audit page. Leaf check-in: dba4c4f2c4 user: drh tags: audit-command
14:20
Enhance codecheck1.c to check recently added varargs functions. check-in: b17aba9e20 user: drh tags: trunk
13:44
Per forum discussion, moved the /fileedit ajax dispatching back down below the login check, but have it emit a JSON response if an ajax route was requested, else an HTML response. check-in: 62263b9cb0 user: stephan tags: trunk
13:27
fossil.fetch() now uses onreadystatechange instead of onload because the latter does not handle connection errors and timeouts. Added timeout option to fossil.fetch() with a default of 15s. Corrected non-closing of a failed transaction when fileedit/commit fails. check-in: 6849d9a557 user: stephan tags: trunk
12:16
Moved /fileedit permissions check below the ajax dispatching check, as ajax bootstrapping performs that check itself, along with a CSRF check for write-mode requests, and emits a JSON-format response (as opposed to HTML) if it fails. check-in: 13e26db403 user: stephan tags: trunk
12:05
Add a notification that online file editing is enabled to the security audit. check-in: a80861de03 user: drh tags: trunk
12:02
Removed fileedit-glob from the list of syncable config options. It must be explicitly set on each repo where it is desired. check-in: d6341b3a55 user: stephan tags: trunk
12:01
Fix on Check-in pages to preserve the current "diffType" setting (side-by-side or unified) when toggling the show/ignore whitespace option. check-in: e6ab947e1e user: graham tags: ui-local-diff
11:49
Disable all access to the /fileedit page and its associated AJAX entry points if the user lacks write privilege or if file editing is not enabled. check-in: f231239780 user: drh tags: trunk
11:42
Cosmetic fix for "/file?name=xxxx" where ci defaults to "tip". Title used to be "xxxx at []"; now it is "xxxx at tip" which matches the behaviour of "/file?name=xxxx&ci=tip". check-in: 551676bc28 user: graham tags: ui-local-diff
09:47
Added /fileedit to changes.wiki. check-in: 2c9aa1b939 user: stephan tags: trunk
09:40
Introducing the /fileedit page. check-in: 1243bf3999 user: stephan tags: trunk
09:18
Reworked how style.css is emitted: all default rules first, then page-specific rules (if passed name=PAGENAME and if builtin file style.PAGENAME.css exists), then the skin. This increases the default style.css output by only approx. 800 bytes before compression (approx. 300 after compression). Has no visual impact on existing built-in skins, and none is expected on 3rd-party skin edits. See [https://fossil-scm.org/forum/forumpost/d63ff33063|/forumpost/d63ff33063] for discussion. check-in: 064c1c9588 user: stephan tags: trunk
08:55
Editing forum posts now applies delta compression to the edits. check-in: 5b7888c994 user: stephan tags: trunk
08:48
Add --reset flag to add/rm/addremove commands. check-in: e0fc98caa1 user: stephan tags: trunk
2020-05-27
22:41
The "tags" Makefile target added in [ebb67be4] relied on GNU make conditionals, which causes BSD make to choke. Reworked the feature to do the conditional work entirely on the Autosetup side instead. check-in: 42111658ca user: wyoung tags: trunk
22:14
Updated all user-facing documentation and "fossil help" output (plus select internal comments and function names) to use "hash" rather than "UUID". No functional changes. (Yet?) See forum thread https://www.fossil-scm.org/forum/forumpost/ddc14c6866 for discussion. Closed-Leaf check-in: df5201950e user: wyoung tags: uuid-to-hash
22:05
New document, "Hashes: Fossil Artifact Identification", which attempts to break down the HASH vs VERSION vs commit ID vs NAME vs UUID mess. It also serves to document my current understanding of all the ways "UUID" is currently misused, but because it is only documenting the current state of things, it's safe to put it on trunk. (Changes to cope with that particular slice of the mess will appaar later, on a branch.) check-in: 33bec291b0 user: wyoung tags: trunk
20:45
In www/checkin_names.wiki, documented the date: prefix for timestamps, added fragment IDs for subsections, added a differentiating example of "fossil info" vs "/info/NAME" for special check-in names, and documented the order that Fossil resolves such names. check-in: 74a7309aad user: wyoung tags: trunk
19:45
A few small improvements to embeddeddoc.wiki: added a named anchor so we can refer directly to the section talking about "ckout", referred to checkin_names.wiki only once from the relevant paragraph instead of twice, and added a paragraph explaining why this feature is particularly useful. This is in support of an upcoming commit: we're going to remove some redundant commentary about "ckout" in checkin_names.wiki. check-in: 51511b7205 user: wyoung tags: trunk
19:22
Updated release version number in index.wiki. check-in: c0a91653ab user: stephan tags: trunk
17:56
Added a top-level "tags" Makefile target for updating a Vim tags file using Exuberant Ctags (requires -R feature). It also updates a cscope file if we find cscope at configuration time. One so interested could add etags support to this as well. check-in: ebb67be487 user: wyoung tags: trunk
16:56
The error message Fossil gives on TLS certificate check failure changed in Fossil 2.11, so updated www/ssl.wiki to show the new message. Left the old message in place, since many people will be running versions of Fossil that still use that format, and a big part of the reason why we have this error message in the document is to make it come up in web searches for the error, since we give solutions later in the same doc. check-in: 3c0565ab5e user: wyoung tags: trunk
16:02
Merged trunk changes in check-in: 32f391f655 user: wyoung tags: artifact-view-links
13:28
Demonstrate how the mkindex.c utility could be extended to automatically put a complete web-page construction inside a transaction. Closed-Leaf check-in: 67c420402f user: drh tags: auto-webpage-txn
07:56
s/checkin/check-in/ in the help tab, per forum feedback. Closed-Leaf check-in: 91948d3afa user: stephan tags: fileedit-ajaxify
2020-05-26
18:30
Fix a bug in the "Delete Ad-Unit" button in the setup pages. check-in: 48dca1b4c9 user: drh tags: trunk
18:27
Merge in trunk (version-2.11) check-in: 6819e2ffab user: george tags: wiki-history
15:54
Update the version number to 2.12 as we begin the next release cycle. check-in: ad9295fd59 user: drh tags: trunk
15:54
Attempt to fix markdown rendering so that it correctly ignores table column separators that are contained without "code-span" back-ticks. check-in: d6058989ed user: drh tags: trunk
07:42
Removed a no-longer-true line from the fileedit help tab. check-in: 616333e5ba user: stephan tags: fileedit-ajaxify
07:16
Merged in trunk. Closed-Leaf check-in: 58ee06450c user: stephan tags: unaddremove-command
06:56
merged in trunk Closed-Leaf check-in: a2b0ed37af user: stephan tags: forum-edit-deltify
06:47
merged in trunk. Closed-Leaf check-in: fe018289e3 user: stephan tags: style-css-revamp
06:43
Merged in trunk. check-in: 559807ba86 user: stephan tags: fileedit-ajaxify
2020-05-25
23:40
Update the changes log to include a date for 2.11 and to add a place-holder to begin recording 2.12 changes. check-in: 87e3ad3132 user: drh tags: trunk
23:23
Version 2.11 check-in: 4df919803b user: drh tags: trunk, release, version-2.11
17:28
Update the built-in SQLite to version 3.32.1. check-in: bb713f1337 user: drh tags: trunk
2020-05-22
20:16
Merge trunk Closed-Leaf check-in: 1e4aaf7b2e user: jan.nijtmans tags: multi-thread
17:54
Update the built-in SQLite to version 3.32.0. check-in: f82e054fd6 user: drh tags: trunk
16:19
Clean shutdown in the "fossil sql" command. check-in: fbb15cc4a8 user: drh tags: trunk
12:26
For Download links, only include the tail-name of the file in the Content-Disposition header. check-in: 0feb412869 user: drh tags: trunk
00:27
Add CSS rules to limit the width of input and textarea items to 95% of the available screen width. check-in: dbcfcef7ac user: drh tags: trunk
2020-05-21
23:59
Change a case of isalnum() to fossil_isalnum(). check-in: 02e7c86b3f user: drh tags: trunk
23:56
Add a Content-Disposition: header to the HTTP reply for the "Download" button. check-in: 34cb4766f1 user: drh tags: trunk
17:12
This does not work. Was: Alternative way of fixing Download links that provides web-browsers with a suggested filename for saving the file. Closed-Leaf check-in: 232033c98b user: drh tags: mistake
13:00
Fix the URL on some Download submenu links. check-in: 9d18585d54 user: drh tags: trunk
06:32
Added a doc section about CSRF/HTTP Referrer. Other minor doc/message cleanups. check-in: 6de7e48021 user: stephan tags: fileedit-ajaxify
2020-05-19
18:31
Merge in trunk. Closed-Leaf check-in: 0ad3e06bd2 user: ashepilko tags: revert-dir
16:51
Update the built-in SQLite to the third beta for 3.32.0. check-in: a8098efebf user: drh tags: trunk
2020-05-18
12:32
Reverted [5abc0f6e7] because testing has shown the referrer to simply be too fragile and subject to browser-side whims (which also includes the option to send only the scheme and host, without the path, as the referrer, which breaks what that commit did). Now style.css supports both style.css/pagename and style.css?page=name, preferring the former, pending a decision on which one of those syntaxes the other devs prefer. check-in: 45341a2869 user: stephan tags: style-css-revamp
11:48
When compiling with older versions of OpenSSL that do not support SHA256, hash certs using SHA1 instead. check-in: 64d79ad457 user: drh tags: trunk
10:55
Fix harmless compiler warnings in http_ssl.c that occur when building without SSL support. check-in: b2824009b2 user: drh tags: trunk
06:05
Internal commentary on the validity of the global UI enable/disable approach to XHR handling. check-in: 7a95a0f178 user: stephan tags: fileedit-ajaxify
05:19
Added optional fossil.fetch() beforesend/aftersend callbacks to allow us to... /efilepage now disables all input elements while AJAX requests are in-flight and updates the page with a 'wait' cursor. check-in: 7e197260fd user: stephan tags: fileedit-ajaxify
03:41
Replaced style.css?page=xxx with style.css/page, like the [style-css-revamp] branch does. check-in: bc40707425 user: stephan tags: fileedit-ajaxify
03:38
Removed doc/help references to "overriding" CSS rules, as that no longer applies in this branch. check-in: a21e26684f user: stephan tags: style-css-revamp
03:24
All /fileedit/ajax requests now do a CSRF check and fail with 403 if CSRF seems likely. check-in: 88a69253cd user: stephan tags: fileedit-ajaxify
02:59
style.css now checks for a builtin file named after the first path component of the referer (sic), rather than PD("name"), however, we still have to emit style.css/PAGENAME in $stylesheet_url in order to pick up the the page-specific CSS, otherwise /style.css?id=... is the same for all pages and a page with its own style may pick up a cached copy without its own styles, or with the styles from another page. check-in: 5abc0f6e79 user: stephan tags: style-css-revamp
2020-05-17
20:38
Allow unversioned files to be identify by hash in addition to name. For the /uv webpage, when a file is identify by hash it has a long expiration time. check-in: b5ab1ebe5e user: drh tags: trunk
19:55
Removed accidental dual-emit of skin-level CSS. Copy/paste bug. check-in: eddb5ac552 user: stephan tags: style-css-revamp
19:49
Eliminated an unnecessary allocation. Code style conformance tweaks. check-in: e2a9fe4bc8 user: stephan tags: style-css-revamp
18:56
Cherrypick [100c67fa] for bootstrap skin fix. check-in: 06c7d57d18 user: stephan tags: style-css-revamp
17:52
Proof of concept for my proposal of reworking how style.css emits CSS, as discussed in [https://fossil-scm.org/forum/forumpost/d63ff33063|forumpost/d63ff33063]. check-in: ae10ddf330 user: stephan tags: style-css-revamp
17:07
Merged in trunk. check-in: b9b746e50f user: stephan tags: fileedit-ajaxify
16:33
Update the built-in SQLite to the second 3.32.0 beta, for testing. check-in: 5181332eb5 user: drh tags: trunk
12:59
Fix and improve comments associated with the previous check-in. check-in: 3cbf02aceb user: drh tags: trunk
12:55
Improvements to the skin_id() routine. check-in: 56ad55415f user: drh tags: trunk
2020-05-16
01:08
Integrate ARIA suggestions from Peter Laursen. check-in: 7dd07b2e01 user: drh tags: trunk
2020-05-15
13:49
Typo fix on the homepage. check-in: 5f66f28806 user: drh tags: trunk
2020-05-14
17:03
Fix the upper bound on the number of digits of hash to display so that it can display full-length SHA3-256 hashes. check-in: 311aa9dd67 user: drh tags: trunk
15:01
Fixed a comment: it was not only referring to the now-removed /test-forumnew page, it didn't properly describe what followed. check-in: 0475b4f120 user: wyoung tags: trunk
2020-05-13
18:49
Update the built-in SQLite with the patch to support the IIF() function. check-in: 6fa4d92e6a user: drh tags: trunk
11:59
Add the --db-only and --quick options to the test-integrity command. check-in: 6711b22251 user: drh tags: trunk