Fossil: View Ticket

2012-11-30
15:53		• Fixed ticket [46bf4baedc]: wrongly reported illigal character, "" and "" plus 1 other change artifact: dc44506c53 user: drh
15:52		Allow characters *[]? to appear in filenames. Tickets [46bf4baedce] and [d17d6e5b174bd6] and [10aee063c413c107] check-in: 647bb7b79f user: drh tags: trunk
13:05		Changes to allow *[]? in check-in comments were added by check-in [647bb7b79f3c2a], which is sufficient to address ticket [46bf4baedcea6c]. The additional logic in this branch that tries to do special encodings for double-quote characters on windows is complication we can do without. Was: fix merge problem, which cause an OSX broken build check-in: 7885b60187 user: jan.nijtmans tags: ticket-d17d6e5b17
2012-11-19
01:46		• Ticket [46bf4baedc] wrongly reported illigal character, "" and "" status still Closed with 1 other change artifact: 8eba5abcfc user: anonymous
2010-02-10
20:13		• Ticket [46bf4baedc]: 1 change artifact: b88445aa5f user: drh
13:20		• Closed ticket [46bf4baedc]. artifact: f9406ba8c8 user: drh
10:19		• New ticket [46bf4baedc]. artifact: 79a1ebe520 user: anonymous

Ticket Hash:	46bf4baedcea6ca9df279e3ddd813c263db46f1c
Title:	wrongly reported illigal character, "[" and "]"
Status:	Fixed	Type:	Code_Defect
Severity:	Important	Priority:
Subsystem:		Resolution:	Fixed
Last Modified:	2012-11-30 15:53:23 13.33 years ago	Created:	2010-02-10 10:19:34 16.14 years ago
Version Found In:	94bb313444

Description:

This has been tested under windows only.

Create a file named: $ () + ,-!= @ [ ]^_{ }~.txt

This file is perfectly legal under windows (WinXP) but if i try to add it via: fossil add "testCase-fileUpload\$ () + ,-!= @ [ ]^_{ }~.txt"

I get

fossil: filename contains illegal characters: testCase-fileUpload/$ ( ) + ,-!= @ [ ]^_{ }~.txt

Basically it chokes over the ] and [ characters.

Regards.

drh added on 2010-02-10 13:20:00:
The [ and ] characters are also legal for Unix filenames. (Any character other than 0x00 and / is valid in a unix filename.) But [ and ] are used as globbing characters by the shell, so there use must be escaped in the shell. this can lead to subtle problems. So as a safety mechanism, I deliberately disallow such filename characters in Fossil.

Behavior is by design.

anonymous added on 2012-11-19 01:46:46 UTC:
Yes, I agreed [ and ] has special usage under Unix, but I am a Win32 user, and I have a lots of files contains [ and ]. So I think we should add a option to check whether we need to valid those characters, by default, it's ON, but I can choose to disable it(OFF to check it) . It's the only blocker stops me to use fossil..