Fossil

History of src/fileedit.c of b7f70ffc14489d7f
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

History of file src/fileedit.c at check-in b7f70ffc14489d7f

2025-12-28
23:00
Remove some more duplicates in comments. No functional changes. file: [b919130f16] check-in: [d83638e40e] user: danield branch: trunk, size: 73532
2025-12-23
16:06
Assorted fixes of typos and grammar in code comments. No functional changes. file: [ad22643378] check-in: [e2bdc10572] user: danield branch: trunk, size: 73536
2025-10-28
15:05
Cache the name of the main branch. file: [0ab7f117c3] check-in: [ca0d66b2e4] user: danield branch: trunk, size: 73538
2025-10-23
14:50
Replace hard-coded "trunk" with the value of 'main-branch' (defaulting to "trunk"). file: [67943e54cb] check-in: [dd8995bbdd] user: danield branch: softcoded-main-branch, size: 73546
2025-08-01
04:50
Added the --verbose|v flag to the test-looks-like-utf8 command so that one can find out why a command like "fossil ci" is considering an input known to be text as "binary", then fix it. file: [e86ff60ed8] check-in: [cf6c15bb28] user: wyoung branch: verbose-looks-like, size: 73535
2025-07-23
15:58
Minor optimization: replace calls to mprintf("%s", X) with fossil_strdup(X). file: [3d4a726208] check-in: [4c3e1728e1] user: danield branch: trunk, size: 73529
2024-10-12
12:03
Emit only \n, not \r\n, even in places where protocols technically require a full \r\n. Provide a compile-time option -DSEND_CR=1 that includes the CRs when necessary. file: [61518be239] check-in: [0dcce257b0] user: drh branch: omit-cr, size: 73527
2024-02-02
22:18
Remove trailing whitespace from non-external C files. file: [9e040d72f6] check-in: [7db0a2d910] user: danield branch: fix-overlength-lines, size: 73525
16:26
Fix lines over 80 characters long, excluding external source files and @-lines. file: [2882ac0404] check-in: [942f691b39] user: danield branch: fix-overlength-lines, size: 73538
2023-12-16
01:10
In /wikiedit and /fileedit, add a checkbox to disable shift-enter for toggling preview, as per discussion in [forum:dbd5b68366147ce8|forum post dbd5b68366147ce8]. file: [3ad5ab4df6] check-in: [8c1c4fa985] user: stephan branch: shift-enter-preview, size: 73566
2023-02-17
14:37
A large collection of compiler warning fixes re. signed/unsigned comparison from Daniel D. file: [db34273e01] check-in: [c71f711ec9] user: stephan branch: compiler-warnings, size: 73505
2023-01-09
13:06
Further consistency improvements in docs for various commands. file: [cd96c3b433] check-in: [2512d2d472] user: km branch: trunk, size: 73500
2022-12-21
11:52
Merge in help consistency improvements. file: [37dc9887fa] check-in: [526b0a54c4] user: danield branch: check-in-spelling, size: 73515
2022-12-20
09:46
Change spelling for check-in and similar file: [82c70eecc9] check-in: [d9c4321e7a] user: danield branch: check-in-spelling, size: 73514
2022-11-16
20:05
Fix harmless typos reported by [forum:/forumpost/15f7327318|forum post 15f7327318]. file: [ce1b992983] check-in: [f3adbd8874] user: drh branch: trunk, size: 73473
2022-11-13
16:26
Apply fixes to all web views to pass WCAG 2.1 tests performed by "axe DevTools" browser extension. Most fixes related to screen reader compatibility, like making sure that form elements have labels. Some color changes to improve contrast on Default skin. Made more HTML5 compliant. Minor improvement to select combo boxes for UX. Improved Search form UX. Two minor bug fixes for malformed HTML. Fixed help pages to resolve issues with non-compliant HTML being generated. Mostly documented at https://fossil-scm.org/forum/forumpost/aafb17a981df4166 file: [9b97d9b224] check-in: [1f231db380] user: ericwikman branch: wcag-2.1, size: 73541
2021-09-14
22:07
eagle skin: cleaned up the clock-update JS function and modernized the logo appearance a bit. /fileedit: fixed a help test typo. file: [a2929d6f2b] check-in: [7912deb5fd] user: stephan branch: trunk, size: 73472
09:04
/wikiedit and /fileedit can now dynamically load more diff context. Discovered that the unified diff scrolling under the new diff model is not quite right and the magical CSS invocations to solve it properly elude me: for now they're scrolling (if needed) from a higher parent container level of the DOM than they should be, so the line numbers scroll along with the code. file: [b83b45de0b] check-in: [ef69044cf9] user: stephan branch: trunk, size: 73471
2021-09-07
22:28
Ongoing refactoring and feature-adding related to the JS/ajax components of the new diff views. file: [52ded97da7] check-in: [65aa2c9643] user: stephan branch: diff-js-refactoring, size: 73384
2021-09-02
14:25
Various improvements and bug fixes to the new diff logic. file: [cb2f19fcaa] check-in: [10f736f04f] user: drh branch: diff-color-enhancements, size: 73372
2021-03-11
13:22
Numerous help text consistency tweaks based on forum discussion [forum:8c644048f0]. file: [985a7c8047] check-in: [4cb50c4ef3] user: stephan branch: trunk, size: 73375
2021-02-05
09:32
Amend 'fossil help' output for all commands to make options conform to GNU 'short|long' convention (e.g., -v|--verbose). file: [fc24522347] check-in: [7f3c728db3] user: jamsek branch: trunk, size: 73375
2020-12-22
12:13
Removed the parameter from style_finish_page() since the resulting content div class is now redundant with respect to the body class. This potentially breaks CSS made against old class names that a prior commit on this branch changed, but such skins would be made against an unreleased version of Fossil, it's unlikely many are using that first version of the feature anyway, and most of the class names did *not* change unless you were targeting a "div" instead of "body" or just a generic class name. None of the shipping skins are affected. file: [b016229301] check-in: [0e83ca88ce] user: wyoung branch: body-feature-class, size: 73375
2020-12-04
18:35
The variadic function builtin_fossil_js_bundle_or() was using 0 as a sentinel to detect end-of-list, but that isn't equivalent to NULL in a list of pointed-to objects in all C compilers, on all systems. Using a GCC/Clang function attribute to force a warning when 0 is passed instead of NULL, then fixed all resulting warnings. This fixes the SEGV reported in [forum:/forumpost/5feca9c36a|forum post 5feca9c36a] on Mac OS X 10.11 with Clang from Xcode 7. Later versions of Clang on macOS don't have this problem, but it's still UB, so fixing it may solve some pain for us later on. file: [742f482f3b] check-in: [815b4fc493] user: wyoung branch: trunk, size: 73395
2020-11-07
13:25
Rename the "style_body_and_footer()" interface to "style_finish_page()" and add a more detailed header comment to the implementation. file: [90dbe9306c] check-in: [942b2076c6] user: drh branch: default-css-cleanups, size: 73392
2020-11-05
23:15
Added a parameter to style_footer() and renamed it to match its actual function (style_body_and_footer()) so we can add a CSS class to each page that indicates which major Fossil feature served the page, so we can have module-specific CSS. file: [4d8aae086d] check-in: [ef5424b683] user: wyoung branch: default-css-cleanups, size: 73400
2020-09-18
09:21
Fixed a preview quirk which caused the pikchr click handlers to not get processed on wikiedit/fileedit previews after the first one. file: [7af9d6b27e] check-in: [052d374809] user: stephan branch: trunk, size: 73362
05:07
Minor C-side fossil JS API simplification to ease upcoming changes. file: [225d05554d] check-in: [58d86b16bf] user: stephan branch: trunk, size: 73381
03:28
Clarify the origin of JS in the generated HTML. file: [595d796d05] check-in: [6854244949] user: drh branch: trunk, size: 73435
2020-09-15
16:40
fossil.pikchr.addSrcView() now tags each processed SVG element to avoid potentially processing the same one multiple times. Added fossil.pikchr support to /doc, /wiki, and /wikiedit/fileedit previews. This is harmless if there are no pikchrs or JS is disabled. file: [34629a5d53] check-in: [83f03e91c4] user: stephan branch: trunk, size: 73429
2020-09-12
06:13
Added style_emit_noscript_for_js_page() to emit a NOSCRIPT tag and an error message if JS is not available, and call it from the pages which *required* JS in order to work. Added a note about potential browser-induced SVG blurring when using the pikchrshow dark mode option. file: [88c6dfec77] check-in: [070716d835] user: stephan branch: trunk, size: 73373
2020-08-24
22:46
Improved cross-page caching of wikiedit/fileedit bundle, reducing those pages to a single request of 10-13k once cache is warm. Fixed non-bundled JS distribution of fileedit and wikiedit. file: [5888dd53fd] check-in: [20c50cd1e5] user: stephan branch: misc-js-experiments, size: 73336
22:20
Moved C routines which emit fossil.XYZ JS APIs from style.c to builtin.c, and renamed appropriately. Added flag to output_text_with_line_numbers() to disable emit of JS (needed for fileedit preview, at a minimum). The experimental emitting of all fossil.XYZ APIs at once is now limited to bundled mode, as that's the only place it's potentially of benefit. file: [b50bca957e] check-in: [c515e5fd9f] user: stephan branch: misc-js-experiments, size: 73319
20:49
Experimentally added '?' help buttons in wikiedit. Experimentally emit all fossil.XYZ APIs, rather than selected ones, to test whether that reduces overall transmission together with caching. DOM init-time timing workarounds to get confirmer buttons to pin their sizes properly. file: [53c86bb6ec] check-in: [9edbb7eab1] user: stephan branch: misc-js-experiments, size: 73261
2020-08-14
14:38
fileedit: removed a call to blob_reserve() (optimization) because we have a report which seems to imply that it unconditionally fails on mingw 32-bit builds. file: [fc44a733b2] check-in: [b99c069a2c] user: stephan branch: trunk, size: 73125
2020-08-12
11:44
Minor style consistency/layout tweaks to wikiedit and fileedit. file: [042eaf55a2] check-in: [e7c348f1d9] user: stephan branch: trunk, size: 73330
2020-08-11
15:29
fileedit confirmer buttons now use the new pinSize confirmer option. Minor style consistency tweak. fileedit no longer complains when discarding stashed edits when no file is loaded, and reloads the current file only if it was in the now-discarded local edits. file: [9a42c56d4e] check-in: [83a95dbff1] user: stephan branch: trunk, size: 73373
09:29
Doc tweaks only - no code changes. file: [64e4cdb868] check-in: [b5496da66f] user: stephan branch: trunk, size: 73347
2020-08-10
17:38
Added a 'Save and Close' button to wikiedit. Cleaned up the styling and wrapping of the status/links menu bars in fileedit and wikiedit. Minor style tweaks to get input field borders to appear in the default skin on Chromium. file: [cd3630676d] check-in: [3814c9ff58] user: stephan branch: trunk, size: 72424
11:53
/fileedit now embeds the current open leaf list and the file list for the current checkin (defaulting to the most recent leaf) in the page content, saving 2 XHR requests at startup. If passed filename= without checkin= then it tries to load the given file from the most recent leaf. file: [b26fa035e6] check-in: [5fc0f7c33a] user: stephan branch: trunk, size: 72444
2020-08-01
21:31
Ported several features between wikiedit and fileedit, improving them both a bit. file: [678c0799e6] check-in: [0d5006bed5] user: stephan branch: trunk, size: 71277
13:53
Merged in the Ajax-based /wikiedit reimplementation. file: [565417a4f2] check-in: [19f2753522] user: stephan branch: trunk, size: 71145
2020-07-31
23:33
Merged in trunk for builtin_request_js() changes and ported wikiedit/fileedit/forumpost to use those. file: [e727fc59b5] check-in: [2ec332a0c2] user: stephan branch: ajax-wiki-editor, size: 71147
21:57
Further simplification of the javascript loading code. file: [b979a544d5] check-in: [b7f70ffc14] user: drh branch: refactor-js-handling, size: 70814
21:47
Replace various style_emit_script...() calls with builtin_request_js(). file: [ebd731d85a] check-in: [699a977cfc] user: drh branch: refactor-js-handling, size: 70791
18:49
Made all tab elements hidden on /fileedit to lessen the impact of FOUC before JS assembles the tabbed interface. file: [ad04d89722] check-in: [99f288d2a5] user: stephan branch: ajax-wiki-editor, size: 71260
16:44
Corrected doc falsehoods. file: [dea0167ce8] check-in: [1f0a3354aa] user: stephan branch: ajax-wiki-editor, size: 70975
16:40
Added style_emit_script_bundle() to simplify page-level bundle usage a small bit. /forumpost, /wikiedit, /fileedit now use that routine. file: [1d16107f74] check-in: [0c233bc697] user: stephan branch: ajax-wiki-editor, size: 71003
16:14
Extended /builtin/filename to support /builtin/:filename for packing up cacheable bundles of page-specific code. /wikiedit, /fileedit, and /forumpost now serve their JS that way. file: [352d84abf4] check-in: [18da05b903] user: stephan branch: ajax-wiki-editor, size: 71011
14:44
/wikiedit and /fileedit now dump all of their common static JS into a single SCRIPT tag instead of making numerous requests, per forum feedback. Fixed/expanded some of the newer script-emitting logic in style.c to handle these. wikiedit no longer mangles the page-level header. file: [9f7e1bf186] check-in: [a4b73fd081] user: stephan branch: ajax-wiki-editor, size: 71072
2020-06-11
07:22
Refactored the generic ajax-related parts of src/fileedit.c into src/ajax.c for eventual re-use in other pages. Added /ajax "page" to act as a dispatcher for page-agnostic ajax routes. file: [8aff0a8529] check-in: [c313cac828] user: stephan branch: trunk, size: 70721
2020-06-03
22:43
Squelched a compiler warning reported at [https://fossil-scm.org/forum/forumpost/4215cf68c7]. file: [f2a148f1eb] check-in: [35ce9e3ed9] user: stephan branch: trunk, size: 79113
2020-06-02
20:05
Add the safe-html setting that determines which kinds of documents are allowed to generate unsafe HTML from Markdown. file: [97ba8230ad] check-in: [89b6dda99c] user: drh branch: trunk, size: 79092
17:38
Update the HTML safeing mechanism so that it does the entire Markdown output all at once. In this way it is better able to cope with block markup that spans multiple paragraphs. file: [4c67b034ce] check-in: [382f3731ee] user: drh branch: trunk, size: 79057
2020-05-28
14:20
Enhance codecheck1.c to check recently added varargs functions. file: [d7b1c125e7] check-in: [b17aba9e20] user: drh branch: trunk, size: 79054
13:44
Per forum discussion, moved the /fileedit ajax dispatching back down below the login check, but have it emit a JSON response if an ajax route was requested, else an HTML response. file: [7d130c6316] check-in: [62263b9cb0] user: stephan branch: trunk, size: 79062
13:27
fossil.fetch() now uses onreadystatechange instead of onload because the latter does not handle connection errors and timeouts. Added timeout option to fossil.fetch() with a default of 15s. Corrected non-closing of a failed transaction when fileedit/commit fails. file: [bf253d3d84] check-in: [6849d9a557] user: stephan branch: trunk, size: 78717
12:16
Moved /fileedit permissions check below the ajax dispatching check, as ajax bootstrapping performs that check itself, along with a CSRF check for write-mode requests, and emits a JSON-format response (as opposed to HTML) if it fails. file: [43fc5f0039] check-in: [13e26db403] user: stephan branch: trunk, size: 78717
12:05
Add a notification that online file editing is enabled to the security audit. file: [f04df0cec5] check-in: [a80861de03] user: drh branch: trunk, size: 78568
11:49
Disable all access to the /fileedit page and its associated AJAX entry points if the user lacks write privilege or if file editing is not enabled. file: [c7727840c4] check-in: [f231239780] user: drh branch: trunk, size: 78576
2020-05-27
07:56
s/checkin/check-in/ in the help tab, per forum feedback. file: [5c4ec921aa] check-in: [91948d3afa] user: stephan branch: fileedit-ajaxify, size: 78089
2020-05-26
07:42
Removed a no-longer-true line from the fileedit help tab. file: [162ab8530f] check-in: [616333e5ba] user: stephan branch: fileedit-ajaxify, size: 78086
2020-05-21
06:32
Added a doc section about CSRF/HTTP Referrer. Other minor doc/message cleanups. file: [4dbfdd1bc5] check-in: [6de7e48021] user: stephan branch: fileedit-ajaxify, size: 78221
2020-05-18
03:24
All /fileedit/ajax requests now do a CSRF check and fail with 403 if CSRF seems likely. file: [b14d75b940] check-in: [88a69253cd] user: stephan branch: fileedit-ajaxify, size: 78068
2020-05-17
06:40
Minor style improvements. Dry-run mode is now OFF by default. Reordered checkboxes on the commit tab. Eliminated a couple more uses of the term 'stash' (for local edits), to avoid potential confusion with fossil's stash feature. file: [8c39662008] check-in: [42f2cd77d5] user: stephan branch: fileedit-ajaxify, size: 77863
04:08
Replaced /fileedit?ajax=blah with /fileedit/blah. This simplifies the passing of URL arguments, eliminating it in several cases, and just looks nicer. file: [e48f26afda] check-in: [2c4e7c3785] user: stephan branch: fileedit-ajaxify, size: 77813
03:35
Several layout tweaks. The 'Prefer delta?' option is now checked by default if the repo contains any deltas and the forbid-delta-manifests setting is not true (that setting trumps this checkbox, in any case). file: [c9e54f73b9] check-in: [25f5f592d1] user: stephan branch: fileedit-ajaxify, size: 77514
2020-05-16
17:05
Clear the preview/diff views after a non-dry-run commit. Added toggle to include (or not) manifest in the commit response. Added branch name to finfo objects from the server so that we have the branch names for stashed non-leaf edits. Extended fossil.connectPagePreviewers() to be able to optionally specify methods, instead of element IDs, for the 'from' source and 'to' target, in order to support custom editor/preview widgets. file: [184c89d946] check-in: [b5944d4ede] user: stephan branch: fileedit-ajaxify, size: 77357
06:34
Removed the hard-coded restriction against using /fileedit on the main fossil repo and tweaked an error message. file: [d8774780b7] check-in: [3c795e877c] user: stephan branch: fileedit-ajaxify, size: 74956
05:03
Added widget to browse/select locally-edited files. Related cleanups and refactoring. file: [dceebf551d] check-in: [aefceac57c] user: stephan branch: fileedit-ajaxify, size: 75523
2020-05-15
18:43
/fileedit now uses fileStorage or sessionStorage, if available, to store unsaved local edits to the 7 most recently edited checkin/file combinations. TODO: make that configurable and offer a widget to manage that stash and quickly switch between those files. It warns loudly if persistent storage is not available. file: [1090533ffc] check-in: [d130f35687] user: stephan branch: fileedit-ajaxify, size: 75886
04:40
Modernized sbsdiff.js a tiny bit, adapted it to optionally be callable multiple times via fossil.page.tweakSbsDiffs(), and activate that when fileedit's sbs diff is refreshed. file: [e920e4985f] check-in: [dd46579617] user: stephan branch: fileedit-ajaxify, size: 74864
04:20
Internally rearranged how diff flags are passed around, in anticipation of having to refactor for wiki/forum diffs. Added annotate/blame links to /fileedit's first tab. file: [9ff5770888] check-in: [39a5241b6f] user: stephan branch: fileedit-ajaxify, size: 74835
03:35
Cleaned up some JSON output using the new %!j format. file: [a91c7692b5] check-in: [d9fffa4c58] user: stephan branch: fileedit-ajaxify, size: 73688
2020-05-14
23:34
EOL conversion: had neglected to pass that option on in the ajax request. Fixed a bug which caused duplicate CRs to get injected into force-to-windows-EOL conversions. file: [415089d0c1] check-in: [439f446df6] user: stephan branch: fileedit-ajaxify, size: 73719
04:14
Removed some dead code. file: [30752ffb56] check-in: [4619c9a772] user: stephan branch: fileedit-ajaxify, size: 73172
03:55
Minor help text, style, and layout tweaks. file: [cbe26df031] check-in: [28b2261b75] user: stephan branch: fileedit-ajaxify, size: 73224
03:39
The filename/version block on the first fileedit tab is now generated completely dynamically, rather than being filled out with '???' with broken links before a file is loaded. file: [bb334d05f8] check-in: [371b162ff3] user: stephan branch: fileedit-ajaxify, size: 73214
03:00
fileedit: now gets the file perms via the response header and updates the Is Executable checkbox accordingly. Similary, mimetype is now harvested from the response headers and is used, in place of file extensions, for the "is this a wiki page?" determination. Added fossil-level event infrastructure to allow pages to communicate page-specific events to skin-injected/user-supplied JS code, and fileedit now emits a fileedit-file-loaded event when it loads a new file. Replaced old uses of the term "save" with "commit", per forum feedback. file: [2401f8bb01] check-in: [f1b2e509e7] user: stephan branch: fileedit-ajaxify, size: 73538
2020-05-12
13:25
/fileedit now accommodates relative links in wiki-rendered previews by dynamically adjusting/restoring the base.href when the preview tab is selected/deselected, and the backend can now report to the client, via response header, which rendering mode was selected, allowing the UI to adjust from 'Guess' to the current format. file: [0d626aefe0] check-in: [2bec2c758f] user: stephan branch: fileedit-ajaxify, size: 73162
10:24
/fileedit now squelches errors related to 'missing' URL args, as they are now optional. It also now displays an informative warning at the top of the page if fileedit-glob is not set or is empty. Added a hint about hyperlink in the preview page. Added a Help tab with useful(?) tips. file: [0b5e1159b5] check-in: [c145140d3e] user: stephan branch: fileedit-ajaxify, size: 72577
08:54
Double-clicking the status message bar now clears the message (useful when a long HTML-format error comes in via ajax). Removed the unsightly 'new and experimental' banner. file: [fcf98a15ce] check-in: [ff7ad7125f] user: stephan branch: fileedit-ajaxify, size: 69940
08:28
After committing, reload the leaves/files list. Added a reload button to the leaves/files widget. Several style improvements. file: [7301c8be7b] check-in: [2318c419c9] user: stephan branch: fileedit-ajaxify, size: 70003
2020-05-11
13:03
Replaced the /fileedit_AJAX_ROUTE calls with /fileedit?ajax=ROUTE_NAME to eliminate the dispatch-time and help-system bloat. file: [b7d56570ec] check-in: [9f26fd1eee] user: stephan branch: fileedit-ajaxify, size: 69988
12:06
Removed a trailing 'ajax' WEBPAGE flag which should not have been checked in. file: [c1563e02a0] check-in: [50a6a75ba1] user: stephan branch: fileedit-ajaxify, size: 69430
11:51
/fileedit no longer requires URL arguments: it has a leaf checkin/file selection list on the first tab. file: [f8966d6ed7] check-in: [e184992161] user: stephan branch: fileedit-ajaxify, size: 69435
2020-05-10
19:51
Fixed a semantic collision in the fileedit 'column' CSS class, which means something different in the /dir page. This fixes mis-alignment of the commit button. file: [889daec5ae] check-in: [d0a83a38f5] user: stephan branch: fileedit-ajaxify, size: 66395
19:42
Minor tooltip tweaks. file: [2af13e12f8] check-in: [0b1085d724] user: stephan branch: fileedit-ajaxify, size: 66299
09:16
Minor efficiency hack in style_emit_script_builtin() and swapped a potentially problematic ordering of two JS includes. file: [63f7d72e2e] check-in: [c60ad868b4] user: stephan branch: fileedit-ajaxify, size: 66404
08:47
Several small style tweaks. Changed style_labeled_checkbox() parameter order for better readability. TabManager class now supports events alerting before/after a tab is switched to. Added auto-refresh of preview when the preview tab is activated, with a checkbox to disable it for slow connections and/or large documents (the refresh button still works as before). file: [771e584adb] check-in: [ee175636aa] user: stephan branch: fileedit-ajaxify, size: 66404
2020-05-09
13:56
Disable rendering of the comment mime type selection list, as it's not honored/implemented where comments are rendered. file: [6efec17c81] check-in: [875b60bccd] user: stephan branch: fileedit-ajaxify, size: 65947
12:54
Determine which comment editing mode to enable based on which of the editor fields is hidden by default, so that we stay in sync if the C side changes. file: [378571494b] check-in: [a4314603f7] user: stephan branch: fileedit-ajaxify, size: 65372
12:36
Added style_select_list_str(), selection list for commit comment mime type, and a toggle to switch between single- and multi-line comment editing modes. file: [6131999976] check-in: [4d5004ef2d] user: stephan branch: fileedit-ajaxify, size: 65314
2020-05-08
14:15
Swapped the style_emit_script_builtin() parameters for consistency with style_emit_script_tag(). file: [023126ca26] check-in: [02240eec90] user: stephan branch: fileedit-ajaxify, size: 64459
14:00
Delay the initial filepage loadFile() until a windows.load event. This seems to eliminate what appears to have been a race between that call and the filepage init code. file: [70c91c9d35] check-in: [07d0bcc598] user: stephan branch: fileedit-ajaxify, size: 64458
12:39
/fileedit now accepts 'fn' and 'ci' as undocumented aliases for 'filename' resp. 'checkin', for consistency with some other pages. style_emit_script_builtin() now includes a cache-buster on URLs (a prefix of the builtin content's MD5 hash). file: [870b18e1d0] check-in: [3733293a01] user: stephan branch: fileedit-ajaxify, size: 64395
2020-05-07
01:19
Added hash_digits() info to fossil.config object and added fossil.hashDigits(). Factored out fileedit JS use of innerHTML where possible. Reworked the Version Info tab a bit. file: [dfcf7d9c08] check-in: [29567e6e7e] user: stephan branch: fileedit-ajaxify, size: 63547
2020-05-06
22:57
Improved the tab control styling, and no longer use buttons so that their :focus style doesn't break the appearance. Fixed some CSS which no longer matched after removal of the outer wrapping FORM element. file: [021baf9bfe] check-in: [a84f6458c0] user: stephan branch: fileedit-ajaxify, size: 63577
17:52
Renamed the file=filename, r=checkin query params to filename=..., checkin=..., for consistency with the annotate/blame URLs and possibly others. file: [2c2aed4beb] check-in: [6b7805e056] user: stephan branch: fileedit-ajaxify, size: 63109
17:37
s/f-post-/f-preview-/. file: [369419c09d] check-in: [99bd288bce] user: stephan branch: fileedit-ajaxify, size: 63006
17:33
First step in the automation of connecting an editor widget to a preview-mode widget, as demo'd in [https://fossil-scm.org/forum/forumpost/d44564bad4|/forumpost/d44564bad4]. file: [4af0b014ac] check-in: [7ede6122e5] user: stephan branch: fileedit-ajaxify, size: 62997
04:52
Minor code style improvements, fixed a couple jquery-isms in the confirmer port, added the ability to select tabs by number and pre-select a specific tab, removed a superfluous C function. file: [e3e011431b] check-in: [9085ec2351] user: stephan branch: fileedit-ajaxify, size: 62685
03:02
Added fossil.confirmer JS API to offer a non-intrusive click confirmation mechanism. Re-activated the /filepage content reload button with a confirmation click required. file: [bd63db9624] check-in: [e70ab3a368] user: stephan branch: fileedit-ajaxify, size: 62432
01:58
Removed the FORM element - it was superfluous and particularly stubborn in how it responded to every button. file: [1f3443a09f] check-in: [7635d9345d] user: stephan branch: fileedit-ajaxify, size: 62145
01:51
Reworked how /fileedit loads its JS - it now fetches them rather than embedding them inline. Moved fossil.fetch() docs from style.c into the JS file. file: [b09e8a25d4] check-in: [b48212f6ea] user: stephan branch: fileedit-ajaxify, size: 62742
2020-05-05
23:54
Re-added the editor font size selector. Added a button to discard/reload edits, but it's too easy to activate by accident, so it's disabled until we have a common confirmation mechanism in place. Added timestamp to fossil.message() and fossil.error() output. file: [29a46fbb4f] check-in: [25dfd243a1] user: stephan branch: fileedit-ajaxify, size: 62926
23:31
Added missing checks for negative result value from symbolic_name_to_rid() (indicating an ambiguous name). file: [f993b4a943] check-in: [d8c21f2f09] user: stephan branch: fileedit-ajaxify, size: 62369
22:18
Added option to render HTML previews inline, as opposed to in an iframe. Layout improvements in the preview/diff/commit tabs. file: [960eb0b1e3] check-in: [bd81a5f601] user: stephan branch: fileedit-ajaxify, size: 62203
21:41
Unified diff now produces empty output when the diff is empty, insead of an empty wrapper element. file: [10ccd061d8] check-in: [146e867eb5] user: stephan branch: fileedit-ajaxify, size: 62010
16:51
Completely overhauled the /fileedit layout, using a homebrew tabbed interface. file: [5ee3e9494f] check-in: [33ffe5762b] user: stephan branch: fileedit-ajaxify, size: 61988
11:51
/fileedit_content now only uses application/octet-stream for files which explicitly have that type via mimetype_by_name() or which look like binary content, falling back to text/plain, per suggestion in the discussion thread. file: [53aa50f774] check-in: [4270ecb3a2] user: stephan branch: fileedit-ajaxify, size: 60029
08:41
Numerous minor cleanups. file: [aa8ecf0b15] check-in: [f54ac21745] user: stephan branch: fileedit-ajaxify, size: 59922
06:48
Ajaxified commit. All that's left is cleanup and prettification. file: [a989f8988f] check-in: [1a6c5090ce] user: stephan branch: fileedit-ajaxify, size: 59465
04:06
Initial work on ajaxifying /fileedit. Fetching content, preview, and diffs are ajax'd, but save is not yet. file: [b0da37855b] check-in: [8edf9dbfc2] user: stephan branch: fileedit-ajaxify, size: 58158
2020-05-04
23:26
Moved some generic fileedit code to style.c. Refactored /fileedit to not require JS to update version info, making this impl pure no-JS. Now to ajaxify it... file: [b7cc73cb31] check-in: [8d4ce834ed] user: stephan branch: checkin-without-checkout, size: 58592
17:48
Add the submit button IDs programmatically (was previously hand-coded), to avoid them getting out of sync with their enum. file: [5175c583dc] check-in: [032a0326e8] user: stephan branch: checkin-without-checkout, size: 59540
17:44
Added SBS/unified diff to /fileedit. file: [28cbf39ad3] check-in: [ae8e24d021] user: stephan branch: checkin-without-checkout, size: 59469
16:22
Style improvements and code consolidation. file: [9be83ab4f6] check-in: [67a2bfb0dc] user: stephan branch: checkin-without-checkout, size: 58082
13:12
Added preview render mode selection list. file: [3e42e686c6] check-in: [65b6c01afd] user: stephan branch: checkin-without-checkout, size: 55754
12:46
Implemented HTML-in-iframe preview. Related internal cleanups. file: [22005f3b97] check-in: [ac309281e6] user: stephan branch: checkin-without-checkout, size: 54905
12:10
Implemented preview mode for plain text and wiki/embedded doc, but how to populate the necessary iframe for HTML preview, without a URL back to the preview content, eludes me. file: [9f3aacecaf] check-in: [079030faaf] user: stephan branch: checkin-without-checkout, size: 53824
2020-05-03
14:57
Added: Moved /fileedit and friends to fileedit.c. file: [6800035c10] check-in: [6cdb091adb] user: stephan branch: checkin-without-checkout, size: 48108