Fossil

Check-in [fc4782e7ef]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Typo fix which led to an exception and caused the timestamp popups to misbehave.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: fc4782e7ef82d7ea2628e5c9f80d00477fdd0694ac515839e2dbc957f5e5fd36
User & Date: stephan 2020-12-26 16:54:26.885
Context
2020-12-26
17:07
Removed some debug output. When toggling between bottom-up/top-down chat, scroll to the input widget (which flips between the top and the bottom of the page). ... (check-in: 34547542d2 user: stephan tags: trunk)
16:54
Typo fix which led to an exception and caused the timestamp popups to misbehave. ... (check-in: fc4782e7ef user: stephan tags: trunk)
16:39
Worked around a browser-dependent scrolling quirk and fixed a logic bug in the recent PopupWidget.installHideHandlers() API change which caused the timestamp popups not to close. ... (check-in: 322627ed7e user: stephan tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/fossil.popupwidget.js.
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
       whether an ESC handler is installed.

       Passing no arguments is equivalent to passing (true,true,true),
       and passing fewer arguments defaults the unpassed parameters to
       true.
    */
    installHideHandlers: function f(onClickSelf, onClickOther, onEsc){
      if(!arguments.length) onClick = onClickOther = onEsc = true;
      else if(1===arguments.length) onClickOther = onEsc = true;
      else if(2===arguments.length) onEsc = true;
      if(onClickSelf) this.e.addEventListener('click', ()=>this.hide(), false);
      if(onClickOther) document.body.addEventListener('click', ()=>this.hide(), true);
      if(onEsc){
        const self = this;
        document.body.addEventListener('keydown', function(ev){







|







226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
       whether an ESC handler is installed.

       Passing no arguments is equivalent to passing (true,true,true),
       and passing fewer arguments defaults the unpassed parameters to
       true.
    */
    installHideHandlers: function f(onClickSelf, onClickOther, onEsc){
      if(!arguments.length) onClickSelf = onClickOther = onEsc = true;
      else if(1===arguments.length) onClickOther = onEsc = true;
      else if(2===arguments.length) onEsc = true;
      if(onClickSelf) this.e.addEventListener('click', ()=>this.hide(), false);
      if(onClickOther) document.body.addEventListener('click', ()=>this.hide(), true);
      if(onEsc){
        const self = this;
        document.body.addEventListener('keydown', function(ev){