Fossil

Check-in [89b724dcfa]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Update the form spider protections so that links to /register go through even if spider protection is fully enabled. This allows self-registration even if user "nobody" has no permissions.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 89b724dcfae8a6c59f409241c9622184b0505352c64f1d39e5ad99704c41ad5e
User & Date: drh 2021-03-24 15:40:49.511
Context
2021-03-26
13:33
Update the built-in SQLite to version 3.35.3. There are no changes other than the version string. ... (check-in: 8e5bdcebd5 user: drh tags: trunk)
2021-03-25
15:43
Merge current trunk. ... (check-in: d1adf6c40a user: larrybr tags: panic-reduction)
04:11
At /rptview page show link to /reportslist. If request's query string contains <b>rvsmpl</b> parameter then also show an auxiliary link to the page defined by the value of this parameter. Labels and links rendered via %s format specifier because %h and %T did not work properly. In this particular case this seems fine because style_finish_page() renders HTML via %h(...). Code review is very welcome though. ... (check-in: b982c00150 user: george tags: rptview-submenu-paralink)
2021-03-24
15:40
Update the form spider protections so that links to /register go through even if spider protection is fully enabled. This allows self-registration even if user "nobody" has no permissions. ... (check-in: 89b724dcfa user: drh tags: trunk)
04:25
Always include a report number parameter into the report's "Raw" link (at the top of the /rptview page). This fixes the glitch for the case when the report number is "hidden" within [/waliassetup|URL alias]. ... (check-in: bed4b0f7fc user: george tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/style.c.
210
211
212
213
214
215
216

217

218
219
220
221
222
223
224
void form_begin(const char *zOtherArgs, const char *zAction, ...){
  char *zLink;
  va_list ap;
  if( zOtherArgs==0 ) zOtherArgs = "";
  va_start(ap, zAction);
  zLink = vmprintf(zAction, ap);
  va_end(ap);

  if( g.perm.Hyperlink && !g.javascriptHyperlink ){

    @ <form method="POST" action="%z(zLink)" %s(zOtherArgs)>
  }else{
    needHrefJs = 1;
    @ <form method="POST" data-action='%s(zLink)' action='%R/login' \
    @ %s(zOtherArgs)>
  }
}







>
|
>







210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
void form_begin(const char *zOtherArgs, const char *zAction, ...){
  char *zLink;
  va_list ap;
  if( zOtherArgs==0 ) zOtherArgs = "";
  va_start(ap, zAction);
  zLink = vmprintf(zAction, ap);
  va_end(ap);
  if( fossil_strcmp(zLink,"/register")==0
   || (g.perm.Hyperlink && !g.javascriptHyperlink)
  ){
    @ <form method="POST" action="%z(zLink)" %s(zOtherArgs)>
  }else{
    needHrefJs = 1;
    @ <form method="POST" data-action='%s(zLink)' action='%R/login' \
    @ %s(zOtherArgs)>
  }
}