Fossil

Check-in [c60ad868b4]
Login

Check-in [c60ad868b4]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Minor efficiency hack in style_emit_script_builtin() and swapped a potentially problematic ordering of two JS includes.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | fileedit-ajaxify
Files: files | file ages | folders
SHA3-256: c60ad868b41266c39dd5599458ae5828236c0e455b32814beebb04c566d1feec
User & Date: stephan 2020-05-10 09:16:56.947
Context
2020-05-10
14:50
Merge in trunk for fossil_exe_id() and use it, instead of md5, as the builtin/*.js cache-buster value. ... (check-in: 7e43119a91 user: stephan tags: fileedit-ajaxify)
09:16
Minor efficiency hack in style_emit_script_builtin() and swapped a potentially problematic ordering of two JS includes. ... (check-in: c60ad868b4 user: stephan tags: fileedit-ajaxify)
08:47
Several small style tweaks. Changed style_labeled_checkbox() parameter order for better readability. TabManager class now supports events alerting before/after a tab is switched to. Added auto-refresh of preview when the preview tab is activated, with a checkbox to disable it for slow connections and/or large documents (the refresh button still works as before). ... (check-in: ee175636aa user: stephan tags: fileedit-ajaxify)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/fileedit.c.
︙︙
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880

       blob_str(&err));
  }
  blob_reset(&err);
  CheckinMiniInfo_cleanup(&cimi);
  style_emit_script_fossil_bootstrap(0);
  style_emit_script_fetch(0);
  style_emit_script_tabs(0);
  style_emit_script_builtin(0, "fossil.page.fileedit.js");
  style_emit_script_confirmer(0);
  if(blob_size(&endScript)>0){
    style_emit_script_tag(0,0);
    CX("(function(){\n");
    CX("try{\n%b\n}"
       "catch(e){"
       "fossil.error(e);\n"
       "console.error('Exception:',e);\n"








|
|








1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880

       blob_str(&err));
  }
  blob_reset(&err);
  CheckinMiniInfo_cleanup(&cimi);
  style_emit_script_fossil_bootstrap(0);
  style_emit_script_fetch(0);
  style_emit_script_tabs(0);
  style_emit_script_confirmer(0);
  style_emit_script_builtin(0, "fossil.page.fileedit.js");
  if(blob_size(&endScript)>0){
    style_emit_script_tag(0,0);
    CX("(function(){\n");
    CX("try{\n%b\n}"
       "catch(e){"
       "fossil.error(e);\n"
       "console.error('Exception:',e);\n"
︙︙
Changes to src/style.c.
︙︙
1584
1585
1586
1587
1588
1589
1590
1591

1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608

*/
void style_emit_script_builtin(int asInline, char const * zName){
  if(asInline){
    style_emit_script_tag(0,0);
    CX("%s", builtin_text(zName));
    style_emit_script_tag(1,0);
  }else{
    char * zFull = mprintf("builtin/%s",zName);

    const char * zBuiltin = builtin_text(zName);
    const char * zHash = 0;
    if(zBuiltin!=0){
      md5sum_init();
      md5sum_step_text(zBuiltin,-1);
      zHash = md5sum_finish(0);
    }
    CX("<script src='%R/%T?cache=%.8s'></script>\n",zFull,
       zHash ? zHash : "MISSING");
    fossil_free(zFull);
  }
}

/*
** The first time this is called it emits the JS code from the
** built-in file fossil.fossil.js. Subsequent calls are no-ops.
**








|
>
|



|


|

|








1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609

*/
void style_emit_script_builtin(int asInline, char const * zName){
  if(asInline){
    style_emit_script_tag(0,0);
    CX("%s", builtin_text(zName));
    style_emit_script_tag(1,0);
  }else{
    char * zFullName = mprintf("builtin/%s",zName);
    int nLen = 0;
    const char * zBuiltin = (const char *)builtin_file(zName, &nLen);
    const char * zHash = 0;
    if(zBuiltin!=0){
      md5sum_init();
      md5sum_step_text(zBuiltin,nLen);
      zHash = md5sum_finish(0);
    }
    CX("<script src='%R/%T?cache=%.8s'></script>\n",zFullName,
       zHash ? zHash : "MISSING");
    fossil_free(zFullName);
  }
}

/*
** The first time this is called it emits the JS code from the
** built-in file fossil.fossil.js. Subsequent calls are no-ops.
**
︙︙