Fossil

Check-in [95f02a572e]
Login

Check-in [95f02a572e]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Use binary mode for CGI related trace files.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | cgiTraceBinary
Files: files | file ages | folders
SHA1: 95f02a572e712e6b64a95579b8d0b5444b06f4f6
User & Date: mistachkin 2012-11-25 02:57:43.981
Context
2012-11-25
11:16
Use binary mode for CGI trace files. Make CGI trace cross-platform. ... (check-in: 6a8084abcb user: drh tags: ticket-enhancements)
02:57
Use binary mode for CGI related trace files. ... (Closed-Leaf check-in: 95f02a572e user: mistachkin tags: cgiTraceBinary)
2012-11-24
23:54
Bug fixes in the TICKETCHNG update mechanism. ... (check-in: 7136ff4c65 user: drh tags: ticket-enhancements)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/cgi.c.
︙︙
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812

    return;
  }
  if( pLog==0 ){
    char zFile[50];
    unsigned r;
    sqlite3_randomness(sizeof(r), &r);
    sqlite3_snprintf(sizeof(zFile), zFile, "httplog-%08x.txt", r);
    pLog = fopen(zFile, "w");
    if( pLog ){
      fprintf(stderr, "# open log on %s\n", zFile);
    }else{
      fprintf(stderr, "# failed to open %s\n", zFile);
      return;
    }
  }








|








798
799
800
801
802
803
804
805
806
807
808
809
810
811
812

    return;
  }
  if( pLog==0 ){
    char zFile[50];
    unsigned r;
    sqlite3_randomness(sizeof(r), &r);
    sqlite3_snprintf(sizeof(zFile), zFile, "httplog-%08x.txt", r);
    pLog = fossil_fopen(zFile, "wb");
    if( pLog ){
      fprintf(stderr, "# open log on %s\n", zFile);
    }else{
      fprintf(stderr, "# failed to open %s\n", zFile);
      return;
    }
  }
︙︙
Changes to src/main.c.
︙︙
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644

  fossil_binary_mode(g.httpIn);
  g.cgiOutput = 1;
  blob_read_from_file(&config, zFile);
  while( blob_line(&config, &line) ){
    if( !blob_token(&line, &key) ) continue;
    if( blob_buffer(&key)[0]=='#' ) continue;
    if( blob_eq(&key, "debug:") && blob_token(&line, &value) ){
      g.fDebug = fossil_fopen(blob_str(&value), "a");
      blob_reset(&value);
      continue;
    }
    if( blob_eq(&key, "HOME:") && blob_token(&line, &value) ){
      cgi_setenv("HOME", blob_str(&value));
      blob_reset(&value);
      continue;








|








1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644

  fossil_binary_mode(g.httpIn);
  g.cgiOutput = 1;
  blob_read_from_file(&config, zFile);
  while( blob_line(&config, &line) ){
    if( !blob_token(&line, &key) ) continue;
    if( blob_buffer(&key)[0]=='#' ) continue;
    if( blob_eq(&key, "debug:") && blob_token(&line, &value) ){
      g.fDebug = fossil_fopen(blob_str(&value), "ab");
      blob_reset(&value);
      continue;
    }
    if( blob_eq(&key, "HOME:") && blob_token(&line, &value) ){
      cgi_setenv("HOME", blob_str(&value));
      blob_reset(&value);
      continue;
︙︙