Fossil

Check-in [28436ab9d5]
Login

Check-in [28436ab9d5]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Remove an extraneous call of find_server_repository() in win32 implementation of server/ui, added by [0a473cd5533f5bb2]. The extra call to find_server_repository() unnecessary lock which prevent "fossil close" from deleting the checkout db while a server instance is running. (reported in forum post: [forum:e7f3472c46eae4bd])
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 28436ab9d5a1d6691a85f5f10f59beeb660fd79b7d5aa11abea2cd1b6d964bce
User & Date: mgagnon 2025-03-02 18:57:46.546
Original Comment: Remove an extraneous call of find_server_repository() in win32 implementation of server/ui. It even cause some unnecessary lock which prevent "fossil close" delete the checkout db while a server instance is running. (reported in forum post: [forum:e7f3472c46eae4bd])
Context
2025-03-02
23:22
Fix a harmless comment typo. ... (check-in: a0d9093d8c user: drh tags: trunk)
20:36
Merge from trunk. ... (check-in: b591622016 user: brickviking tags: bv-infotool)
18:57
Remove an extraneous call of find_server_repository() in win32 implementation of server/ui, added by [0a473cd5533f5bb2]. The extra call to find_server_repository() unnecessary lock which prevent "fossil close" from deleting the checkout db while a server instance is running. (reported in forum post: [forum:e7f3472c46eae4bd]) ... (check-in: 28436ab9d5 user: mgagnon tags: trunk)
2025-03-01
20:31
Remove the "fossil usage" and "fossil options" command. Use instead the the --usage/-u or --options/-o options on the "fossil help" command. Other improvements and fixes to the recent "fossil help" enhancement. ... (check-in: b097e6899e user: drh tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/main.c.
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
  if( g.httpUseSSL && g.httpSSLConn ){
    ssl_close_server(g.httpSSLConn);
    g.httpSSLConn = 0;
  }
#endif /* FOSSIL_ENABLE_SSL */

#else /* WIN32 */
  find_server_repository(2, 0);
  if( fossil_strcmp(g.zRepositoryName,"/")==0 ){
    allowRepoList = 1;
  }
  /* Win32 implementation */
  if( allowRepoList ){
    flags |= HTTP_SERVER_REPOLIST;
  }
  if( win32_http_service(iPort, zAltBase, zNotFound, zFileGlob, flags) ){
    win32_http_server(iPort, mxPort, zBrowserCmd, zStopperFile,
                      zAltBase, zNotFound, zFileGlob, zIpAddr, flags);
  }







|



<







3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607

3608
3609
3610
3611
3612
3613
3614
  if( g.httpUseSSL && g.httpSSLConn ){
    ssl_close_server(g.httpSSLConn);
    g.httpSSLConn = 0;
  }
#endif /* FOSSIL_ENABLE_SSL */

#else /* WIN32 */
  /* Win32 implementation */
  if( fossil_strcmp(g.zRepositoryName,"/")==0 ){
    allowRepoList = 1;
  }

  if( allowRepoList ){
    flags |= HTTP_SERVER_REPOLIST;
  }
  if( win32_http_service(iPort, zAltBase, zNotFound, zFileGlob, flags) ){
    win32_http_server(iPort, mxPort, zBrowserCmd, zStopperFile,
                      zAltBase, zNotFound, zFileGlob, zIpAddr, flags);
  }