abc2svg
Check-in [e541a7f522]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:core: fix: crash on tuplets of rests - reported by Frédéric Boulanger
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: e541a7f522f4f53fea8e09e7c5c42e12c3bc55d6
User & Date: jef 2022-05-07 17:07:55.673
Context
2022-05-08
06:11
core: fix: crash when command/parameter at start of tune since commit [2c336cdff0] - reported by Stuart Soloway ... (check-in: 0b33b10279 user: jef tags: trunk)
2022-05-07
17:07
core: fix: crash on tuplets of rests - reported by Frédéric Boulanger ... (check-in: e541a7f522 user: jef tags: trunk)
14:12
core: fix: bad start of music line when voice overlay starting with space or grace notes ... (check-in: 2c336cdff0 user: jef tags: trunk)
Changes
Unified Diff Ignore Whitespace Patch
Changes to core/draw.js.
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
		error(1, s1, "No end of tuplet in this music line")
		return
	}

	dir = tp.f[3]				// 'where'
	if (!dir) {				// if auto
		s3 = s1
		while (s3.type != C.NOTE)
			s3 = s3.next
		dir = s3.stem > 0 ? C.SL_ABOVE : C.SL_BELOW
	}

	if (s1 == s2				// tuplet with 1 note (!)
	 || tp.f[1] == 2) {			// what == nothing
		nb_only = true
	} else if (tp.f[1] == 1) {			/* 'what' == slur */
		nb_only = true;







|

|







2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
		error(1, s1, "No end of tuplet in this music line")
		return
	}

	dir = tp.f[3]				// 'where'
	if (!dir) {				// if auto
		s3 = s1
		while (s3 && !s3.stem)		// (may have tuplets of rests!)
			s3 = s3.next
		dir = (s3 && s3.stem < 0) ? C.SL_BELOW : C.SL_ABOVE
	}

	if (s1 == s2				// tuplet with 1 note (!)
	 || tp.f[1] == 2) {			// what == nothing
		nb_only = true
	} else if (tp.f[1] == 1) {			/* 'what' == slur */
		nb_only = true;