Changes On Branch mistake
Not logged in
Home Timeline Branches Tags Tickets Wiki Login
Patch Side-by-Side Diff

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Changes In Branch mistake Excluding Merge-Ins

This is equivalent to a diff from 859458555b to a3e5bd4a52

2026-06-29
10:59
Fix the forum approval/rejection broken by the previous check-in by injecting a hidden input field to replace the hijacked button. Also add separate links to the markdown/wiki format rules, rather than a link to the list of links to those rules, as requested in [https://sqlite.org/forum/forumpost/d6343657f0865d44|sqlite forum post 2026-06-28T11:49:... check-in: 68414a4117 user: stephan tags: trunk
10:41
In JS-capable browsers, add a confirmation step to the forum Approve and Reject buttons in an attempt to reduce the odds of a repeat of sqlite forum post 2026-06-29T09:52:29Z. Add some space between those buttons. Edit: move to mistake branch as this is having undesired side effects. Closed-Leaf check-in: a3e5bd4a52 user: stephan tags: mistake
2026-06-27
10:28
Update the built-in SQLite to the latest trunk version for testing. check-in: 859458555b user: drh tags: trunk
2026-06-24
16:42
Replace an ad-hoc query with rid_to_uuid(). Add a note about fossil historically eliding the U-card on wiki edits made by 'nobody', which isn't spec-legal but is an age-old practice. check-in: a44ae96c9b user: stephan tags: trunk

Changes to src/forum.c.
︙
1305
1306
1307
1308
1309
1310
1311
1312
1313




1314
1315
1316
1317
1318
1319
1320

1305
1306
1307
1308
1309
1310
1311


1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322








-
-
+
+
+
+








            @ <input type="submit" name="nullout" value="Delete">
          }
        }
      }else if( g.perm.ModForum ){
        /* Allow moderators to approve or reject pending posts.  Also allow
        ** forum supervisors to mark non-special users as trusted and therefore
        ** able to post unmoderated. */
        @ <input type="submit" name="approve" value="Approve">
        @ <input type="submit" name="reject" value="Reject">
        @ <input type="submit" name="approve" value="Approve" \
        @  class="action-approve">\
        @ <input type="submit" name="reject" value="Reject" \
        @  class="action-reject">\
        if( g.perm.AdminForum && !login_is_special(pManifest->zUser) ){
          @ <br><label><input type="checkbox" name="trust">
          @ Trust user "%h(pManifest->zUser)" so that future posts by \
          @ "%h(pManifest->zUser)" do not require moderation.
          @ </label>
          @ <input type="hidden" name="trustuser" value="%h(pManifest->zUser)">
          bBrBeforeAttach = 1 /* slightly unmangle the layout */;
︙
Changes to src/fossil.page.forumpost.js.
︙
980
981
982
983
984
985
986













987
988
989
990
991
992
993
994
995
996
997

980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002

1003
1004
1005
1006
1007
1008
1009








+
+
+
+
+
+
+
+
+
+
+
+
+



-








            F.confirmer(e, {
              confirmText: (e.classList.contains('action-reopen')
                            ? "Confirm re-open"
                            : "Confirm close"),
              onconfirm: ()=>form.submit()
            });
          });
        form
          .querySelectorAll("input.action-approve, input.action-reject")
          .forEach(function(e){
            e.type = 'button'/*do not submit form on click*/;
            F.confirmer(e, {
              confirmText: (e.classList.contains('action-approve')
                            ? "Confirm approval"
                            : "Confirm rejection"),
              onconfirm: ()=>form.submit()
            });
            /* We should also arguably disable the approve/reject
               button's counterpart while it's counting down. */
          });
        form
          .querySelectorAll("input[type='button'].action-status")
          .forEach(function(btn){
            btn.classList.remove('hidden');
            const sel = btn.previousElementSibling;
            const updateButton = ()=>{
              /* Enable btn only when the status has been locally
                 modified. */
              if( sel.dataset.initialValue ){
                if( sel.dataset.initialValue===sel.value ){
                  btn.setAttribute('disabled','');
︙
Changes to src/style.forum.css.
︙
99
100
101
102
103
104
105





99
100
101
102
103
104
105
106
107
108
109








+
+
+
+

}

.forumTime {
  /* Animate the transition when a ForumPostEditor shifts
     its post to the left. */
  transition: margin-left 0.25s linear;
}

.forum form input.action-approve {
  margin-right: 1em;
}
Fossil version [1205ec86cb] 2025-04-30 16:57:32