Check-in [aad3ef3288]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Per feedback, further improve the Tcl shared library error message.
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: aad3ef32885dd1c6b765c1b0c94a5837188da6bb
User & Date: mistachkin 2013-09-19 18:36:02.578
Context
2013-09-23
10:17
Prevent a crash in fossil during exit, when a mingw-compiled (with dw2) Tcl version is still loaded. This is clearly a dw2 bug (see: http://comments.gmane.org/gmane.comp.gnu.mingw.user/41724), but the suggested workaround works and is managable. check-in: da96f916cb user: jan.nijtmans tags: trunk
2013-09-19
18:36
Per feedback, further improve the Tcl shared library error message. check-in: aad3ef3288 user: mistachkin tags: trunk
11:48
Fix MSVC build error and warnings: c:\localdata\workspace\fossil\src\util.c(249) : warning C4715: 'fossil_timer_fetch' : not all control paths return a value c:\localdata\workspace\fossil\src\util.c(270) : warning C4715: 'fossil_timer_reset' : not all control paths return a value check-in: 6e1e4bb83d user: jan.nijtmans tags: trunk
Changes
Unified Diff Ignore Whitespace Patch
Changes to src/th_tcl.c.
669
670
671
672
673
674
675
676
677

678
679
680
681
682
683
684
685
      *pLibrary = library;
      *pxFindExecutable = xFindExecutable;
      *pxCreateInterp = xCreateInterp;
      *pxDeleteInterp = xDeleteInterp;
      return TH_OK;
    }
  } while( --fileName[TCL_MINOR_OFFSET]>'3' ); /* Tcl 8.4+ */
  fileName[TCL_MINOR_OFFSET]++;
  Th_ErrorMessage(interp,

      "could not load Tcl shared library \"", fileName, -1);
  return TH_ERROR;
#else
  *pLibrary = 0;
  *pxFindExecutable = Tcl_FindExecutable;
  *pxCreateInterp = Tcl_CreateInterp;
  *pxDeleteInterp = Tcl_DeleteInterp;
  return TH_OK;







|

>
|







669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
      *pLibrary = library;
      *pxFindExecutable = xFindExecutable;
      *pxCreateInterp = xCreateInterp;
      *pxDeleteInterp = xDeleteInterp;
      return TH_OK;
    }
  } while( --fileName[TCL_MINOR_OFFSET]>'3' ); /* Tcl 8.4+ */
  fileName[TCL_MINOR_OFFSET] = 'x';
  Th_ErrorMessage(interp,
      "could not load any supported Tcl 8.6, 8.5, or 8.4 shared library \"",
      fileName, -1);
  return TH_ERROR;
#else
  *pLibrary = 0;
  *pxFindExecutable = Tcl_FindExecutable;
  *pxCreateInterp = Tcl_CreateInterp;
  *pxDeleteInterp = Tcl_DeleteInterp;
  return TH_OK;