Fossil 1.23 behaves as expected: > fossil-123 md5sum common\* 2a9d384b95db916a22cc05b7227ab55b common\fileutils.cpp eb7ae4d4d206c73079faa4bfb4d737ca common\fileutils.h

However, under 1.24: > fossil md5sum common\* Assertion failed: (p)->xRealloc==blobReallocMalloc || (p)->xRealloc==blobReallocStatic, file ./src/blob.c, line 273

This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.

Wildcards also fail, but less spectacularly, with other Fossil commands:

Fossil 1.24: >fossil add gui\forms.* fossil: not found: C:/Projects/InkSpector2/src/gui/forms.*

Fossil 1.23: >fossil-123 add gui\forms.* ADDED src/gui/forms.cpp ADDED src/gui/forms.h

Thanks Mark.

drh added on 2012-11-02 21:46:52 UTC:
Working now for MinGW. Need to fix the parse_windows_command_line() function to do wildcard expansion in order to fix the problem for non-mingw windows compilers.

jan.nijtmans added on 2012-11-03 11:21:18 UTC:
Note: Mingw is the only toolset which does command line expansion in crt0, mingw-w64 and msvc do not. It is really a problem of the Windows console: Shells are supposed to do their own command line expansion. Cygwin and Msys do that, but the Windows console does not do that. Therefore the mingw people decided to build it into crt0, but it makes mingw incompatible with msvc.

Unfortunately, mingw doesn't have an unicode-aware crt0, that would solve everything. Mingw-w64 and msvc have it, but those don't do command line expansion.

I would recommend to build command line expansion into fossil. It would make command line expansion available to mingw-w64 and msvc builds on the Windows console as well. The risk is that when using Msys or Cygwin, the command line expansion is done twice, I don't know exactly what possible problems that could give.

So, the easiest workaround would be: use the Msys or Cygwin or any other shell, just not the Windows console.

drh added on 2012-11-03 12:47:01 UTC:
Maybe the right thing to do is add a new "fossil glob CMD ARG1 ARG2 ...." command. The glob command applies file globing to all arguments, then runs CMD with the globed arguments. This is similar to how the "glob" command worked in very early Unix systems, before globing got built into the shell.

Unix, Msys, and cygwin shells would continue to operate normally. Users on a windows shell, however, would need to add the "glob" keyword if they want globing to occur in their command.

anonymous added on 2012-11-03 14:30:05 UTC:
Hi,

I'm not sure if it's been mentioned before, but msvc does support expanding command-line wildcards into separate argv strings: http://msdn.microsoft.com/en-us/library/8bch7bkk%28v=vs.80%29.aspx

Mark.

jan.nijtmans added on 2012-11-04 21:04:47 UTC:
Regarding the assertion:

However, under 1.24: > fossil md5sum common\* Assertion failed: (p)->xRealloc==blobReallocMalloc || (p)->xRealloc==blobReallocStatic, file ./src/blob.c, line 273

drh added on 2012-11-04 21:36:42 UTC:
The "fossil md5sum" segfault has already been fix by check-in [52199a504a9c7c20].

I think we want to continue to run with assert()s enabled. This gives better visibility to mistaken assumptions in the code.