View Ticket
Ticket UUID: eb08c005fa5b6af3d253b4f5fb4b3745671b2638
Title: vc-fossil-checkin: Wrong type argument: char-or-string-p, nil
Status: Closed Type: Incident
Severity: Minor Priority: Immediate
Subsystem: Resolution: Fixed
Last Modified: 2017-10-02 03:59:38
Version Found In: 20160324.349
User Comments:
anonymous added on 2016-05-13 10:48:00:


I've got error when a I've tried to commit some changes:

  1. C-x v v
  2. Type text to Summary
  3. C-c The text of error is :
    vc-fossil-checkin: Wrong type argument: char-or-string-p, nil

Other functionality works. On emacs version 24.5 all works without problem.

Some useful information are:

  1. GNU Emacs (x86_64-unknown-linux-gnu, GTK+ Version 3.14.13) of 2016-02-04
  2. OS - Ubuntu 15.10
  3. vc-fossil - 20160324.349
  4. Init fossil:
      (use-package vc-fossil
        (add-to-list 'vc-handled-backends 'Fossil)

fifr added on 2016-06-08 20:43:15:

Hm, it seems as if they changed the order of the arguments of the checkin command: in Emacs 24 was (FILES REV COMMENT), in Emacs 25 it is (FILES COMMENT &optional REV). The problem is that a simple change will make the code incompatible with Emacs 24. So we have to add version specific code, I guess.

fifr added on 2016-06-08 21:06:53:

Actually, there have been several incompatible changes in the interface (e.g. vc-fossil-diff). So it may be more work to make vc-fossil work on Emacs 25.

anonymous added on 2016-06-28 00:03:37:

FYI, this is affecting more than vc-checkin; vc-dir also breaks with an inscrutable error. It also appears vc-checkin has changed since you looked at it, my Emacs 25 shows:

C-x v d runs the command vc-dir (found in global-map), which is an
interactive autoloaded compiled Lisp function in ‘vc-dir.el’.

It is bound to C-x v d, <menu-bar> <tools> <vc> <vc-dir>.

(vc-dir DIR &optional BACKEND)
Unfortunately, Emacs 25 also has great new security benefits by default.

fifr added on 2016-07-11 07:02:29:
The real problem is not fixing the code but to do it in way that works on both, emacs 24 and emacs 25

venks added on 2016-09-21 17:12:26:
fifr:  I have been traveling, so I haven't really focussed here, but will have time in october.   If you have time, you can make the changes in a branch and I'll merge with 24.* code, or I'll get to it in late october.

venks added on 2017-10-02 03:59:38:
Emacs 25 support was added by pdo in [82000499a7] .   Closing ticket