Emacs-Fossil

Hello,

I've got error when a I've tried to commit some changes:

1. C-x v v
2. Type text to Summary
3. C-c The text of error is :

   vc-fossil-checkin: Wrong type argument: char-or-string-p, nil
   

Other functionality works. On emacs version 24.5 all works without problem.

Some useful information are:

1. GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.13) of 2016-02-04
2. OS - Ubuntu 15.10
3. vc-fossil - 20160324.349
4. Init fossil:

     (use-package vc-fossil
       :init
       (add-to-list 'vc-handled-backends 'Fossil)
     )
   

Hm, it seems as if they changed the order of the arguments of the checkin command: in Emacs 24 was (FILES REV COMMENT), in Emacs 25 it is (FILES COMMENT &optional REV). The problem is that a simple change will make the code incompatible with Emacs 24. So we have to add version specific code, I guess.

Actually, there have been several incompatible changes in the interface (e.g. vc-fossil-diff). So it may be more work to make vc-fossil work on Emacs 25.

FYI, this is affecting more than vc-checkin; vc-dir also breaks with an inscrutable error. It also appears vc-checkin has changed since you looked at it, my Emacs 25 shows:

C-x v d runs the command vc-dir (found in global-map), which is an
interactive autoloaded compiled Lisp function in ‘vc-dir.el’.

It is bound to C-x v d, <menu-bar> <tools> <vc> <vc-dir>.

(vc-dir DIR &optional BACKEND)

The real problem is not fixing the code but to do it in way that works on both, emacs 24 and emacs 25

fifr:  I have been traveling, so I haven't really focussed here, but will have time in october.   If you have time, you can make the changes in a branch and I'll merge with 24.* code, or I'll get to it in late october.

Emacs 25 support was added by pdo in [82000499a7] .   Closing ticket