@@ -1,10 +1,9 @@ // Package ioutil contains various constructs for io operations package ioutil import ( - //"fmt" "io" ) // An function alias type that implements io.Writer type WriterFunc func([]byte) (int, error) @@ -22,30 +21,28 @@ return r(b) } // Returns a reader that will delegate calls to Read(...) while ensuring // that the output buffer will never be smaller than the required size -func MinReader(reader io.Reader, size int) io.Reader { +// and will be downsized to a multiple of the required size if larger +func BlockReader(reader io.Reader, size int) io.Reader { var buffer []byte = make([]byte, 0, size) return ReaderFunc(func(output []byte) (int, error) { var ( readCount int err error ) start: - //fmt.Println("Requesting read with length ", len(output), "buffer's length is ", len(buffer)) - // Reply with the buffered data if there is any if len(buffer) > 0 { readCount = copy(output, buffer) // Advance the data in the buffer buffer = buffer[:copy(buffer, buffer[readCount:])] - //fmt.Println("After buffer read - buffer lenght is", len(buffer)) - + // Return count and error if we have read the whole buffer if len(buffer) == 0 { return readCount, err } // Do not propagate an error until the buffer is exhausted @@ -52,23 +49,22 @@ return readCount, nil } // Delegate if the buffer is empty and the destination buffer is large enough if len(output) >= size { - //fmt.Println("Delegating read for output length ", len(output), " and size ", size) return reader.Read(output[:(len(output)/size)*size]) } // Perform a read into the buffer readCount, err = reader.Read(buffer[:size]) - // Size the buffer down to the read data size and restart + // Size the buffer down to the read data size + // and restart if we have successfully read some bytes buffer = buffer[:readCount] - - //fmt.Println("Read into buffer: ", len(buffer), "bytes") - if len(buffer) > 0 { goto start } + + // Returning on err/misbehaving noop reader return 0, err }) }