Check-in [b0fa9fd94c]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:I've changed my mind about what the IP version selection options in the config should do when IPv6 is configured out. They shouldn't sit there looking silly with only `Auto' and `IPv4' settings: they should instead be completely absent. I had thought the former was acceptable since IPv4-only was a configuration that people should only be using if their compilers didn't support IPv6, but now it occurs to me that ports to fundamentally non-IPv6-supporting platforms are not implausible, and on such ports the presence of a vestigial config option under the _standard_ build conditions would be a low-quality solution.
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: b0fa9fd94cf969a5015175339b10c42c23675cc5
User & Date: simon 2005-01-09 05:44:21.000
Context
2005-01-09
05:58
Having laboriously constructed a hints parameter for getaddrinfo, it would help to _use_ it! check-in: 74977dc42d user: simon tags: trunk
05:44
I've changed my mind about what the IP version selection options in the config should do when IPv6 is configured out. They shouldn't sit there looking silly with only `Auto' and `IPv4' settings: they should instead be completely absent. I had thought the former was acceptable since IPv4-only was a configuration that people should only be using if their compilers didn't support IPv6, but now it occurs to me that ports to fundamentally non-IPv6-supporting platforms are not implausible, and on such ports the presence of a vestigial config option under the _standard_ build conditions would be a low-quality solution. check-in: b0fa9fd94c user: simon tags: trunk
2005-01-08
08:45
For local and dynamic port forwardings (i.e. the ones which listen on a local port), the `Auto' protocol option on the Tunnels panel should always produce a port you can connect to in _either_ of IPv4 and v6, because the aim is for the user not to have to know or care which one they're using. This was not the case on Windows, and now is. Also, updated the docs to give more detail on issues like this. check-in: f307208157 user: simon tags: trunk
Changes
Side-by-Side Diff Ignore Whitespace Patch
Changes to config.c.
1374
1375
1376
1377
1378
1379
1380

1381
1382
1383

1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397

1398
1399
1400
1401
1402
1403
1404
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383

1384





1385
1386
1387
1388
1389

1390

1391
1392
1393
1394
1395
1396
1397
1398
1399







+


-
+
-
-
-
-
-





-

-

+







			  'n', HELPCTX(connection_nodelay),
			  dlg_stdcheckbox_handler,
			  I(offsetof(Config,tcp_nodelay)));
	    ctrl_checkbox(s, "Enable TCP keepalives (SO_KEEPALIVE option)",
			  'p', HELPCTX(connection_tcpkeepalive),
			  dlg_stdcheckbox_handler,
			  I(offsetof(Config,tcp_keepalives)));
#ifndef NO_IPV6
	    s = ctrl_getset(b, "Connection", "ipversion",
			  "Internet protocol version");
	    ctrl_radiobuttons(s, NULL, NO_SHORTCUT,
	    ctrl_radiobuttons(s, NULL, NO_SHORTCUT, 3,
#ifndef NO_IPV6
			  3,
#else
			  2,
#endif
			  HELPCTX(connection_ipversion),
			  dlg_stdradiobutton_handler,
			  I(offsetof(Config, addressfamily)),
			  "Auto", NO_SHORTCUT, I(ADDRTYPE_UNSPEC),
			  "IPv4", NO_SHORTCUT, I(ADDRTYPE_IPV4),
#ifndef NO_IPV6
			  "IPv6", NO_SHORTCUT, I(ADDRTYPE_IPV6),
#endif
			  NULL);
#endif
	}

	/*
	 * A sub-panel Connection/Data, containing options that
	 * decide on data to send to the server.
	 */
	if (!midsession) {
1797
1798
1799
1800
1801
1802
1803

1804
1805

1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818

1819
1820
1821
1822
1823
1824
1825
1792
1793
1794
1795
1796
1797
1798
1799
1800

1801





1802
1803
1804
1805

1806

1807
1808
1809
1810
1811
1812
1813
1814
1815







+

-
+
-
-
-
-
-




-

-

+







	pfd->direction = ctrl_radiobuttons(s, NULL, NO_SHORTCUT, 3,
					   HELPCTX(ssh_tunnels_portfwd),
					   portfwd_handler, P(pfd),
					   "Local", 'l', P(NULL),
					   "Remote", 'm', P(NULL),
					   "Dynamic", 'y', P(NULL),
					   NULL);
#ifndef NO_IPV6
	pfd->addressfamily =
	    ctrl_radiobuttons(s, NULL, NO_SHORTCUT,
	    ctrl_radiobuttons(s, NULL, NO_SHORTCUT, 3,
#ifndef NO_IPV6
			      3,
#else
			      2,
#endif
			      HELPCTX(ssh_tunnels_portfwd_ipversion),
			      portfwd_handler, P(pfd),
			      "Auto", NO_SHORTCUT, I(ADDRTYPE_UNSPEC),
			      "IPv4", NO_SHORTCUT, I(ADDRTYPE_IPV4),
#ifndef NO_IPV6
			      "IPv6", NO_SHORTCUT, I(ADDRTYPE_IPV6),
#endif
			      NULL);
#endif
	ctrl_tabdelay(s, pfd->addbutton);
	ctrl_columns(s, 1, 100);

	if (!midsession) {
	    /*
	     * The Connection/SSH/Bugs panel.
	     */