Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

64 check-ins using file windows/winplink.c version e27babb65c

2005-04-20
17:52
Ifdef out the actual code supporting 3des-ctr and blowfish-ctr, since GCC now notices that it isn't used. check-in: b9f8f8776e user: ben tags: trunk
17:47
Simon (accidentally, I think) enabled 3des-ctr and blowfish-ctr. Turn them back off again since they're still untested. check-in: 045da486d1 user: ben tags: trunk
16:29
Minimally document our support of aes*-ctr. check-in: e9f761c95c user: ben tags: trunk
15:57
Enable arcfour256-draft-00@putty.projects.tartarus.org, since I've now tested it against an independent implementation. check-in: e1e36d0b66 user: ben tags: trunk
2005-04-19
14:18
Invent a way of specifying control characters numerically in ctrlparse(): ^<27>, ^<0x1B>, ^<033>. (This doesn't tread on any syntax that already had a non-null behaviour.) check-in: d75014453b user: jacob tags: trunk
13:58
Pull out parsing of ^C style strings from the terminal answerback code to its own function, since I'll be wanting it for `terminal-modes'. check-in: 8baaaf38f8 user: jacob tags: trunk
08:27
Remove "none" from the MACs we offer to support in SSH-2. (It was at the end, after the REQUIRED "hmac-sha1".) This has been present since SSH-2 support was introduced (r569). check-in: 40843350e9 user: jacob tags: trunk
2005-04-18
16:09
Add ability to construct SSH-1 packets incrementally (not used yet). I've added this to support `terminal-modes', but since this unifies some SSH-1 and SSH-2 packet construction code, it saves a few hundred bytes. Bonus. check-in: 6ce70c5c20 user: jacob tags: trunk
07:21
Add a comment describing `dummyitem' in prefslist and associated problems. check-in: 4556c394db user: jacob tags: trunk
05:01
Recent CTR mode changes stopped OS X PuTTY from compiling, because -Werror objects at various static data items being defined but not used. Ifdef some things out to restore warning-free compilability. check-in: 3833248e32 user: simon tags: trunk
2005-04-15
08:11
Index "Event Log", "system menu", and "context menu" better. check-in: b833d0f66d user: ben tags: trunk
2005-04-14
17:58
Implement my experimental arcfour modes. The 256-bit version is disabled until I can test it against someone else's implementation. check-in: 3782733aa1 user: ben tags: trunk
2005-04-12
15:04
Unify GET_32BIT()/PUT_32BIT() et al from numerous source files into misc.h. I've done a bit of testing (not exhaustive), and I don't _think_ I've broken anything... check-in: a434996c3e user: jacob tags: trunk
2005-04-11
12:37
Comment: change "window.c" to "the front end" check-in: b50106acc1 user: jacob tags: trunk
11:24
Factor out the code to read and write the Environment and PortForwardings mappings into two new functions. check-in: 6f46b8e06b user: jacob tags: trunk
11:23
Retire winctrls.c:multiedit() in favour of a new simpler function for a single full-width edit box. multiedit()'s extra functionality has been superseded by the "columns" mechanism, and it didn't allow an edit box to be created with no label. Also add no-label capability to a couple of other controls. check-in: 5b60777159 user: jacob tags: trunk
2005-04-09
18:02
Add WS_VSCROLL style to drop-down non-combo boxes, to add a scroll bar if needed. (Doesn't affect the appearance of any existing controls.) check-in: 1fdf9bd382 user: jacob tags: trunk
2005-04-07
17:33
Tone down canonical-name resolution when using getaddrinfo(). Previously we were doing a forward+reverse lookup, which seems above and beyond the call of duty, especially given that getaddrinfo() can be persuaded to return a canonical name (this is what unix/uxnet.c does). Unfortunately, I'm unable to test this at all as Win98 doesn't have getaddrinfo(); hopefully I'll be able to find a mug with a modern version of Windows to check it's not completely broken. I think the effects of this are mostly cosmetic -- the canonical name is used for window titles (and some people have been annoyed at the new behaviour), other displays, and probably also for proxy exclusions. check-in: 3cce74bf22 user: jacob tags: trunk
07:38
I always get a lot of personal mail about PuTTY when I send out a release announcement, because people reply directly to the putty-announce mail. I should remember to set a Reply-To header next time. check-in: 91d83f7b9a user: simon tags: trunk
07:00
Oops, forgot to credit Ahmad Khalifa of arabeyes.org for the bidi/shaping work. check-in: 91dfa430a2 user: jacob tags: trunk
2005-04-06
20:42
Add keyboard accelerators for IPv4/IPv6 selections options. (Also for `window_border'.) check-in: 71eb9cf248 user: jacob tags: trunk
20:36
If a new session was saved from Change Settings, a side-effect on Windows was that the global `sesslist' got out of sync with the saved-sessions submenu, causing the latter to launch the wrong sessions. Also, Change Settings wasn't getting a fresh session list, so if the set of sessions had changed since session startup it wouldn't reflect that (at least until a session was saved). Fixed (on all platforms). Therefore, since the global sesslist didn't seem to be useful, I've got rid of it; config.c creates one as needed, as do the frontends. (Not tried compiling Mac changes.) Also, we now build the saved-sessions submenu on demand on Windows and Unix. (This should probably also be done on the Mac.) check-in: 11a4164f51 user: jacob tags: trunk
20:32
In get_sesslist(), when freeing, set freed members to NULL on general principles. check-in: 249f1326fc user: jacob tags: trunk
18:40
Remove support for the "rijndael256-cbc", "rijndael192-cbc", and "rijndael128-cbc" names for AES. These are in the IANA namespace, but never appeared in any secsh-transport draft, and no version of OpenSSH has supported them without also supporting the aes*-cbc names. "rijndael-cbc@lysator.liu.se" gets to live because it's in the private namespace. check-in: 7ee3abdcf4 user: ben tags: trunk
18:27
Implement SDCTR modes, as defined in the newmodes draft. This adds aes128-ctr, aes192-ctr, and aes256-ctr. blowfish-ctr and 3des-ctr are present but disabled, since I haven't tested them yet. In addition, change the user-visible names of ciphers (as displayed in the Event Log) to include the mode name and, in Blowfish's case, the key size. check-in: d3f3f9c216 user: ben tags: trunk
17:16
`xp-wont-run': Apparently my application-manifest trims of r5534 aren't acceptable on all versions of XP. Bah. Revert to pre-r5534 format (but keep version number as 0.0.0.0). People who've had this problem have reported putty.mft to make it go away. NB, putting these updated manifests alongside the executable (e.g. as `putty.exe.manifest') is also reported to work. check-in: 5370dde63c user: jacob tags: trunk
2005-04-05
14:36
Version number and other tweakings prior to the 0.58 release. check-in: 49ffff2389 user: simon tags: trunk
13:38
tweak wording in "pscp -ls" check-in: 151bf3ba13 user: jacob tags: trunk
13:15
add XXX-REMOVE-BEFORE-RELEASE re uninstaller check-in: 233f1d558d user: jacob tags: trunk
13:11
Add target to build `info' file. We probably already require a new enough version of Halibut that this isn't a problem; nevertheless, I've put it in a separate target for now. check-in: 94ca16030a user: jacob tags: trunk
13:03
Add versionid for index. Also plumb in pgpkeys.but versionid. check-in: c03e6a193d user: jacob tags: trunk
13:01
Index the complete PuTTY manual. This was a bit rushed, and could doubtless be improved. Also fix a couple of things I noted on the way, including: - "pscp -ls" wasn't documented - Windows XP wasn't mentioned enough check-in: d3a077fa53 user: jacob tags: trunk
2005-04-04
08:44
NULL needs to be cast to void * when passed to a variadic function like execl(). Spotted by Damien Miller. check-in: eb7b985525 user: ben tags: trunk
2005-04-01
07:25
#ifdef out expensive combining-character/scrollback diagnostics (for now). check-in: e1292dcaea user: jacob tags: trunk
02:46
sk_address_is_local() was ignoring the possibility that a SockAddr might have an IPv4 address in `ai' rather than in `addresses'. Thanks to Martin Prikryl for pointing this out. check-in: 904f28216b user: simon tags: trunk
2005-03-31
12:52
Add text to the troubleshooting chapter about the errors that can be caused when an active connection times out due to outgoing data exceeding its maximum number of retries, and mention that this can occur even when you didn't think you'd sent anything due to rekeys and/or keepalives. Unix generates ETIMEDOUT in this situation. Windows, it turns out after doing an actual experiment by disabling my firewall, generates ECONNABORTED! So _that's_ what it means under Windows. I wish I'd done this experiment years ago now. check-in: 045dd26b66 user: simon tags: trunk
07:45
FAQ entry on rekeys: Jacob would like to pre-emptively try to avoid the possibility of people falling back to SSH-1 just because it gets rid of the irritating delays. check-in: 13f6a8ffb8 user: simon tags: trunk
06:25
Beef up the `unfinished and experimental' warnings for the two Mac ports, mentioning in particular that even if you downloaded a _release_ source archive these particular ports are not considered to be of release quality. check-in: 654cd509e1 user: simon tags: trunk
03:02
XXX-REMOVE-BEFORE-RELEASE: check docs too check-in: d7303869d2 user: jacob tags: trunk
2005-03-30
13:33
Further fix for lcc-win32. The PuTTY suite now compiles fine for me using lcc-win32 v3.8 (compilation date Mar 2 2005 18:40:17) provided I pass COMPAT="-DNO_IPV6 -DNO_MULTIMON" on the command line. check-in: 77e295b6c2 user: simon tags: trunk
04:20
faq-timeout: update for XP check-in: 17dff8e65f user: jacob tags: trunk
02:27
<1112163342.018492.101240@f14g2000cwb.googlegroups.com> on comp.security.ssh contains a Dr Watson log which looks to me as if `unclean-close-crash' occurred due to a rekey timer going off after the session had closed. Hence, ssh2_timer() now avoids doing anything if the session is already closed, and also ssh_do_close() proactively calls expire_timer_context(). Between those I think they ought to solve the problem. check-in: a38745f290 user: simon tags: trunk
2005-03-29
08:24
Small markup fixes I just noticed, mostly use of literal double quotes where \q{} would be better. check-in: 4fd797a1e1 user: simon tags: trunk
07:10
After we receive EOF on stdin, we should clear ssh->send_ok so that we stop trying to read anything further from stdin. Otherwise we send a continuous stream of SSH2_MSG_CHANNEL_EOF. check-in: b8c79bfc5c user: simon tags: trunk
2005-03-28
11:48
Render timing.c robust in the face of strangeness. The strangenesses in question vary per OS: on Windows the problem is that WM_TIMER sometimes goes off too early, so that GetTickCount() is right and the callback time is wrong, whereas on Unix the problem is that my GETTICKCOUNT implementation comes from the system clock which means it can change suddenly and non-monotonically if the sysadmin is messing about (meaning that the timing of callbacks from GTK or select timeouts is _more_ likely to be right than GETTICKCOUNT). This checkin provides band-aid workarounds for both problems, which aren't pretty but ought to at least prevent catastrophic assertion failure. check-in: 19b26a1cc7 user: simon tags: trunk
2005-03-23
20:22
In fact, I'll document the wrinkle with "plink -load", rather than just wittering about it on a mailing list. check-in: f382c137f8 user: jacob tags: trunk
19:01
Fix comment re dmemdumpl() check-in: 0d7a14b8db user: jacob tags: trunk
14:23
Since Markus Kuhn no longer explicitly places wcwidth.c in the public domain, it'd probably be generous to list him in the copyrights. check-in: 53095c321f user: jacob tags: trunk
14:04
`wcwidth-upgrade': upgrade to latest wcwidth.c from Markus Kuhn <http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c>. This is identified both internally and in HTTP headers as 2003-05-20, for Unicode 4.0. Only changes from upstream are to make mk_wcwidth_cjk() non-static and to #include "putty.h" for prototypes. The status of some code points has changed; see the wishlist item. We've had some feedback from the CJK and Arabic communities that upgrading is probably the right thing to do. check-in: 43aaadc6f0 user: jacob tags: trunk
2005-03-22
19:08
Another fix from Hung-Te Lin; apparently in some IMEs (such as "MS NewPhonetics"), move events (arrow keys) were being doubled up, apparently because we turned both KEYDOWN and KEYUP events into new KEYDOWN events. I don't claim to understand the precise effect of this patch :( but I'm reasonably confident that it only affects IME users, and experimentally it doesn't seem to break anything obvious, so if piaip says it makes things better that's good enough for me :) check-in: b571a72780 user: jacob tags: trunk
17:25
Fix my fix (r5539) to the `multi-changesettings-crash' fix. Ahem. check-in: 8eba346720 user: jacob tags: trunk
17:20
Add an option to use wcwidth_cjk() instead of wcwidth(), as several people have asked for it. check-in: 196df61809 user: jacob tags: trunk
2005-03-21
16:20
Hung-Te Lin spotted that the `multi-changesettings-crash' workaround for Windows would prevent a user opening Change Settings if they'd cancelled a previous Change Settings. check-in: b1e67f39ff user: jacob tags: trunk
11:43
Mention PUTTY.RND by name check-in: 0fadae178d user: jacob tags: trunk
07:46
Martin Trautmann spotted a bare char being passed to isspace. check-in: a7eef72fe4 user: simon tags: trunk
2005-03-20
19:51
Trim application manifests as much as MS' documentation and Owen's experiments on XP allow while still having the desired effect -- this allows removal of some fibs. Also, change version number to 0.0.0.0 in preparation for `win-versioninfo' (not that we found anything that took any notice of the version number declared here). check-in: f01e04c784 user: jacob tags: trunk
19:05
Improvement for IME font display from Hung-Te Lin. Not tested, but it appears only to affect Glenn Maynard's r1406 code from <20011006170741.A23470@zewt.org> and nothing else, so seems harmless enough. check-in: 6e9a512a1b user: jacob tags: trunk
16:28
Add comments about default processing in DialogProc/WindowProc, since I often forget the rules. check-in: dafb82d057 user: jacob tags: trunk
2005-03-19
13:23
Revert last change: Some versions of the GNU C Library (notably SUSE glibc-2.3.3-118 and Debian libc6 2.3.2.ds1-20) have clock_gettime() and CLOCK_MONOTONIC in their headers, but not in libc itself, which we can't detect easily. check-in: 938b498699 user: ben tags: trunk
13:02
If it's available, try to use clock_gettime(CLOCK_MONOTONIC) rather than gettimeofday(), since the former shouldn't warp when the user resets the clock. check-in: fa500e0b32 user: ben tags: trunk
10:34
Work around lcc's annoying (but, even more annoyingly, legitimate) refusal to allow comparison of function pointers. Unfortunately this still doesn't cause PuTTY to compile on my lcc installation, because the GetCharacterPlacement stuff in exact_textout() is missing from its header files. This may have been fixed in a future version (I'm using lcc-win32 version 3.8 from December 2003), but I haven't checked. check-in: c21f956e2f user: simon tags: trunk
2005-03-18
21:05
More compact display for the key links/fingerprints. Still not ideal, but it'll probably do. check-in: 5c3fe3560a user: jacob tags: trunk
20:29
Set SVN properties on udp.but the same as everything else check-in: d59b56948b user: jacob tags: trunk
20:26
Try to make our PGP signing more useful: * All the PuTTY tools for Windows and Unix now contain the fingerprints of the Master Keys. The method for accessing them is crude but universal: a new "-pgpfp" command-line option. (Except Unix PuTTYgen, which takes "--pgpfp" just to be awkward.) * Move the key policy discussion from putty-website/keys.html to putty/doc/pgpkeys.but, and autogenerate the former from the latter. Also tweak the text somewhat and include the fingerprints of the Master Keys themselves. (I've merged the existing autogeneration scripts into a single new one; I've left the old scripts and keys.html around until such time as the webmonster reviews the changes and plumbs in the new script; he should remove the old files then.) check-in: d2a830c19a user: jacob tags: trunk