Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

15 check-ins using file macosx/osxwin.m version db52faf47c

2005-12-07
12:01
Apparently some SSH servers object to our claiming port-forwarded connections to be from IP "client-side-connection". Claiming "0.0.0.0" instead seems to work. Spotted by Brant Thomsen. check-in: 0cf3aea3e9 user: jacob tags: trunk
2005-12-06
18:24
Institutional failure to memset() things pointed at rather than pointers. Things should now be zeroed and memory not leaked. Spotted by Brant Thomsen. check-in: 2a7f73d55f user: jacob tags: trunk
17:18
Improvements from Spyros Blanas to the MSVC optimisations of r6469: don't do a function call for each divmod, and don't rely on details of the calling convention. (This didn't actually make any measurable difference to runtime in any of my tests, but we may as well keep it as it's neater.) Also document some general caveats of the divmod macro. check-in: f970409cb9 user: jacob tags: trunk
2005-12-01
10:41
SSH-2 rekey bug compatibility setting wasn't being saved (but _was_ being loaded). check-in: 5af5c8f9a9 user: jacob tags: trunk
2005-11-23
15:26
An MSVC version of the 16->32-bit bignum optimisation, derived from part of a patch by Lionel Fourquaux. Seems to be about a factor of four improvement (see wishlist item for details). I don't claim to understand this in detail, so I can't vouch for its correctness, but it didn't fall over immediately. It also produces some compiler warnings, unfortunately. check-in: eefc5f979e user: jacob tags: trunk
2005-11-14
03:41
Missing close parenthesis. check-in: 61c0f1e69b user: jacob tags: trunk
2005-11-13
10:06
r6437 broke the case where Pageant is running but contains no SSH-2 keys that the SSH-2 server is happy with. Fixed, and since I'm here, fix `pubkeyfile-and-pageant' as well (for SSH-1 and SSH-2). Also, in SSH-2, we now reexamine "methods that can continue" for every Pageant key offer, which is technically more correct although it seems unlikely that it was causing any real problems. (It's not entirely pretty, but neither was the old code. We could probably do with some sort of abstraction for public/private keys to avoid carting lots of fiddly bits of data around.) check-in: 5ecfcce6b6 user: jacob tags: trunk
06:13
Oops, used \I where I meant \i. I think this is the only instance. check-in: 6c6d33724f user: jacob tags: trunk
2005-11-09
17:19
I broke the ability to cope with multiple consecutive k-i INFO_REQUESTS in r6437. This ought to be better (but I can't test that case). check-in: eefac6dd49 user: jacob tags: trunk
2005-11-04
17:31
Fix minor hiccup in SSH-1 p-k auth. check-in: b965b38836 user: jacob tags: trunk
17:21
Placate a compiler warning introduced in r6437. (I forgot we usually compile with -Werror on Unix, oops.) check-in: 992b547918 user: jacob tags: trunk
08:49
Fix for `ssh2-password-expiry'. Success case tested. (Much easier since r6437, and actually works to boot.) check-in: 5033091888 user: jacob tags: trunk
2005-11-02
17:15
When a userpass interaction has finished, make sure the 'prompts' structure is safe for re-use. check-in: be2be716fa user: jacob tags: trunk
2005-10-31
16:43
(do_ssh2_authconn_state).method is redundant since r6437; remove. Remove FIXMEs from .type assignments, as they look fine. check-in: ad1b2a4de9 user: jacob tags: trunk
2005-10-30
14:24
Revamp SSH authentication code so that user interaction is more abstracted out; replace loops structured around a single interaction per loop with less tortuous code (fixes: `ki-multiprompt-crash', `ssh1-bad-passphrase-crash'; makes `ssh2-password-expiry' and `proxy-password-prompt' easier). The new interaction abstraction has a lot of fields that are unused in the current code (things like window captions); this is groundwork for `gui-auth'. However, ssh.c still writes directly to stderr; that may want to be fixed. In the GUI apps, user interaction is moved to terminal.c. This should make it easier to fix things like UTF-8 username entry, although I haven't attempted to do so. Also, control character filtering can be tailored to be appropriate for individual front-ends; so far I don't promise anything other than not having made it any worse. I've tried to test this fairly exhaustively (although Mac stuff is untested, as usual). It all seems to basically work, but I bet there are new bugs. (One I know about is that you can no longer make the PuTTY window go away with a ^D at the password prompt; this should be fixed.) check-in: fa1347493a user: jacob tags: trunk