Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
21 check-ins using file psftp.c version d30256fffb
|
2001-09-05
| ||
| 14:33 | When pscp in SFTP mode does client-side matching of a server-side wildcard, it's polite to let the user know if the wildcard didn't match any file names. check-in: 057992d7ea user: simon tags: trunk | |
|
2001-08-29
| ||
| 03:56 | Fix segfault (should free act.buf not act.name, because the latter might not point at the start of the former). Cheers Minefield :-) check-in: d02e404690 user: simon tags: trunk | |
|
2001-08-28
| ||
| 07:26 | stripslashes() should have been dealing with colons as well. I don't _think_ there was an exploit (even if the server sends "c:foobar", the client will not attempt to create "c:foobar"; instead it will try to create ".\c:foobar" which will fail), but it's as well to be sure. check-in: e6fe329d9c user: simon tags: trunk | |
| 07:24 | Semantic fix in the X11 `authentication failed' error packet construction. Doesn't actually affect anything right now, since the bug was a failure to round a length up to the next multiple of 4 and it so happens that our current message was exactly 40 bytes anyway :-) But if we start giving a wider variety of messages one day then it might be handy to be able to do them without gratuitous crashes. check-in: b37b4aae64 user: simon tags: trunk | |
| 04:53 | Add documentation of the new PSCP `-unsafe' option and the associated warning message. check-in: 24cfbbc03b user: simon tags: trunk | |
| 03:43 | D'oh! Putting keyboard-interactive authentication _before_ publickey causes password login to occur on a server that supports password- through-k-i. Of course when we use the new preference list mechanism for selecting the order of authentications this will all become much more sane, but for the moment I've put publickey back up to the top and things seem to be happier. check-in: 3cb4b5568a user: simon tags: trunk | |
| 03:36 | Fix externally added SSH1 keys in Pageant. I have no idea how this code _ever_ worked before! But it's been like this for four months and nobody has noticed, including me. That's quite spooky. check-in: 8ae7f39455 user: simon tags: trunk | |
| 03:08 | Fix various small compiler warnings, mostly unused local variables check-in: 0a5751b809 user: simon tags: trunk | |
|
2001-08-27
| ||
| 12:40 | PuTTYgen: add an extra button to save a public key into a file (as well as showing it for cut and paste). For SSH1, this feature is largely cosmetic and added for orthogonality; it comes into its own in SSH2, where it saves the Official One True Public Key Format as specified in the draft spec, and more particularly as used by ssh.com's product for authentication. Now that ssh-3.0.1 supports RSA user keys, this is suddenly actually useful. check-in: 3ec80d2102 user: simon tags: trunk | |
| 11:58 | Fix handling of SSH2_MSG_CHANNEL_CLOSE, which was breaking in port forwarding talking to ssh.com's ssh-3.0.1. check-in: e28e899e99 user: simon tags: trunk | |
| 10:59 | Port forwarding update: local-host-only listening sockets are now done properly (by binding to INADDR_LOOPBACK) instead of hackishly (by binding to INADDR_ANY, looking at the peer address when a connection is accepted, and slamming the connection shut at that point). check-in: da6aaddf6b user: simon tags: trunk | |
| 10:55 | Add a couple of missing return values check-in: 589e1d2cc0 user: simon tags: trunk | |
| 10:13 | Port forwarding bug fix: we were unable to handle receiving CHANNEL_OPEN_FAILURE messages, which occur when the remote side is unable to open a forwarded network connection we have requested. (It seems they _don't_ show up if you get something mundane like Connection Refused - the channel is cheerfully opened and immediately slammed shut - but they do if you try to connect to a host that doesn't even exist. Try forwarding a port to frogwibbler:4800 and see what you get.) check-in: f7b3ee5549 user: simon tags: trunk | |
| 10:02 | Finally tighten up the server-side wildcard security hole, the _right_ way. (SSWs are disabled by default and can be re-enabled using `-unsafe', meaning that pscp will _never_ do anything unexpected to your local file system unless you explicitly give consent. The sftp-based variant will work fine because the corresponding mechanism is _not_ unsafe.) check-in: b3d4e1612d user: simon tags: trunk | |
| 09:51 | Fix tiny bug in new sftp-mode wildcards: when there wasn't a leading path component (just `host:*' rather than `host:directory/*') there was trouble. check-in: 912522e575 user: simon tags: trunk | |
| 05:24 | Minor modification: in remote->local non-recursive mode matching a wildcard, we don't abandon ship completely if the wildcard matches a directory; we just warn and carry on with the rest. check-in: a6483ad1a9 user: simon tags: trunk | |
| 05:17 | Implemented a simple wildcard matching engine, and used it to restore remote wildcard capability in sftp-style PSCP. check-in: ad2723cc77 user: simon tags: trunk | |
|
2001-08-26
| ||
| 13:32 | PSCP now uses the modern SFTP protocol if it can, and falls back to scp1 if it can't. Currently not very tested - I checked it in as soon as it completed a successful recursive copy in both directions. Also, one known bug: you can't specify a remote wildcard, because by the nature of SFTP we'll need to implement the wildcard engine on the client side. I do intend to do this (and use the same wildcard engine in PSFTP as well) but I haven't got round to it yet. check-in: 0d8a92d58d user: simon tags: trunk | |
| 10:45 | Arrgh; yet again I make my security checking too draconian to actually get things done. I'm sure this is the second time I've checked in this mistake :-/ Still, this time I've got right to the bottom of the cause, and commented it clearly. Phew. check-in: 85efe1705a user: simon tags: trunk | |
| 10:32 | Oops. ^X^S comes _before_ `cvs commit'. Two more diagnostics gone :-) check-in: 635360f2f9 user: simon tags: trunk | |
| 10:31 | Further tightening up in PSCP. Fixed a couple more holes whereby a malicious SCP server could have written to areas other than the ones the user requested; cleared up buffer overruns everywhere. Hopefully we now do not use arbitrary buffer limits _anywhere_. check-in: 0963d65406 user: simon tags: trunk | |