Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

202 check-ins using file sftp.c version aebe7b3dfb

2002-10-26
07:42
Richard points out that it would probably help if I committed ldisc.h. Bah. :-) check-in: fc513a6cb8 user: simon tags: trunk
06:23
X forwarding authentication is now invented on a per-SSH-connection basis, so the statics are gone from x11fwd.c. check-in: f79eb3364d user: simon tags: trunk
06:12
Fix proxy.c so that the static variables become const. check-in: a5d6220305 user: simon tags: trunk
06:08
Reorganised the Unicode layer somewhat: moved luni_send and lpage_send out into the line discipline, making them _clients_ of the Unicode layer rather than part of it. This means they can access ldisc->term, which in turn means I've been able to remove the temporary global variable `term'. We're slowly getting there. check-in: 457ce6905a user: simon tags: trunk
05:33
Port forwarding module now passes backend handles around properly. As a result I've now been able to turn the global variables `back' and `backhandle' into module-level statics in the individual front ends. Now _that's_ progress! check-in: 06cff2eb6c user: simon tags: trunk
05:16
Line discipline module now uses dynamically allocated data. Also fixed one or two other minor problems. check-in: d16199ae68 user: simon tags: trunk
2002-10-25
17:00
Oops; remembering to call term_provide_resize_fn in the Unix front end would probably help. Thanks Colin. check-in: 40732d161f user: simon tags: trunk
08:26
The Zlib module now uses dynamically allocated contexts. I think that completes the static-removal in the crypto library. Ooh. check-in: d666740d70 user: simon tags: trunk
08:08
Diffie-Hellman key exchange now uses a dynamically allocated context. check-in: 28d1810cc5 user: simon tags: trunk
08:00
Fix some compiler warnings. check-in: faa5c4fe6e user: simon tags: trunk
07:59
Tidy up and fix a compiler warning. check-in: 409a2fa882 user: simon tags: trunk
07:58
SSH CRC attack detector now uses a dynamically allocated context. check-in: 45540e784d user: simon tags: trunk
07:51
SSH2 MACs now use dynamically allocated contexts. check-in: fb0d4d686d user: simon tags: trunk
07:35
SSH ciphers now use dynamically allocated contexts. check-in: f12024de9a user: simon tags: trunk
06:58
Fix the nasty flashing-light-grey-on-resize problem, after MCV helpfully alerted me to the existence of gdk_window_set_background(). check-in: 5fa48e3449 user: simon tags: trunk
06:50
pty backend now supports the changed function interface, so pterm now compiles and runs again after the major destabilisation. Unfortunately it wasn't feasible to actually encapsulate all of the pty backend's data, since the utmp helper and the need to fork and drop privileges before doing anything else at all rather confuses matters. So the data handle passed around to the pty backend is a null pointer, and the pty backend is just as global-ridden as it always has been. Shame, but such is life. check-in: feb8faf680 user: simon tags: trunk
06:30
Major destabilisation, phase 2. This time it's the backends' turn: each backend now stores all its internal variables in a big struct, and each backend function gets a pointer to this struct passed to it. This still isn't the end of the work - lots of subsidiary things still use globals, notably all the cipher and compressor modules and the X11 forwarding authentication stuff. But ssh.c itself has now been transformed, and that was the really painful bit, so from here on it all ought to be a sequence of much smaller and simpler pieces of work. check-in: 92e8b2cec5 user: simon tags: trunk
2002-10-24
09:48
Need to stub frontend_keypress() in console.c as well as window.c. check-in: da3de94483 user: simon tags: trunk
09:12
Oops - repercussions of the close-on-exit stuff which I forgot to check in. I must stop doing my Unix checkins in the Unix subdir :-( check-in: 74f4ced28a user: simon tags: trunk
2002-10-23
09:24
Minor compiler nits: - use smalloc/sfree, not malloc/free - include <ctype.h> - include <string.h> (although this doesn't shut the compiler up about non-ANSI stricmp/strnicmp) check-in: 358caa17e7 user: jacob tags: trunk
09:21
Implement handling of all Close On Exit modes. Default is to close only on clean exit, which is a departure from most xterm-alikes but Ian reckons people will love me for it. If this turns out to be wrong, we can always change the default for Unix. check-in: e33f2e8338 user: simon tags: trunk
09:03
Fixes for (Backend)->size() changes -- internal declarations didn't include new arguments and neither did internal calls. check-in: f41c1604fd user: jacob tags: trunk
08:46
Remove apparently unnecessary declaration of typedef Config from winstuff.h -- it was breaking mingw builds (gcc being more picky than Visual C). check-in: dbc6f05d2a user: jacob tags: trunk
07:41
Cleanups from yesterday's destabilisation: lots of stuff in terminal.c was apparently relying on implicit initialisation to zero, and also I've removed the backends' dependency on terminal.h by having terminal sizes explicitly passed in to back->size(). check-in: 4bdb37398f user: simon tags: trunk
04:11
Oops. Forgot to check in terminal.h from yesterday's work. There's always one :-/ check-in: 4c7c6ce91d user: simon tags: trunk
2002-10-22
11:11
Major destabilisation, phase 1. In this phase I've moved (I think) all the global and function-static variables out of terminal.c into a dynamically allocated data structure. Note that this does not yet confer the ability to run more than one of them in the same process, because other things (the line discipline, the back end) are still global, and also in particular the address of the dynamically allocated terminal-data structure is held in a global variable `term'. But what I've got here represents a reasonable stopping point at which to check things in. In _theory_ this should all still work happily, on both Unix and Windows. In practice, who knows? check-in: c56a5fa8ee user: simon tags: trunk
08:27
Make -ut work the right way round! :-) check-in: b42bbd8274 user: simon tags: trunk
08:26
Stop `pterm -ut-' leaving the unnecessary utmp helper as a zombie process (Debian bug #165887). check-in: 9a67f6a55f user: simon tags: trunk
05:31
Thanks to Richard B for pointing out that xterm has its own variants of the alternate-screen and save-cursor control sequences, with subtly different semantics and entertaining interactions with the usual ones. No thanks to xterm for doing so in the first place :-( This checkin should sort it all out. check-in: c17e8cfefd user: simon tags: trunk
04:40
Justin Bradford's patch for increased proxy robustness. check-in: 76e58c77c8 user: simon tags: trunk
2002-10-21
18:01
Make sure SIGINT and SIGQUIT haven't been nobbled in our child process by weird POSIX-required shell behaviour. check-in: 179d3e66f2 user: simon tags: trunk
18:00
Don't bother closing fds 0-2 before dup2ing over them; there's no need, and it means we always have a valid open stderr. check-in: e44f39631e user: simon tags: trunk
17:59
VT100 line drawing characters should only happen between 0x5F and 0x7E, not everywhere else. Silly me thought nobody would bother to depend on this :-) check-in: 9f5e3fc49d user: simon tags: trunk
2002-10-20
08:23
Implement Richard's really clever idea about bell overload mode: it's automatically deactivated by any keypress, so that command-line beeps from (e.g.) filename completion don't suddenly stop occurring, but it still provides a rapid response to an accidental spewing of a binary to your terminal. check-in: 89a7cd7830 user: simon tags: trunk
07:44
ScrollOnKey wasn't working because I failed to set seen_key_event in pterm.c. check-in: ba3068e889 user: simon tags: trunk
2002-10-18
10:26
Reject unrecognised command-line options; thanks rjk. check-in: 6b1f39e18f user: simon tags: trunk
05:38
Fix typo in man page. Thanks Richard. check-in: f623806109 user: simon tags: trunk
2002-10-17
11:58
Oops - that fix wasn't _quite_ right, since it killed all non-function keys completely :-/ check-in: 13faee9f62 user: simon tags: trunk
11:51
Make the shadow bold offset configurable, after discovering that 7x13 goes the other way to all other X fonts I've ever seen. (Arrgh.) check-in: 4245aa8933 user: simon tags: trunk
11:45
This should fix the bug causing Alt-Shift to generate Escape. check-in: 2163edba1a user: simon tags: trunk
2002-10-16
17:54
Add the -xrm command-line option, to allow specification of an arbitrary X resource which doesn't have a dedicated command-line option. check-in: a258b8a88b user: simon tags: trunk
17:43
Add a man page. check-in: f1505a5669 user: simon tags: trunk
11:32
Temporarily change the default for cut-and-paste of line drawing characters, under Unix only, because the stub Unicode layer makes the usual default break moderately painfully. check-in: 2ef611e291 user: simon tags: trunk
11:00
A few more command-line options. check-in: c544ce865f user: simon tags: trunk
09:32
Oops, forgot to add BoldFont to the settings module. check-in: 53b9f89c82 user: simon tags: trunk
09:32
Implement reading of X resources, and -name to change the name under which to look them up. check-in: dc7f9c04de user: simon tags: trunk
07:30
Add a file to the source archive mentioning the version number of the latest release. This is so that .tar.gz snapshots for the Unix port can be versioned as `0.53-20021016' or similar, meaning that (e.g.) Debian version numbering can be monotonic between releases and snapshots. check-in: 0372c5661c user: simon tags: trunk
07:17
Fix utmp and pty handling so that GTK never complains about running set[ug]id. All privs-requiring pty operations are done at the very start of the run, then privs are dropped before initialising GTK. Utmp is handled by forking a still-privileged subprocess at this point, and later asking it (through a pipe) to stamp utmp. The subprocess cleans up utmp on exit, which has the additional advantage that if the main pterm process suffers some sort of unexpected termination (up to and including SIGKILL) the subprocess can still mop up utmp. check-in: 7f9a81d03e user: simon tags: trunk
06:35
Fix for `hostname-whitespace'; thanks to Justin Bradford. check-in: 39093dcc64 user: simon tags: trunk
04:40
Bug `shift-backspace': whichever of ^H and ^? is configured for Backspace, Shift-Backspace should do the _other_ one. Thanks to Justin Bradford. check-in: 74ba290d86 user: simon tags: trunk
04:28
Oops - check in leftovers from yesterday's development. That's what I get for running most of my cvs commands in the unix subdir :-/ check-in: 2d5d551feb user: simon tags: trunk
2002-10-15
13:42
Support bold-as-font, by means of a separate bold font (if one was supplied) or shadow bolding (if not). As usual, can't yet be turned on without a recompile. check-in: b2569827d3 user: simon tags: trunk
13:36
Configure the pty so that it agrees with our idea of whether Backspace sends ^H or ^?. check-in: 8a75f4f208 user: simon tags: trunk
13:18
Support underline and vertical-line cursors as well as block. check-in: 3931a8354d user: simon tags: trunk
12:41
If we can't load the specified font, give an error message rather than segfaulting. check-in: d6f20644bd user: simon tags: trunk
12:38
Printer support: cfg.printer is assumed to be a Unix command through which to pipe printed data. Of course by default printing is disabled; typically cfg.printer would be set to `lpr', perhaps with some arguments. check-in: 50eaa1e2b3 user: simon tags: trunk
12:24
Scrollbar can now be configured to go on the left (although the current configuration mechanism doesn't support it). check-in: 94f7e9d448 user: simon tags: trunk
12:18
Support ALT + numeric keypad for typing in strange character codes. check-in: 5a7aebaff7 user: simon tags: trunk
11:52
Add newline at EOF in uxucs.c. Thanks Richard. :-) check-in: 206255935f user: simon tags: trunk
11:50
Support scrolling with the mouse wheel (X servers apparently usually send a button 4 press for an upward wheel movement and a button 5 press for a downward one). Untested since my own trackball's button 4 does nothing obvious. Someone with a mouse wheel should give this a workout. check-in: 622fd3d843 user: simon tags: trunk
11:40
Fixes to terminal.c to support blinking and visual bells under Unix. check-in: b34b6047b5 user: simon tags: trunk
11:38
Support for blinking text and blinking cursor. Won't actually be accessible until there's a way to configure it on, but it worked in tests. check-in: a0a5506f59 user: simon tags: trunk
11:24
Use the appalling gnome-terminal hack for server-controlled resizes rather than the gtk_window_set_policy approach; the GNOME people say that the former is the Right Thing in spite of the latter looking obviously plausible. check-in: 6cb6d56d5f user: simon tags: trunk
10:44
Remove some rogue diagnostics. check-in: 842a63a48e user: simon tags: trunk
10:16
Don't forget to initialise the pixel size parameters of the window as passed to the pty... check-in: f47218505b user: simon tags: trunk
09:58
Richard's patch to fix `make clean' under Unix. check-in: 93fe7922e6 user: simon tags: trunk
09:55
Richard's patch to make the scrollbar configurably absent. (Still want a new option to configure it to be on the LHS though. And some lunatic is bound to ask for an xterm-style scrollbar too... :-) check-in: c816ac1e38 user: simon tags: trunk
09:31
Support for all the server-side window configuration requests, including server-controlled resizing. Irritatingly I've had to use a deprecated option to gtk_window_set_policy() to make this work, resulting in me raising GNOME bug #95818 to ask for it to be un- deprecated again... check-in: ef25478d2b user: simon tags: trunk
08:07
Introduce the ability to control whether the shell run in pterm is a login shell or not. Also moved these new pieces of configuration into the Config structure, though they won't stay there forever since they will need to be moved out into platform-dependent config. check-in: 889a957cfd user: simon tags: trunk
07:42
Finish up utmp processing: add the -ut- command-line option to suppress stamping it at all. (I suppose this ought to be part of the cfg structure really.) check-in: 48d2913a94 user: simon tags: trunk
07:29
Support for utmp, wtmp and lastlog. Probably not terribly portable as yet, but seems to work plausibly on Linux. check-in: 04380af359 user: simon tags: trunk
05:52
Deal with the warnings generated when passing a pointer-to-enum to gppi as a pointer-to-int. check-in: b55c35f796 user: simon tags: trunk
05:49
Support for BSD-style pty devices. Tested under Linux; might need minor tweaks to run under other BSD-style OSes. check-in: 29530e8f6a user: simon tags: trunk
04:30
Trim wide text properly at the RH edge of the screen. check-in: 1d7a84f45a user: simon tags: trunk
2002-10-14
19:22
Support for line attributes: ESC #3, #4 and #6 for double-width and double-height text. check-in: 3a57c840d6 user: simon tags: trunk
18:39
Don't cause the mouse pointer to reappear just because it's changed shape. check-in: b5dce740cb user: simon tags: trunk
18:32
Only engage a GTK idle function when absolutely necessary, otherwise the whole app spins on it and takes up CPU all the time. check-in: 7a5991bb3f user: simon tags: trunk
17:14
Set up the palette _before_ trying to paint the window black. check-in: 65d1404fa3 user: simon tags: trunk
05:33
Add the -log option, which activates full session logging. Should be handy next time I need to debug any weird terminal problems... check-in: c3440c092b user: simon tags: trunk
05:29
Bell overload was working in principle, but wasn't scaled to Unix's greater time resolution. Oops. check-in: 924bd61e8e user: simon tags: trunk
05:21
Support server requests for colour palette changes. check-in: 12a36f9ab5 user: simon tags: trunk
05:14
Don't forget to call term_paste() when we get the chance, or big pastes won't go through. (Not sure whether I should remove this weird behaviour completely for pterm. It's a bit bizarre.) check-in: 03a780c15b user: simon tags: trunk
05:06
Support NetHack keypad mode. :-) check-in: e8759a8b36 user: simon tags: trunk
04:58
Support for hiding the mouse pointer on keypresses. Currently activated by `-hide' on the command line. check-in: 26a987d390 user: simon tags: trunk
04:18
xterm-class programs should exit when their primary child process dies, rather than waiting around until the last open handle on the pty closes. check-in: fe669158ac user: simon tags: trunk
04:06
SEL_NL is different between Windows and Unix; move it out into the platform-specific header files. check-in: 85f63b0224 user: simon tags: trunk
04:04
Oops. Defining max() the wrong way round was breaking rect select. check-in: d0017c34d9 user: simon tags: trunk
03:56
Various faffs in the pty allocation process to get controlling terminals right. Irritatingly this was working when run from another [xsp]term but not when run from my GNOME panel. I think it's now more robust. check-in: ed8734df95 user: simon tags: trunk
2002-10-13
19:05
Window title configurability: -T to set it from the command line, support for the xterm escape sequences to set it, and support for the xterm escape sequence to query it. check-in: bcb2aa106a user: simon tags: trunk
18:57
Don't forget to set $TERM when we spawn the pty. Of course I haven't noticed this until now because I've always been spawning it _from_ another xterm! :-) check-in: d49f2941d0 user: simon tags: trunk
18:48
gnome-terminal insists on receiving the selection as COMPOUND_TEXT rather than STRING, so we can now supply that too. Pasting both ways between pterm and gnome-terminal now works. check-in: 525fd6d0f4 user: simon tags: trunk
07:54
Added two simple command-line arguments: -fn (so I can have my Font Of Choice back :-) and -e to run a command other than $SHELL. check-in: 7a2269ba51 user: simon tags: trunk
07:44
Resizing of pterm now works, and the size information is correctly sent on to the pty. check-in: 2fb4abdb44 user: simon tags: trunk
07:17
Deal with the appalling mouse pointer colours. (Why doesn't GTK let us select our own mouse pointer fg and bg for standard pointers? It's ludicrous that we can only do it for pixmap-derived ones. :-( ) check-in: c8de8d4871 user: simon tags: trunk
06:27
Shift-Ins pastes. check-in: 4b2f26182c user: simon tags: trunk
06:24
Selection now supported in pterm. Required small modifications outside the unix subdir, owing to more things needing to become platform-dependent. check-in: e4d89ad7c0 user: simon tags: trunk
04:57
Fix underline, which I cleverly broke while adding support for the window border. Oops. check-in: ebd5e8cfd3 user: simon tags: trunk
04:54
Scrollbar now exists and functions; so do Shift-PgUp / Shift-PgDn. check-in: 3bcb27e451 user: simon tags: trunk
03:56
The Great Defaults Change (and about time too)! SSH now defaults to protocol 2, and background-colour erase now defaults to on. check-in: 1f6b063eb7 user: simon tags: trunk
2002-10-11
07:29
Initialise some members of the Proxy_Socket structure that were left uninitialised. This problem only showed up with mingw builds of PuTTY (maybe MSVCRT is more forgiving with malloc initialisation than CRTDLL?). The 'error' field was causing me most trouble, and I think the other two were necessary too before things started working. Note however that I don't fully understand the code, and that there are more uninitialised fields in the structure. check-in: d8e30b5284 user: jacob tags: trunk
2002-10-10
09:42
Stop hard-coding a nonstandard font. We now default to `fixed', and pick up the font's real width and height. This means I now _can't_ use my font of choice until I implement some command-line options; I wonder what feature will appear next :-) check-in: 3628bd7d8c user: simon tags: trunk
09:39
Update to reflect 0.53 release. check-in: 79f1b92c1c user: jacob tags: trunk
07:40
And that's it! pty.c is now a real pty backend rather than a loopback interface; pterm now runs $SHELL and gives every impression of being not a bad terminal emulator. I'm quite pleased with that. :-) check-in: df838b2e56 user: simon tags: trunk
07:14
Half-decent keyboard handling for pterm. Not very well done - it would have been better to abstract the general key-handling rules away from the platform-specific keysyms rather than doing clone- and-hack as I've done - but it'll serve for now. Now all I need is a real pty back end and pterm should be a just-about-usable prototype. check-in: 85cfc8acc0 user: simon tags: trunk
06:33
Temporary hack which makes vt100 line drawing work in the prototype pterm. check-in: a571f42c1a user: simon tags: trunk
05:40
A sensible minimum of do_text() and do_cursor() is now implemented. This means pterm actually _looks_ like the PuTTY terminal emulator engine, instead of merely giving evidence to the expert eye that said engine is hidden in there somewhere :-) check-in: 3d9a36b500 user: simon tags: trunk
2002-10-09
13:09
First phase of porting. pterm now compiles and runs under Linux+gtk. The current pty.c backend is temporarily a loopback device for terminal emulator testing, the display handling is only just enough to show that terminal.c is functioning, the keyboard handling is laughable, and most features are absent. Next step: bring output and input up to a plausibly working state, and put a real pty on the back to create a vaguely usable prototype. Oh, and a scrollbar would be nice too. In _theory_ the Windows builds should still work fine after this... check-in: 2d8039929a user: simon tags: trunk
2002-10-07
17:21
Oops. Dirsep in Makefile.cyg should be / not \. check-in: fb7695beb0 user: simon tags: trunk
12:43
Remove "-log" option from Plink. AFAICT this code has been dead since Roman Pompejus' improved logging (Jan 2001). check-in: a0a2b7568d user: jacob tags: trunk
12:31
Fix pscp-cmdline-port-bug for PSFTP too. (Also removes what appears to be a gratuitous re-implementation of the "-l user" option.) check-in: 17d1c99570 user: jacob tags: trunk
11:52
Fix code which was clobbering people's -P arguments in PSCP (moved it to before the deferred command line processing). Also removed a couple of unused variables. check-in: a1e4761e51 user: jacob tags: trunk
11:45
Begin destabilisation in the wake of 0.53! This checkin contains the beginning of a Unix port. It's nowhere near done, and currently it won't even compile on Unix. But this represents the start of the process of separating out platform-specific code, and also contains the mkfiles.pl changes required to support a Unix makefile and a non-flat source tree. check-in: 1baf2504b1 user: simon tags: trunk
2002-10-01
13:30
Remove last vestiges of `buggymac' in the Config structure. Might have been cause of a Plink bug since it no longer got initialised. check-in: 53f6591e2e user: simon tags: trunk
12:27
Bump the version number on the installer script. check-in: c32f0eba5b user: simon tags: trunk
11:27
Add a chapter explaining common error messages check-in: a03fe734a9 user: simon tags: trunk
2002-09-26
13:37
Add a new SSH2 bug: some servers apparently claim to be able to do DH group exchange, but choke when you actually try it. Never automatically enabled; manual control only. check-in: 1f07089633 user: simon tags: trunk
13:01
Any application using non-modal dialogs must use IsDialogMessage in its main message loop, otherwise keyboard accelerators will not work in the dialogs. I MUST NOT FORGET THIS AGAIN. check-in: f27b8e7e8a user: simon tags: trunk
12:57
If the user asks for the Pageant key list window and it's already present, bring it to the front. check-in: b48429d153 user: simon tags: trunk
2002-09-24
14:27
Finish replacing `Network error' with `Proxy error' throughout proxy code. check-in: 4ffa7303ca user: simon tags: trunk
13:44
Add a missing space in an error message. check-in: faeaee8977 user: simon tags: trunk
2002-09-23
04:55
Add context help support for Proxy panel check-in: 712c459cab user: jacob tags: trunk
2002-09-21
11:52
Cleanups to proxy code: greater robustness in receiving proxy data, better error reporting for SOCKS 5 and HTTP proxies. check-in: 842273612c user: simon tags: trunk
11:07
Support username/password authentication in SOCKS 5. check-in: 8ec7225e99 user: simon tags: trunk
09:03
Support username and password authentication when talking to HTTP proxies. check-in: 67128cfa54 user: simon tags: trunk
2002-09-20
13:57
Update README to make it clear it's a _source_ README. check-in: b7747e0bae user: simon tags: trunk
13:57
Initial checkin of PuTTY installer script and associated files. check-in: 3d34fcadbe user: simon tags: trunk
12:54
Use memcpy rather than strncpy in sk_addrcopy! How did that happen? check-in: 4b5b64e694 user: simon tags: trunk
2002-09-15
17:18
Jordan Russell's mysterious workaround for an almost equally mysterious Windows GDI bug. Looks unlikely to cause any other trouble and it's pretty small, so it can go in. check-in: 42fa4ba837 user: simon tags: trunk
08:31
Be proactively pedantic about channel-close irregularities: we no longer just sit there like a lemon if we can't find the channel in question, we bomb out and complain. With any luck, remaining problems of this type should be easier to catch under this policy. check-in: ab762b8245 user: simon tags: trunk
08:24
Improvements to SSH1 channel close handling: track sending and receiving of CLOSE and CLOSE_CONFIRMATION separately rather than taking short cuts. I believe ssh-1.2.33 sending CLOSE_CONFIRMATION before CLOSE was causing the remaining incidences of bug `nonexistent-channel'. (ssh-1.2.33 appears to have unilaterally decreed that CLOSE and CLOSE_CONFIRMATION are respectively renamed INPUT_EOF and OUTPUT_CLOSING, hence there is no longer an ordering constraint on them. Bah.) check-in: 973da1f5cd user: simon tags: trunk
08:21
Log file tinkering: copy Event Log entries into the SSH packet log, so that when people send us a packet log they never forget to send the Event Log alongside it :-) check-in: 019c881e88 user: simon tags: trunk
2002-09-14
05:24
OpenSSH vs OpenSSL Q: mention older OpenSSH versions check-in: 248bdf7692 user: jacob tags: trunk
2002-09-12
11:05
Semi-bug "long-usernames": Bump username storage from 32 to 100 chars. Also replaced a couple of magic numbers with sizeof in ssh.c. I don't believe this is going to startle any of the protocols PuTTY talks. check-in: 1a39e619f8 user: jacob tags: trunk
2002-09-11
12:30
Updated usage messages for command-line utilities to reflect new options. Updated manual to reflect reality (e.g. usage messages, '-p port' not actually implemented, sprinkle references to '-i keyfile'). (I've put "Release 0.53" in the messages; let's hope this doesn't cause a flood of "where is 0.53?" email.) I don't guarantee that the result is entirely sane and sensible in all respects, but it is at least consistent. check-in: 8165c812b8 user: jacob tags: trunk
2002-09-10
07:30
Note about separate client-server and server-client encryption in SSH-2 check-in: c753f62b98 user: jacob tags: trunk
2002-09-08
08:28
Introduce the Bugs control panel, for overriding PuTTY's server version number checks to determine the presence or absence of server bugs. check-in: 748d581331 user: simon tags: trunk
08:25
Update to reflect the last batch of proxy stuff we got from Justin Bradford. check-in: 9d618c33f1 user: jacob tags: trunk
2002-09-07
07:27
Increase length limit on SSH1_MSG_DEBUG; 70 chars is short enough to lose vital information in some existing servers' messages. check-in: d6aae5e38d user: simon tags: trunk
2002-09-02
08:47
After trying a succession of tests on Jacob's machine, I think I've finally isolated the _important_ difference between Romano Trampus's working printing.c and my failing one: he ignores the error return from the first exploratory how-big-does-my-buffer-need-to-be call to EnumPrinters(), because not having enough buffer space counts as an error condition. Hence I am officially a klutz, but this should now work. (Also reverted ENUM_LEVEL to 1, again, because that seems to be the choice of people whose code works.) check-in: 61ff40d80b user: simon tags: trunk
08:04
Mention PocketPC in the WinCE question. I'm not sure how similar WinCE and PocketPC are, though -- perhaps it merits its own question. (Although I don't know of anyone who's looked into it yet.) check-in: fbf45efbb9 user: jacob tags: trunk
2002-09-01
08:12
I'm rapidly running out of patience for trying all possible combinations of options to EnumPrinters() to see which one works, but here's another one tried at random for now. *sigh* check-in: 0680fdc776 user: simon tags: trunk
2002-08-18
04:27
Add BUG_SSH2_DERIVEKEY, present (according to OpenSSH) in ssh.com versions 2.0.*, and causing the shared secret not to be included in key derivation hashes. (This doesn't quite cause a blatant security hole because the session ID - _derived_ from the shared secret - is still included.) check-in: 3926a303ff user: simon tags: trunk
04:10
In SSH2, if decrypting the packet length gave us a negative value, subsequent packet-receiver code would fail to notice anything was wrong and segfault. Since this is clearly a silly packet length anyway, we now explicitly reject it as a daft encryption error. check-in: c4a931b9c1 user: simon tags: trunk
2002-08-15
09:59
Changed wording of OpenSSH vs bad OpenSSL FAQ so that it's more obvious it applies to 3.4p1. check-in: e3ca79cb06 user: jacob tags: trunk
2002-08-12
09:08
Alter the Feedback page, so that instead of saying `at some point we plan to start blocking executable attachments' it now says we _do_ block executable attachments. :-) check-in: a941cdf400 user: simon tags: trunk
2002-08-11
08:02
Final fixes to keyboard-interactive so it now works with packets containing more than one prompt instead of less than one, and also correctly enables echo on prompts that the server requests it for. In the process I've moved the whole username/password input routine out into its own function, where it's called independently of which SSH protocol we're using, so this should even have _saved_ code size. Rock! check-in: 24d0aa25e9 user: simon tags: trunk
07:17
Anecdotal evidence suggests that a single EnumPrinters() call specifying both PRINTER_ENUM_LOCAL and PRINTER_ENUM_CONNECTIONS catches more printers in some circumstances than two EnumPrinters() calls each specifying just one of them. We'll try it for a bit; if it goes wrong I might have to put back the two original calls as well and sort out some means of removing duplicate printers from the list. check-in: 928ce21464 user: simon tags: trunk
2002-08-09
04:14
Actually, VirtualLock() looks better as \cw{} not \c{}. check-in: c30968c54c user: simon tags: trunk
04:11
Add two more FAQs: `why don't you use VirtualLock()' and `are you based on OpenSSH'. check-in: 9d65ceabbf user: simon tags: trunk
2002-08-08
12:03
ssh.com 3.2.0 uses zlib sync flush (start and close an empty uncompressed block at the end of each compressed packet) which we were embarrassingly unable to deal with because we assumed every uncompressed block contained at least one byte. Particularly silly because I _knew_ about the existence of sync flush when I coded this module. Arrgh. Still, now fixed. check-in: 826438c7fa user: simon tags: trunk
2002-08-07
14:20
Document all the new command-line stuff. check-in: 57c582a771 user: simon tags: trunk
14:09
Arrgh, we can't have -p for port number because we're already using it for preserving file attributes in PSCP! Ah well; looks as if that's one where we'll have to agree to differ with OpenSSH. check-in: 7e90e87344 user: simon tags: trunk
13:43
Some of the new options shouldn't be available in the file transfer tools. check-in: df30dee415 user: simon tags: trunk
13:08
Fix Halibut syntax error (oops). check-in: 68b76f620a user: simon tags: trunk
12:57
Oops. Didn't quite get the new SSH protocol selection code right. *blush* check-in: d5f0c03954 user: simon tags: trunk
12:55
Add a load of new command-line options pilfered from OpenSSH. Full list is: -A, -a, -X, -x, -T, -t, -C, -1, -2, -i keyfile. check-in: 3dc74c6868 user: simon tags: trunk
12:48
Add an option to force SSH1 protocol only. Partly for symmetry; mostly because I'm about to want it for the -1 command line option. check-in: a87a66409f user: simon tags: trunk
12:29
Clean up the argv splitter, and in particular stop it from bombing out ignominiously when given no arguments :-) check-in: 2b9d1f1799 user: simon tags: trunk
2002-08-06
12:57
Pageant's command line handling now uses my new split_into_argv() function, because it's silly to have two (and because the old one was not the same as the new one, violating the Principle of Least Surprise). check-in: 40423b941a user: simon tags: trunk
12:48
PuTTYgen will now start by loading a private key file if one is provided on its command line. check-in: c3af1e66ed user: simon tags: trunk
12:35
Oops. That is to say, only loading and saving of PuTTY private keys should default to .PPK - loading and saving of public keys and of foreign key formats still defaults to All Files. Ahem. check-in: 67bb09d557 user: simon tags: trunk
12:27
Now that we've decided on a file extension for private key files (.PPK), make it the default in all the private-key file dialogs. check-in: d49eafa9b5 user: simon tags: trunk
2002-08-05
05:35
Buttress is now Halibut: change the docs makefile. check-in: d58645e39d user: simon tags: trunk
05:35
Make it clear that we're only responsible for our own web site, and people should contact mirror admins for problems with mirrors. check-in: e27f739511 user: simon tags: trunk
2002-08-04
16:18
Revamp of command-line handling. Most command line options should now be processed in cmdline.c, which is called from all utilities (well, not Pageant or PuTTYgen). This should mean we get to standardise almost all options across almost all tools. Also one major change: `-load' is now the preferred option for loading a saved session in PuTTY proper. `@session' still works but is deprecated. check-in: 6e2207da2f user: simon tags: trunk
2002-08-03
11:22
Fix culpable lack of generality in keyboard-interactive authentication: a k-i request packet can contain any number of auth prompts (including zero!) and we must ask the user all of them and send back a packet containing the same number of responses. FreeBSD systems were sending a zero-prompts packet which was crashing us; this now appears fixed (we correctly return a zero-responses packet) but I haven't tested a multiple-prompts packet because I can't immediately think of a server that generates them. check-in: 2678a20dff user: simon tags: trunk
2002-07-09
06:34
OpenSSH/OpenSSL versioning problems: as of 3.4p1 this is _still_ not entirely fixed. check-in: 5dda0cf55f user: jacob tags: trunk
2002-06-25
13:51
Forgot to call fxp_init() in `pscp -ls' mode under SFTP. check-in: bb04719c42 user: simon tags: trunk
2002-06-17
11:45
Failure to initialise a local variable was leading to free(garbage) on loading an OpenSSH key and getting the wrong passphrase. check-in: 3eeccc764c user: simon tags: trunk
2002-06-15
11:52
One of the recent port forwarding crash reports contained details which suggested bufchain_prefix() was finding an improperly initialised bufchain structure. Looking at the code, this may indeed have been able to happen, since the bufchain in a SOCKDATA_DORMANT channel was not initialised until CHANNEL_OPEN_CONFIRMATION was received. This seems utterly daft, so I now call bufchain_init() when the channel structure is actually created. With any luck the crash will mystically disappear now (I wasn't able to reproduce it myself). check-in: 6e2c2cce2c user: simon tags: trunk
11:31
Padding on the end of the encrypted data in OpenSSH key format was broken: the OpenSSL EVP layer specifies a very particular form of padding, which I wasn't generating because it hadn't occurred to me that it might be mandatory. Irritatingly this was causing our exported OpenSSH keys to load perfectly happily back in through our OpenSSH import routines, but to be rejected by OpenSSH proper. Sigh. check-in: 6623e565a3 user: simon tags: trunk
10:37
Small memory allocation bug in openssh_encrypted() fixed. check-in: 463604eca5 user: simon tags: trunk
2002-06-08
04:00
Modify the Feedback page / Appendix B to expand the section about not sending us large attachments, and in particular remove the emphasis on screen shots in the hope of also decreasing the number of _other_ large attachments we get. check-in: 712fdd4664 user: simon tags: trunk
2002-05-31
12:39
Workaround for the SSH2 RSA padding bug in OpenSSH 2.5 - 3.2 inclusive. Padding is accomplished by rewriting the signature blob rather than at the point of generation, in order to avoid having to move part of the workaround into Pageant (and having to corrupt the agent wire protocol to allow PuTTY to specify whether it wants its signatures padded!). check-in: 7a4afe7b5e user: simon tags: trunk
2002-05-30
07:41
Fix AltGr/Application/Compose/CtrlAlt discrepancies introduced in windlg.c rev 1.118 [r1033] (pointed out by Rob Pitman). check-in: de3aa67d0b user: jacob tags: trunk
2002-05-23
17:02
Trying to use an SSH2 key with an SSH1 connection seems to be quite common, so I've added a FAQ. check-in: 7572c5d251 user: jacob tags: trunk
2002-05-22
16:18
Note that answerback string can contain control characters with ^C notation, and the ^~ escape, but don't go into the gory details. check-in: a8fffb9835 user: jacob tags: trunk
2002-05-18
04:20
UI changes for key imports. We now have a separate Load command and Import command; the former warns you if you load a foreign key, whereas the latter doesn't. So the user should always be aware, one way or the other, that a format conversion is taking place. check-in: 2cf1ef8dbd user: simon tags: trunk
2002-05-17
07:33
ieof-for-nonexistent-channel problem: avoid comparing an unsigned with -1 check-in: 9832c81afd user: simon tags: trunk
2002-05-16
17:36
Nit: PuTTYgen can generate RSA _and DSA_ keys check-in: 7dd851e21a user: jacob tags: trunk
2002-05-15
15:07
Final cleanups on key import/export work. Rationalised the UI (so that menu options are greyed out helpfully) and added documentation. check-in: 08285efb5d user: simon tags: trunk
14:16
Added export of ssh.com key files. check-in: c1a44eb091 user: simon tags: trunk
2002-05-14
13:11
Implemented export of OpenSSH keys. check-in: d43d5163af user: simon tags: trunk
2002-05-13
11:56
Add some basic framework code preparatory to adding key export. check-in: 43c3b91680 user: simon tags: trunk
11:48
Update FAQ to mention ssh.com key importing check-in: 0d41be3d2e user: simon tags: trunk
11:37
Be more careful about destroying sensitive data after private key load/store/import operations. check-in: fbb61c5a99 user: simon tags: trunk
11:32
Add import of ssh.com private keys. check-in: e22787ee8c user: simon tags: trunk
2002-05-11
11:45
Added a framework for importing foreign key formats, and implemented importing of OpenSSH SSH2 private key files (both encrypted and unencrypted). Seems to work fine. check-in: b7502058f0 user: simon tags: trunk
08:12
Remove tiny unnecessary faff in new SSH-2-only code check-in: afee84cb9a user: simon tags: trunk
08:08
SSH2 only support check-in: 9cc8742e75 user: owen tags: trunk
08:03
Added SSH2 only support. check-in: 9f710e4c31 user: owen tags: trunk
07:13
Improved error messages if you use the wrong key type: you should now be told that the key is the wrong type, _and_ what type it is, rather than being given a blanket `unable to read key file' message. check-in: 9f93ab88b5 user: simon tags: trunk
2002-04-27
11:30
Removed the old Visual C++ master makefile, since it has now been superseded by the new Recipe / mkfiles.pl mechanism. check-in: 8003f4c3f0 user: simon tags: trunk
11:20
Additions to the Feedback page to emphasise that we can't answer all our mail any more, and to encourage support questions to be sent elsewhere as a first resort. check-in: d58918be8c user: simon tags: trunk
10:01
SOCKS proxy support added (next instalment of Justin Bradford's proxy work). SOCKS 5 username/password authentication still unsupported. check-in: 12982b75cc user: simon tags: trunk
2002-04-18
17:23
Added comments to document '-gui' Windows messages, based on putty-bugs post <E14g2ty-0008WN-00@ixion.tartarus.org> (except for Ryan Finnie's extra messages). check-in: 1f3fc1c1eb user: jacob tags: trunk
15:45
Added documentation of PuTTY command-line options (derived from the source) check-in: 852da43114 user: jacob tags: trunk
2002-04-10
14:54
The SFTP form of PSCP should remember to send FXP_INIT! Oops. check-in: 4868a1912f user: simon tags: trunk
2002-04-03
12:24
Mention that numeric code pages can be entered manually in the Translation box. check-in: 871adbb898 user: simon tags: trunk
2002-04-01
09:18
Add a couple of extra FAQ entries. check-in: 645db2c88e user: simon tags: trunk
2002-03-31
10:28
The console version of askappend() completely forgot to check cfg.logxfovr to see whether the user had already specified what should happen to log files. Fixed. check-in: 7a188749df user: simon tags: trunk
10:26
Fix major memory leak in sftp_cmd_ls (thanks to Hans-Juergen Petrich for pointing it out). check-in: d8cae6eb26 user: simon tags: trunk