Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
382 check-ins using file sshrsa.c version 7cfdb8212c
|
2007-04-30
| ||
| 15:09 | Create installations directories before installing into them, like GNU packages do. Problem reported by Manfred Pausch. check-in: e44d7df824 user: ben tags: trunk | |
|
2007-04-29
| ||
| 06:28 | Update version numbers for 0.60 release. check-in: 7614cbc865 user: simon tags: trunk | |
|
2007-04-22
| ||
| 09:39 | Avoid creating the Session/hostport control set in mid-session. check-in: ea6f078243 user: simon tags: trunk | |
| 03:56 | Capitalisation error. check-in: a43692e9ff user: simon tags: trunk | |
|
2007-04-10
| ||
| 16:46 | When we get an error writing to a local file, stop the download rather than pretending we just got -1 bytes. Not actually tested, but it looks pretty obvious. Bug reported by dking wang. check-in: 3af8c37407 user: ben tags: trunk | |
|
2007-04-02
| ||
| 03:44 | When the comments say `if we're in restart mode', the code in question should actually be conditional on restart mode! check-in: 1efe703050 user: simon tags: trunk | |
|
2007-03-27
| ||
| 14:10 | In the wake of r7415, let's have some better error reporting. Instead of passing -1 to its gotdata and sentdata callbacks on error, winhandl.c will now pass the negation of the Windows error number; and the Plink front end will now format that into an error message and pass it on to the user. check-in: 9fe9b33c47 user: simon tags: trunk | |
| 13:49 | Windows apparently sends ERROR_BROKEN_PIPE when a pipe we're reading from is closed normally from the writing end. This is ludicrous; if that situation isn't a natural EOF, _nothing_ is. So if we get that particular error, we pretend it's EOF. check-in: 293169b60e user: simon tags: trunk | |
| 13:16 | Patch from John Sullivan: process double-clicks in the session list box on button-up rather than button-down. The effect of this is that if a saved session is already selected in the list box and then you double-click it, it will open rather than beeping annoyingly. check-in: 7d216c3d83 user: simon tags: trunk | |
|
2007-03-19
| ||
| 07:05 | Fix a stupid one-character typo that was breaking 256-colour support on GTK. check-in: ee598e12ce user: ben tags: trunk | |
|
2007-03-13
| ||
| 09:43 | get_random_data() can return NULL (for instance, if we can't open /dev/random on Unix), yet cmdgen failed to deal with this. Spotted by Darren Tucker. check-in: 39d27e9f1d user: jacob tags: trunk | |
|
2007-02-28
| ||
| 17:31 | Process -t/-T later than -m, so that they can override -m's default behaviour of no pty. check-in: 6ecbbc4f02 user: jacob tags: trunk | |
| 15:30 | Prepend \\.\ to configured serial line string, to allow easy access to ports above COM9. check-in: 5260ceae34 user: jacob tags: trunk | |
|
2007-02-24
| ||
| 20:15 | Attempt to scrub -pw's argument in argv[], to make it less obvious. check-in: 20aafd8d77 user: jacob tags: trunk | |
| 18:51 | Delay evaluating the "-pw" option, so we can criticise the user's choice of backend, bailing out if anything other than SSH is in use. check-in: c4c12aecc8 user: jacob tags: trunk | |
| 18:50 | Since r7265, a user could not launch a PuTTY session to a specific host by simply specifying a hostname on the command line -- this would bring up the config dialog. Use a slightly more sophisticated notion of whether the user meant to launch a session. check-in: 3be54b7561 user: jacob tags: trunk | |
| 16:43 | "-noagent" and friends should be marked SAVEABLE, to ensure they're not clobbered by "-load". check-in: e7311276ec user: jacob tags: trunk | |
| 07:36 | Gareth pointed out yesterday that the Unix terminal front end treats BELL_DISABLED as BELL_DEFAULT. How embarrassing. check-in: 3e3c1216c5 user: simon tags: trunk | |
|
2007-02-18
| ||
| 16:05 | This reordering of the Unix Makefiles (requested by Michael Shigorin) allows use of -Wl,--as-needed. check-in: fee4847de2 user: jacob tags: trunk | |
| 13:56 | In controls where a list of entries is manipulated by Add/Remove buttons (SSH tunnels, TTY modes, and environment variables), when the Remove button is pressed, populate the edit controls from the entry that has just been deleted. Several users have requested this, as it makes editing an entry easier (read- modify-write) in the cases where order is unimportant, and also provides a degree of undo-ability. check-in: 847b1e85da user: jacob tags: trunk | |
| 13:50 | Allow dlg_listbox_index() to be called on multi-selection list boxes. check-in: 375dedc432 user: jacob tags: trunk | |
| 09:59 | Bring the OS X front end up to date with recent changes to the main code base. check-in: 2798a724a2 user: simon tags: trunk | |
| 08:02 | Ctrl-Break now sends a Break signal (previously it was equivalent to Ctrl-C). check-in: 65285954f0 user: jacob tags: trunk | |
|
2007-02-17
| ||
| 16:33 | Use preprocessor trickery to make the signal translation mechanism a little less hideous. The output of the preprocessor should be basically unchanged. check-in: 491721f229 user: ben tags: trunk | |
| 16:15 | ssh2_set_window checks whether the channel is being closed, so there's no need to check that before calling it. check-in: b91d8b1269 user: ben tags: trunk | |
| 11:44 | Unbreak "Duplicate session" on Windows, in a similar way to r7291. check-in: de46d1c4c8 user: jacob tags: trunk | |
|
2007-02-16
| ||
| 12:44 | r7265 broke the legacy `putty @sessionname' construction, which I wouldn't care about except for the fact that it's still used to implement the Saved Sessions menu item in PuTTY and Pageant. check-in: dc0247bf7b user: simon tags: trunk | |
|
2007-02-15
| ||
| 17:27 | LICENCE in the installer should have CP/M line endings. check-in: 5700f6f2ee user: jacob tags: trunk | |
|
2007-02-13
| ||
| 16:57 | It turns out that HH_INITIALIZE and HH_UNINITIALIZE are optional, and are for putting HTML Help into "single-threaded" mode. Furthermore, this requires extra work from the application (message pumping via HH_PRETRANSLATEMESSAGE). Thus, remove them and run Help in a secondary thread. This means that keyboard input into the Index and Search tabs now works. check-in: c55f4bfb2d user: jacob tags: trunk | |
|
2007-02-11
| ||
| 14:27 | Note that htmlhelp.h from HTML Help Workshop works perfectly well with Cygwin. check-in: 4919a4ebcc user: jacob tags: trunk | |
| 12:13 | chm.but contains $Id$ but didn't have a svn:keywords property. Fixed. check-in: a3b965711e user: jacob tags: trunk | |
| 12:09 | Typo. check-in: 80ed2bac99 user: jacob tags: trunk | |
|
2007-02-10
| ||
| 11:12 | Since we're now able to cope with Default Settings describing a launchable session without getting confused by it, we can relax the restriction on storing a host name in DS, which has attracted a steady stream of complaints over the past six or seven years. check-in: 81d5f6836c user: simon tags: trunk | |
| 11:02 | Avoid launching a session from the Default Settings, even if they do represent a launchable session, unless the user can be construed to have really meant it. This means: - starting up PuTTY when the Default Settings are launchable still brings up the config box, and you have to hit Open to actually launch that session - double-clicking on Default Settings from the config box will load them but not launch them. On the other hand: - explicitly loading the Default Settings on the command line using `-load' _does_ still launch them. check-in: e32793db99 user: simon tags: trunk | |
| 10:38 | More svn:ignores. I'm constantly amazed that I keep not having put in all the useful ones yet! check-in: dee2e1d2b4 user: simon tags: trunk | |
|
2007-02-08
| ||
| 12:53 | I've changed my mind about the PuTTY build script. It now delivers the release directory into a _subdirectory_ of the main build.out, and delivers the link maps and sign.sh alongside it. That simplifies both the nightly snapshot cron job (which now doesn't have to carefully move the maps out of the release directory or go looking in strange places for sign.sh) and my release procedure (for much the same reasons). check-in: 12ec555df0 user: simon tags: trunk | |
| 03:24 | The big payoff from bob (from my POV at least): the PuTTY release procedure is now a huge amount less painful. check-in: 48ac997cd1 user: simon tags: trunk | |
|
2007-02-06
| ||
| 16:39 | `installer.ico' doesn't fit into 8.3, so gets truncated to INSTALLE.ICO in the Windows source Zips. Rename to `puttyins.ico'. check-in: 0185769107 user: jacob tags: trunk | |
| 07:57 | When emitting SSH_MSG_IGNORE to protect against known-IV attacks on CBC, remember to put an empty string in it rather than sending a completely empty packet. This should help with those servers (notably RomSShell) that actually check the contents of SSH_MSG_IGNORE. check-in: bcc614254b user: ben tags: trunk | |
|
2007-02-05
| ||
| 14:14 | Ahem; other half of r7232... check-in: 6f2b9734d1 user: simon tags: trunk | |
| 14:04 | When calling TIOCSCTTY, it helps to pass it an fd that's still open, instead of one we closed two lines earlier. I apparently broke this in r7107. check-in: 4b39592852 user: simon tags: trunk | |
| 12:07 | Avoid passing modified SVN revision numbers (of the form 1234M) to parts of the versioning code which might not like them. As a result of this checkin, bob builds from modified SVN working copies will still announce themselves as revision nnnnM in the textual version strings, but their binary version in the Windows VERSIONINFO will now be 0.0.0.0. check-in: 0d6ba4a6e7 user: simon tags: trunk | |
| 09:01 | Fiddle further with .htaccess: add some $s on the ends of the regexps to stop them matching the wrong files. check-in: bf61139205 user: simon tags: trunk | |
| 08:23 | HTTP redirects for the variably-named signatures as well as their base files. (The signatures aren't actually _generated_ by bob, of course, but the redirects are harmless in their absence.) check-in: c4807a3220 user: simon tags: trunk | |
| 07:53 | Script to generate signatures on the various PuTTY build outputs. Saves me having to remember all the fiddly gpg arguments every time. Should be usable for both releases (with manual passphrase input) and snapshots (run automatically). check-in: f4a0252883 user: simon tags: trunk | |
| 06:49 | Fixes for snapshot building using bob. All of releases, snapshots and custom svn builds should now have appropriately named Unix source archives and installer binaries, plus .htaccess files providing redirects to them from totally standard filenames. I _think_ this now makes it feasible to switch the nightly builds to using bob. check-in: 4b5a9a3433 user: simon tags: trunk | |
| 02:02 | Be slightly more forgiving about the nature of SVN_REV; bob will be reliable at defining it, and it's useful to be able to pass `1234M'- type revisions in for testing purposes. check-in: 02d1e62321 user: simon tags: trunk | |
| 02:02 | Fix errors in $(Makeargs) which only occur when building development snapshots. check-in: c1d4b20b6e user: simon tags: trunk | |
|
2007-02-04
| ||
| 06:37 | PuTTY builds should save the map files. check-in: 1f0939b35e user: simon tags: trunk | |
| 06:30 | Version management updates for the new bob build script. There's now a fourth class of PuTTY version tags in addition to release, snapshot and unidentified: we now have `Custom build r1234', indicating a build made from that SVN revision in a context other than that of a dated snapshot. The build script generates these when it doesn't know what else to do; `unidentified builds' will now only occur when you run nmake from the command line. Also, the build script now generates sensible version data in the installer to match this. So I _think_ we should now be set to use bob to generate installer builds of the nightly snapshots, although of course I'll have to wait until tomorrow to test one. check-in: d9fefbf9f7 user: simon tags: trunk | |
| 06:12 | Document \\.\COM10 faff on Windows. References: <http://msdn2.microsoft.com/en-us/library/aa363858.aspx> (CreateFile() docs) describes the use of \\.\ <http://msdn2.microsoft.com/en-us/library/aa365247.aspx> ("Naming a File") lists the reserved filenames (COM1-COM9, LPT1-LPT9, CON, PRN, AUX, NUL) check-in: af7f556843 user: jacob tags: trunk | |
| 05:17 | Build script for PuTTY using bob. check-in: ff6b0c11d2 user: simon tags: trunk | |
|
2007-02-01
| ||
| 17:24 | Swap order of `Columns' and `Rows' in the config dialog, to make it consistent with sizetip.c (and more nebulous conventions). check-in: 64d5560d28 user: jacob tags: trunk | |
|
2007-01-31
| ||
| 06:30 | Colin Watson has fixed the disgusting icons on GTK1. His patch appears to merely fix the background colour (arranging for it to have transparency rather than being on some kind of default grey background), but it turns out to also fix the strange blurry behaviour I see in the GNOME Taskbar, for no very obvious reason. check-in: 11d422587d user: simon tags: trunk | |
|
2007-01-29
| ||
| 14:10 | In the cases where Setup asks to restart the computer, explain exactly why this is deemed necessary. check-in: 91c9da859e user: jacob tags: trunk | |
|
2007-01-26
| ||
| 13:43 | Switch round the order of CFLAGS and XFLAGS, so that the latter comes last on the compiler command line. This makes it easier to override the normal compile options (since conflicting command-line options usually follow a last-wins policy) in order to compile (for example) the Unix version -g -O0. check-in: 91bd9df8ab user: simon tags: trunk | |
| 08:11 | If I'd tested under Minefield before releasing, r7168 would have been committed before the release. Therefore, stick it on the checklist for next time. check-in: 221d1e2668 user: simon tags: trunk | |
| 08:06 | Kai Jourdan spotted a rather embarrassing double-free, and Minefield confirms that it's a real problem. check-in: be198c9138 user: simon tags: trunk | |
|
2007-01-24
| ||
| 18:14 | We may as well update the website icon to match the other new ones. check-in: 203b64aae3 user: jacob tags: trunk | |
| 15:43 | Post-release corrections to the checklist. check-in: c19f8fb422 user: simon tags: trunk | |
| 14:16 | Version number bumps, and associated changes, for the 0.59 release. check-in: c8cb2b479e user: simon tags: trunk | |
| 14:00 | Add .CHM to the ignore property. check-in: 2e1552cab6 user: simon tags: trunk | |
| 07:53 | The direct link between the terminal and the back end via term_provide_resize_fn() was not being broken when the back end was destroyed on session termination, causing resizing an inactive PuTTY to be a segfault hazard. check-in: f75921a917 user: simon tags: trunk | |
| 05:20 | faq-xpwontrun wants tweaking before the next release. check-in: 065773ed3e user: jacob tags: trunk | |
|
2007-01-23
| ||
| 08:12 | Mention XXX-REVIEW-BEFORE-RELEASE in the same place as XXX-REMOVE-BEFORE-RELEASE. check-in: 016bfdfedc user: jacob tags: trunk | |
| 05:38 | Mention the potential networked-CHM problem in the post-installer README. check-in: 84823feae7 user: simon tags: trunk | |
| 05:15 | Checklist updates for the upcoming release, mostly to do with the retirement of the Alpha build. check-in: e159ee7b68 user: simon tags: trunk | |
|
2007-01-22
| ||
| 12:02 | Add an icon for the PuTTY installer. Design concept (and noticing that Inno Setup had an option to specify an icon) by Jacob; detailed artwork and translation into Python by me. check-in: e5e89377a0 user: simon tags: trunk | |
| 08:04 | Improve error reporting. check-in: 7e73cf761a user: simon tags: trunk | |
|
2007-01-21
| ||
| 17:34 | Fix several bugs that stopped %proxyport from doing anything useful. check-in: 7ea0580824 user: jacob tags: trunk | |
| 17:34 | Fix Plink, the serial backend, and local-proxy support on Win98SE (at least), which have been broken since r6797. (At least some versions of Win9x are gratuitously picky about the arguments to CreateThread(), requiring lpThreadId not to be NULL.) check-in: 803dd5a810 user: jacob tags: trunk | |
|
2007-01-20
| ||
| 14:05 | Fix compiles on GCC 3.3, which doesn't know about assert(0); check-in: fe98cc1cc0 user: ben tags: trunk | |
| 10:14 | Mention more versions of Windows. (Not Vista, yet.) check-in: 869a65387f user: jacob tags: trunk | |
| 08:13 | Don't use C99 mid-block declarations and don't do arithmetic on void *. This helps with compilations on ancient Sun compilers. check-in: cb66fce8a1 user: ben tags: trunk | |
|
2007-01-19
| ||
| 08:33 | Move README.txt into windows subdir. It's specific to the Windows installer, so it seems unnecessarily confusing to have it in the top level of the source distribution alongside README. check-in: 1e87ebdb85 user: jacob tags: trunk | |
|
2007-01-17
| ||
| 12:38 | Flag user cancellation of authentication as a clean exit, so that it will close the window even in `close window only on clean exit' mode. Also, while I'm here, arrange a suitable exit code for "exit-signal". check-in: b95f1de6c0 user: simon tags: trunk | |
|
2007-01-16
| ||
| 15:32 | Update WINVER to 0x500 to avoid build failures from Jacob's FlashWindow changes. Also fiddle with the <multimon.h> include, which was subtly broken in turn by that. check-in: 93485461a3 user: simon tags: trunk | |
| 14:54 | At least, I have the technology to fix `beepind-win2k'. Tested on Win98, Win2K, and WinXP. check-in: d34719e103 user: jacob tags: trunk | |
| 13:26 | Add more ifdefs to make uxser.c compile on OS X. check-in: 194a6ad085 user: simon tags: trunk | |
| 12:48 | Fold up the `SSH' branch of the treeview by default; it's getting quite big and tends to hide the existence of the `Serial' config panel. This is implemented by folding up every branch of depth 2 or more, which with any luck might turn out to be general enough to carry over unchanged if other branches start expanding. Then again, we may have to fiddle with it again when that time comes; who knows? check-in: 0a82529a8f user: simon tags: trunk | |
|
2007-01-14
| ||
| 15:50 | I've just realised that the data-logging options only work in PuTTY proper. Document this. check-in: 7eaf06be84 user: jacob tags: trunk | |
| 07:44 | Remove the loops that close all open fds before running a subprocess. They were intended to make sure the child process didn't inherit anything embarrassing or inconvenient from us, such as the master end of its own pty, but now we instead do this by making sure to set all our own fds to not-FD_CLOEXEC on creation. This should fix Debian bug #357520. (This doesn't seem to work _quite_ right in uxproxy.c's invocation of a local proxy command: both ends of a GTK internal pipe end up in the child process's fd space. This appears to be another GTK 1 bug, inasmuch as it goes away when I build with Colin's preliminary GTK 2 patch; for the moment I think leaving that pipe lying around is probably less harmful than hampering the proxy process's ability to use extra fds by prior arrangement with PuTTY's parent process.) check-in: 5efc5c6876 user: simon tags: trunk | |
|
2007-01-12
| ||
| 17:35 | Experimental fix for `psftp-hang'. (Experimental only in that I haven't thought about it very hard; it's a plausible fix for the observed cause of the extreme CPU usage, being that we were asking to be notified of Windows messages and then not dealing with them, plausibly leading to a loop. Works for me, anyway.) check-in: 03548c6c2e user: jacob tags: trunk | |
| 14:00 | Remove redundant sentence. check-in: ed59f62f69 user: jacob tags: trunk | |
|
2007-01-09
| ||
| 18:54 | Miscellaneous updates. check-in: 3f94e0a489 user: jacob tags: trunk | |
| 18:46 | According to Frank Dijcks, this cast makes OpenWatcom happier. check-in: 75ed054d54 user: jacob tags: trunk | |
| 18:16 | Various SSH-related things were appearing in the PuTTYtel configuration dialog, probably since the addition of the serial backend. Use a more robust check for SSH support. check-in: b777e07a90 user: jacob tags: trunk | |
| 17:47 | MinGW needs an extra symbol _WIN32_IE defined to a particular value before it'll let you see an identifier (SHGFP_TYPE_CURRENT) referenced since r7082. (Actually, you need a pretty recent w32api before it's there at all.) Morally, this should be defined for all toolchains, not just MinGW/Cygwin, but I'll leave that to people who have those toolchains. <http://msdn2.microsoft.com/en-us/library/aa383745.aspx> Also add some other comments on our use of this API (since it's a horrible one that I suspect will come back and haunt us...) check-in: 01620f18e2 user: jacob tags: trunk | |
| 12:24 | Get rid of all the MSVC warnings. check-in: 1ef7a9aa1d user: simon tags: trunk | |
| 12:14 | Fix `puttygen-unix-perms': f_open(), PuTTY's wrapper on fopen, now takes a third argument which is TRUE if the file is being opened for writing and wants to be created in such a way that it's readable only to the owner. This is used when saving private keys. While I'm here, I also use this option when writing session logs, on the general principle that they probably contain _something_ sensitive. The new argument is only supported on Unix, for the moment. (I think writing owner-accessible-only files is the default on Windows.) check-in: 24342cc035 user: simon tags: trunk | |
| 12:05 | Fix `win-randseed-location': use SHGetFolderPath() to find the Application Data directory in preference to the old-fashioned attempt to find the user's home directory, and use the _local- machine_ Application Data directory in preference even to that. SHGetFolderPath() is called via GetProcAddress, so this degrades gracefully on old Windowses. (Tested myself on Win95.) As part of this change, we now search for a location for the seed file separately for reading and writing, so that installing the new PuTTY should cause a seamless migration as the old seed file is read from the old location and then a new one written to the new location. `putty -cleanup' attempts to delete the seed file from _all_ affected locations. Naturally, a user-specified seed file path in the Registry still takes priority over all other means of finding the location. check-in: 3d5197d71a user: simon tags: trunk | |
|
2007-01-08
| ||
| 13:38 | The remaining issue in `win-askappend-multi' appears to have been caused by the MessageBox() internal message loop eating WinSock FD_READ notifications, which then don't reappear afterwards because you have to explicitly prod a socket in order to get a repeat notification on it. Hence, here's a piece of infrastructure which seems to sort it out: a new winnet.c function called socket_reselect_all(), whose function is to go through all currently active sockets and re-run WSAAsyncSelect() on them, causing repeat notifications for anything we might have missed. I call this after every call to MessageBox(), and that seems to solve the problem. (The problem was actually masked in very recent revisions, probably by the reinstatement of pending_netevent in r7071. However, I don't believe that was a complete fix. This should be.) check-in: b73205c7e6 user: simon tags: trunk | |
| 12:54 | Have one call to from_backend() per call to do_telnet_read(), instead of the previous rate of one per character. In `Flush log file frequently' mode, the latter was causing excessive slowdown due to fflush()ing once per byte. check-in: fb422327bb user: simon tags: trunk | |
|
2007-01-07
| ||
| 08:30 | Fix ssh2-cisco-pw-pad by reverting r5122. However, I've kept the ability to easily re-enable the r5122 behaviour, in case we need to conditionally switch between the two at a later date. check-in: a5397b1479 user: simon tags: trunk | |
| 08:20 | Greater leniency when importing private key files: accept both CRLF and LF, and don't object if the final line of the key lacks a newline. Also, while I'm here, switch to using fgetline() throughout so as not to have to do nasty buffer-size ad-hockery. check-in: 88c81664c7 user: simon tags: trunk | |
| 06:40 | Reinstate RDB's pending_netevent mechanism, which was removed in r4906 in the process of adding the new timing code. It seems to have been what was previously preventing spew-lockup, and still seems to prevent it now I've put it back in. check-in: 5abeff92fa user: simon tags: trunk | |
| 04:17 | Tweak the icon script, and the generated icons, to more closely match the original icons. (Apparently I managed to introduce errors while transcribing the originals for detailed analysis.) While I'm at it, add the obviously useful `make install' target in icons/Makefile, and fix the svn:ignore property on the icons directory. check-in: ca7615f72f user: simon tags: trunk | |
|
2007-01-06
| ||
| 14:01 | I think this change to Recipe was accidentally omitted from r7064. check-in: 5eb27bf21e user: jacob tags: trunk | |
| 12:27 | No, I tell a lie: GTK 1 _does_ support icons, at least partially. Ooh. check-in: c1ecd0cf4d user: simon tags: trunk | |
| 12:15 | Shiny new script which constructs the various icons for the PuTTY suite. In a dramatic break with tradition, I'm actually checking in the resulting icon files as well as the script that generates them, because the script requires Python and ImageMagick and I don't think it's reasonable to require that much extra infrastructure on everyone checking out from Subversion. The new icons should be _almost_ indistinguishable from the old ones, at least at the 32x32 resolution. The immediately visible change is that all the icons now come in 16x16, 32x32 and 48x48 formats, in both 16 colours and monochrome, instead of an ad-hoc mixture of whichever ones I could be bothered to draw. The same code can also be adapted to generate icons for the GTK port (although icons for the running programs don't seem to be supported by GTK 1 - another reason to upgrade to GTK 2!). check-in: 18b8e361e6 user: simon tags: trunk | |
|
2007-01-05
| ||
| 12:43 | Francois L'Archeveque spotted that the variable `winsock2_module' only exists when compiling for IPv6, so we shouldn't try assigning to it the rest of the time. check-in: a08780c4f7 user: simon tags: trunk | |
|
2007-01-01
| ||
| 15:19 | It's a new year. check-in: de6aa71b1f user: jacob tags: trunk | |
|
2006-12-31
| ||
| 09:33 | Patch inspired by one from Daniel Silverstone in Debian bug #229232: We now have an option where a remote window title query returns a well-formed response containing the empty string. This should keep stop any server-side application that was expecting a response from hanging, while not permitting the response to be influenced by an attacker. We also retain the ability to stay schtum. The existing checkbox has thus grown into a set of radio buttons. I've changed the default to the "empty string" response, even in the backward- compatibility mode of loading old settings, which is a change in behaviour; any users who want the old behaviour back will have to explicitly select it. I think this is probably the Right Thing. (The only drawback I can think of is that an attacker could still potentially use the relevant fixed strings for mischief, but we already have other, similar reports.) check-in: 793e619dd8 user: jacob tags: trunk | |
|
2006-12-30
| ||
| 17:00 | Patch from Colin Watson intended to give a clean Unix compile with GCC 4. (Since we choose to compile with -Werror, this is particularly important.) I haven't yet checked that the resulting source actually compiles cleanly with GCC 4, hence not marking `gcc4-warnings' as fixed just yet. check-in: ef14243dce user: jacob tags: trunk | |
|
2006-12-29
| ||
| 10:38 | Use va_copy() where available. This should fix a segfault in vsnprintf() on AMD 64 Linux. (This has been sitting in my checkout for ages and hasn't obviously caused any trouble -- I think I was waiting to get round to trying it with VC6, which I haven't yet. There are some notes in comments on further tweaks that could be made.) check-in: f420fa4505 user: jacob tags: trunk | |
| 08:35 | Colin Watson points out that there was no need for me to write the custom Panels container widget for the PuTTY config box, since the perfectly standard GtkNotebook does the same job. Hence, let's remove Panels completely in favour of doing it the proper way. check-in: 6231db6b35 user: simon tags: trunk | |
|
2006-12-28
| ||
| 14:56 | Add a NO_HTMLHELP option, and enable it by default in the Cygwin Makefile, since even the latest version of w32api (3.6) shows no sign of HTMLHelp support. (This touches mkfiles.pl because that's where the details of what Cygwin doesn't support are kept currently. This may be deliberate, so I haven't changed it.) check-in: fed7b51bdd user: jacob tags: trunk | |
| 09:47 | I'm not sure why I added htmlhelp.lib to the PuTTY link lines in r7000. I was probably half asleep. Actually, it's completely unnecessary to bind to it at link time, because we load it at run time in order to continue working as before on Win95. So I'm removing it again. check-in: 869dac9697 user: simon tags: trunk | |
| 04:39 | Nearly forgot: add the .CHM to the PuTTY installer. This involves making the manual shortcut in the Start menu point to one or other of the two help files depending on the version of Windows; fortunately Inno Setup has no difficulty doing that. check-in: a81b70cd1c user: simon tags: trunk | |
| 04:38 | `make mostlyclean', to remove everything directly Halibut-generated but not the CHM. It'll come in useful during the release process. check-in: 0587b1c08a user: simon tags: trunk | |
|
2006-12-24
| ||
| 10:25 | Add some CHM-related stuff to the release checklist. Don't want to forget about it when the time comes. check-in: 468f29b0f0 user: simon tags: trunk | |
|
2006-12-23
| ||
| 03:04 | After discussion with Jeroen Massar, here's a patch (mostly his) which we think fixes the vista-ipv6 problem. check-in: 7406c4f48d user: simon tags: trunk | |
|
2006-12-19
| ||
| 04:28 | Minor style tweaks for the CHM. check-in: ddecf5104c user: simon tags: trunk | |
|
2006-12-17
| ||
| 11:46 | Sort out line-endings on new file. check-in: 2a01e4927d user: jacob tags: trunk | |
| 05:16 | Initial support for HTML Help. All the ad-hoc help-file finding code and various calls to WinHelp() have been centralised into a new file winhelp.c, which in turn has been modified to detect a .CHM file as well as .HLP and select between them as appropriate. It explicitly tries to load HHCTRL.OCX and use GetProcAddress, meaning that it _should_ still work correctly on pre-HTML-Help platforms, falling gracefully back to WinHelp, but although I tested this by temporarily renaming my own HHCTRL.OCX I haven't yet been able to test it on a real HTML-Help-free platform. Also in this checkin: a new .but file and docs makefile changes to make it convenient to build the sources for a .CHM. As yet, owing to limitations of Halibut's CHM support, I'm not able to write a .CHM directly, more's the pity. check-in: e861af5aa9 user: simon tags: trunk | |
|
2006-12-09
| ||
| 09:44 | Set FD_CLOEXEC in a little convenience function that does the right thing with F_GETFD and F_SETFD. check-in: 7af697811b user: ben tags: trunk | |
|
2006-11-28
| ||
| 15:51 | Correct an embarrassingly wrong comment. check-in: 3c8ea162b2 user: simon tags: trunk | |
|
2006-11-23
| ||
| 08:32 | I've just discovered that using the saved sessions menu from Unix PuTTY causes the child process to inherit a lot of socket fds from its parent, which is a pain if one of them then ends up holding open a listening socket which the parent was using for port forwarding after the parent itself is dead. Therefore, this checkin sprinkles FD_CLOEXEC throughout the Unix platform directory wherever there looks like being a long-lived fd. check-in: 1002c29630 user: simon tags: trunk | |
|
2006-11-18
| ||
| 09:10 | Reinstate as much of the Windows font-linking behaviour as I can easily manage, by adopting a hybrid approach to Unicode text display. The old approach of simply calling ExtTextOutW provided font linking without us having to lift a finger, but didn't do the right thing when it came to bidirectional or Arabic-shaped text. Arabeyes' replacement exact_textout() supported the latter, but turned out to break the former (with no warning from the Windows API documentation, so it's not their fault). So now I've got a second wrapper layer called general_textout(), which splits the input string into substrings based on bidi character class. Any character liable to cause bidi or shaping behaviour if fed straight to ExtTextOutW is instead fed through Arabeyes' exact_textout(), but the rest is fed straight to ExtTextOutW as it used to be. The effect appears to be that font linking is restored for all characters _except_ Arabic and other bidi scripts, which means in particular that we are no longer in a state of regression over 0.57. (0.57 would have done font linking on Arabic as well, but would also have misbidied it, so we've merely exchanged one failure mode for another slightly less harmful one in that situation.) check-in: 76941fa153 user: simon tags: trunk | |
|
2006-11-15
| ||
| 17:42 | Chris Boucher spotted that after "-nc" was added (r6823), cfg->ssh_nc_host was not always initialised, which could lead to spurious attempts to open a bogus channel (typically refused: "FATAL ERROR: Server refused to open a direct-tcpip channel"). Fixed. check-in: 8472f487a9 user: jacob tags: trunk | |
| 17:12 | (Config).remote_cmd2[512] was added in r1208, but it wasn't used then and isn't now, so presumably never has been. Remove. check-in: ba05ea5d22 user: jacob tags: trunk | |
| 06:56 | publickeyfile now an RFC check-in: 81eb81326b user: jacob tags: trunk | |
| 05:48 | Link to faq-cleanup from faq-settings. check-in: 5174b633ca user: jacob tags: trunk | |
|
2006-11-08
| ||
| 15:15 | There's been an increase in people posting non-SSH PuTTY-related questions to comp.security.ssh, posting queries that are clearly about PuTTY to newsgroups without actually mentioning PuTTY, and so on. They may have been directed there by this document :( Add a futile attempt to instil a sense of etiquette. check-in: eac1e0cf0e user: jacob tags: trunk | |
|
2006-11-07
| ||
| 18:55 | Administrivia: most SSH-2 specs are no longer drafts. check-in: a5a1de44c9 user: jacob tags: trunk | |
|
2006-10-31
| ||
| 10:59 | Tiny comment fix. check-in: 2a8b9e487d user: jacob tags: trunk | |
|
2006-10-22
| ||
| 15:19 | Spotted by Tim Kosse: we were returning an incorrect path in canonify() when we couldn't get any sense out of the server. check-in: a809c336dd user: jacob tags: trunk | |
| 14:51 | Minor semantic tweak to bug-compatibility modes: make BUG_NEEDS_SSH1_PLAIN_PASSWORD do exactly what it says on the tin, independent of whether BUG_CHOKES_ON_SSH1_IGNORE is set. This is invisible in the default configuration, as all servers marked as having the second bug have the first one too, but it would allow one to manually configure PuTTY to cope with a SSH-1 server that got upset by ignore messages during authentication, but was fine with their use as keepalives. check-in: d0102515d4 user: jacob tags: trunk | |
|
2006-10-03
| ||
| 12:16 | Disable a bunch of undesirable termios flags. ICRNL, in particular, is liable to have been set on serial ports previously used as terminal devices, and definitely wants not to be set on serial ports being used for callout. check-in: b632e7b72f user: simon tags: trunk | |
|
2006-10-02
| ||
| 15:52 | IXON and IXOFF belong in _iflag_, not cflag! While I'm here, be more reliable in clearing of RTS/CTS flags. check-in: 4a236e9e9f user: simon tags: trunk | |
|
2006-09-21
| ||
| 06:48 | Fix breakage of `Restart Session' in r6802. When restarting the session, we were clearing the new session_closed flag, but failing to clear must_close_session; with that set, the session was being opened but immediately re-closed. check-in: 856b30b874 user: simon tags: trunk | |
|
2006-09-15
| ||
| 09:44 | Note that the dynamic-tunnel proxy does not support UDP, since we get asked about this quite often. check-in: 83c7b4cc04 user: jacob tags: trunk | |
|
2006-09-05
| ||
| 17:08 | CSI 3 J now clears the scrollback, as in xterm. check-in: de3c767e85 user: jacob tags: trunk | |
| 16:41 | I seem to have slightly funted Plink's display of banners etc in r6437, oops. Fixed. check-in: 93bc517218 user: jacob tags: trunk | |
| 16:39 | Slight change to password expiry UI for the benefit of Cisco servers, which are as usual slightly odd. check-in: 2887f76e0f user: jacob tags: trunk | |
|
2006-09-03
| ||
| 09:31 | Support for an alternative mechanism for displaying wide characters under X: instead of having two separate fixed-width fonts one of which is twice the width of the other, you can instead have a single font in which some characters are twice as wide as others. This is implemented very simply: if you specify a wide font, it will be used for wide characters, and if you don't then the normal font will be used for wide characters (so they'd better _be_ wide in that font, or there'll be trouble). I got this idea from Jed, whose latest version supports UTF-8 and requires a font of this type. If there are going to be X fonts like that kicking around, there will doubtless be people who want to use them. check-in: 8007266fdc user: simon tags: trunk | |
| 07:55 | Add a mini-rant to the top comment explaining why threads are required. (I just tried getting rid of them; it worked fine for serial ports, but not for anything else. The Windows I/O API sucks.) check-in: b2cd494085 user: simon tags: trunk | |
|
2006-08-29
| ||
| 16:46 | Updates for today's changes: - changes to Logging panel - breaks in serial backend (Plus, completely unrelated, an index term entry related to port forwarding which seems to have been sitting around for ages, possibly waiting for me to think about `see also' index terms in Halibut.) check-in: 8f65282e5c user: jacob tags: trunk | |
| 14:07 | New logging mode, which records the exact bytes sent over the wire in an SSH connection _in addition_ to the decrypted packets. This will hopefully come in useful for debugging wire data corruption issues: you can strace the server, enable this mode in the client, and compare the sent and received data. I'd _like_ to have this mode also log Diffie-Hellman private exponents, session IDs, encryption and MAC keys, so that the resulting log file could be used to independently verify the correctness of all cryptographic operations performed by PuTTY. However, I haven't been able to convince myself that the security implications are acceptable. (It doesn't matter that this information would permit an attacker to decrypt the session, because the _already_ decrypted session is stored alongside it in the log file. And I'm not planning, under any circumstances, to log users' private keys. But gaining access to the log file while the session was still running would permit an attacker to _hijack_ the session, and that's the iffy bit.) check-in: 5b5937160f user: simon tags: trunk | |
| 13:50 | Explicitly closing logctx on various kinds of error exit means that the log file gets fclosed properly and the critical last few messages might be recoverable from the log file more often... check-in: b802bd4ac5 user: simon tags: trunk | |
| 13:32 | The Windows HANDLE type, despite being a `void *', does not actually behave like a pointer. In particular, the right thing to set a HANDLE to to indicate that it's invalid is INVALID_HANDLE_VALUE, not NULL. Crack down on sloppy use of NULL HANDLEs across all Windows code. (There is one oddity, which is that {Create,Open}FileMapping are documented to return a NULL HANDLE instead of INVALID_HANDLE_VALUE on failure. Shrug. If MS want to be inconsistent, I suppose I have to live with it.) check-in: 8c6438590b user: simon tags: trunk | |
| 13:20 | Support for sending serial breaks, in both the Windows and Unix serial backends. check-in: 92fba70907 user: simon tags: trunk | |
| 04:18 | Inhibit the Serial configuration panel in mid-session if the session isn't a serial one. In particular, this causes pterm not to fail an assertion if you select `Change Settings'. Ahem. check-in: 0f9a8f4bb2 user: simon tags: trunk | |
|
2006-08-28
| ||
| 14:09 | Apparently MsgWaitForMultipleObjects doesn't always return the values one might expect, which means that GetMessage() was occasionally blocking the process. That appears to be the last of the annoying data loss issues, so I think the Windows serial back end actually looks vaguely reliable now. Phew. check-in: b83e5fdf72 user: simon tags: trunk | |
| 13:36 | That OVERLAPPED fix seems to have made flow control useful as well (presumably Windows's serial buffer is actually _filling up_, causing an XOFF to be sent, now that my dodgy I/O code isn't causing it to leak). So I think I'll switch the default flow control to XON/XOFF, since it actually seems to do something now. check-in: eca76f8423 user: simon tags: trunk | |
| 13:27 | Eep! Next bit flag after 1 and 2 is _4_, not 3. Perhaps it's time I stopped coding and went and sat down quietly and tried not to touch anything for a while. check-in: 8e09b64fa5 user: simon tags: trunk | |
| 13:26 | Reading 4K at a time from a serial port turns out to be a bit unfriendly in an interactive session, because at 19200 baud it takes nearly two seconds to receive that much data, and as long as the data is flowing continuously Windows waits until it has a full buffer. So here's another annoying flag in the winhandl API, which restricts reads to length 1 so that serial output shows up as it appears. (I tried this yesterday, but without the OVERLAPPED fix in r6826 it behaved very erratically. It now seems solid.) check-in: da46d6cd48 user: simon tags: trunk | |
| 13:16 | Apparently it helps for an OVERLAPPED structure to contain a valid event handle. This seems to have fixed _some_, but not all, of the curious data loss issues in the Windows serial backend. check-in: 51fdd5e6b1 user: simon tags: trunk | |
| 12:47 | Minor tweaks to -nc: - log host:port in event log - add -nc to Plink usage message check-in: 6310d3d2a4 user: jacob tags: trunk | |
| 12:41 | Missed a couple of instances of cfg_launchable(). check-in: 451f6c4481 user: simon tags: trunk | |
| 10:12 | New command-line option in Plink (and PuTTY, though it's less useful there): `plink host -nc host2:port' causes the SSH connection's main channel to be replaced with a direct-tcpip connection to the specified destination. This feature is mainly designed for use as a local proxy: setting your local proxy command to `plink %proxyhost -nc %host:%port' lets you tunnel SSH over SSH with a minimum of fuss. Works on all platforms. check-in: 3171b7e2b9 user: simon tags: trunk | |
| 09:29 | Serial back end for Unix. Due to hardware limitations (no Linux box I own has both an X display and a working serial port) I have been unable to give this the full testing it deserves; I've managed to demonstrate the basic functionality of Unix Plink talking to a serial port, but I haven't been able to test the GTK front end. I have no reason to think it will fail, but I'll be more comfortable once somebody has actually tested it. check-in: d6cb32325e user: simon tags: trunk | |
| 08:08 | ... and here's the rest of r6820. Ahem. check-in: 7f2ba0608e user: simon tags: trunk | |
| 08:08 | Because not all OSes will support the same set of serial port options, here's a slight change to the API of ser_setup_config_box() to make it filter its parity and flow control options using platform-supplied bit masks. check-in: 55bede7fcd user: simon tags: trunk | |
| 06:33 | Fix small event log bug. check-in: 8f84a68c51 user: simon tags: trunk | |
| 06:32 | Forgot to initialise serial->bufsize to zero. check-in: 13da7f5aa9 user: simon tags: trunk | |
| 06:13 | Fix line endings (svn:eol-style properties and actual CRs). check-in: a85def1d7c user: simon tags: trunk | |
| 05:35 | Support for Windows PuTTY connecting straight to a local serial port in place of making a network connection. This has involved a couple of minor infrastructure changes: - New dlg_label_change() function in the dialog.h interface, which alters the label on a control. Only used, at present, to switch the Host Name and Port boxes into Serial Line and Speed, which means that any platform not implementing serial connections (i.e. currently all but Windows) does not need to actually do anything in this function. Yet. - New small piece of infrastructure: cfg_launchable() determines whether a Config structure describes a session ready to be launched. This was previously determined by seeing if it had a non-empty host name, but it has to check the serial line as well so there's a centralised function for it. I haven't gone through all front ends and arranged for this function to be used everywhere it needs to be; so far I've only checked Windows. - Similarly, cfg_dest() returns the destination of a connection (host name or serial line) in a text format suitable for putting into messages such as `Unable to connect to %s'. check-in: d160e39029 user: simon tags: trunk | |
|
2006-08-27
| ||
| 06:55 | Now that Local proxy type exists on both Unix and Windows, document it and associated stuff. check-in: 7771df9f07 user: jacob tags: trunk | |
| 05:00 | Grow some nasty warts on the side of winhandl.c, in preparation for a serial port backend: - In order to do simultaneous reading and writing on the same HANDLE, you must enable overlapped access and pass an OVERLAPPED structure to each ReadFile and WriteFile call. This would make sense if it were an optional thing I could do if I wanted to do the reading and writing in the same thread, but making it mandatory even if I'm doing them in _different_ threads is just annoying and arbitrary. - Serial ports occasionally return length 0 from ReadFile, for no particularly good reason. Fortunately serial ports also don't have a real EOF condition to speak of, so ignoring EOFs is actually a viable response in spite of sounding utterly gross. Hence, handle_{input,output}_new() now accept a flags parameter, which includes a flag to enable the OVERLAPPED bureaucracy and a flag to cause EOFs to be ignored on input handles. The current clients of winhandl.c do not use either of these. check-in: 57c8f4b305 user: simon tags: trunk | |
| 04:53 | Remove spurious #include. check-in: 2510e22900 user: simon tags: trunk | |
| 03:34 | Call console_provide_logctx _before_ initialising the back end, so that logevent() will go to stderr in -v mode even during the back end init function. check-in: ed9c98fc34 user: simon tags: trunk | |
| 03:03 | The `socket' function in the backends is only ever checked to see if it's NULL. Since we already have one back end (uxpty) which doesn't in fact talk to a network socket, and may well have more soon, I'm replacing this TCP/IP-centric function with a nice neutral `connected' function returning a boolean. Nothing else about its semantics has currently changed. check-in: 32affe9699 user: simon tags: trunk | |
|
2006-08-26
| ||
| 05:59 | It's critically important that the local proxy process should not inherit _our_ ends of its I/O pipes! Otherwise, closing our copy of those handles does not cause it to see EOF on its stdin, because it's holding the pipe open itself. check-in: 6f9311ed1e user: simon tags: trunk | |
| 05:58 | We _can_ have handle_throttle() called on defunct handles after all, so it should just do nothing rather than failing an assertion. check-in: 4c082609c7 user: simon tags: trunk | |
| 05:20 | ProxyCommand support for Windows, using the new winhandl.c API. Seems a bit clunky when I actually try to use it - not sure why - but I think all the actual functionality is there. check-in: d173edc72d user: simon tags: trunk | |
| 05:19 | Another bug fix: always set the busy flag when telling a subthread to do something, otherwise handle_get_events will forget to tell the front end to check for that subthread finishing. This applies even when we're only setting `busy' to tell the subthread to terminate! check-in: 1ec96c6c9f user: simon tags: trunk | |
| 05:18 | Cleanups to reduce dependency on Windows SFTP tools always having a real network socket. check-in: bb3428dea2 user: simon tags: trunk | |
| 05:17 | On cleanup, PSCP and PSFTP should explicitly check that the back end is still running rather than relying on ssh_sftp_loop_iteration() to return a bogus value. check-in: 3f40f538fa user: simon tags: trunk | |
| 05:04 | Start using notify_remote_exit() in the Windows front end, in place of the previous ad-hockery which depended on the return value from select_result() and hence which will not adapt sensibly to a world in which the primary session is something local rather than a network connection. check-in: ce96560653 user: simon tags: trunk | |
| 04:21 | Return a non-zero exit code in the event of a fatal-error SSH session termination. `Close window only on clean exit' was not working properly on Unix in the absence of this: notify_remote_exit() was being called and ssh_return_exitcode was returning zero, causing gtk_main_quit() to be called, _before_ connection_fatal() happened. check-in: da0b093aaa user: simon tags: trunk | |
| 03:37 | Always initialise the `addresses' field of a SockAddr to NULL, because it gets unconditionally sfree()d in sk_addr_free(). This just bit me when running under the MSVC debugger; not sure how it hasn't bitten anyone until now! check-in: 6d715080f0 user: simon tags: trunk | |
| 03:15 | Bug fix: since the input thread does not wait for the event object until _after_ its first read, we should not start by signalling that object in order to trigger the first read. Ahem. check-in: bb6d97d9b2 user: simon tags: trunk | |
| 02:41 | Small tweak to the new handle API: provide a `privdata' field in each handle structure, set on initialisation and readable by an API call. check-in: 620f32c917 user: simon tags: trunk | |
|
2006-08-25
| ||
| 17:10 | New piece of Windows infrastructure: winhandl.c takes Plink's thread-based approach to stdin and stdout, wraps it in a halfway sensible API, and makes it a globally available service across all network tools. There is no direct functionality enhancement from this checkin: winplink.c now talks to the new API instead of doing it all internally, but does nothing different as a result. However, this should lay the groundwork for several diverse pieces of work in future: pipe-based ProxyCommand on Windows, a serial port back end, and (hopefully) a pipe-based means of communicating with Pageant, which should have sensible blocking behaviour and hence permit asynchronous agent requests and decrypt-on-demand. check-in: 2156c9bb4b user: simon tags: trunk | |
|
2006-08-15
| ||
| 17:48 | Er, ahem. Other half of r6788. :-/ check-in: 0544b4b30e user: simon tags: trunk | |
| 15:29 | Shifts left and right by 32 were tripping a gcc warning (fatal with -Werror, of course) about shifting by more than the range of a data type. They only appeared in `if' statements testing sizeof(off_t), but gcc warns even when the code is unreachable. I've removed the conditional code (the general case should still work even on 32-bit machines), and hacked each shift by 32 into a pair of shifts by 16. Note that the gcc warning is not just a helpful indication that you may be using the wrong data type; it's actually pointing out ANSI- undefined behaviour in shifting a signed integer beyond the size of its type. check-in: 3771100200 user: simon tags: trunk | |
| 07:45 | Aha! At long last I've managed to reproduce the intermittent problem I've been having with the cursor sometimes restoring to the wrong place when screen(1) terminates. The offending sequence of escape sequences goes ESC 7 (save cursor), ESC [?47h (switch to alternate screen), ESC 7 (save cursor _again_), do some stuff, ESC 8 (restore cursor), run screen session for a bit, ESC [?47l (return to main screen), ESC 8 (restore cursor). The final ESC 8 is expected to restore the cursor to where it was saved by the initial ESC 7. Translation: the ESC 7 saved cursor state is part of the state we must swap out when switching to the alternate screen. In other words, we need to track _four_ cursor positions: active and saved, on each of main and alternate screen. Previously we were tracking only three. check-in: b6448111db user: simon tags: trunk | |
|
2006-08-12
| ||
| 10:20 | Large file support for psftp and pscp on both Windows and Unix. On Unix we set _FILE_OFFSET_BITS to 64 on the compiler command line (via mkfiles.pl), and on Windows we use SetFilePointer and GetFileSize to cope with 64-bit sizes where possible. Not tested on Win9x. check-in: ec84bb61b9 user: owen tags: trunk | |
|
2006-08-05
| ||
| 08:48 | Some extra int64 functions. check-in: 7655cbbe4f user: owen tags: trunk | |
|
2006-07-07
| ||
| 15:56 | Spell out more explicitly what needs to be done with vanilla VC6, since it seems to be becoming a FAQ. check-in: 704a813ad8 user: jacob tags: trunk | |
| 09:18 | Random Unix puttygen improvements highlighted by a post to comp.security.ssh: - fix diagnostic if keyfile and '-t' both specified - add diagnostic for generating a key but discarding the private part - document '-q' option check-in: 7eabb3b6ff user: jacob tags: trunk | |
|
2006-06-20
| ||
| 16:10 | In the config dialog, clip RGB values to [0..255] rather than reducing them mod 256. Document that the RGB values can be edited, and their range. check-in: c17530c621 user: jacob tags: trunk | |
|
2006-06-17
| ||
| 08:01 | When Unix PuTTYgen gives brief usage information, it should mention "--help"! check-in: b9a8213d57 user: jacob tags: trunk | |
| 07:02 | Robert Evans spotted that bignum_decimal() failed to cope with being given a zero input. This shouldn't matter for PuTTY, as these routines are only used in PuTTYgen, to output SSH-1 format public key exponents/moduli, which should be nonzero. check-in: fced7ed12c user: jacob tags: trunk | |
|
2006-06-16
| ||
| 08:09 | Update status of our PocketPC port. check-in: 4f52be62ba user: jacob tags: trunk | |
|
2006-06-11
| ||
| 07:56 | Do not send raw mouse events in the middle of a selection operation, even if we otherwise would (for instance, if Shift is released before the mouse button being used for selection). check-in: 2e768838ff user: jacob tags: trunk | |
|
2006-06-02
| ||
| 03:46 | Lionel Fourquaux offers this very simple patch to speed up SFTP, simply by upping the packet sizes and maximum in-flight packet count. Got to be worth a try, I think! check-in: 2cb25a46b3 user: simon tags: trunk | |
|
2006-05-26
| ||
| 07:45 | Make it clearer that `psftp -b' doesn't return to the interactive prompt if the script doesn't end with an explicit `quit'. check-in: 1bc1435899 user: simon tags: trunk | |
|
2006-05-21
| ||
| 07:20 | Port r6710 from puzzles: Patch from Ben Hutchings to prevent an ugly special case in &splitline in which a line is `split' into a line ending in a backslash followed by a completely blank line. check-in: d90992e39c user: jacob tags: trunk | |
|
2006-05-17
| ||
| 07:06 | Link to new `key-formats-natively' wishlist item from appropriate FAQ. check-in: 95c74259f2 user: jacob tags: trunk | |
|
2006-05-12
| ||
| 06:02 | pty_init should put _something_ into realhost check-in: d92da8d7b9 user: owen tags: trunk | |
|
2006-04-26
| ||
| 18:01 | sbcsgen.pl was giving different results on different machines in the case where two SBCS code points mapped to a single Unicode point. Changed so that by default it favours the lower SBCS code point. On ixion, this highlighted ambiguities in CS_MAC_THAI, CS_MAC_SYMBOL, and CS_VISCII. Guessed at a preference for the first two and added "sortpriority" directives. (No idea about VISCII.) check-in: 471812fd14 user: jacob tags: trunk | |
|
2006-04-23
| ||
| 13:26 | Sprinkle some header comments in various files in an attempt to explain what they're for. check-in: 7932188e51 user: jacob tags: trunk | |
|
2006-04-16
| ||
| 06:15 | PocketPuTTY website moved. check-in: fba210a48f user: jacob tags: trunk | |
|
2006-04-13
| ||
| 16:18 | Everywhere we print an fxp_error(), try to make it clear what we were trying to do at the time. (A lot of these say just "canonify:". This isn't a nice thing to show to a user, but I don't believe canonify() will ever return failure due to a server error, so users shouldn't actually see it, and it means we have a chance of tracing it if reported.) check-in: 5196811374 user: jacob tags: trunk | |
|
2006-04-07
| ||
| 16:42 | Remove login name prompt from PSFTP. ssh.c will prompt for a login name as required, and doing so in psftp.c before we've even made a connection is incorrect wrt `bypass-ssh2-userauth'. check-in: daea38aac5 user: jacob tags: trunk | |
|
2006-03-31
| ||
| 03:26 | ECCN / FIPS - we can't be arsed. check-in: f7fda73b4a user: owen tags: trunk | |
|
2006-03-29
| ||
| 11:55 | Update size when going from maximised to full screen. check-in: 23a1c6f75e user: owen tags: trunk | |
|
2006-03-15
| ||
| 08:31 | Explicitly add linking to our website to the "asking permission for things" section. Replace the FAQ text with a summary + link to feedback.but. check-in: f4f5824aac user: jacob tags: trunk | |
|
2006-03-14
| ||
| 16:01 | Fix minor memory leak. check-in: c92727f499 user: jacob tags: trunk | |
| 05:21 | Pageant docs didn't mention that you could load keys into an existing Pageant from the command line. check-in: b338eb7806 user: jacob tags: trunk | |
|
2006-03-12
| ||
| 16:17 | Equivalent of r6583 window-border palette-change fix for Gtk. check-in: 06ec31208c user: jacob tags: trunk | |
| 13:24 | Dimitry Andric spotted that DH gex with SHA-256 was overflowing a buffer. Fixed, and added paranoia so that this shouldn't happen again. check-in: ff7555e2cd user: jacob tags: trunk | |
| 09:39 | Log the hash used for DH kex (now there's a choice). check-in: 160e173d94 user: jacob tags: trunk | |
| 08:53 | Fix inadvertent O(N^2) loop within do_paint() which I just discovered when profiling IPBT. check-in: e368f18c9a user: simon tags: trunk | |
|
2006-03-08
| ||
| 17:16 | Flesh out `-m' caveats slightly. check-in: 309de1336c user: jacob tags: trunk | |
| 12:15 | Oh, and update the docs for NetHack keypad mode too. check-in: 91b0027b9e user: simon tags: trunk | |
| 12:10 | David Damerell tells me I should be using Ctrl-hjklyubn rather than Shift-hjklyubn for batch movement in NetHack, because they have subtly different behaviour within the game and the Ctrl-moves are more useful. Unfortunately, PuTTY's NetHack keypad mode doesn't support Ctrl-moves. Therefore, it does now :-) check-in: 396c775fc5 user: simon tags: trunk | |
|
2006-02-27
| ||
| 17:55 | Fix a memory leak in key generation. check-in: 898c8db8c4 user: jacob tags: trunk | |
| 16:30 | Change XXX-REMOVE-BEFORE-RELEASE to XXX-REVIEW-BEFORE-RELEASE to allow more general changes to be queued up. check-in: 8e223dda48 user: jacob tags: trunk | |
| 16:27 | Batch of miscellaneous tweaks to the Windows installer: - Now we've fixed `win-versioninfo', choose some sensible outcomes from the installer's comparisons of binary version numbers. Also, give the installer _itself_ a matching binary version. In particular, without this change, it would not have been possible to downgrade PuTTY -- it would have silently left the "newer" files in place. Now it will make some fuss, but permit it. - Also remove descriptions from shortcuts, on the grounds that the binaries have embedded descriptions now. (Although I've not checked whether those are actually visible in the Start Menu.) - At the request of various people (e.g., PJB), add flags so that if files are in use at the time the (un)installer is run, replacement is deferred to the next restart. (The user may be prompted to restart, which isn't ideal; see comments). This is supposed to make centrally-pushed silent upgrades more robust. - Note some limitations of the installer. check-in: ae70784090 user: jacob tags: trunk | |
|
2006-02-25
| ||
| 08:13 | Alain Guibert points out that palette changes weren't causing the space between the text area and the window border to be refreshed. Fixed on Windows. Gtk still has a similar problem. check-in: e9756c0bd4 user: jacob tags: trunk | |
|
2006-02-23
| ||
| 07:38 | Do proper select-for-write on ptys. Currently, pasting a sufficiently large string into pterm in any circumstances in which it's echoed back to the terminal will cause a deadlock once the pty's write buffer fills up. check-in: f7782e75bd user: simon tags: trunk | |
|
2006-02-20
| ||
| 13:54 | Alain Guibert points out that ESC]P sequences were erroneously accepting 'G' as a hex digit. (The _first_ digit of the sequence intentionally goes up further than F, but the remaining ones shouldn't have.) check-in: 14247e5d72 user: simon tags: trunk | |
|
2006-02-19
| ||
| 16:37 | Daniel Meidlinger points out a redundant test :-) check-in: f643efedb0 user: simon tags: trunk | |
| 08:59 | Fix `restart-reset-terminal': terminal now restored to a sensible state when reusing a window to restart a session. check-in: a9fe99c1ad user: jacob tags: trunk | |
| 08:10 | Add/tweak a couple of comments. check-in: 4c1dee7ad6 user: jacob tags: trunk | |
| 06:52 | Fix up documentation/usage messages for r6572. check-in: 82ba29d738 user: jacob tags: trunk | |
| 06:05 | Introduce a new checkbox and command-line option to inhibit use of Pageant for local authentication. (This is a `don't use Pageant for authentication at session startup' button rather than a `pretend Pageant doesn't exist' button: that is, agent forwarding is independent of this option.) check-in: 312df617cd user: simon tags: trunk | |
|
2006-02-18
| ||
| 19:37 | At last, a fix for `large-clipboard-crash'. A growable buffer was only being grown for actual text, not for newlines or trailing NULs. A large run of empty lines could lead to newlines overflowing the buffer (> 100 should be enough to guarantee this on all platforms, after the initial 5k size of the buffer). Also fix some valgrind in the same area (was probably harmless), and a memory leak introduced by the RTF attribute pasting. check-in: 8c998698f4 user: jacob tags: trunk | |
| 16:30 | Pointer type correction in term_clrsb(). (Harmless, as it happens.) check-in: d02651ccc3 user: jacob tags: trunk | |
|
2006-02-14
| ||
| 07:14 | Typo in r6555 spotted by Daniel Meidlinger. check-in: 43fb61a310 user: jacob tags: trunk | |
|
2006-02-13
| ||
| 16:25 | RTF pasting now includes colours and style. Say so. check-in: a6e9490e62 user: owen tags: trunk | |
| 16:18 | Preserve more attributes of text copied as RTF. Thanks to Stephen Balousek. check-in: e24538d25e user: owen tags: trunk | |
|
2006-02-11
| ||
| 13:10 | Don Heap spotted that our heuristics for dealing with IPv6 literal addresses in the PSCP command line were bogus, giving "remote to remote not supported" errors with filenames like '[].txt'. Made the heuristic less bogus. check-in: 5f8792b0e9 user: jacob tags: trunk | |
| 12:29 | Failure to connect to a Unix-domain socket could cause a segfault. Fixed. check-in: 54ac07652e user: jacob tags: trunk | |
| 12:00 | A zero-length return from platform_get_x_display() (for instance, a zero-length DISPLAY variable in the environment) caused an assertion failure when X11 forwarding was attempted. Fixed (now treated the same as a NULL return, e.g., a non-existent DISPLAY variable). check-in: 2c5a04569e user: jacob tags: trunk | |
|
2006-02-10
| ||
| 14:57 | Oops. Since r6546, old "Special Commands" menus weren't being deleted from the context menu, and they tended to pile up. check-in: 963c5c5a87 user: jacob tags: trunk | |
|
2006-02-09
| ||
| 17:06 | Users of Virtual Dimension are reporting that the "Close" menu item and button tend to get disabled on login. After a suggestion by "Tkil", change the way we handle the specials menu to be robust against the window menu being externally modified. check-in: a7b8c32f79 user: jacob tags: trunk | |
|
2006-01-27
| ||
| 14:49 | Somewhat gruesome tweak to use SetClassLongPtr where available and degrade nicely elsewhere, which should fix `win64' _properly_. Tested on recent-ish MinGW (with GetWindowLongPtr but not GetClassLongPtr), and VC++ 6.0 with a recent SDK, but not with vanilla VC++. check-in: 13b73ead40 user: jacob tags: trunk | |
|
2006-01-25
| ||
| 16:46 | Don't explicitly open the logfile on startup; it'll automatically be opened by logwrite() as necessary. Should fix win-askappend-multi. check-in: 5f02ab2b2a user: owen tags: trunk | |
|
2006-01-24
| ||
| 05:08 | s/PuTTY/PuTTYgen/ in two places. check-in: 571d5eb05b user: jacob tags: trunk | |
|
2006-01-11
| ||
| 17:43 | VC6 doesn't define LONG_PTR check-in: 9a3790cdaa user: owen tags: trunk | |
| 17:42 | Configurable font quality on Windows. (Together with a little bit of macro stuff to cope with the inadequacy of VC++ 6 headers.) check-in: 051f4cfea4 user: owen tags: trunk | |
|
2006-01-10
| ||
| 14:02 | Fix zero-rows-cols-crash check-in: 04df52bdb7 user: owen tags: trunk | |
|
2006-01-08
| ||
| 12:18 | It's a new year. check-in: f65373bcc5 user: jacob tags: trunk | |
|
2005-12-18
| ||
| 11:05 | Update status of this library wrt other variants. check-in: ba7f6a48ca user: jacob tags: trunk | |
| 10:57 | CP866 is popular and small. Add it to both the general and PuTTY implementations of libcharset, since we've had at least one request for it in PuTTY. check-in: 20a3f339c5 user: jacob tags: trunk | |
|
2005-12-16
| ||
| 10:43 | Mention compile-time directives and where they're documented. check-in: 196244c2fc user: jacob tags: trunk | |
|
2005-12-09
| ||
| 14:04 | A few small changes to make the PuTTY source base more usable as a basis for other terminal-involving applications: a stub implementation of the printing interface, an additional function in notiming.c, and also I've renamed the front-end function beep() to do_beep() so as not to clash with beep() in lib[n]curses. check-in: bc74216dab user: simon tags: trunk | |
|
2005-12-07
| ||
| 12:01 | Apparently some SSH servers object to our claiming port-forwarded connections to be from IP "client-side-connection". Claiming "0.0.0.0" instead seems to work. Spotted by Brant Thomsen. check-in: 0cf3aea3e9 user: jacob tags: trunk | |
|
2005-12-06
| ||
| 18:24 | Institutional failure to memset() things pointed at rather than pointers. Things should now be zeroed and memory not leaked. Spotted by Brant Thomsen. check-in: 2a7f73d55f user: jacob tags: trunk | |
| 17:18 | Improvements from Spyros Blanas to the MSVC optimisations of r6469: don't do a function call for each divmod, and don't rely on details of the calling convention. (This didn't actually make any measurable difference to runtime in any of my tests, but we may as well keep it as it's neater.) Also document some general caveats of the divmod macro. check-in: f970409cb9 user: jacob tags: trunk | |
|
2005-12-01
| ||
| 10:41 | SSH-2 rekey bug compatibility setting wasn't being saved (but _was_ being loaded). check-in: 5af5c8f9a9 user: jacob tags: trunk | |
|
2005-11-23
| ||
| 15:26 | An MSVC version of the 16->32-bit bignum optimisation, derived from part of a patch by Lionel Fourquaux. Seems to be about a factor of four improvement (see wishlist item for details). I don't claim to understand this in detail, so I can't vouch for its correctness, but it didn't fall over immediately. It also produces some compiler warnings, unfortunately. check-in: eefc5f979e user: jacob tags: trunk | |
|
2005-11-14
| ||
| 03:41 | Missing close parenthesis. check-in: 61c0f1e69b user: jacob tags: trunk | |
|
2005-11-13
| ||
| 10:06 | r6437 broke the case where Pageant is running but contains no SSH-2 keys that the SSH-2 server is happy with. Fixed, and since I'm here, fix `pubkeyfile-and-pageant' as well (for SSH-1 and SSH-2). Also, in SSH-2, we now reexamine "methods that can continue" for every Pageant key offer, which is technically more correct although it seems unlikely that it was causing any real problems. (It's not entirely pretty, but neither was the old code. We could probably do with some sort of abstraction for public/private keys to avoid carting lots of fiddly bits of data around.) check-in: 5ecfcce6b6 user: jacob tags: trunk | |
| 06:13 | Oops, used \I where I meant \i. I think this is the only instance. check-in: 6c6d33724f user: jacob tags: trunk | |
|
2005-11-09
| ||
| 17:19 | I broke the ability to cope with multiple consecutive k-i INFO_REQUESTS in r6437. This ought to be better (but I can't test that case). check-in: eefac6dd49 user: jacob tags: trunk | |
|
2005-11-04
| ||
| 17:31 | Fix minor hiccup in SSH-1 p-k auth. check-in: b965b38836 user: jacob tags: trunk | |
| 17:21 | Placate a compiler warning introduced in r6437. (I forgot we usually compile with -Werror on Unix, oops.) check-in: 992b547918 user: jacob tags: trunk | |
| 08:49 | Fix for `ssh2-password-expiry'. Success case tested. (Much easier since r6437, and actually works to boot.) check-in: 5033091888 user: jacob tags: trunk | |
|
2005-11-02
| ||
| 17:15 | When a userpass interaction has finished, make sure the 'prompts' structure is safe for re-use. check-in: be2be716fa user: jacob tags: trunk | |
|
2005-10-31
| ||
| 16:43 | (do_ssh2_authconn_state).method is redundant since r6437; remove. Remove FIXMEs from .type assignments, as they look fine. check-in: ad1b2a4de9 user: jacob tags: trunk | |
|
2005-10-30
| ||
| 14:24 | Revamp SSH authentication code so that user interaction is more abstracted out; replace loops structured around a single interaction per loop with less tortuous code (fixes: `ki-multiprompt-crash', `ssh1-bad-passphrase-crash'; makes `ssh2-password-expiry' and `proxy-password-prompt' easier). The new interaction abstraction has a lot of fields that are unused in the current code (things like window captions); this is groundwork for `gui-auth'. However, ssh.c still writes directly to stderr; that may want to be fixed. In the GUI apps, user interaction is moved to terminal.c. This should make it easier to fix things like UTF-8 username entry, although I haven't attempted to do so. Also, control character filtering can be tailored to be appropriate for individual front-ends; so far I don't promise anything other than not having made it any worse. I've tried to test this fairly exhaustively (although Mac stuff is untested, as usual). It all seems to basically work, but I bet there are new bugs. (One I know about is that you can no longer make the PuTTY window go away with a ^D at the password prompt; this should be fixed.) check-in: fa1347493a user: jacob tags: trunk | |
| 13:13 | In Unix PuTTYgen, existing SSH-1 key comments were coming out as "(null)" for operations not performing decryption (e.g., "puttygen rsa1.ppk -L") (A use for r6434 -- wasn't expecting that.) check-in: 58ea3b5986 user: jacob tags: trunk | |
| 10:28 | Fixes to make r6434 actually useful. check-in: 406df7aa52 user: jacob tags: trunk | |
| 09:16 | Allow rsakey_pubblob() to return the key comment. (like r6433 but for SSH-1) check-in: 4c5674dd5b user: jacob tags: trunk | |
| 07:42 | Add ability for ssh2_userkey_loadpub() to return the key comment. (Not actually used currently, but it makes life easier for a patch I'm working on.) check-in: d7d7b6fd7d user: jacob tags: trunk | |
|
2005-10-26
| ||
| 17:18 | Fix an error I introduced into SSH packet logging in r5642: some outgoing packets over about 256 bytes would be logged with 12 bytes of preceding garbage. (But the rest of the packet was logged in its entirety. This holds for packets where (int(len/256)%2)==1, with an appropriate fudge factor applied to `len'.) Ahem. check-in: b982e695f5 user: jacob tags: trunk | |
| 15:58 | Comment explaining back->sendok() semantics from Simon. check-in: b4c7e4df9c user: jacob tags: trunk | |
|
2005-10-13
| ||
| 17:51 | Tweak to r6392: spell "MAC" thus. check-in: bdcb94cf82 user: jacob tags: trunk | |
| 16:56 | Fix 256-colours-match-xterm, based on 256colres.pl from xterm-205. Largely untested -- may not even compile on Windows. check-in: a232015fce user: ben tags: trunk | |
| 16:51 | Make SSH_MSG_DISCONNECT reasons less scary (without removing useful content). check-in: 9ad31acae5 user: ben tags: trunk | |
|
2005-10-08
| ||
| 04:09 | Failed to call set_erase_char() after processing SCO colour sequences. check-in: adc8ae5a8d user: simon tags: trunk | |
|
2005-10-04
| ||
| 09:13 | `win-versioninfo': all builds of all Windows binaries now contain a VERSIONINFO resource. The versioning scheme is described in windows/version.rc2. Some .rc files are now #included in others. In order to keep MSVC project files working, these have been renamed to .rc2; there may exist a better solution. (This checkin also includes the documentation tweak missing from r6367.) Testing performed: - MinGW (cross-compiler): works - VC nmake: works (tested with VC6) - VC project files: builds with VERSIONINFO resource (no VER variable though) - Borland: an old version of this patch was tested with it and more or less worked, except that some of the VERSIONINFO strings were apparently not terminated properly. Not attempted to work around this. - LCC: not tested. Some fixes are in there from the last time we tried this, but then the build ultimately failed and I haven't tried this since that was fixed. - Dev-C++: untested. (Haven't done anything special.) - Unix Gtk/autoconf Makefiles work as before. check-in: 5532c18e9c user: jacob tags: trunk | |
|
2005-10-03
| ||
| 06:38 | UTF-8 processing was discarding a valid character which interrupted an otherwise legal sequence, if that valid character was the last thing in a term_out() run. Spotted by Egmont Koblinger. check-in: 39c08b8213 user: simon tags: trunk | |
| 05:24 | thinko check-in: d91314ba65 user: jacob tags: trunk | |
|
2005-10-01
| ||
| 07:36 | Split out SVN_REV from SNAPSHOT define. This is to support `win-versioninfo', but since Simon's made the corresponding change to the build process, this bit needs checking in now (it should be harmless). (The documentation in Recipe is slightly out of date; with luck I'll be checking in `win-versioninfo' changes soon, and I can't be bothered to disentangle the relevant changes in the meantime.) check-in: dcf7ae3503 user: jacob tags: trunk | |
| 06:40 | A swathe of new FAQ questions, along the general theme of `will you sign something for us / give us assurances / give us indemnity'. check-in: 9777e6fa6a user: simon tags: trunk | |
|
2005-09-30
| ||
| 09:54 | Mention SSH-2 rekeys in the keepalive section. check-in: 0d7e423c6b user: jacob tags: trunk | |
|
2005-09-24
| ||
| 13:33 | A first stab at guidance for those lost souls who email us asking for login names and/or passwords. Feel free to hack. (NB, renumbers a section of the FAQ.) check-in: 7038b14bd0 user: jacob tags: trunk | |
| 11:17 | Add DEVCPP to svn:ignore. check-in: b710d22e3a user: jacob tags: trunk | |
|
2005-09-21
| ||
| 12:09 | dlg_listbox_select() now scrolls the list box to ensure that the item it's just selected is visible. check-in: 720b8943c1 user: simon tags: trunk | |
| 09:53 | Platform-independent support for zooming around session list by typing in the session name box. Thwarted on Unix by GTK not automatically scrolling the listbox to the selected item, but we can fix that in the platform-specific side later. check-in: 4cda7c3ac3 user: owen tags: trunk | |
|
2005-09-19
| ||
| 09:34 | Mention that sessions can be saved from "Change Settings" in using.but. check-in: 3cf3850e9e user: jacob tags: trunk | |
|
2005-09-14
| ||
| 06:00 | AIX 5.1 has <utmpx.h> but no updwtmpx(). Treat the latter as a reason to OMIT_UTMP. Reported by Mike Protts. check-in: 3a73862242 user: ben tags: trunk | |
| 05:53 | Some systems (HP-UX) don't yet have <sys/select.h>, putting select() in <sys/time.h>. Cope with this. Where <sys/select.h> _is_ available, though, use it (since it's where POSIX puts select()). Problem reported by Mike Protts. check-in: 36d43f446e user: ben tags: trunk | |
|
2005-09-13
| ||
| 15:17 | When asked to malloc zero bytes, malloc one byte instead. This ensures that we get a unique pointer rather than NULL (which ANSI C otherwise permits). Problem pointed out by Mike Protts. check-in: b6d6e37138 user: ben tags: trunk | |
| 15:08 | The ANSI-C constant FILENAME_MAX is ludicrously small on some systems. Use the POSIX PATH_MAX if it exists, and fall back to 1024 otherwise. We should really allocate filenames dynamically if PATH_MAX isn't defined. check-in: fb2701ef6e user: ben tags: trunk | |
| 14:57 | Some hosts don't have TIOCSCTTY. Don't try to use it on them. Patch from Mike Protts. check-in: 6da243c989 user: ben tags: trunk | |
| 14:54 | A couple of places in sk_newlistener were using AF_INET6 even with NO_IPV6. Correct them. check-in: 42d139827f user: ben tags: trunk | |
| 14:24 | Nothing seems to use the "int64" type, and it apparently causes conflicts on some platform, so remove it. Thanks to Mike Protts for spotting this. check-in: e2a5a2ad4f user: ben tags: trunk | |
| 09:12 | Apparently the OS X port is stalled. check-in: 4aa5e07e85 user: jacob tags: trunk | |
|
2005-09-12
| ||
| 10:45 | When the first element in a preference list was unrecognised, PuTTY would hang when reading it because strtok() kept getting the full list passed in. Fix this, and add an assert() for an assumption documented in a comment while I'm in the area. check-in: 28904047ca user: ben tags: trunk | |
|
2005-09-10
| ||
| 12:36 | Mention relationship between terminal types, keyboard sequences, and termcap/terminfo. Suggested by Joachim Durchholz. check-in: 219982d46f user: ben tags: trunk | |
| 11:19 | Implement hmac-sha1-96. It's RECOMMENDED in the current transport draft, and we don't have any strong reason not to implement it, for all that it's rather pointless. check-in: 07e74def32 user: ben tags: trunk | |
|
2005-09-04
| ||
| 09:53 | Add support for diffie-hellman-group-exchange-sha256. Tested against a patched OpenSSH server. This is controlled by the same user settings as diffie-hellman-group-exchange-sha1, which may not be optimal, especially given that they're both referred to as dh-gex-sha1 in saved sessions. check-in: fac0751ecf user: ben tags: trunk | |
|
2005-09-03
| ||
| 12:29 | Mention xp-wont-run. check-in: 38dc422cce user: ben tags: trunk | |
| 12:03 | Now that my arcfour-fixes draft has been approved by the IESG, use the IANA-assigned names for its modes. check-in: 2269771ab3 user: ben tags: trunk | |
| 08:41 | Restructure things so that a single entry in the KEX preference list can correspond to multiple SSH-2 KEX algorithms. We already do the equivalent for cipher algorithms. check-in: 45f5ec7b5a user: ben tags: trunk | |
|
2005-09-02
| ||
| 05:51 | Check ssh->v2_session_id_len _after_ assigning to it. check-in: 2b3bb67839 user: jacob tags: trunk | |
|
2005-08-31
| ||
| 17:32 | Don't bother compiling SHA-256 for now -- I need to think a bit before I use it. check-in: 0677815069 user: ben tags: trunk | |
| 16:48 | SHA-256 implementation, for use in future KEX algorithms, in particular diffie-hellman-group-exchange-sha256, which the last DHGEX draft defined. Code lifted from Simon's "crypto" directory, with changes to make it look more like sshsh512.c. check-in: b428aa5211 user: ben tags: trunk | |
| 15:43 | Add infrastructure for supporting multiple hashes in key exchange. Nothing very surprising here. check-in: 5e476e7efc user: ben tags: trunk | |
| 14:11 | Rename ssh_md5 and ssh_sha1 to ssh_hmac_md5 and ssh_hmac_sha1 respectively. This is to make room for a hash abstraction that's likely to want to use ssh_sha1, at least. check-in: 9afc7f5e94 user: ben tags: trunk | |
| 11:14 | Explicitly note that "remote command" semantics typically involve the server closing the connection after the command has executed. check-in: 91d028877b user: jacob tags: trunk | |
|
2005-08-30
| ||
| 17:39 | Further progress in the direction of variable exchange hashes -- stash the outgoing KEXINIT, and only start generating the exchange hash once we know which KEX method we're using. check-in: d49b79d098 user: ben tags: trunk | |
| 15:38 | Beginnings of support for multiple exchange hashes in SSH-2: rather than storing a SHA-1 hash of the client and server version strings, store the strings themselves so we can feed them through the appropriate hash when we know what it is. check-in: 9636ea0134 user: ben tags: trunk | |
|
2005-08-28
| ||
| 19:34 | More versions of WeOnlyDo have the rekey bug (but they've fixed it now). check-in: fb8ffeb494 user: jacob tags: trunk | |
|
2005-08-26
| ||
| 16:17 | I think this should fix various problems with queued incoming data not being processed and incoming data being processed out of order, which I suspect is the cause of `ssh1-fwd-trouble' as noted by Gevan Dutton. I'm not able to test the failure case, but it doesn't seem to have obviously broken anything in the cases I have tested, anyway. check-in: 8579417a41 user: jacob tags: trunk | |
|
2005-08-22
| ||
| 15:37 | Add support for generating project files for use with Dev-C++, contributed by Florian Gaab. check-in: 493c4ae935 user: ben tags: trunk | |
| 15:07 | Florian Gaab reports that freeSSHd 1.0.7, which claims a "softwareversion" of "WeOnlyDo-1.2.6", mishandles repeat key exchange. Add it to the list. check-in: 6c5b1e2063 user: ben tags: trunk | |
|
2005-08-10
| ||
| 13:31 | Ben Rudiak-Gould points out that we should be using WM_APP as the base for our app-private window messages, which is considerably higher than the WM_XUSER we arbitrarily chose. (This isn't known to be causing any actual problems. The fix seems not to have obviously broken anything.) check-in: 8b2c50dec0 user: jacob tags: trunk | |
|
2005-07-24
| ||
| 08:46 | draft-ietf-secsh-transport-24 says that only "SSH-" at the start of a line marks a version string. It's a bit vague about the definition of a line, but I think it's reasonable to assume that they'll end with LF. Change do_ssh_init() to ignore "SSH-" anywhere else. This makes the existing state machine overkill, so replace it with something a little more readable. check-in: 4a58cc8686 user: ben tags: trunk | |
|
2005-07-17
| ||
| 08:37 | This is getting silly; nearly 25% of our mirrors are now in the US. Discourage more strongly mirrors in well-served areas in the Feedback section. Also, duplicate that text on the Mirrors page, along with a request to tell us the country (since lots of people still don't). check-in: e1741520c4 user: jacob tags: trunk | |
|
2005-07-15
| ||
| 06:47 | Patch from Colin Watson: we were sometimes passing stack storage to putenv(), which is Bad (in his case, it caused TERM to end up unset). Use malloc()'d storage instead. check-in: d0c607099f user: jacob tags: trunk | |
|
2005-07-06
| ||
| 13:26 | Missing argument in MALLOC_LOG version of snrealloc() macro. check-in: 1d9695328f user: jacob tags: trunk | |
|
2005-07-05
| ||
| 16:15 | Piers Finlayson reports that "DigiSSH_2.0" chokes (in a new and exciting manner) on rekeys. Add it to the list. check-in: 1ccaca97e2 user: ben tags: trunk | |
|
2005-06-29
| ||
| 13:20 | Try to make it slightly clearer that TIS/CryptoCard are generic, since SSH:TDGv2 seems to think that TIS is only relevant to its original application (whose name eludes me at the moment). check-in: 8e13e4c6c5 user: jacob tags: trunk | |
|
2005-06-25
| ||
| 16:43 | In local-to-remote copies, abort if fxp_init() fails, rather than ploughing on and trying to transfer files, which caused a null-pointer deference. Thanks to Fernando Najera for reporting the bug. check-in: 632f55a867 user: ben tags: trunk | |
| 14:22 | Quote session name in command line example for robustness. check-in: 9aacb09159 user: ben tags: trunk | |
|
2005-06-22
| ||
| 05:00 | Improve IPA representation of "PuTTY", as suggested by John Lunney. My rationale (as mailed to him): I think you're right. I got the pronunciation there from the second edition of the OED and my Collins dictionary at home, both of which believe that "pretty" is pronounced /'prItI/, but, at least to me, those two vowels are different. Both of them think that /i/ doesn't occur in English words, the vowel in "beat" being /i:/. The third edition of the OED, though, adds /i/ as an English vowel in its pronunciation guide, with "happy" as an example of its use. I'll update the FAQ following your suggestion. check-in: e7afd4150b user: ben tags: trunk | |
|
2005-06-21
| ||
| 15:13 | Fix an apparently-harmless error spotted by Ben Rudiak-Gould: do_ssh2_transport() was returning the wrong value for rekeys after the first. This apparent error was introduced in r4901, but we can't see any reason for the change to have been made. If it turns out to be a mistake to revert it, I'm sure we'll find out. Here for posterity is Simon's analysis: | A lot of the return values from do_ssh2_transport appear to be vestigial: it | used to be that a zero return from do_ssh2_transport meant it had handled the | packet internally, and a 1 return meant the packet wasn't a transport-layer | one and needed to pass on to do_ssh2_authconn. Since r4901, however, the | layer discrimination is done based on the message type ranges, and the only | remaining dependency on the return value from do_ssh2_transport is a special | case in ssh2_protocol which detects the first 1 return and makes the | initialisation call to do_ssh2_authconn. | | Therefore, the gratuitous 1 return on every key exchange as a result of the | confusing if statement is simply ignored in ssh2_protocol (because | ssh->protocol_initial_phase_done is already TRUE). So the remaining question | was, why does the _lack_ of that 1 return not cause a problem, if the if's | sense is indeed reversed? | | The answer is that 1 is still returned, just not by the crReturn inside the | if statement. It's returned by the next crReturn, just after | wait_for_rekey(). Which suggests that in fact, the if statement has the | correct sense, but the crReturn inside it has the wrong value - it should be | returning _zero_, to indicate that every NEWKEYS after the first one is | uninteresting to the authconn code, and on the very first run through that | doesn't happen and the NEWKEYS gets all the way to the crReturn(1) later on. check-in: d4dea14f10 user: jacob tags: trunk | |
|
2005-06-20
| ||
| 08:56 | Make the sanity-checks on the size of incoming packets much stricter. We now enforce the following: * Packet must have at least one byte of payload and four bytes of padding. * Total packet length must not exceed 35000 bytes compressed. * Total packet length including length field must be a multiple of cipher block size (or eight bytes). The feebleness of our old checks was noticed by Ben Rudiak-Gould. check-in: be45b43e16 user: ben tags: trunk | |
|
2005-06-19
| ||
| 09:17 | A major purpose of PuTTY's memory-allocation functions is to succeed or die trying, so there's no need to check their return values for NULL. Spotted by Ben Rudiak-Gould. check-in: 3e02f6edcc user: ben tags: trunk | |
| 08:57 | Move comment about ECHO and LINE input modes to a more sensible position. Spotted by Ben Rudiak-Gould. check-in: da08d99cd3 user: ben tags: trunk | |
|
2005-06-14
| ||
| 18:20 | Detection of "auth-agent@openssh.com" was too liberal. Spotted by Ben Rudiak-Gould. check-in: a3dc59e09b user: jacob tags: trunk | |
| 09:48 | We should wait until the Rlogin server indicates that it's happy to receive window-size notifications before we send them. This clears up a problem where the first password entry always failed. check-in: c05a45ef27 user: jacob tags: trunk | |
|
2005-06-09
| ||
| 05:05 | "SanskritFritz" points out that digits at the start of RTF pastes were being eaten by the trailing "\f0" on the RTF preamble. The RTF spec (1.0 and 1.6) suggests that adding a space should defuse this situation and be otherwise harmless, and it works for me (Win98). check-in: 072eafc3e1 user: jacob tags: trunk | |
|
2005-06-08
| ||
| 10:14 | Double-free on mkdir error, spotted by Brian Hartsock. check-in: 9021e82fe5 user: jacob tags: trunk | |
|
2005-05-28
| ||
| 08:46 | Remove a couple of mistaken references to Telnet in comments. check-in: 28407185fe user: jacob tags: trunk | |
|
2005-05-23
| ||
| 07:41 | Miscellaneous updates: - note Visual Foo version requirements - note which things are done for you in our source snapshots - other tweaks check-in: 2dbc3b7826 user: jacob tags: trunk | |
|
2005-05-21
| ||
| 11:49 | Factor out all local SSH disconnections into a new function ssh_disconnect(), and add the ability to treat a local disconnection as "unclean" -- notably, if we can't agree any authentication methods to even try; someone was complaining that the PuTTY window by default just disappears for no apparent reason in this circumstance. Also, use appropriate disconnect codes for those SSH2_MSG_DISCONNECT messages that we do send. I don't think I've seriously broken any user-visible behaviour, but the way that connection-close distinctions are transmitted to the front-end is shaky (or so it seems to me), so there may be non-ideal changes on some platforms. check-in: e6f29ea107 user: jacob tags: trunk | |
| 10:09 | Fix documentation of NO_MANIFESTS (oops). check-in: 35009b643f user: jacob tags: trunk | |
| 09:35 | Add NO_MANIFESTS option to Windows build, as the manifests apparently cause trouble for 64-bit Windows builds. Also flag the build flags that only apply to Windows. check-in: aa0be5f249 user: jacob tags: trunk | |
| 09:16 | Use {Get,Set}WindowLongPtr() instead of {Get,Set}WindowLong() for compatibility with 64-bit Windows. Untested on 64-bit, but it doesn't appear to have broken anything on 32-bit. check-in: 15d9ec22cf user: jacob tags: trunk | |
|
2005-05-20
| ||
| 16:52 | Minor memory leak spotted by Mikhail Kruk. check-in: 5209b23aff user: jacob tags: trunk | |
|
2005-05-16
| ||
| 09:41 | connection_fatal() should be called after ssh_closing() and other accesses to `ssh', since it potentially frees it and potentially doesn't return. Only affected a couple of rare circumstances. check-in: cd4cc612f7 user: jacob tags: trunk | |
| 03:31 | Don't try and set up reconfigured port-forwardings if the connection isn't yet ready for them. Spotted by Martin Dushkov. check-in: 669d063475 user: jacob tags: trunk | |
|
2005-05-14
| ||
| 17:01 | Add experimental support for detecting BREAK on input and propagating it as TS_BRK on output. This is tested to the extent that other data survive the escaping performed by PARMRK, at least on my system. Actual passing on of BREAK is as-yet untested. check-in: 31fdd0bdc3 user: ben tags: trunk | |
|
2005-05-12
| ||
| 10:09 | Use the packet dispatch table to handle USERAUTH_BANNER messages, which should hopefully solve `drop-banner'. I haven't been able to test the failure case, but the behaviour with OpenSSH appears no worse. check-in: c9089df91e user: jacob tags: trunk | |
|
2005-05-09
| ||
| 16:01 | s/public/private/ spotted by Walter Cleverly. check-in: df8d67a25f user: jacob tags: trunk | |
| 08:27 | Make Makefile.gtk build again on Linux (assume <utmpx.h>). check-in: 298c44bd3c user: jacob tags: trunk | |
|
2005-05-08
| ||
| 06:47 | Fix what looks like a cut-and-paste error which was stopping Unix Plink building on MacOS X. check-in: dc62c29d04 user: simon tags: trunk | |
|
2005-05-06
| ||
| 05:19 | Add `install-sh' to svn:ignore check-in: fca1b751a6 user: jacob tags: trunk | |
|
2005-05-05
| ||
| 17:47 | Correct apparent misspelling of `SIOCATMARK'. check-in: 67721ff97e user: jacob tags: trunk | |
| 17:37 | Implement `bypass-ssh2-userauth', since from correspondence it sounds like there are servers which could in principle operate in this mode, although I don't know if any do in practice. (Hence, I haven't been able to test it.) check-in: a2682d011b user: jacob tags: trunk | |
|
2005-04-30
| ||
| 12:08 | Also blank X authentication data when using SSH-1, and add a comment explaining why this may not be sufficient to hide it. check-in: 56037102d7 user: ben tags: trunk | |
| 11:13 | X11 authentication data are generally sensitive, so blank them from packet logs by default. check-in: 8f27c860e7 user: ben tags: trunk | |
| 09:30 | Unlike the AES and Blowfish code, our implementations of the various DES modes of operation all took separate source and destination pointers. They were never called with those pointers different, though, so reduce them to a single pointer like everything else uses. check-in: 4b8dc4839b user: ben tags: trunk | |
| 09:26 | Fix stupid typo that probably utterly broke SSH-1 support, and caused compiles with GCC to fail. Not sure how it survived long enough to test, really. check-in: 4e40e32ee3 user: ben tags: trunk | |
|
2005-04-28
| ||
| 04:03 | Minimally document 3des-ctr and blowfish-ctr. check-in: 1e5ba103b5 user: ben tags: trunk | |
| 04:00 | Remove comment explaining why 3des-ctr is disabled, since it isn't. check-in: 74d9dcaee0 user: ben tags: trunk | |
| 03:56 | Enable blowfish-ctr by default. It's been tested and found working. Thanks to der Mouse for help with the testing. check-in: e62ce290e8 user: ben tags: trunk | |
| 03:24 | In blowfish-ctr mode, increment the counter in the correct order. Thanks to der Mouse for spotting the same error in my 3des-ctr implementation. check-in: c78d18dbc7 user: ben tags: trunk | |
| 03:21 | Fix two more stupid bugs in 3des-ctr: - We were using the first word of each block of keystream block twice and the second not at all. - We were incrementing the high-order word of the counter after every block rather than the low-order one. With those fixed, our 3des-ctr implementation interoperates with the one in Moussh. Thanks to der Mouse for his help with the testing. 3des-ctr is now enabled by default. check-in: 7b4c6bab9d user: ben tags: trunk | |
|
2005-04-27
| ||
| 16:42 | On monochrome displays, display the cursor in reverse video so that it's visible on reversed out text. This only applies to active block cursors for now. check-in: 58f5d476a6 user: ben tags: trunk | |
| 16:22 | Tiny manual CSE of previous commit. check-in: aa5d4730d1 user: ben tags: trunk | |
| 16:09 | On 1bpp displays, ignore colour attributes. This makes pterm minimally useful there, though (e.g.) switching to using reverse video for the cursor would probably also help. Displays with other silly depths (e.g. 2bpp) aren't catered for, but I suspect they're rare in the X world. check-in: cda1056254 user: ben tags: trunk | |
| 15:30 | Make palette changes use "best match" colours too. check-in: 462bcba811 user: ben tags: trunk | |
| 10:42 | Rather than checking for <sys/sockio.h>, just include it if our other attempts at finding SIOCATMARK have failed. This removes one of our Autoconf tests, which is always nice. check-in: 50cf1a835f user: ben tags: trunk | |
| 07:39 | Use the correct key order for 3des-ctr. check-in: 7e9c015fce user: ben tags: trunk | |
| 06:10 | In SSH-2 mode, PuTTY wasn't sending KEXINIT until it had received one from the server, which led to stalemate if the server did the same. PuTTY now sends KEXINIT proactively as soon as it's worked out that it's talking SSH-2. check-in: d33118fd29 user: ben tags: trunk | |
| 03:09 | mkunxarc.sh is supposed to be silent, so I'm having it discard the stderr output from mkauto.sh. (I debated discarding it within mkauto.sh itself, but decided against it.) check-in: cfbe481de8 user: simon tags: trunk | |
|
2005-04-25
| ||
| 19:03 | According to the termio(7I) on Solaris, OLCUC is overridden by OPOST, so we should send it with the SSH terminal modes too. check-in: 44c192333d user: ben tags: trunk | |
| 18:57 | Squash OPOST locally when we're not in line-editing mode, and propagate the other output flags with SSH. This means that when I log into a remote system using Plink and then run "stty -onlcr" I get the expected stair-stepping. check-in: 58f646b407 user: ben tags: trunk | |
| 18:28 | Use pututxline() in place of pututline(), since the former is standardised by X/Open and actually seems to be more common (NetBSD has it). Also use updwtmpx() rather than directly writing to the wtmpx file, though more for reasons of aesthetics than anything practical. check-in: abb9ed30fb user: ben tags: trunk | |
| 17:46 | Ask GDK to give us reasonable approximations if it can't get precisely the colours we asked it for. This means that I can run pterm on an 8-bit PseudoColor display even if I have another program running. check-in: dfe65fbf2d user: ben tags: trunk | |
| 13:51 | Check for <sys/sockio.h> and include it in uxnet.c if we find it. It's necessary on Solaris if we want to use SIOCATMARK. Using sockatmark() might be preferable, but despite being notionally standard it's missing on Solaris 9 and Mac OS X 10.3.9, whereas everyone seems to have SIOCATMARK somewhere. check-in: 373ac11e25 user: ben tags: trunk | |
| 12:21 | uxpty.c uses non-X/Open facilities (notably strsignal()), so don't define _XOPEN_SOURCE. We do still need _GNU_SOURCE in order to get grantpt() on GNU systems. This allows uxpty.c to compile on NetBSD. check-in: 43bdc0d3b5 user: ben tags: trunk | |
| 11:36 | Move generation of the "configure" script into its own script so that people who check the code out of Subversion can get it to go. check-in: e6535f2a9e user: ben tags: trunk | |
| 10:55 | Add a mechanism for using autoconf to detect the quirks of Unix systems rather than relying on the user to edit the Makefile. Makefile.gtk still works as well as it ever did, but now we get a Makefile.in alongside it. mkunxarc.sh now relies on autoconf and friends to build the configure script for the Unix source distribution. check-in: f4e8b20c96 user: ben tags: trunk | |
|
2005-04-24
| ||
| 09:43 | On some systems (NetBSD 1.6 and Solaris 9, at least), GCC doesn't understand the semantics of assert(0) and believes it can return. Add a gratuitous exit(1) to convince it that this won't happen, and hence quell a couple of warnings about variables' being used uninitialised. check-in: 99e52e867d user: ben tags: trunk | |
|
2005-04-23
| ||
| 11:22 | Now that we've got at least some SDCTR modes working (and aes256-ctr is our default preferred cipher), add code to inject SSH_MSG_IGNOREs to randomise the IV when using CBC-mode ciphers. Each cipher has a flag to indicate whether it needs this workaround, and the SSH packet output maze has gained some extra complexity to implement it. check-in: 98cafbbe9b user: ben tags: trunk | |
|
2005-04-22
| ||
| 10:47 | Stir in process ID at start. check-in: 24f22a29b4 user: jacob tags: trunk | |
|
2005-04-21
| ||
| 19:00 | Change proxy-dns `Auto' default for SOCKS5 from local DNS to remote DNS. SOCKS5 should always be able to do this, and I suspect our not doing so dates from when the SOCKS proxy types were under a single configuration option (pre-r3168). check-in: 2767d1c080 user: jacob tags: trunk | |
| 08:57 | First crack at `terminal-modes' in SSH. PuTTY now sends ERASE by default, Unix Plink sends everything sensible it can find, and it's fully configurable from the GUI. I'm not entirely sure about the precise set of modes that Unix Plink should look at; informed tweaks are welcome. Also the Mac bits are guesses (but trivial). check-in: 533d29650c user: jacob tags: trunk | |
|
2005-04-20
| ||
| 17:52 | Ifdef out the actual code supporting 3des-ctr and blowfish-ctr, since GCC now notices that it isn't used. check-in: b9f8f8776e user: ben tags: trunk | |
| 17:47 | Simon (accidentally, I think) enabled 3des-ctr and blowfish-ctr. Turn them back off again since they're still untested. check-in: 045da486d1 user: ben tags: trunk | |
| 16:29 | Minimally document our support of aes*-ctr. check-in: e9f761c95c user: ben tags: trunk | |
| 15:57 | Enable arcfour256-draft-00@putty.projects.tartarus.org, since I've now tested it against an independent implementation. check-in: e1e36d0b66 user: ben tags: trunk | |
|
2005-04-19
| ||
| 14:18 | Invent a way of specifying control characters numerically in ctrlparse(): ^<27>, ^<0x1B>, ^<033>. (This doesn't tread on any syntax that already had a non-null behaviour.) check-in: d75014453b user: jacob tags: trunk | |
| 13:58 | Pull out parsing of ^C style strings from the terminal answerback code to its own function, since I'll be wanting it for `terminal-modes'. check-in: 8baaaf38f8 user: jacob tags: trunk | |
| 08:27 | Remove "none" from the MACs we offer to support in SSH-2. (It was at the end, after the REQUIRED "hmac-sha1".) This has been present since SSH-2 support was introduced (r569). check-in: 40843350e9 user: jacob tags: trunk | |
|
2005-04-18
| ||
| 16:09 | Add ability to construct SSH-1 packets incrementally (not used yet). I've added this to support `terminal-modes', but since this unifies some SSH-1 and SSH-2 packet construction code, it saves a few hundred bytes. Bonus. check-in: 6ce70c5c20 user: jacob tags: trunk | |
| 07:21 | Add a comment describing `dummyitem' in prefslist and associated problems. check-in: 4556c394db user: jacob tags: trunk | |
| 05:01 | Recent CTR mode changes stopped OS X PuTTY from compiling, because -Werror objects at various static data items being defined but not used. Ifdef some things out to restore warning-free compilability. check-in: 3833248e32 user: simon tags: trunk | |
|
2005-04-15
| ||
| 08:11 | Index "Event Log", "system menu", and "context menu" better. check-in: b833d0f66d user: ben tags: trunk | |
|
2005-04-14
| ||
| 17:58 | Implement my experimental arcfour modes. The 256-bit version is disabled until I can test it against someone else's implementation. check-in: 3782733aa1 user: ben tags: trunk | |
|
2005-04-12
| ||
| 15:04 | Unify GET_32BIT()/PUT_32BIT() et al from numerous source files into misc.h. I've done a bit of testing (not exhaustive), and I don't _think_ I've broken anything... check-in: a434996c3e user: jacob tags: trunk | |