Timeline

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

76 check-ins using file plink.c version 742497658c

2003-08-25
09:30
... and there's a Unix port of PSCP. Ooh. check-in: 7ca13b1af9 user: simon tags: trunk
09:18
Fix a couple of blatant memory leaks; thanks to Ruurd Beerstra for pointing at least one of them out. check-in: 2b5ae5cfd4 user: simon tags: trunk
08:53
Windows PSCP now links against winsftp.c, and scp.c is now a platform-independent source file. Haven't yet added the extra abstraction routines to uxsftp.c to create a Unix PSCP port, but it shouldn't take long. Also in this checkin, a change of semantics in platform_default_s(): now strings returned from it are expected to be dynamically allocated. check-in: 902945de56 user: simon tags: trunk
2003-08-24
08:22
And just to prove that psftp.c really is now platform-independent ... here's a Unix port of PSFTP. Woo. (Oddly PSCP looks to be somewhat harder; there's more Windows code interleaved than there was in PSFTP.) check-in: a9746849d8 user: simon tags: trunk
07:47
Next phase of general SFTP reworking: psftp.c is now a platform- independent source file. All Windowsisms have been moved out to winsftp.c. check-in: cf9dbdd668 user: simon tags: trunk
2003-08-21
14:48
Fix for `slow-startup-printer': use PRINTER_INFO_4 on NT-class systems, which apparently tries less hard to find printers so won't slow the system down. Tested on 2000 and 98; in both cases printer enumeration and printing worked as well as they did in 2003-08-21. Made a single shared copy of osVersion in winmisc.c so that printing.c can find it. Made other users (window.c, pageant.c) use this copy. check-in: 7271667d51 user: jacob tags: trunk
13:39
Richard B's patch to enable users to explicitly request shadow bold by disabling bold-font-name guessing (if their bold fonts are ugly). I've turned the UI inside out, but the meat is pretty much the same. check-in: ff01a069c4 user: simon tags: trunk
13:07
Richard B's patch to support X cut buffers as well as ordinary selections, meaning that (a) a pterm can leave copied text in the cut buffer after it terminates so that applications can pick it up even though it isn't still around to deliver the selection in person, and (b) pterm can pick up things left in this way by other apps. Downside is that all of this only happens in ISO8859-1, because X is weird like that. check-in: 620a90455a user: simon tags: trunk
13:03
Richard Boulton's patch for improved correctness in selection handling (generally, selection request timestamps should be set to the timestamp on the event that caused them). check-in: ca4726e5f8 user: simon tags: trunk
2003-08-07
11:04
Control of 'addr' is now handed over to {platform_,}new_connection() and sk_new() on invocation; these functions become responsible for (eventually) freeing it. The caller must not do anything with 'addr' after it's been passed in. (Ick.) Why: A SOCKS5 crash appears to have been caused by overzealous freeing of a SockAddr (ssh.c:1.257 [r2492]), which for proxied connections is squirreled away long-term (and this can't easily be avoided). It would have been nice to make a copy of the SockAddr, in case the caller has a use for it, but one of the implementations (uxnet.c) hides a "struct addrinfo" in there, and we have no defined way to duplicate those. (None of the current callers _do_ have a further use for the SockAddr.) As far as I can tell, everything _except_ proxying only needs addr for the duration of the call, so sk_addr_free()s immediately. If I'm mistaken, it should at least be easier to find the offending free()... check-in: d318104cf5 user: jacob tags: trunk
2003-07-16
03:28
Clarify that '-m' takes a _local_ file. ref. <kjt9hv49dagqmvru0nq9qcc0f5p11vg0ma@4ax.com> check-in: 0174559f47 user: jacob tags: trunk
2003-07-12
08:45
Add SSH-1 password camouflage bug detection for version OSU_1.4alpha3 of the OSU VMS SSH server <http://kcgl1.eng.ohio-state.edu/~jonesd/ssh/>. The changelog appears to indicate that the server was fixed for pwplain1 at 1.5alpha4, and for IGNORE and DEBUG messages at 1.5alpha6. However I'm going to go on the reports we've had as I haven't tested this; and they indicate only that 1.5alpha6 is known not to require any bug compatibility modes. (I wasn't sure whether to add this at all, given that upgrading to version OSU_1.5alpha6 is an easy way to fix the problem. However, there is precedent for adding detection for old versions of servers which have since been fixed.) check-in: 2cf32ed275 user: jacob tags: trunk
08:25
Add section on "Access denied". This was mostly inspired by the password camouflage problems with SSH-1.5-OSU_1.4alpha3. check-in: 7efa9327f7 user: jacob tags: trunk
2003-07-06
04:34
Mention Roald Ribe's success with OpenWatcom and Makefile.vc check-in: 524b21d095 user: jacob tags: trunk
2003-07-05
06:35
Consider bells as a display event. check-in: 50345c3388 user: owen tags: trunk
2003-06-29
09:47
Phase 1a of SFTP re-engineering: fix the glaring memory and request ID leak in the previous checkin. Oops :-) check-in: 0180a6b327 user: simon tags: trunk
09:26
First phase of SFTP re-engineering. Each base-level fxp_* function has been split into a send half and a receive half, so that callers can set several requests in motion at a time and deal with the responses in whatever order they arrive. check-in: b9024f3254 user: simon tags: trunk
2003-06-28
09:11
Failure to set multipliers[NPRIMES] was rendering the input-modulus feature (make sure your prime is not congruent to Foo mod Bar) largely ineffective. As a result, RSA keys were being generated every so often with at least one prime congruent to 1 mod 37, causing modinv(37, phi(n)) to divide by zero, and rightly so. I believe this fixes `puttygen-zero-div'. check-in: 7806f0f2c6 user: simon tags: trunk
09:10
bignum_mod_short shouldn't be depending on a fixed place value in the bignum data! This wasn't actually causing puttygen-zero-div (its unwarranted assumption was still correct under Windows) but it would have caused the same symptoms under Unix when I got round to porting PuTTYgen. check-in: 17934d0f46 user: simon tags: trunk
02:52
Someone pointed out that ^~ should generate the same as ^^, for consistency with xterm. check-in: 54510097cb user: simon tags: trunk
2003-06-26
10:08
Implement sftp-backend-diagnostic in pscp. check-in: 2cb6a9eb00 user: owen tags: trunk
09:19
Implement hostkey-prompt-type everywhere except Macintosh. check-in: 4f0e9c740b user: owen tags: trunk
08:41
Fix a segfault (non-security-critical - null dereference for reading) in the zlib code when fed certain kinds of invalid data. As a result, ssh.c now needs to be prepared for zlib_decompress_block to return failure. check-in: 0d2defefe0 user: simon tags: trunk
2003-06-25
10:52
Incorporate Brad Clarke's suggestion to use "REGEDIT /EA" rather than "REGEDIT /E". On newer versions of Windows (verified on 2K), this will cause the .REG file to be saved in REGEDIT4 format (ASCII) which can be read by older Windows, rather than REGEDIT5 (Unicode). On older Windows, the extra "A" is harmless (verified on Win98). check-in: c7a798eb4f user: jacob tags: trunk
2003-06-21
18:13
Missing part of my recent SCOANSI fix. check-in: 43df005e0b user: ben tags: trunk
17:40
Improve SCOANSI emulation: The colours that SGR 0 returns to are now changed by the SCO SNF and SNB sequences, which seems to be what the SCO console does (at least in the new mode documented for OpenServer 5.0.6). check-in: c31bb4b658 user: ben tags: trunk
16:19
Oops, Ben got there first. Oh well, here's a comment. check-in: 1fe3821653 user: jacob tags: trunk
15:21
The specific SSH cipher algorithms supported by PuTTY weren't listed anywhere in the documentation. Added some detail - feel free to tweak. check-in: d54cd3d495 user: jacob tags: trunk
14:38
Add comments to case statements containing the mnemonics for the various escape and control sequences. This should make it easier to find the implementation of the one you're interested in. check-in: 0051dbf761 user: ben tags: trunk
14:34
Remove -DNO_SECURITY from the cygwin build, since <aclapi.h> has been available in cygwin for a year and a half. Pointed out by Bruno Kozlowski. check-in: 820c046442 user: ben tags: trunk
2003-06-19
18:04
Fix problem quitting terminal window while Change Settings active check-in: bb5b43fd80 user: owen tags: trunk
15:42
Fix for `double-alt-keystrokes'. Thanks to Leonid Lisovskiy. check-in: fdafcc52a8 user: jacob tags: trunk
2003-06-18
12:25
Make SaneDialogBox and SaneEndDialog use [GS]etWindowLong rather than a global variable. Should mean that pageant builds. check-in: fac607e778 user: owen tags: trunk
2003-06-16
18:55
Fix double-keystrokes by wrapping CreateDialog check-in: f097cec457 user: owen tags: trunk
2003-06-15
17:05
Support for more SCO ANSI escape sequences: CSI = Ps c CSI = Pn1 ; Pn2 C CSI = Ps D CSI = Ps F CSI = Ps G SGR 6 Patch derived from one supplied by Leonid Lisoskiy, with several fixes from me. check-in: caf1367436 user: ben tags: trunk
2003-06-14
13:27
Fix a couple of memory leaks pointed out by Adam Bernstein. check-in: f251013cab user: ben tags: trunk
2003-06-06
13:16
Suggest that local support staff are useful. check-in: e0337d361a user: ben tags: trunk
05:42
Move prototype for platform_new_connection() to a header file so the definitions can be checked against it. check-in: ee0a576001 user: ben tags: trunk
2003-05-27
04:43
Experimental change in the behaviour of `disable alternate terminal screen'. Now it also disables the save-and-restore-cursor behaviour of ESC[?1048h and ESC[?1049h, since these sequences seem to be output by software trying to switch to the alternate screen, and it looks very odd to have the cursor position restored to where it was before `less' when the garbage `less' wrote all over the screen is still around. The `traditional' ESC 7 and ESC 8 still function as normal, on the basis that they aren't usually used in conjunction with the alternate screen. I'm not sure whether this will be the right decision; I'm prepared to change it back if a sufficiently serious counterexample shows up. check-in: 28053f5cb7 user: simon tags: trunk
2003-05-24
14:03
Add exceptions for "VShell" to the ssh.com bug compatibility modes (which are just numbers) in an attempt to fix `vshell-no-bug-compat'. Not even tested a little bit. check-in: 07103bef21 user: jacob tags: trunk
13:02
Fixed accelerator clash between "Conversions" menu and "key comment" control (former is now "Con&versions"). Add shortcut to key fingerprint for ease of copy-and-paste. check-in: 0ef9f00904 user: jacob tags: trunk
07:31
Modified form of Jim Lucas's PC speaker patch. I don't like discriminating on the Windows version in order to decide whether to call MessageBeep(-1) or Beep() - I'd prefer to directly test the specific OS property in any given case - but it looks as if this is the best available option. check-in: ec24b318e6 user: simon tags: trunk
05:57
Incorporate matthew.gabeler-lee's suggested fix for badness with multiple exact hostnames in the proxy exclusion list. <OF63043512.26ABC6B9-ON85256D21.006C33C6-85256D21.006C4B81@EU.novartis.net> check-in: 19dcf6e327 user: jacob tags: trunk
2003-05-22
03:43
Update a couple of bits of the FAQ. We do now default to SSH2, and we do have a Unix port of PuTTY proper. check-in: e699ed6ea4 user: simon tags: trunk
2003-05-14
13:53
Rene Post's other patch: PuTTYgen was generating double file dialogs by mistake. check-in: bea54a66b8 user: simon tags: trunk
2003-05-13
14:57
Real COMPOUND_TEXT support! I was expecting to have to read the spec and implement the required subset of ISO-2022 in libcharset, but it turns out that Xlib provides conversion functions between UTF-8 and compound text, which are just about ideal for us. So now we can paste multilingual stuff both to and from emacs21. Rock on. check-in: f09b9e07b0 user: simon tags: trunk
13:43
Allow pterm to receive selections in compound text format. Doesn't actually _understand_ compound text yet - anything with non-ASCII-or-8859-1 characters will fail miserably - but it will at least successfully receive plain text if the pasting application doesn't see fit to give it out in any other format. check-in: 968a183c28 user: simon tags: trunk
13:23
Rename crc32() to crc32_compute(), to avoid clashing catastrophically with the crc32() function in the zlib interface. (Not that PuTTY itself _uses_ zlib, but on Unix it's linked against libgtk which uses libpng which uses zlib. And zlib has poor namespace management so it defines this ridiculously intrusive function name. Arrrrgh.) check-in: 3bdddd4aca user: simon tags: trunk
13:14
Debian bug #193013 points out that the (default-)one-pixel border is not redrawn when the window background colour is reconfigured mid- session. In addition, the Official Window Background is not reset, meaning that opaque resizes etc will flicker in the old background colour. This checkin should fix both. check-in: 58b0de2d23 user: simon tags: trunk
2003-05-12
08:41
Patch from Rene Post: ctrl_{drag,drop}list both now initialise the same set of structure fields that the ordinary ctrl_listbox does. check-in: 831ebbbfab user: simon tags: trunk
2003-05-11
09:32
Brief man pages for PuTTY and PuTTYtel. check-in: f5b8fd889c user: simon tags: trunk
09:19
Missing full stop. check-in: 475007a30b user: simon tags: trunk
09:19
Some time ago I arranged for -geometry to be able to specify window position as well as size. Now reflected in manpage. check-in: a083cca719 user: simon tags: trunk
07:28
I think I've just fixed Debian bug #166396. The +ut option was causing pty_utmp_helper_pipe to be closed, but its fd was kept around even when stale, and closed again when the main child process terminated - by which time the fd number had been reused for a rather more vital fd, which GTK didn't appreciate having closed under its feet. Hence, spin on POLLNVAL. Should now be sorted. check-in: 3000ac05c2 user: simon tags: trunk
2003-05-10
15:51
Finally, column spanning. check-in: 4801159691 user: ben tags: trunk
15:23
Change the way that panel-switching works so that we only hide the panel we're switching from and show the panel we're switching to, rather than iterating over all the panels, hiding and showing them as appropriate. This has that consequence that all controls have to be created invisible, since they no longer get hidden after creation. As usual, the scroll bars on list boxes have a special hack of their own. check-in: acb67a74ed user: ben tags: trunk
07:54
Make ssh_agent_callback() and ssh_agentf_callback() static. check-in: 4e8c6bdb81 user: ben tags: trunk
07:27
I believe that verify_ssh_host_key() should now be passed a real front-end handle, which removes one of its many flaws. check-in: 05277e0eb1 user: ben tags: trunk
06:57
Extra const for loop_init() and null_init(). check-in: d3d894df55 user: ben tags: trunk
06:50
Eliminate a "possible unintended assignment" warning. check-in: 84bfa51b16 user: ben tags: trunk
06:40
Update signature of agent_query() to match the rest of the world. check-in: 92853bdca9 user: ben tags: trunk
06:26
Comment a few things I need to fix. check-in: a512e8630f user: ben tags: trunk
05:15
Remove the now incorrect `Unicode is not supported' from the bugs in the pterm man page :-) check-in: b41b828c1d user: simon tags: trunk
05:15
pterm will now attempt to guess suitable names for any missing fonts from the ones given; so it'll ask for a font twice as wide as your base one if you don't specify a wide font, it'll ask for a bolded version of your base font if you don't specify a bold font, and similarly for a wide/bold font. Should solve Debian bug #187389; at least it works for me. check-in: d3acdabf8d user: simon tags: trunk
04:06
pterm's manpage now documents the NoRemoteQTitle resource. Should fix the other half of Debian bug #191751. check-in: fb72bd7176 user: simon tags: trunk
04:05
Stupid braino in get_window_title (thanks Colin): window and icon titles were being reported the wrong way round. Should fix half of Debian bug #191751. check-in: d622d5a81e user: simon tags: trunk
03:37
Should fix Debian bug #192674: another gcc complaint about potentially uninitialised variable. check-in: ce4d5b47fb user: simon tags: trunk
03:35
Fixes for Debian bug #192701 (64-bit gccs warn about casts between ptrs and ints of different size and -Werror makes this serious). The GTK bits are done by Colin's patch to use GINT_TO_POINTER (thanks); the uxnet bits are done by cleaning up the rest of the code. In particular, network.h now typedefs `OSSocket' to be a type capable of holding whatever the OS's socket data type is that underlies our socket abstraction. Individual platforms can make this typedef themselves if they define OSSOCKET_DEFINED to prevent network.h redoing it; so the Unix OSSocket is now int. Default is still void *, so other platforms should be unaffected. check-in: e1f861acb0 user: simon tags: trunk
2003-05-08
04:07
Fix a typo in my backwards-compatibility wart. Oops. check-in: 1ca67c7332 user: simon tags: trunk
2003-05-07
08:14
Bah. Stop the Proxy panel appearing empty in Change Settings. One day I'll make a reasonably big checkin and _not_ have six tiny mop- up issues after it... check-in: 1106ef9013 user: simon tags: trunk
07:07
Yesterday's proxy enhancements also slightly nadgered the config box, in that it started to expand under the weight of proxy options. Now fixed, by folding the SOCKS version selector into the general proxy type selector so there's one single 5- or 6-way radio button set split over two lines. settings.c has of course grown a backwards compatibility wart to deal with legacy config data. check-in: e5c791f97a user: simon tags: trunk
03:49
Ahem. Well, the complicated Unix implementation of platform_new_connection() worked fine, but the really simple stub version for the other ports fell over horribly because I got its name wrong. NEVER ASSUME YOU'VE DONE THE EASY BIT RIGHT. check-in: af02c1fbaa user: simon tags: trunk
2003-05-06
14:55
Reinstate `-T title', in pterm only. check-in: 0fed8bc460 user: simon tags: trunk
14:52
Support, on Unix only (so far), for OpenSSH-style generic proxying (running a local command in a pair of pipes and proxying through that, for example `ssh proxyhost nc -q0 %host %port'). check-in: 5f42413627 user: simon tags: trunk
03:43
Update to use -title rather than -T check-in: 3d5f4bd15e user: owen tags: trunk
2003-05-04
09:18
Colin's const-fixing Patch Of Death. Seems to build fine on Windows as well as Unix, so it can go in. check-in: c9f1945192 user: simon tags: trunk