Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
40 check-ins using file windows/winpgnt.c version 44bb813791
|
2010-09-09
| ||
| 09:36 | Missing close() causing resource leak when reading from /dev/random. check-in: 98904e2e61 user: simon tags: trunk | |
| 09:35 | Remove redundant check for NULL in sshfwd_close(). The thing we're testing against NULL has already been dereferenced by the time we bother to test it, so it's a bit pointless - and in any case, no null pointer can come to this function from any existing call site. check-in: f6168ac02d user: simon tags: trunk | |
| 09:32 | Cast incoming characters to unsigned char to avoid accidental sign extension. Since ldisc_send() uses bit 8 as an internal flag, we shouldn't be setting it except when we really want to. check-in: c0b06b69f5 user: simon tags: trunk | |
|
2010-08-10
| ||
| 13:45 | When we disconnect because we have no supported authentication methods left to try, it's nice to have the version of that message going to the client contain the list of methods sent by the server. Saves a user having to pull it out of an SSH packet log. check-in: b79dae693b user: simon tags: trunk | |
| 12:21 | Mass correction of svn:keywords and svn:eol-style properties. check-in: fdf4280859 user: simon tags: trunk | |
|
2010-07-30
| ||
| 15:47 | Cancelling a remote port forwarding that had been refused by the server caused a double-free. Reported and diagnosed by Sven Schaepe. Also fix a minor memory leak in ssh_free(). check-in: 679b1b8e8b user: jacob tags: trunk | |
| 14:45 | A comment typo fix I've had lying around for a while. check-in: 8d38bf5439 user: jacob tags: trunk | |
|
2010-07-04
| ||
| 17:53 | Patch from Alan Ning (somewhat polished by me): introduce a flag called 'pending_close'. This deals with the situation in which we're forwarding a port, have received and locally buffered some data from the local endpoint but not yet been able to pass it down the SSH connection due to window limitations, and then the local endpoint closes its socket. In this situation what we've been doing until now is to immediately send SSH2_MSG_CHANNEL_CLOSE, causing the data still in our local buffer to be lost; now we instead set the new flag, which will remind us to send SSH2_MSG_CHANNEL_CLOSE _after_ we empty our bufchain. Should fix at least one manifestation of 'portfwd-close', though I don't know if it's the cause of all the reports we've ever seen. check-in: d39e55d060 user: simon tags: trunk | |
|
2010-06-29
| ||
| 17:00 | Set WM_TRANSIENT_FOR appropriately on the "about" box so that fvwm doesn't insist on finding a bit of spare screen to put it in. Still pondering whether it's sensible to do this with the "change settings" box as well. check-in: 4600d0085a user: ben tags: trunk | |
|
2010-05-30
| ||
| 17:50 | Move '-w' in the #! line into 'use warnings;' in the Perl code, to simplify the #! line. check-in: c2d1be4c30 user: simon tags: trunk | |
|
2010-05-29
| ||
| 09:04 | 'perl -w' safety in mkfiles.pl. check-in: 4d70ed20bd user: simon tags: trunk | |
|
2010-05-22
| ||
| 09:07 | Restore the configure check for GTK 1, which I accidentally removed as part of r8952 (the patch submitter had done it as a temporary measure and I forgot to undo it before checkin). check-in: 63cb12ddf5 user: simon tags: trunk | |
|
2010-05-19
| ||
| 13:22 | Patch from Alejandro Sedeno, somewhat modified by me, which reorganises the GSSAPI support so that it handles alternative implementations of the GSS-API. In particular, this means PuTTY can now talk to MIT Kerberos for Windows instead of being limited to SSPI. I don't know for sure whether further tweaking will be needed (to the UI, most likely, or to automatic selection of credentials), but testing reports suggest it's now at least worth committing to trunk to get it more widely tested. check-in: d096e14ac5 user: simon tags: trunk | |
|
2010-04-26
| ||
| 12:28 | When doing custom bob builds from a given SVN revision, include the date and time in the About box. check-in: e39ea5f37a user: simon tags: trunk | |
|
2010-04-24
| ||
| 02:14 | Bah, missed out a tiny but build-breaking part of r8926. check-in: cbd85b4490 user: simon tags: trunk | |
|
2010-04-23
| ||
| 13:32 | New SSH bug flag, for 'can't handle SSH2_MSG_IGNORE'. Another user today reported an SSH2_MSG_UNIMPLEMENTED from a Cisco router which looks as if it was triggered by SSH2_MSG_IGNORE, so I'm experimentally putting this flag in. Currently must be manually enabled, though if it turns out to solve the user's problem then I'll probably add at least one version string... [Edited commit message: actually, I also committed in error a piece of experimental code as part of this checkin. Serve me right for not running 'svn diff' first.] check-in: 9c99f25c74 user: simon tags: trunk | |
|
2010-04-12
| ||
| 06:02 | Add comments on OpenSSH AES-encrypted key support, including one mentioning that I haven't yet switched to _exporting_ OpenSSH keys in the new style. check-in: 3b36ea5a90 user: simon tags: trunk | |
| 05:55 | Support importing of new-style OpenSSH private keys (encrypted by AES rather than 3DES). check-in: ef0fbcd9b8 user: simon tags: trunk | |
|
2010-03-25
| ||
| 19:54 | Remove SECURITY_WIN32 (knock-on from r8910, which validates it somewhat). check-in: 137be05b3b user: jacob tags: trunk | |
| 13:41 | r8909 broke the Visual Studio build. check-in: 0fc8f8c9ea user: jacob tags: trunk | |
|
2010-03-24
| ||
| 15:12 | When looking for a local username on Windows, if we can get hold of the NameUserPrincipal, use that; this avoids an issue with SSPI/GSSAPI where the user logged in to the local machine with a different case of username to the (case-sensitive) Kerberos username. Falls back to GetUserName as before if that doesn't work (for machines not on a domain, and Win9x). Based on a patch by SebastianUnger. check-in: 2080e9716a user: jacob tags: trunk | |
|
2010-03-14
| ||
| 13:58 | r8854/5 broke compilation with Gtk 1.2. Grow a hack to cope. check-in: 97d481dae0 user: jacob tags: trunk | |
|
2010-03-13
| ||
| 09:14 | I think r8738 broke IPv6 in MSVC Windows builds due to conflict with the WspiapiGetAddrInfo wrapper for getaddrinfo() in MSVC. Split GET_WINDOWS_FUNCTION into two variants, one with the old behaviour (bypassing the preprocessor) and another with the new behaviour (for ANSI/Unicode, although it's not actually used anywhere currently). check-in: 731886a245 user: jacob tags: trunk | |
| 08:47 | Tweak description of dynamic port forwarding, and point people running into 'Out of space for port forwardings' at it. check-in: 0e44be0bf1 user: jacob tags: trunk | |
|
2010-03-06
| ||
| 09:50 | Centralise generation of the control sequences for arrow keys into a function in terminal.c, and replace the cloned-and-hacked handling code in all our front ends with calls to that. This was intended for code cleanliness, but a side effect is to make the GTK arrow-key handling support disabling of application cursor key mode in the Features panel. Previously that checkbox was accidentally ignored, and nobody seems to have noticed before! check-in: 35aecab820 user: simon tags: trunk | |
|
2010-02-20
| ||
| 13:15 | Unix console utilities should send prompts to /dev/tty or failing that stderr, not to stdout. check-in: d32827a7f2 user: simon tags: trunk | |
| 13:06 | Colin Watson reports that linking with 'gold' doesn't work, because PuTTY makes explicit use of libX11 without including -lX11 on the link line. (GNU ld appears to pull in libX11 automatically because it's needed for the dependencies of GTK, but gold expects that dependency to be satisfied at run time via DT_NEEDED and hence doesn't bother.) Hence, add explicit -lX11 to both Makefile.gtk and the autoconf world. check-in: b7eb6b8ae9 user: simon tags: trunk | |
| 05:21 | Update to r8614: another -D_FORTIFY_SOURCE=2 fix. check-in: a89fe5a769 user: simon tags: trunk | |
|
2010-02-17
| ||
| 13:02 | Null out the socket pointers in X- and port-forwarding channels for which we close the socket without destroying the channel. John Peterson reports periodic crashes under heavy load which appear to be fixed by this, though I don't know the exact circumstances induced by that load. check-in: 40866f6b70 user: simon tags: trunk | |
|
2010-01-25
| ||
| 08:33 | ...and the rest of r8854. check-in: 698420e57a user: jacob tags: trunk | |
|
2010-01-23
| ||
| 06:25 | Our handling of timers in Gtk was truncating times on 64-bit systems; one symptom was that the terminal window would not update until a focus-change event. Spotted and patched by Max Kellermann. check-in: d38cce3d87 user: jacob tags: trunk | |
|
2010-01-17
| ||
| 17:53 | Revert r8847, which was bilge; I can't magically change the order of a tree just by giving a different sorting function to find234(). check-in: c2eb6eced0 user: jacob tags: trunk | |
| 11:27 | It's a new year. check-in: 396c88ece5 user: jacob tags: trunk | |
| 10:22 | Change expiry of timers when their contexts go away from lazy to eager. Intended to be of benefit to derived code making many connections from a single process. check-in: bb1cad5917 user: jacob tags: trunk | |
| 10:20 | Plug a few minor memory leaks, based on a patch by Sirp Potijk. While I'm here, add an assertion in sshrand.c to catch mistakes in reference counting. check-in: fecf1a52c9 user: jacob tags: trunk | |
|
2009-11-22
| ||
| 13:10 | On Windows, character set specifications of the form 'IBM437' would never have worked due to a typo. Spotted by Todd Burkey. check-in: 395ba90760 user: jacob tags: trunk | |
|
2009-11-13
| ||
| 07:24 | Add a keyboard shortcut for the "serial" protocol to the GUI. Will cause non-zero, but hopefully acceptable, disruption to people's finger macros. check-in: b79ee3085f user: jacob tags: trunk | |
|
2009-11-10
| ||
| 13:14 | Patch from Tim Kosse to fix 64-bit-cleanness in SHA-512. check-in: d32d173608 user: simon tags: trunk | |
|
2009-11-08
| ||
| 13:25 | We defined tried_shgetfolderpath but never actually set it. Harmless, but fixed. check-in: e07225584a user: jacob tags: trunk | |
| 13:22 | Use DECL/GET_WINDOWS_FUNCTION in a few more places in place of ad-hoc GetProcAddress(). check-in: de2a5fba6a user: jacob tags: trunk | |