Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
183 check-ins using file mac/macpgkey.c version 32408ae906
|
2010-09-25
| ||
| 02:16 | Cleanups of the GSSAPI support. On Windows, standard GSS libraries are now loaded from standard locations (system32 for SSPI, the registry-stored MIT KfW install location for KfW) rather than using the risky default DLL search path; I've therefore also added an option to manually specify a GSS DLL we haven't heard of (which should in principle Just Work provided it supports proper GSS-API as specified in the RFC). The same option exists on Unix too, because it seemed like too useful an idea to reserve to Windows. In addition, GSSAPI is now documented, and also (unfortunately) its GUI configuration has been moved out into a sub-subpanel on the grounds that it was too big to fit in Auth. check-in: e760173d54 user: simon tags: trunk | |
|
2010-09-15
| ||
| 13:50 | Use the same key for both saving and loading the GSSAPI implementation preference list. Spotted by Daniel Kessler. check-in: cd8bd17f89 user: jacob tags: trunk | |
|
2010-09-13
| ||
| 03:45 | Fix obvious braino in the Windows GSSAPI library display names. check-in: ef13b5d841 user: simon tags: trunk | |
| 03:29 | Create, and use for all loads of system DLLs, a wrapper function called load_system32_dll() which constructs a full pathname for the DLL using GetSystemDirectory. The only DLL load not covered by this change is the one for gssapi32.dll, because that one's not in the system32 directory. check-in: ebb9344ea6 user: simon tags: trunk | |
|
2010-09-09
| ||
| 09:36 | Missing close() causing resource leak when reading from /dev/random. check-in: 98904e2e61 user: simon tags: trunk | |
| 09:35 | Remove redundant check for NULL in sshfwd_close(). The thing we're testing against NULL has already been dereferenced by the time we bother to test it, so it's a bit pointless - and in any case, no null pointer can come to this function from any existing call site. check-in: f6168ac02d user: simon tags: trunk | |
| 09:32 | Cast incoming characters to unsigned char to avoid accidental sign extension. Since ldisc_send() uses bit 8 as an internal flag, we shouldn't be setting it except when we really want to. check-in: c0b06b69f5 user: simon tags: trunk | |
|
2010-08-10
| ||
| 13:45 | When we disconnect because we have no supported authentication methods left to try, it's nice to have the version of that message going to the client contain the list of methods sent by the server. Saves a user having to pull it out of an SSH packet log. check-in: b79dae693b user: simon tags: trunk | |
| 12:21 | Mass correction of svn:keywords and svn:eol-style properties. check-in: fdf4280859 user: simon tags: trunk | |
|
2010-07-30
| ||
| 15:47 | Cancelling a remote port forwarding that had been refused by the server caused a double-free. Reported and diagnosed by Sven Schaepe. Also fix a minor memory leak in ssh_free(). check-in: 679b1b8e8b user: jacob tags: trunk | |
| 14:45 | A comment typo fix I've had lying around for a while. check-in: 8d38bf5439 user: jacob tags: trunk | |
|
2010-07-04
| ||
| 17:53 | Patch from Alan Ning (somewhat polished by me): introduce a flag called 'pending_close'. This deals with the situation in which we're forwarding a port, have received and locally buffered some data from the local endpoint but not yet been able to pass it down the SSH connection due to window limitations, and then the local endpoint closes its socket. In this situation what we've been doing until now is to immediately send SSH2_MSG_CHANNEL_CLOSE, causing the data still in our local buffer to be lost; now we instead set the new flag, which will remind us to send SSH2_MSG_CHANNEL_CLOSE _after_ we empty our bufchain. Should fix at least one manifestation of 'portfwd-close', though I don't know if it's the cause of all the reports we've ever seen. check-in: d39e55d060 user: simon tags: trunk | |
|
2010-06-29
| ||
| 17:00 | Set WM_TRANSIENT_FOR appropriately on the "about" box so that fvwm doesn't insist on finding a bit of spare screen to put it in. Still pondering whether it's sensible to do this with the "change settings" box as well. check-in: 4600d0085a user: ben tags: trunk | |
|
2010-05-30
| ||
| 17:50 | Move '-w' in the #! line into 'use warnings;' in the Perl code, to simplify the #! line. check-in: c2d1be4c30 user: simon tags: trunk | |
|
2010-05-29
| ||
| 09:04 | 'perl -w' safety in mkfiles.pl. check-in: 4d70ed20bd user: simon tags: trunk | |
|
2010-05-22
| ||
| 09:07 | Restore the configure check for GTK 1, which I accidentally removed as part of r8952 (the patch submitter had done it as a temporary measure and I forgot to undo it before checkin). check-in: 63cb12ddf5 user: simon tags: trunk | |
|
2010-05-19
| ||
| 13:22 | Patch from Alejandro Sedeno, somewhat modified by me, which reorganises the GSSAPI support so that it handles alternative implementations of the GSS-API. In particular, this means PuTTY can now talk to MIT Kerberos for Windows instead of being limited to SSPI. I don't know for sure whether further tweaking will be needed (to the UI, most likely, or to automatic selection of credentials), but testing reports suggest it's now at least worth committing to trunk to get it more widely tested. check-in: d096e14ac5 user: simon tags: trunk | |
|
2010-04-26
| ||
| 12:28 | When doing custom bob builds from a given SVN revision, include the date and time in the About box. check-in: e39ea5f37a user: simon tags: trunk | |
|
2010-04-24
| ||
| 02:14 | Bah, missed out a tiny but build-breaking part of r8926. check-in: cbd85b4490 user: simon tags: trunk | |
|
2010-04-23
| ||
| 13:32 | New SSH bug flag, for 'can't handle SSH2_MSG_IGNORE'. Another user today reported an SSH2_MSG_UNIMPLEMENTED from a Cisco router which looks as if it was triggered by SSH2_MSG_IGNORE, so I'm experimentally putting this flag in. Currently must be manually enabled, though if it turns out to solve the user's problem then I'll probably add at least one version string... [Edited commit message: actually, I also committed in error a piece of experimental code as part of this checkin. Serve me right for not running 'svn diff' first.] check-in: 9c99f25c74 user: simon tags: trunk | |
|
2010-04-12
| ||
| 06:02 | Add comments on OpenSSH AES-encrypted key support, including one mentioning that I haven't yet switched to _exporting_ OpenSSH keys in the new style. check-in: 3b36ea5a90 user: simon tags: trunk | |
| 05:55 | Support importing of new-style OpenSSH private keys (encrypted by AES rather than 3DES). check-in: ef0fbcd9b8 user: simon tags: trunk | |
|
2010-03-25
| ||
| 19:54 | Remove SECURITY_WIN32 (knock-on from r8910, which validates it somewhat). check-in: 137be05b3b user: jacob tags: trunk | |
| 13:41 | r8909 broke the Visual Studio build. check-in: 0fc8f8c9ea user: jacob tags: trunk | |
|
2010-03-24
| ||
| 15:12 | When looking for a local username on Windows, if we can get hold of the NameUserPrincipal, use that; this avoids an issue with SSPI/GSSAPI where the user logged in to the local machine with a different case of username to the (case-sensitive) Kerberos username. Falls back to GetUserName as before if that doesn't work (for machines not on a domain, and Win9x). Based on a patch by SebastianUnger. check-in: 2080e9716a user: jacob tags: trunk | |
|
2010-03-14
| ||
| 13:58 | r8854/5 broke compilation with Gtk 1.2. Grow a hack to cope. check-in: 97d481dae0 user: jacob tags: trunk | |
|
2010-03-13
| ||
| 09:14 | I think r8738 broke IPv6 in MSVC Windows builds due to conflict with the WspiapiGetAddrInfo wrapper for getaddrinfo() in MSVC. Split GET_WINDOWS_FUNCTION into two variants, one with the old behaviour (bypassing the preprocessor) and another with the new behaviour (for ANSI/Unicode, although it's not actually used anywhere currently). check-in: 731886a245 user: jacob tags: trunk | |
| 08:47 | Tweak description of dynamic port forwarding, and point people running into 'Out of space for port forwardings' at it. check-in: 0e44be0bf1 user: jacob tags: trunk | |
|
2010-03-06
| ||
| 09:50 | Centralise generation of the control sequences for arrow keys into a function in terminal.c, and replace the cloned-and-hacked handling code in all our front ends with calls to that. This was intended for code cleanliness, but a side effect is to make the GTK arrow-key handling support disabling of application cursor key mode in the Features panel. Previously that checkbox was accidentally ignored, and nobody seems to have noticed before! check-in: 35aecab820 user: simon tags: trunk | |
|
2010-02-20
| ||
| 13:15 | Unix console utilities should send prompts to /dev/tty or failing that stderr, not to stdout. check-in: d32827a7f2 user: simon tags: trunk | |
| 13:06 | Colin Watson reports that linking with 'gold' doesn't work, because PuTTY makes explicit use of libX11 without including -lX11 on the link line. (GNU ld appears to pull in libX11 automatically because it's needed for the dependencies of GTK, but gold expects that dependency to be satisfied at run time via DT_NEEDED and hence doesn't bother.) Hence, add explicit -lX11 to both Makefile.gtk and the autoconf world. check-in: b7eb6b8ae9 user: simon tags: trunk | |
| 05:21 | Update to r8614: another -D_FORTIFY_SOURCE=2 fix. check-in: a89fe5a769 user: simon tags: trunk | |
|
2010-02-17
| ||
| 13:02 | Null out the socket pointers in X- and port-forwarding channels for which we close the socket without destroying the channel. John Peterson reports periodic crashes under heavy load which appear to be fixed by this, though I don't know the exact circumstances induced by that load. check-in: 40866f6b70 user: simon tags: trunk | |
|
2010-01-25
| ||
| 08:33 | ...and the rest of r8854. check-in: 698420e57a user: jacob tags: trunk | |
|
2010-01-23
| ||
| 06:25 | Our handling of timers in Gtk was truncating times on 64-bit systems; one symptom was that the terminal window would not update until a focus-change event. Spotted and patched by Max Kellermann. check-in: d38cce3d87 user: jacob tags: trunk | |
|
2010-01-17
| ||
| 17:53 | Revert r8847, which was bilge; I can't magically change the order of a tree just by giving a different sorting function to find234(). check-in: c2eb6eced0 user: jacob tags: trunk | |
| 11:27 | It's a new year. check-in: 396c88ece5 user: jacob tags: trunk | |
| 10:22 | Change expiry of timers when their contexts go away from lazy to eager. Intended to be of benefit to derived code making many connections from a single process. check-in: bb1cad5917 user: jacob tags: trunk | |
| 10:20 | Plug a few minor memory leaks, based on a patch by Sirp Potijk. While I'm here, add an assertion in sshrand.c to catch mistakes in reference counting. check-in: fecf1a52c9 user: jacob tags: trunk | |
|
2009-11-22
| ||
| 13:10 | On Windows, character set specifications of the form 'IBM437' would never have worked due to a typo. Spotted by Todd Burkey. check-in: 395ba90760 user: jacob tags: trunk | |
|
2009-11-13
| ||
| 07:24 | Add a keyboard shortcut for the "serial" protocol to the GUI. Will cause non-zero, but hopefully acceptable, disruption to people's finger macros. check-in: b79ee3085f user: jacob tags: trunk | |
|
2009-11-10
| ||
| 13:14 | Patch from Tim Kosse to fix 64-bit-cleanness in SHA-512. check-in: d32d173608 user: simon tags: trunk | |
|
2009-11-08
| ||
| 13:25 | We defined tried_shgetfolderpath but never actually set it. Harmless, but fixed. check-in: e07225584a user: jacob tags: trunk | |
| 13:22 | Use DECL/GET_WINDOWS_FUNCTION in a few more places in place of ad-hoc GetProcAddress(). check-in: de2a5fba6a user: jacob tags: trunk | |
| 12:47 | Move the two existing DECL/GET_foo_FUNCTION macro sets used for dynamic linking on Windows into a single global one, which can cope with function renaming. Intended to enable eventual removal of ANSI-specific DoSomethingA references (although I've not removed any). check-in: 10f4a37d77 user: jacob tags: trunk | |
| 12:25 | Improve buffer handling in Windows sk_getaddr() -- we were passing uninitialised storage into WSAAddressToString()'s length function (and presumably getting away with it by luck). Also improve error handling (exposed by my Wine installation, which returns an error from WSAAddressToString() for connections to localhost for some reason). check-in: 6f1dcc5227 user: jacob tags: trunk | |
|
2009-11-01
| ||
| 16:06 | Stop trying to enumerate all the kinds of Windows we support on the download page. Define in more detail what we mean by "Windows" in the Ports section of the FAQ. check-in: 14ddde52f8 user: jacob tags: trunk | |
|
2009-09-27
| ||
| 11:20 | Remove is_shift_pressed() -- it's not been used since r4906. check-in: 63058ec840 user: jacob tags: trunk | |
| 11:07 | Another warning fix and cosmetic tweakage. check-in: 24756eb643 user: jacob tags: trunk | |
| 10:52 | Quell more warnings and, perhaps, avoid alignment faults on 64-bit Windows. check-in: d56656f7b8 user: jacob tags: trunk | |
| 10:31 | Fix some (probably harmless) warnings. check-in: 95f383c5c3 user: jacob tags: trunk | |
|
2009-09-25
| ||
| 18:32 | Change manifest files to declare Windows GUI apps to be "DPI-aware", that is, not fazed by being displayed at other than 96DPI; testing on Vista at a range of DPIs indicates that we cope (with the minor and inevitable exception of the drag-list control). This stops pixel scaling and hence fuzzy display on high-resolution displays. (Hope this is last disastrous than my last set of manifest tweaks! -- <http://support.fogcreek.com/default.asp?copilot.6.26840.1> suggests that this is an OK thing to do.) check-in: e4ebebae53 user: jacob tags: trunk | |
|
2009-09-16
| ||
| 17:28 | Fix minor file descriptor leaks. Found by cppcheck, reported by Tim Kosse. check-in: f22fd7eb98 user: jacob tags: trunk | |
|
2009-09-14
| ||
| 16:26 | Since r7266, it's been possible to get a hostname into Default Settings; but plink did not cope gracefully with this -- it was not possible to override that hostname on the command line (attempts at doing so would be treated as part of the remote command). Fix this by applying the principle of r7265: if the user didn't explicitly specify that they wanted to launch the hostname in the default (for instance with '-load "Default Settings"', we assume they don't want to, and such a hostname doesn't count when deciding whether to treat a non-option argument as hostname or command. check-in: 20880a1ebe user: jacob tags: trunk | |
|
2009-09-13
| ||
| 18:41 | In Unix PuTTY, grey out "Restart Session" when it doesn't apply (as the Windows version does), rather than hiding it completely. check-in: 239594768a user: jacob tags: trunk | |
| 18:37 | Add a couple of ellipses in Unix context menu (like r759 on Windows). check-in: 0a2d6244f2 user: jacob tags: trunk | |
| 18:29 | If there are no saved sessions, put a grayed "(No sessions)" entry on the saved sessions submenu of the terminal window context menu (as Pageant does), rather than an empty menu (which often renders poorly). check-in: 67bc4c7b05 user: jacob tags: trunk | |
|
2009-08-30
| ||
| 08:16 | Avoid compiling autoconf test programs with -Wall -Werror; doing so causes trouble on Ubuntu, where the Gtk test programs don't check the return value from system() and thus fall foul of the combination of our -Werror and <https://wiki.ubuntu.com/CompilerFlags#-D_FORTIFY_SOURCE=2>. check-in: 0516506708 user: jacob tags: trunk | |
| 06:09 | Minor improvements to error reporting in logging. check-in: f5f8c5e862 user: jacob tags: trunk | |
|
2009-08-21
| ||
| 18:25 | Remove outdated comment. check-in: 337a48e8d8 user: jacob tags: trunk | |
| 17:29 | From Corey Stup: when we're declaring stuff for WSAAddressToStringA, we should use the explicitly-narrow type LPSTR, not the switchable type LPTSTR. (Since we currently build without UNICODE this makes no practical difference to us now.) check-in: 911d1f3e09 user: jacob tags: trunk | |
| 16:16 | Corey Stup points out a memory leak in the local-proxy implementations. check-in: d2d15b58f4 user: jacob tags: trunk | |
| 15:05 | Corey Stup points out that any attempt to display the message "Unable to load any WinSock library" will lead to a segfault. check-in: 71f110ef4b user: jacob tags: trunk | |
|
2009-08-18
| ||
| 18:51 | Attempt to filter out duplicate port forwardings in the GUI. check-in: a55940aad5 user: jacob tags: trunk | |
| 18:38 | Fix handling of duplicate port forwardings; they were effectively cancelling out, but are now just ignored. (We should make more effort to prevent duplicates before they get as far as ssh_setup_portfwd() -- it's currently trivially easy to enter them in the GUI and on the command line, let alone both -- but there's bound to be someone with a saved session containing dupes out there by now, and anyway there are duplicates we can't detect before getting this far, for instance "1234:localhost:22" vs "1234:localhost:ssh".) check-in: 16f350f6b0 user: jacob tags: trunk | |
|
2009-08-16
| ||
| 17:51 | Quell "config.status: WARNING: Makefile.in seems to ignore the --datarootdir setting" warning when running ./configure, per <http://www.gnu.org/software/autoconf/manual/html_node/Changed-Directory-Variables.html> check-in: dfb13212a3 user: jacob tags: trunk | |
|
2009-08-15
| ||
| 12:45 | Keep the state of the "Full Screen" menu item on the Ctrl+right-click context menu in sync with reality and the system menu. check-in: 8ce7de2804 user: jacob tags: trunk | |
|
2009-08-13
| ||
| 17:01 | Add "-serial" to Plink's usage message. check-in: db550eade7 user: jacob tags: trunk | |
|
2009-08-10
| ||
| 15:55 | Patch from Alan Clucas (somewhat polished) providing command-line options to select and configure serial port mode. check-in: 8384fb9144 user: simon tags: trunk | |
| 15:38 | Fixes for re-entrant calls in the serial configuration list boxes. (I'm starting to think I made an egregious design error somewhere in this mechanism.) check-in: aa0d4a985b user: simon tags: trunk | |
|
2009-08-06
| ||
| 19:19 | Workarounds for compiling with -D_FORTIFY_SOURCE=2 (as Ubuntu does), which doesn't like you to ignore the return value from read()/write()/etc (and apparently can't be shut up with a cast to void). check-in: c1918bea98 user: jacob tags: trunk | |
| 17:55 | More use of sockaddr_union (above and beyond that necessary to remove current warnings). check-in: a341764006 user: jacob tags: trunk | |
| 17:12 | Avoid "dereferencing pointer 'sa' does break strict-aliasing rules" warnings from recent versions of GCC. check-in: bbcbaf04fd user: jacob tags: trunk | |
|
2009-07-28
| ||
| 18:45 | Alex Besogonov suggests that our Unix autoconf GSSAPI library search order is sub-optimal -- apparently it prefers shishi above Heimdal, and apparently that's bad. check-in: 3e52850b91 user: jacob tags: trunk | |
| 18:30 | Mention Makefile.ux. Be less certain about the possibility of building with vanilla VC6. Provide more details of actively tested toolchains. check-in: 1cf3100f88 user: jacob tags: trunk | |
| 18:20 | Include putty.h (and hence uxconfig.h) before testing for NO_GSSAPI, so that "./configure --without-gssapi" actually works. Spotted by Rob Shinn. check-in: 8a134cc73a user: jacob tags: trunk | |
|
2009-07-12
| ||
| 07:02 | Typo: replace a \i with a \I. check-in: 3c79a67214 user: simon tags: trunk | |
|
2009-06-10
| ||
| 12:42 | Clearing and refilling the code-pages list box can cause a re-entrant call to its handler in config.c, which destroys the previous value in cfg->line_codepage. Therefore, preserve the right value in an automatic variable until all the re-entrant calls have finished. check-in: 456fa805f5 user: simon tags: trunk | |
|
2009-05-11
| ||
| 13:48 | Add a 'unix' Makefile type, for building the non-GUI parts of the PuTTY suite on non-GTK-enabled build platforms. check-in: b60c3e56cd user: simon tags: trunk | |
| 03:46 | Pango-based font handling: combine display of adjacent characters into a single gdk_draw_layout() where conveniently feasible, after some work with xtrace revealed this as a major source of pterm's slow display updates when using client-side fonts. Ideally we ought to be able to do better. I know exactly what sequence of X protocol operations I want to see on the wire, but I don't know how to persuade Pango to generate them. check-in: e576c2c032 user: simon tags: trunk | |
|
2009-04-26
| ||
| 18:44 | Ansgar Wiechers points out that known_hosts (at least OpenSSH's) has grown a means of specifying port numbers, so we should support that. check-in: dec77ca0b0 user: jacob tags: trunk | |
| 18:03 | Discard hashed hostnames from input. check-in: 518f117cbb user: jacob tags: trunk | |
| 17:32 | Reported by Tim Kosse: on Unix, read_random_seed() wasn't correctly checking the return from open() and behaved wrongly in the absence of a seed file. check-in: 5c8bb6b262 user: jacob tags: trunk | |
| 17:19 | Several people have spotted an uninitialised structure member leading to a potential crash on "reget" in Unix PSFTP. check-in: 62f89992d5 user: jacob tags: trunk | |
|
2009-04-24
| ||
| 13:45 | Richard Clark points out a missing check for ssh->mainchan being NULL. check-in: fbeba1f90f user: simon tags: trunk | |
|
2009-04-23
| ||
| 12:39 | When giving authorisation errors from the proxy code in x11fwd.c, name the proxy using the global 'appname' variable, instead of statically calling it PuTTY. (Knock-on effect is that PSCP and PSFTP have to declare that variable, though of course they shouldn't ever actually _use_ the X forwarding code. Probably I ought to replace it with a stub nox11fwd.c for those applications.) check-in: 39f0cd437b user: simon tags: trunk | |
| 12:33 | When starting a SOCKS connection in dynamic forwarding, freeze the local socket _before_ calling the SSH setup functions. This makes no difference to ssh.c itself, but it makes portfwd.c easier to reuse for other purposes (e.g. as a component of a standalone SOCKS server), because now ssh_send_port_open() can itself call pfd_confirm() without the freeze and unfreeze happening in the wrong order. check-in: 08ea874aac user: simon tags: trunk | |
|
2009-03-24
| ||
| 17:24 | Support in the cross-platform code for translating to and from UTF-16 when exchanging wchar_t strings with the front end. Enabled by a #define in the platform's header file (one should not promiscuously translate UTF-16 surrogate pairs on 32-bit wchar_t platforms since that could give rise to redundant encoding attacks), which is present on Windows. check-in: 40cc1bcada user: simon tags: trunk | |
|
2009-03-03
| ||
| 13:57 | Fix cosmetic keyboard-interactive issue: at the end of a normal k-i session, some servers (Debian in particular seems prone to this) send a k-i packet with no prompts and nothing to display. We were printing an extra "Using keyboard-interactive authentication" message in this case. (Introduced by me in r8172, I think.) check-in: 2229b9d9c3 user: jacob tags: trunk | |
| 12:35 | Handle more gracefully the possibility of a keyboard-interactive prompts packet containing no actual prompts (perhaps due to odd server organisation, or perhaps so it can print a banner message and do nothing else). Previously, the get_userpass_input functions always returned failure when in '-batch' mode, even in this case where no actual input would be required. check-in: 628ac4afae user: simon tags: trunk | |
|
2009-02-28
| ||
| 17:04 | Stop using physical tabs in Python. (I was goaded into doing this by my editor, which has defaulted to showing them as explicit ^I for a while now, but it seems like a generally prudent idea in any case.) check-in: 0a7aa358d3 user: simon tags: trunk | |
| 10:52 | Debian bug #517535: we were unconditionally interpreting the 'string' field in a GdkEventKey structure as ISO-8859-1, which was correct for GTK 1.2 but in 2.0 that field is encoded according to the current C library locale. Hence, we now process that field by converting it to UTF-8 via trips through both libc and libcharset, and then let lpage_send() convert from UTF-8 back to whatever it's supposed to actually go down the line in. check-in: d5f3c90afa user: simon tags: trunk | |
|
2009-02-24
| ||
| 16:56 | Fix inaccurate error message. check-in: cfd96a2662 user: jacob tags: trunk | |
|
2009-02-23
| ||
| 19:01 | Since r8305, Unix PuTTY has always "upgraded" an X11 display like "localhost:0" to a Unix-domain socket. This typically works fine when PuTTY is run on the same machine as the X server, but it's broken multi-hop X forwarding through OpenSSH; when OpenSSH creates a proxy X server "localhost:10", it only listens on TCP, not on a Unix-domain socket. Instead, when deciding on the details of the display, we actively probe to see if there's a Unix-domain socket we can use instead, and only use it if it's there, falling back to the specified IP "localhost" if not. Independently, when looking for local auth details in Xauthority for a "localhost" TCP display, we prefer a matching Unix-domain entry, but will fall back to an IP "localhost" entry (which would be unusual, but we don't trust a Windows X server not to do it) -- this is a generalisation of the special case added in r2538 (but removed in r8305, as the automatic upgrade masked the need for it). (This is now done in platform-independent code, so a side-effect is that get_hostname() is now part of the networking abstraction on all platforms.) check-in: d5c507e1ed user: jacob tags: trunk | |
| 16:40 | Stop attempting to make session logs private on Unix. This was introduced in r7084 at the same time as sensible permissions when writing private key files; however, it causes an assertion failure whenever an attempt is made to append to an existing log file on Unix, and it's not clear what "is_private" *should* do for append, so revert to log file security being the user's responsibility. (Fixes Ubuntu LP#212711.) check-in: 6b722846ee user: jacob tags: trunk | |
|
2009-02-03
| ||
| 15:22 | The Windows config option to point at an X authority file is only read at connection setup time, so don't offer it in the Change Settings dialog box. (In particular, this fixes an assertion failure when selecting Change Settings on a non-SSH connection, since wincfg.c would have added that control to Connection/SSH/X11 when the parent panel Connection/SSH didn't exist. Making the control conditional on the selected protocol would have been sufficient to fix that failure, but I now realise that the setting should never have been presented in mid-session in any case.) check-in: 505eceb938 user: simon tags: trunk | |
|
2009-01-21
| ||
| 12:47 | Don't call ReleaseCapture() on any mouse-button-up event. Instead, only call it when the _last_ mouse button comes back up. Otherwise, xterm mouse tracking will lose a button-up event if you press down two buttons, move the mouse outside the window, then release them one at a time. check-in: e7cab95225 user: simon tags: trunk | |
|
2009-01-13
| ||
| 12:18 | Check the two popen() calls in noise_get_heavy for NULL. check-in: 2d54705a73 user: simon tags: trunk | |
|
2009-01-12
| ||
| 14:41 | Patch from Gert-Jan Vons: create an event handle to go in the OVERLAPPED structure in output threads, as we already do for input threads. This apparently sorts out a hanging issue with serial ports when trying to do simultaneous read and write, because (GJV says, and it sounds plausible to me) in the absence of that event object Windows signals the file handle itself to notify GetOverlappedResult that it can return - and since the file handle might be being signalled by a read operation instead, that leads to ambiguity. Using an explicit event object in both directions means Windows always knows which way the data is going. Also a trivial fix in handle_output_new(), which was referencing the wrong element of a union due to a copy and paste error. (Since the result was address-taken and cast to void *, this wasn't a functional error, but it was conceptually wrong.) check-in: d11b0542b8 user: simon tags: trunk | |
|
2009-01-11
| ||
| 08:26 | Arguments to ctype functions are required to be either EOF or representable as unsigned char. This means that passing in a bare char is incorrect on systems where char is signed. Sprinkle some appropriate casts to prevent this. check-in: 099ec87441 user: ben tags: trunk | |
| 08:20 | Propagate my ctype fixes (r8404) from libcharset. check-in: 31f512a4c2 user: ben tags: trunk | |
|
2009-01-09
| ||
| 12:55 | Weaken the assertion in general_textout(). It was failing in the case of double-width text (ESC # 3, ESC # 4, ESC # 6), because the string passed to it was not truncated to the same width as the clipping rectangle. (In fact, it _can't_ reliably be, in the case where the window width is odd.) So instead we just assert that we managed to _at least_ fill the clipping rectangle, not that we exactly filled it. The problem is easily reproduced by sending ESC # 8 (fill the screen with Es) followed by ESC # 3. It doesn't typically happen, though, if you _manually_ fill the screen with Es, because in that case PuTTY's terminal buffer ends up being filled with CSET_ACP | 'E' or similar, which means that general_textout() never gets called because one of the other branches of do_text_internal() does the work instead. ESC # 8 will fill the terminal buffer with genuine _Unicode_ 'E' characters, which exercises the failing code path. check-in: 5e99094c97 user: simon tags: trunk | |
|
2009-01-08
| ||
| 12:21 | Another patch from Colin, providing a "make distclean" target in the autoconf makefile. check-in: 6167ee8ecf user: simon tags: trunk | |
| 12:19 | Colin also suggests that we can replace the backticks in the GTK makefile with make's own $(shell ...) function, which means that gtk-config and krb5-config and so on only get run once per make invocation instead of once per gcc invocation. check-in: 6d8a27ba70 user: simon tags: trunk | |
| 12:18 | Colin Watson reports a strange problem whereby krb5-config incorporates the environment variable CFLAGS into its output. Avoid exporting our version of it from the Makefile (which actually causes build failures, since quoting phase issues mean that the backticks in our version end up unexpanded). check-in: 4cf626f656 user: simon tags: trunk | |
|
2009-01-05
| ||
| 18:25 | Rejig windlg.c:verify_ssh_host_key() to silence a warning. check-in: e26e7e1051 user: jacob tags: trunk | |
| 18:16 | Remove a couple of unused variables. check-in: 021a9a45ae user: jacob tags: trunk | |
| 17:49 | It's a new year (and there have even been checkins). check-in: 3b96830db1 user: jacob tags: trunk | |
| 17:36 | sk_address_is_local() failed to cope when presented with a Unix-domain socket. This could cause Unix PuTTY to segfault when X forwarding over an SSH session through a proxy. (sk_getaddr() wouldn't cope either -- in that case, add an assertion to make it more obvious; I don't think it should ever happen.) check-in: 6691b9082e user: jacob tags: trunk | |
| 16:53 | Be prepared for x11_setup_display() to return NULL (for instance, if DISPLAY has invalid contents). Simply refuse to try X forwarding in this circumstance. check-in: 09b6bc2c14 user: jacob tags: trunk | |
| 13:39 | r5080 didn't go far enough -- since 0.58, anyone on Unix who didn't previously have default settings for "bell overload" mode will have inherited a twitchy set of defaults where bells are disabled after 2ms and enabled after 5ms, rather than 2s and 5s as intended. This error has probably propagated into some people's saved sessions by now, but there's not much to be done. check-in: 961a87a59a user: jacob tags: trunk | |
|
2009-01-04
| ||
| 20:45 | Add some hard-coded textual literal-IP representations of localhost to sk_hostname_is_local(), to catch the case where we're doing something like X11 forwarding over SSH through a proxy, and we've thus disabled local lookup of hostnames. (I think this is what's behind the report in <e9a86996-5dc2-4428-9b0c-c65693ca6351@m32g2000hsf.googlegroups.com> in comp.security.ssh, although I'd like to know more of the circumstances.) check-in: 7bc06e3d51 user: jacob tags: trunk | |
| 19:15 | ...and fix an unlikely memory leak. check-in: d5bdfa2feb user: jacob tags: trunk | |
| 19:01 | Cope with a (non-standard) ENAMETOOLONG return from gethostname(); glibc will do this if the supplied buffer isn't big enough, which shouldn't lead to complete abandonment of X11 auth. (Would only have bitten with hostnames >255 chars anyway.) check-in: 057f0b0fca user: jacob tags: trunk | |
| 17:36 | r8305 made platform_x11_best_transport[] obsolete, but there still seem to be a few instances around; expunge them. check-in: 24aec5eb8d user: jacob tags: trunk | |
| 17:28 | r8305 seems to have made Unix PuTTY rather over-keen on Unix-domain sockets; unless a protocol is explicitly specified with "tcp/foovax:0", it assume a Unix-domain socket, thus not allowing a remote display on a machine other than the client. check-in: ea832c43a2 user: jacob tags: trunk | |
| 16:24 | Bah, I've bumped into this often enough. Change one unsatisfactory cast for another to shut up "warning: cast from pointer to integer of different size" (and hence a -Werror compile failure) when compiling for Unix with DEBUG defined on atreus (x86_64). Minimally checked that it doesn't introduce upset elsewhere (i386). check-in: cd26670299 user: jacob tags: trunk | |
| 15:43 | Log reason for failure to create a connection to a local X display. check-in: ec4e3d53bd user: jacob tags: trunk | |
|
2008-12-29
| ||
| 14:04 | r8338 broke pasting with Shift-Ins and from the context menu on Windows. Divert these to use the request_paste() interface. check-in: 4a0333b4d1 user: jacob tags: trunk | |
|
2008-12-20
| ||
| 13:43 | "Derek" reports that the DECSLPP report of window-size-in-pixels (CSI 14 t) has width and height swapped. Since both a random xterm I have and <http://invisible-island.net/xterm/ctlseqs/ctlseqs.txt> agree with him, I've changed ours. (This stuff appears to originate in dtterm, but I can't check the behaviour of that right now.) While I'm here, the are-we-iconified report (CSI 11 t) looks to have the wrong sense compared to the same sources, so swap that too. (All this has been this way since it was originally implemented in r1414, which doesn't cite a source. all-escapes is silent too.) check-in: 723579ac90 user: jacob tags: trunk | |
| 13:02 | "Derek" points out that reporting of wheel event coordinates to the host on Windows was relative to the screen origin, not the window origin. check-in: 74835487a0 user: jacob tags: trunk | |
| 12:52 | Cosmetic: clarify that term->xterm_mouse is not boolean, etc. check-in: cecf02ac91 user: jacob tags: trunk | |
|
2008-12-02
| ||
| 18:06 | gtk_selection_clear_targets() does not exist on GTK 1, so ifdef it. check-in: 1722b59c4b user: simon tags: trunk | |
| 12:18 | At some point recently, Unix PuTTY started suffering build errors using -DNO_GSSAPI. Move some ifdefs around so it stops. check-in: 449718590d user: simon tags: trunk | |
|
2008-12-01
| ||
| 17:03 | Add missing call to gtk_selection_clear_targets(), without which the list of selection targets offered by GTK PuTTY/pterm grows an extra copy of each of the three supported text formats every time the user makes a selection! check-in: d7ac9e085e user: simon tags: trunk | |
| 15:18 | Change the Unix version of Ssh_gss_name to be a gss_name_t rather than void *, and hence eliminate a few casts. The Windows definition is unchanged, but I daresay I've managed to stop it compiling nonetheless. check-in: 326c946211 user: ben tags: trunk | |
|
2008-11-30
| ||
| 15:35 | As far as I can tell, "simple@putty.projects.tartarus.org" has always been implemented as a channel request, not a global one. Change documentation to match implementation. check-in: 6adcb69429 user: jacob tags: trunk | |
|
2008-11-28
| ||
| 12:28 | Move the code that reads the Windows clipboard into a trivial subthread, so that it won't deadlock if fetching the content of the clipboard turns out to depend on a network connection forwarded through PuTTY. check-in: 9814c17c86 user: simon tags: trunk | |
|
2008-11-26
| ||
| 08:30 | Jacob correctly points out that I accidentally lost a clearing of s->gss_sndtok in r8326. I'm not sure it was strictly necessary, since even if there's no send token, gss_init_sec_context() is meant to explicitly make it empty, but it wasn't an intentional change. check-in: c9729f111e user: ben tags: trunk | |
| 08:11 | Fix a Windows-specific GSS crash introduced in r8326, which (again) apparently triggers in failure cases. Patch by Iain Patterson. check-in: de10671dea user: jacob tags: trunk | |
| 06:49 | Mitigation for VU#958563: When using a CBC-mode server-to-client cipher under SSH-2, don't risk looking at the length field of an incoming packet until we've successfully MAC'ed the packet. This requires a change to the MAC mechanics so that we can calculate MACs incrementally, and output a MAC for the packet so far while still being able to add more data to the packet later. check-in: 4c69183b8d user: ben tags: trunk | |
|
2008-11-25
| ||
| 16:11 | Now that we use real gss_buffer_ts, there's no need to muck about with casts when passing them to GSS-API functions. Removing them makes the code more readable and allows better type-checking. check-in: 972f7f9cba user: ben tags: trunk | |
| 12:54 | Have wingss.c include <windows.h> by way of putty.h rather than directly. Fixes a build failure involving name clashes between winsock2.h and winsock.h, which had somehow managed to get included in succession. check-in: 390169a34f user: simon tags: trunk | |
| 12:43 | Fixed a PuTTYtel startup assertion failure introduced in r8305. While I'm here, a cosmetic PuTTYtel change: remove a reference to SSH from the "logical host name" label in PuTTYtel only. check-in: b1eafe3828 user: jacob tags: trunk | |
|
2008-11-24
| ||
| 17:56 | I think sshgss.h needs puttyps.h for Ssh_gss_buf. Makes it compile for Windows, anyway. check-in: 67d7ae7d6f user: jacob tags: trunk | |
| 17:44 | Change how we handle the Ssh_gss_buf type. Previously, we defined it ourselves, but on Unix then assumed it was compatible with the system's gss_buffer_desc, which wasn't the case on LP64 systems. Now, on Unix we make Ssh_gss_buf into an alias for gss_buffer_desc, though we keep something similar to the existing behaviour on Windows. This requires renaming a couple of the fields in Ssh_gss_buf, and hence fixing all the references. Tested on Linux (MIT Kerberos) and Solaris. Compiled on NetBSD (Heimdal). Not tested on Windows because neither mingw32 nor winegcc worked out of the box for me. I think the Windows changes are all syntactic, though, so if this compiles it should work no worse than before. check-in: 68eb6751c6 user: ben tags: trunk | |
| 12:19 | Treat lines starting with '#' as comments in PSFTP. check-in: 2f3fc67a1b user: jacob tags: trunk | |
| 11:51 | New option to allow use of the local OS username for login to the remote side if we have no better ideas, with UI shamelessly stolen from Quest PuTTY. Off by default, which effectively reverts the change to using the local username by default that came in with GSSAPI support in r8138. Anyone wanting seamless single sign-on will need to set the new option. (The previous default behaviour was getting in the way in ad-hoc scenarios.) Note that the PSCP and Unix-Plink behaviour of using the local username by default have remained unchanged throughout; they are not affected by the new option. Not sure if that's the Right Thing. check-in: ce33b58a4d user: jacob tags: trunk | |
|
2008-11-23
| ||
| 14:11 | Make key file import robust against a PPK file that has somehow lost its final newline. From Debian bug #414784, based on a patch by Justin Pryzby. check-in: fcd0e1e4f9 user: jacob tags: trunk | |
|
2008-11-22
| ||
| 16:49 | Autoconfiscate GSS-API support, including support for manually disabling it. check-in: c502d27121 user: ben tags: trunk | |
| 16:06 | Changes to make this compile on Solaris 9: use <gssapi/gssapi.h> rather than <gssapi/gssapi_krb5.h> and provide the OID for Kerberos 5 ourselves (since it's a known constant). I'm not sure this actually works on Solaris yet, mind. check-in: 37ec80dd2c user: ben tags: trunk | |
|
2008-11-17
| ||
| 12:38 | Revamp of the local X11 connection code. We now parse X display strings more rigorously, and then we look up the local X authority data in .Xauthority _ourself_ rather than delegating to an external xauth program. This is (negligibly) more efficient on Unix, assuming I haven't got it wrong in some subtle way, but its major benefit is that we can now support X authority lookups on Windows as well provided the user points us at an appropriate X authority file in the standard format. A new Windows-specific config option has been added for this purpose. check-in: 8eda1bb259 user: simon tags: trunk | |
| 12:36 | Avoid freeing the backend in notify_remote_exit(), since that's called from within a backend function which will expect its own backend pointer to still be valid on return. Instead, move all the real functionality of notify_remote_exit() out into a GTK idle function. check-in: d576de5599 user: simon tags: trunk | |
|
2008-11-11
| ||
| 01:47 | In SSH packet logging mode, log SSH-2 packet sequence numbers, in both directions. We had a bug report yesterday about a Cisco router sending SSH2_MSG_UNIMPLEMENTED and it wasn't clear for which packet; logging the sequence numbers should make such problems much easier to diagnose. (In fact this logging fix wouldn't have helped in yesterday's case, because the router also didn't bother to fill in the sequence number field in the SSH2_MSG_UNIMPLEMENTED packet! This is a precautionary measure against the next one of these problems.) check-in: e2d3df5243 user: simon tags: trunk | |
|
2008-11-08
| ||
| 10:58 | Implement sk_addr_dup(). check-in: eed2c42118 user: simon tags: trunk | |
| 10:45 | Move out of the SockAddr structure the mutable fields "ai" and "curraddr", and turn "family" into a macro-derived property of the other fields. The idea is that this renders SockAddrs immutable once created, which should open up the possibility of duplicating and reusing one without having to redo the actual DNS lookup. I _hope_ I haven't broken anything. The new code architecture contains several rather dubious-looking operations (namely the arbitrary choice of the first returned address in functions like sk_getaddr and sk_address_is_local - what if, for instance, a DNS lookup returned a local and a non-local address?), but I think they were functionally just as dubious beforehand and all this change has done is to make them more obviously so to a reader. check-in: d1441c22fa user: simon tags: trunk | |
|
2008-10-17
| ||
| 15:55 | Patch from Iain Patterson: fix crash on Windows when GSSAPI auth is attempted but fails for some reason (such as not having a tgt for the server's realm). check-in: a90338986b user: jacob tags: trunk | |
|
2008-10-13
| ||
| 17:34 | Rejig the Translation panel controls and documentation to remove the emphasis on received data. Experiment and suggestion suggest that the character set configuration applies equally to keystrokes sent to the server, or at least that that's close enough to being true that we should document it as a first approximation. check-in: 3a5b181634 user: jacob tags: trunk | |
| 17:16 | Erroneously invisible index term. check-in: ede5168844 user: jacob tags: trunk | |
|
2008-10-12
| ||
| 06:32 | Fix inability to save session on Unix when ~/.putty doesn't exist introduced in r7934. check-in: cbe8f19c30 user: jacob tags: trunk | |
|
2008-10-08
| ||
| 13:09 | Ahem. Make sure I NULL out any unused pointer field that I later plan to free if it isn't NULL. check-in: 040933bf65 user: simon tags: trunk | |
|
2008-10-07
| ||
| 12:48 | sshrsa.c now obeys the RFC793 Robustness Principle when it comes to the ordering of the primes in a fully specified RSA private key: when the key format typically has p > q, it will always output p > q but be willing to tolerate p < q on input. (Inspired by seeing an OpenSSH-format key file in the wild which had p < q, which I've never seen before; I suspect a third-party application incautiously generating the format.) check-in: 1b00ac1adf user: simon tags: trunk | |
|
2008-09-25
| ||
| 14:00 | The "server refused our key" bit didn't link to the public-key auth chapter, which has some hints on server-side setup. Now it does. check-in: 08e05fbf90 user: jacob tags: trunk | |
|
2008-09-21
| ||
| 15:39 | Document that PSFTP's "open" command allows an optional port number. check-in: f83a6f7414 user: jacob tags: trunk | |
|
2008-09-16
| ||
| 17:56 | Further correction: on reflection, after examining all the call sites for uint64_make(), we _shouldn't_ attempt to preserve high bits in the low-order argument; it turns out not to be what the call sites want. check-in: b04b998cac user: simon tags: trunk | |
| 13:21 | 64-bit cleanliness in int64.c. This is all hideous; really I ought to be trying harder to find a 32-bit type rather than making a uint64 structure out of two potentially 64-bit unsigned longs. And really I ought to be using the C99 64-bit integers anyway if they're available. But this should do for the moment. check-in: cde23091b0 user: simon tags: trunk | |
| 07:48 | Tim Kosse points out that xfer_upload_gotpkt can return a negative value on error, so the check at the call site shouldn't test for exactly zero. check-in: 306307fcbb user: simon tags: trunk | |
|
2008-09-14
| ||
| 10:11 | Some Windows keymaps, it turns out, don't translate the key combination Ctrl + \ as the Ctrl-\ character. All of mine have, but at least one laptop turns out not to. Do so explicitly. check-in: 0d25c5708a user: simon tags: trunk | |
|
2008-09-09
| ||
| 15:36 | If we got a keyboard-interactive INFO_REQUEST with an "instruction" string but no actual prompts, we weren't displaying the former, which was wrong. We should now (although I haven't found a server to test it against). check-in: 223743ea02 user: jacob tags: trunk | |
|
2008-09-01
| ||
| 12:56 | Fix punctuation in the large print statements. In particular, one semicolon which crept in in r8138 was causing a lot of the "make install" implementation to be missing from Makefile.gtk. check-in: 7d7ed70323 user: simon tags: trunk | |
|
2008-08-31
| ||
| 16:45 | Good grief. When I originally wrote the local proxy code two years ago, I apparently caused all data received from local proxies to be unconditionally tagged as TCP Urgent. Most network backends ignore this, but it's critical to the Telnet backend, which will ignore all Urgent-marked data in the assumption that there's a SYNCH on its way that it should wait for. Nobody has noticed in two years, presumably meaning that nobody has ever tried to do Telnet over a local proxy in that time. check-in: 6610bc874d user: simon tags: trunk | |
| 14:18 | Colin Watson points out an apparently erroneous cast: Ssh_gss_name and gss_name_t are supposed to be congruent types, so a pointer to one should never be cast to a non-indirect instance of the other. check-in: 784bafd53c user: simon tags: trunk | |
| 12:12 | Minor code cleanup: I just happened to be looking at this file for other reasons and I noticed that the list of TELOPTs is given twice and hence needs to be kept in sync. Replace with my now-standard second-order-macro approach which allows the list to be maintained in only one place. check-in: c592900d31 user: simon tags: trunk | |
|
2008-08-20
| ||
| 17:21 | Fix for portfwd-addr-family: on Unix, when a tunnel is specified as "Auto" (rather than IPv4 or IPv6-only; this is the default), try to open up listening sockets on both address families, rather than (unhelpfully) just IPv6. (And don't open one if the other can't be bound, in a nod to CVE-2008-1483.) Based on a patch from Ben A L Jemmett. check-in: 25ce0f7899 user: jacob tags: trunk | |
|
2008-08-11
| ||
| 13:03 | James has made the URL syntax for http://svn.tartarus.org/ more sensible. Update the FAQ link to it. check-in: 8660ab09c4 user: simon tags: trunk | |
|
2008-08-10
| ||
| 09:28 | Link to pTerm, an SSH client for the iPhone that's apparently based on PuTTY. Attempts at damage limitation from the name similarity with pterm. Also try to refresh the ports section of the FAQ a bit. check-in: 36e8cf9a15 user: jacob tags: trunk | |
| 08:10 | Initial commit of GSSAPI Kerberos support. check-in: 483e1ff871 user: owen tags: trunk | |
|
2008-07-19
| ||
| 11:41 | www.winputty.com check-in: 9e6f8924f9 user: jacob tags: trunk | |
|
2008-07-18
| ||
| 16:39 | Another, subtly different version string for ssh2-bug-maxpkt, from Tim Kosse. check-in: 9b020a65b0 user: jacob tags: trunk | |
|
2008-07-17
| ||
| 12:01 | At least one version of gcc won't figure out that "clear" is never read uninitialised (because the only circumstance under which it isn't initialised is when "update" is FALSE, in which case it isn't read either). Placate it. check-in: dc3f5d00d0 user: simon tags: trunk | |
|
2008-07-11
| ||
| 14:24 | Replicate r8110 from PSFTP to PSCP, and various other minor patchery from Roger Picton. check-in: 85e8a600c9 user: jacob tags: trunk | |
|
2008-07-06
| ||
| 07:24 | Patch from Tim Kosse: check back->exitcode() in both loops on ssh_sftp_loop_iteration(), not just one. Fixes exiting on a negative response to the host key confirmation prompt on Windows (because winsftp.c doesn't have the equivalent of uxsftp.c's no_fds_ok); on Unix it worked already but gave a suboptimal error message, which is fixed too by this patch. check-in: 69902ee8df user: simon tags: trunk | |
| 07:11 | Patch from Tim Kosse to make PSFTP remember to close files on various error conditions. check-in: e85a6b6c59 user: simon tags: trunk | |
|
2008-06-29
| ||
| 04:14 | Patch from Aidan Kehoe to extend the Arabic shaping code to Urdu and Persian, by adding some additional Unicode code points to the shapetypes[] array. check-in: 7ade9c8573 user: simon tags: trunk | |
|
2008-06-15
| ||
| 08:26 | Cosmetic: use `appname' in more places, so that Unix PuTTYtel announces itself thus. check-in: 4de88a2ca4 user: jacob tags: trunk | |
| 07:39 | Exorcise beeps from the Colours pane in Gtk. The colour list box beeped at the user whenever it found that something other than exactly one colour was selected. This seems to happen implicitly in Gtk when the pane is changed. In Gtk1, this gave you a beep whenever you left the Colours dialog after having selected a colour from the list; in Gtk2, you additionally got a beep _every_ time you subsequently re-entered the Colours dialog (for reasons I haven't investigated). Windows was unaffected. Also, in Gtk (unlike Windows), it's possible for the user to go back to the state where no items in the list box are selected at all. For these reasons, stop beeping at the user, and instead blank the RGB edit boxes as a hint that edits to them would be futile. (Really we should be disabling them entirely, but the cross-platform edit controls aren't up to that yet.) check-in: 5f0e743092 user: jacob tags: trunk | |
|
2008-06-11
| ||
| 13:03 | Work around a bug in early versions of GTK (which I'm still forced to use, gah) in which the "model" argument to gtk_tree_selection_get_selected_rows() couldn't be NULL. check-in: 2154cd8b63 user: simon tags: trunk | |
|
2008-06-10
| ||
| 15:18 | Manfred Schwarb points out that scroll wheel support stopped working with the switch to GTK2. This turns out to be because, where GTK1 represented the scroll wheel as mouse buttons 4 and 5 and generated GdkEventButton when it was moved, GTK2 has moved wheel actions out into a new event type GdkEventScroll which we were not handling. Now we do, so scroll wheel support should be back in place. check-in: e42aacd383 user: simon tags: trunk | |
|
2008-06-07
| ||
| 11:30 | Manfred Schwarb also mentions that Alt+drag is captured by at least one well known window manager (KDE's); document that Shift+Alt+drag is worth trying as a workaround. check-in: cc7bc47f00 user: simon tags: trunk | |
| 11:25 | Manfred Schwarb points out that the README contains an outdated comment about GTK 2 not being supported. check-in: 00e544e03f user: simon tags: trunk | |
|
2008-06-05
| ||
| 12:06 | Add an include statement to Makefile.gtk that imports if present a file called Makefile.local. This means that if you're compiling on a platform that needs COMPAT definitions, you can put them in a local file and not have to type them on the command line every time. check-in: 8d02b7f8a5 user: simon tags: trunk | |
|
2008-06-04
| ||
| 18:12 | Bah, there's always something. Check in missing files. check-in: 76e3fc452e user: simon tags: trunk | |
| 18:05 | At last, merge the putty-gtk2 branch back into the trunk! check-in: 8d6cccb962 user: simon tags: trunk | |