Differences From Artifact [c2636dfa5a]:

• File unix/uxpty.c — part of check-in [04c7a24906] at 2013-07-19 13:10:02 on branch trunk — Centralise calls to fcntl into functions that carefully check the error returns. (user: simon size: 30214)

To Artifact [bfe3c96ee9]:

• File unix/uxpty.c — part of check-in [c138704d7f] at 2013-07-21 02:40:28 on branch trunk — When I turned fcntls into noncloexecs in r9940, I missed one. (user: simon size: 30178)

796
797
798
799
800
801
802
803
804
805
806
807
808
809
810

	slavefd = pty_open_slave(pty);
	if (slavefd < 0) {
	    perror("slave pty: open");
	    _exit(1);
	}

	close(pty->master_fd);
	fcntl(slavefd, F_SETFD, 0);    /* don't close on exec */
	dup2(slavefd, 0);
	dup2(slavefd, 1);
	dup2(slavefd, 2);
	close(slavefd);
	setsid();
#ifdef TIOCSCTTY
	ioctl(0, TIOCSCTTY, 1);

|

796
797
798
799
800
801
802
803
804
805
806
807
808
809
810

	slavefd = pty_open_slave(pty);
	if (slavefd < 0) {
	    perror("slave pty: open");
	    _exit(1);
	}

	close(pty->master_fd);
	noncloexec(slavefd);
	dup2(slavefd, 0);
	dup2(slavefd, 1);
	dup2(slavefd, 2);
	close(slavefd);
	setsid();
#ifdef TIOCSCTTY
	ioctl(0, TIOCSCTTY, 1);