Differences From Artifact [2dc8df3696]:

• File ssh.c — part of check-in [911eda30fa] at 2004-10-27 19:23:44 on branch trunk — Malcolm Rowe spotted that we broke display of SSH2_MSG_DEBUG messages while fixing `vuln-ssh2-debug', by missing out a field. In most cases (always_display = 0) we would log a zero-length or truncated message. (Also add a prototype for ssh2_pkt_getbool().) (user: jacob size: 215874)

To Artifact [19cc1ac9e5]:

• File ssh.c — part of check-in [b5c42f2525] at 2004-10-31 18:17:31 on branch trunk — Argh. Failure to make a variable static to get round coroutine mechanics means that each SSH-2 remote tunnel will sfree() something random and thus have a chance of crashing or doing something else bad, although it won't otherwise affect execution. Introduced in 1.319 [r4529] (some of my improved diagnostics). One day I'll make a checkin to ssh.c without forgetting about the coroutines... (user: jacob size: 215881)

5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780

		if (!sport) {
		    logeventf(ssh, "Service lookup failed for source"
			      " port \"%s\"", sports);
		}
	    }
	    if (sport && dport) {
		/* Set up a description of the source port. */
		char *sportdesc = dupprintf("%.*s%.*s%.*s%.*s%d%.*s",
			(int)(*saddr?strlen(saddr):0), *saddr?saddr:NULL,
			(int)(*saddr?1:0), ":",
			(int)(sserv ? strlen(sports) : 0), sports,
			sserv, "(", sport, sserv, ")");
		if (type == 'L') {
		    /* Verbose description of the destination port */
		    char *dportdesc = dupprintf("%s:%.*s%.*s%d%.*s",

|

5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780

		if (!sport) {
		    logeventf(ssh, "Service lookup failed for source"
			      " port \"%s\"", sports);
		}
	    }
	    if (sport && dport) {
		/* Set up a description of the source port. */
		static char *sportdesc = dupprintf("%.*s%.*s%.*s%.*s%d%.*s",
			(int)(*saddr?strlen(saddr):0), *saddr?saddr:NULL,
			(int)(*saddr?1:0), ":",
			(int)(sserv ? strlen(sports) : 0), sports,
			sserv, "(", sport, sserv, ")");
		if (type == 'L') {
		    /* Verbose description of the destination port */
		    char *dportdesc = dupprintf("%s:%.*s%.*s%d%.*s",