Tk Source Code

View Ticket
Login
Ticket UUID: 4a59d535d1c05ba415dbdf694892beda6b5a8b41
Title: Aqua: XFillPolygon() winding rule fill support
Type: Patch Version: 8.6.12
Submitter: chrstphrchvz Created on: 2022-08-09 16:48:12
Subsystem: 82. X11 Emulation Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2022-08-22 19:17:51
Resolution: Fixed Closed By: fvogel
    Closed on: 2022-08-22 19:17:51
Description:

I notice that Aqua implementation of XFillPolygon() currently isn’t affected by [f6e4d4ca30] only because it is hardcoded to use even-odd fill rule (as pointed out by a more recently added comment). Although there is currently no usage of WindingRule in core Tk (and so EvenOddRule is used implicitly), there is nothing stopping an extension from requesting WindingRule, so I believe support should be added, especially since it is trivial to do so; see attached patch (be sure to also use fix for [f6e4d4ca30]).

User Comments: fvogel added on 2022-08-22 19:17:51:
Merged to core-8-6-branch and trunk.

jan.nijtmans added on 2022-08-21 22:05:22:

On Windows, this is already implemented. So, it's an omission this was never done for MacOS. So, +1 for this patch! Thanks!


fvogel added on 2022-08-21 17:06:28:

Thanks, this is indeed easy to add. Patch committed in [a2c68b0bce].


Attachments: