Tk Source Code

View Ticket
Login
2017-01-05
22:32 Closed ticket [dac92f194c]: OS X - text-2.8 and text-2.9 are both run and fail plus 5 other changes artifact: 89eaa80d63 user: fvogel
22:31
Fix [dac92f194c]: OS X - text-2.8 and text-2.9 are both run and fail check-in: 9943305ea2 user: fvogel tags: trunk
22:30
Fix [dac92f194c]: OS X - text-2.8 and text-2.9 are both run and fail check-in: 7e8c4884d3 user: fvogel tags: core-8-6-branch
07:49 Ticket [dac92f194c] OS X - text-2.8 and text-2.9 are both run and fail status still Open with 3 other changes artifact: a43fd2f344 user: fvogel
07:49 Ticket [dac92f194c]: 5 changes artifact: f86eac4543 user: fvogel
07:47
Fix [dac92f194c]: OS X - text-2.8 and text-2.9 are both run and fail Closed-Leaf check-in: 3c69ea3fba user: fvogel tags: bug-dac92f194c
00:27 Ticket [dac92f194c] OS X - text-2.8 and text-2.9 are both run and fail status still Open with 3 other changes artifact: 9b0ab9babe user: bll
2017-01-04
20:54 New ticket [dac92f194c]. artifact: 6624ec47ef user: fvogel

Ticket UUID: dac92f194c7b7330d574bb0d1707a188b0b5e4c7
Title: OS X - text-2.8 and text-2.9 are both run and fail
Type: Bug Version: core-8-6-branch
Submitter: fvogel Created on: 2017-01-04 20:54:34
Subsystem: 86. Test Tools Assigned To: fvogel
Priority: 6 Severity: Minor
Status: Closed Last Modified: 2017-01-05 22:32:10
Resolution: Fixed Closed By: fvogel
    Closed on: 2017-01-05 22:32:10
Description:

On OS X, text-2.8 and text-2.9 are both run and fail.

The strange thing is that text-2.8 is constrained with "aqua" and text-2.9 is constrained by "unix". It seems that OS X has both constraints true.

Note that the results expected from these two tests are mutually exclusive:

==== text-2.8 Tk_TextCmd procedure FAILED
==== Contents of test case:

    catch {destroy .t}
    text .t
    .t tag cget sel -relief 

---- Result was:
flat
---- Result should have been (exact matching):
solid
==== text-2.8 FAILED



==== text-2.9 Tk_TextCmd procedure FAILED
==== Contents of test case:

    catch {destroy .t}
    text .t
    .t tag cget sel -relief 

---- Result was:
flat
---- Result should have been (exact matching):
raised
==== text-2.9 FAILED

The result ("flat") obtained in these two tests seems to have been introduced in [12b024293d2d8e2c], but the expected result in the test was seemingly not changed accordingly (aside of the issue of having both "aqua" and "unix" constraints true).

User Comments: fvogel added on 2017-01-05 22:32:10:
Fix merged into core-8-6-branch and trunk.

fvogel added on 2017-01-05 07:49:30:

OK, thanks for your feedback.

Fix proposed in [3c69ea3fba], following your suggestion for text-2.9, and changing the expected result for text-2.8 since it was apparently not synchronized in 2009 when [12b024293d2d8e2c] was committed.


bll added on 2017-01-05 00:27:16:
unix should always be true on mac os x.
aqua and x11 (i.e. the windowing system) are mutually exclusive.

There's a 'notAqua' constraint in constraints.tcl.
I expect 2.9 should be "unix" && "notAqua".