Tk Source Code

View Ticket
Login
2023-02-06
17:07 Closed ticket [c936def7d3]: New test file errors plus 6 other changes artifact: ab87518cd0 user: griffin
02:29 Ticket [c936def7d3]: 3 changes artifact: 248aa2e009 user: griffin
02:24
Fix for Ticket [c936def7d38]. Filter out Indicator images generated and used by checkbutton and radiobutton widgets. check-in: 5252245d21 user: griffin tags: trunk, main
2023-02-04
15:28 Ticket [c936def7d3] New test file errors status still Open with 4 other changes artifact: 8d6c665c0d user: fvogel
2023-01-30
16:02 New ticket [c936def7d3]. artifact: 251bccf620 user: dgp

Ticket UUID: c936def7d387e43b585a734c4d61c7c2d8be1a57
Title: New test file errors
Type: Bug Version: [200cd8dc]
Submitter: dgp Created on: 2023-01-30 16:02:31
Subsystem: 03. [*button] and [label] Assigned To: griffin
Priority: 5 Medium Severity: Important
Status: Closed Last Modified: 2023-02-06 17:07:49
Resolution: Fixed Closed By: griffin
    Closed on: 2023-02-06 17:07:49
Description:
The recent change to scaling support in some classic buttons causes
test suite to report test file errors.

button.test
Test file error: images remaining: ::tk::icons::9-badge ::tk::icons::error ::tk::icons::question ::tk::icons::!-badge ::tk::icons::1-badge ::tk::icons::2-badge ::tk::icons::3-badge ::tk::icons::4-badge ::tk::icons::9plus-badge ::tk::icons::5-badge ::tk::icons::warning ::tk::icons::information ::tk::icons::6-badge ::tk::icons::7-badge ::tk::icons::indicator0_807e7d_ffffff_ffffff_XXXXXX ::tk::icons::8-badge != ::tk::icons::!-badge ::tk::icons::1-badge ::tk::icons::2-badge ::tk::icons::3-badge ::tk::icons::4-badge ::tk::icons::5-badge ::tk::icons::6-badge ::tk::icons::7-badge ::tk::icons::8-badge ::tk::icons::9-badge ::tk::icons::9plus-badge ::tk::icons::error ::tk::icons::information ::tk::icons::question ::tk::icons::warning
....
nixButton.test
Test file error: images remaining: ::tk::icons::9-badge ::tk::icons::error ::tk::icons::indicator2_807e7d_ffffff_ffffff_221f1e ::tk::icons::question ::tk::icons::!-badge ::tk::icons::1-badge ::tk::icons::2-badge ::tk::icons::3-badge ::tk::icons::4-badge ::tk::icons::9plus-badge ::tk::icons::5-badge ::tk::icons::warning ::tk::icons::information ::tk::icons::6-badge ::tk::icons::7-badge ::tk::icons::indicator0_807e7d_ffffff_ffffff_XXXXXX ::tk::icons::8-badge != ::tk::icons::!-badge ::tk::icons::1-badge ::tk::icons::2-badge ::tk::icons::3-badge ::tk::icons::4-badge ::tk::icons::5-badge ::tk::icons::6-badge ::tk::icons::7-badge ::tk::icons::8-badge ::tk::icons::9-badge ::tk::icons::9plus-badge ::tk::icons::error ::tk::icons::information ::tk::icons::question ::tk::icons::warning
User Comments: griffin added on 2023-02-06 17:07:49:
The tests pass and no errors are reported.
For background reference, this image constraint code originated from ticket [https://sourceforge.net/p/tktoolkit/bugs/2587/].

griffin added on 2023-02-06 02:29:13:
Fixed in [5252245d] by filtering out Indicator images in the image constraint functions.  The alternative is to add image constraint calls in over 500 individual tests.

fvogel added on 2023-02-04 15:28:57:

Brian, since you merged the reported commit [200cd8dc], could you perhaps have a look at this please?

Thanks!