Tk Source Code

View Ticket
Login
2025-10-09
13:01 Ticket [b43dbc0061] nanosvg upstream changes: #273, #275: add paint order parsing status still Closed with 5 other changes artifact: 9cefcca80d user: oehhar
11:16 Ticket [b43dbc0061]: 5 changes artifact: 28d223179e user: nab
2025-10-08
15:10 Ticket [b43dbc0061]: 5 changes artifact: 90815eedd6 user: oehhar
14:58 Ticket [b43dbc0061]: 5 changes artifact: a9162dfd6d user: nab
13:00 Closed ticket [b43dbc0061]. artifact: 72a53d13ae user: oehhar
12:56
[b43dbc00] nanosvg pull request 273 and 275: support svg color order and fix possible nan race condition check-in: c1f0bcf4a4 user: oehhar tags: core-9-0-branch
12:54
[b43dbc00] nanosvg pull request 273 and 275: support svg color order and fix possible nan race condition check-in: 8d4f12e2ff user: oehhar tags: trunk, main
2025-10-07
17:02 Ticket [b43dbc0061] nanosvg upstream changes: #273, #275: add paint order parsing status still Open with 4 other changes artifact: 1e6d3c83ac user: oehhar
16:58 Ticket [b43dbc0061]: 5 changes artifact: ea974bf296 user: oehhar
16:53
[b43dbc00] nanosvg pull request 275: https://github.com/memononen/nanosvg/pull/275 Closed-Leaf check-in: 7894a7060e user: oehhar tags: b43dbc00-nanosvg-pull-273-275
16:44
[b43dbc00] nanosvgpull request 273: https://github.com/memononen/nanosvg/pull/273 check-in: 40a0ea12df user: oehhar tags: b43dbc00-nanosvg-pull-273-275
15:49 Ticket [b43dbc0061] nanosvg upstream changes: #273, #275 status still Open with 3 other changes artifact: 970aa6a2c2 user: oehhar
15:48 New ticket [b43dbc0061]. artifact: 1aede4a9b8 user: oehhar

Ticket UUID: b43dbc00617608043ab799a0fab02dd4b7e1b652
Title: nanosvg upstream changes: #273, #275: add paint order parsing
Type: Bug Version: main
Submitter: oehhar Created on: 2025-10-07 15:48:05
Subsystem: 41. Photo Images Assigned To: oehhar
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2025-10-09 13:01:50
Resolution: Fixed Closed By: oehhar
    Closed on: 2025-10-09 13:01:50
Description:

Implement the following upstram pull requests from nanosvg to image photo svg driver:

User Comments: oehhar added on 2025-10-09 13:01:50:
Ok, great.
THanks,
Harald

nab added on 2025-10-09 11:16:45:
false alarm...
absolutely no complain when compiling trunk on Linux ARM64 with Clang

++

oehhar added on 2025-10-08 15:10:38:

Yes, of cause. The original ticket has discussed that:

https://github.com/memononen/nanosvg/pull/275

and thought, that isnan is better in performance if supported.

You may provide an #ifdef solution for your case and we may propose this also for the upstream project.

I also needed the following for older MS-VC 6-10 compilers https://github.com/tcltk-depot/tksvg/commit/5d3f4951afc0636df026e5dfa1b4e564d10e7203:

/* for MS-VC6-10, define isnan */
#if defined(_MSC_VER) && _MSC_VER <= 1600
#define isnan(a) _isnan(a)
#endif

Thanks and take care, Harald


nab added on 2025-10-08 14:58:05:
Hi,

I'm using Clang to compile Tk everywhere (macOS, Windows, Linux)

in Linux ARM64, I remember that there is a problem with isNan()

is there's any way to diverge from nanoSvg trunk and do not use isNan()?

best regards,
nicolas

oehhar added on 2025-10-08 13:00:28:
merged

oehhar added on 2025-10-07 17:02:25:
Merge proposed to tk branches main, core-9-0-branch and to tknanosvg package.

oehhar added on 2025-10-07 16:58:58:

Changes in branch [b43dbc00-nanosvg-pull-273-275] with commits:

  • 273: [40a0ea12]
  • 275: [7894a706]

Will merge if CI is ok. Please add a note, if any issues.

Thanks, Harald