Tk Source Code

View Ticket
Login
2003-05-20
05:13 Closed ticket [739965ffff]: numerous text test failures (TIP 113?) plus 7 other changes artifact: aea122cc33 user: vincentdarley
04:22 Ticket [739965ffff]: 5 changes artifact: da41193adf user: dkf
04:22 Ticket [739965ffff]: 1 change artifact: 0010405580 user: dkf
01:34 Ticket [739965ffff]: 5 changes artifact: 0eb26efe61 user: vincentdarley
00:30 Ticket [739965ffff]: 2 changes artifact: abefce2218 user: hobbs
2003-05-19
17:14 New ticket [739965ffff]. artifact: 8bc89f3a39 user: dgp

Ticket UUID: 739965
Title: numerous text test failures (TIP 113?)
Type: Bug Version: obsolete: 8.5a0
Submitter: dgp Created on: 2003-05-19 17:14:58
Subsystem: 18. [text] Assigned To: vincentdarley
Priority: 8 Severity:
Status: Closed Last Modified: 2003-05-20 05:13:39
Resolution: Fixed Closed By: vincentdarley
    Closed on: 2003-05-19 22:13:39
Description:
starting with today's HEAD (after TIP 113 commit)
many (~40) tests begin to fail, all with the same
"bad switch" error, for example:

==== text-20.2 TextSearchCmd procedure, -backwards
option FAILED
==== Contents of test case:

    .t search -backwards xyz 1.4

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: bad switch "": must be --, -all,
-backward, -count, -elide, -exact, -forward, -nocase,
-nolinestop, or -regexp
    while executing
".t search -backwards xyz 1.4"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: NONE
==== text-20.2 FAILED

looks like a bug in option parsing for [$text search] ?
User Comments: vincentdarley added on 2003-05-20 05:13:39:
Logged In: YES 
user_id=32170

Can you file a new report with the exact tests that fail and the results. 
For me on Windows, after tip113 only 2 tests fail (subwindow geometry 
ones that I didn't feel confident in adjusting). Before-hand quite a few 
more failed.

thanks.

dkf added on 2003-05-20 04:22:59:
Logged In: YES 
user_id=79902

Fixed all the faults that I've introduced (most of which
were fileable under the heading "Bonehead").  However the
test suite is not passing cleanly for me.  Mind you, my
testing env is *strange* so I can't tell if this is a real
problem.

Over to you, Vince, and remember that not all fonts have the
same metrics...  :^(

vincentdarley added on 2003-05-20 01:34:24:
Logged In: YES 
user_id=32170

Donal's commit appears to have broken all of this, not 
tip113.