Tk Source Code

View Ticket
Login
2022-08-22
19:19
Fix [4a59d535d1]: Aqua: XFillPolygon() winding rule fill support. Thanks to Christopher Chavez. check-in: 5a15a9e944 user: fvogel tags: trunk, main
19:17 Closed ticket [4a59d535d1]: Aqua: XFillPolygon() winding rule fill support plus 5 other changes artifact: 0070631567 user: fvogel
19:17
Fix [4a59d535d1]: Aqua: XFillPolygon() winding rule fill support. Thanks to Christopher Chavez. check-in: 652b1395ed user: fvogel tags: trunk, main
19:16
Fix [4a59d535d1]: Aqua: XFillPolygon() winding rule fill support. Thanks to Christopher Chavez. check-in: f219b2d8bf user: fvogel tags: core-8-6-branch
2022-08-21
22:05 Ticket [4a59d535d1] Aqua: XFillPolygon() winding rule fill support status still Open with 3 other changes artifact: 8f534efc6c user: jan.nijtmans
17:06 Ticket [4a59d535d1]: 5 changes artifact: 57b9865903 user: fvogel
17:04
Fix [4a59d535d1]: Aqua: XFillPolygon() winding rule fill support. Thanks to Christopher Chavez. Closed-Leaf check-in: a2c68b0bce user: fvogel tags: bug-4a59d535d1
2022-08-09
16:57 Add attachment 4a59d535d1c0e.diff to ticket [4a59d535d1] artifact: 7dbf6bfff5 user: chrstphrchvz
16:49 Ticket [f6e4d4ca30] polygon items filled differently depending on platform status still Open with 3 other changes artifact: e0d3c8ee1d user: chrstphrchvz
16:48 New ticket [4a59d535d1] Aqua: XFillPolygon() winding rule fill support. artifact: d0b34d1a46 user: chrstphrchvz

Ticket UUID: 4a59d535d1c05ba415dbdf694892beda6b5a8b41
Title: Aqua: XFillPolygon() winding rule fill support
Type: Patch Version: 8.6.12
Submitter: chrstphrchvz Created on: 2022-08-09 16:48:12
Subsystem: 82. X11 Emulation Assigned To: fvogel
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2022-08-22 19:17:51
Resolution: Fixed Closed By: fvogel
    Closed on: 2022-08-22 19:17:51
Description:

I notice that Aqua implementation of XFillPolygon() currently isn’t affected by [f6e4d4ca30] only because it is hardcoded to use even-odd fill rule (as pointed out by a more recently added comment). Although there is currently no usage of WindingRule in core Tk (and so EvenOddRule is used implicitly), there is nothing stopping an extension from requesting WindingRule, so I believe support should be added, especially since it is trivial to do so; see attached patch (be sure to also use fix for [f6e4d4ca30]).

User Comments: fvogel added on 2022-08-22 19:17:51:
Merged to core-8-6-branch and trunk.

jan.nijtmans added on 2022-08-21 22:05:22:

On Windows, this is already implemented. So, it's an omission this was never done for MacOS. So, +1 for this patch! Thanks!


fvogel added on 2022-08-21 17:06:28:

Thanks, this is indeed easy to add. Patch committed in [a2c68b0bce].


Attachments: