|
2001-09-18
| ||
| 22:15 | • Closed ticket [461801ffff]: build under vc++4.0 plus 7 other changes artifact: b9816be15a user: mdejong | |
| 22:00 | • Ticket [461801ffff]: 4 changes artifact: cd3715ca11 user: hobbs | |
|
2001-09-16
| ||
| 02:24 | • Ticket [461801ffff]: 4 changes artifact: 375e8b64fa user: timmr228 | |
| 01:34 | • Ticket [461801ffff]: 4 changes artifact: cd600493f4 user: nobody | |
|
2001-09-15
| ||
| 23:57 | • Ticket [461801ffff]: 4 changes artifact: e41a3dd125 user: mdejong | |
| 10:40 | • New ticket [461801ffff]. artifact: 7d86ead4c0 user: nobody | |
| Ticket UUID: | 461801 | |||
| Title: | build under vc++4.0 | |||
| Type: | Patch | Version: | None | |
| Submitter: | nobody | Created on: | 2001-09-15 10:40:28 | |
| Subsystem: | 85. Win Build | Assigned To: | mdejong | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2001-09-18 22:15:49 | |
| Resolution: | Rejected | Closed By: | mdejong | |
| Closed on: | 2001-09-18 15:15:49 | |||
| Description: |
undefined ICON_BIG, ICON_SMALL error patch file:tk8.3.3/win/tkWinInt.h. Line 167 /* * Define constants missing from older Win32 SDK header files. */ #ifndef WS_EX_TOOLWINDOW #define WS_EX_TOOLWINDOW0x00000080L #endif +#ifndef ICON_BIG +#define ICON_BIG 1 +#define ICON_SMALL 0 +#endif | |||
| User Comments: |
mdejong added on 2001-09-18 22:15:49:
Logged In: YES user_id=90858 Since we can't really add zmouse.h to Tcl and we don't really support this compiler anymore, I am going to reject this patch. hobbs added on 2001-09-18 22:00:47: Logged In: YES user_id=72656 If zmouse is needed in addition, this really isn't the full patch. Also, I'm not convinced that support for VC4 is still necessary. Unlike Borland which went OSS, VC4 is just old, dead software. It would be nice over time to not need to support every single ancient compiler (just as older CodeWarriors aren't supported for the Mac). timmr228 added on 2001-09-16 02:24:58: Logged In: YES user_id=324662 http://www.microsoft.com/hardware/mouse/intellimouse/sdk/zmouse.h source for zmouse.h nobody added on 2001-09-16 01:34:47: Logged In: NO I also had to grab a file called zmouse.h and throw it in msvc /include dir. I had done that back when I compiled tcl/tk 8.3.2 last year,so it wasn't fresh in mind. I also had to play with paths in makefile.vc, but who doesn't ? That is ALL that I did. mdejong added on 2001-09-15 23:57:26: Logged In: YES user_id=90858 I don't have a problem with this patch but I was under the impression we required at least VC++ 5.0 to build Tcl/Tk. Is this really all that is needed to build with VC++ 4.X again? I seem to remember there were some strange mousewheel header problems the last time I built with VC++ 4.x. | |||