Tk Source Code

View Ticket
Login
2009-07-16
05:07 Closed ticket [2819620fff]: Improvements in Aqua ttk theme plus 7 other changes artifact: 97cbe3a64a user: das
00:07 Ticket [2819620fff]: 4 changes artifact: dcabf33f86 user: das
2009-07-15
22:26 Ticket [2819620fff]: 4 changes artifact: fbb1fc974f user: hobbs
20:46 Ticket [2819620fff]: 4 changes artifact: b55a3e8096 user: wordtech
10:00 Ticket [2819620fff]: 4 changes artifact: e96b81a737 user: das
09:59 Add attachment ttkMacOSXTheme-ModernTabs.diff to ticket [2819620fff] artifact: 101af99ed0 user: das
09:59 Ticket [2819620fff] Improvements in Aqua ttk theme status still Open with 1 other change artifact: 775ca5c7d4 user: das
09:58 Ticket [2819620fff]: 4 changes artifact: 00400a0fa1 user: das
2009-07-10
20:59 Ticket [2819620fff]: 4 changes artifact: 53ee717eab user: wordtech
20:59 Add attachment ttkMacOSXTheme.patch to ticket [2819620fff] artifact: c7978e641b user: wordtech
13:59 New ticket [2819620fff] Improvements in Aqua ttk theme. artifact: 29c10ddc22 user: wordtech

Ticket UUID: 2819620
Title: Improvements in Aqua ttk theme
Type: Patch Version: None
Submitter: wordtech Created on: 2009-07-10 13:59:28
Subsystem: 66. Aqua Window Operations Assigned To: das
Priority: 7 High Severity:
Status: Closed Last Modified: 2009-07-16 05:07:01
Resolution: Fixed Closed By: das
    Closed on: 2009-07-15 22:07:01
Description:
This patch to ttkMacOSXTheme.c: makes two improvements to the Aqua ttk theme:

1. It fixes the "selected" state of the ttk::treeview column header to render in standard "Aqua" blue only. Previously the "selected" state rendered in the "Aqua" blue and also drew an "up" arrow without a corresponding "down" arrow if the column header were clicked on. This change allows the appropriate  up/down arrow to be implemented at the script level, if necessary. The result is a more-native appearance under Aqua. 

2. It modernizes the appearance of the notebook tab under Aqua, cf http://www.codebykevin.com/mac-tabs.png, to use the style that became the system standard in Mac OS X 10.3, released in 2003. Previously the notebook tabs were drawn with an older style that is no longer widely used.
User Comments: das added on 2009-07-16 05:07:01:

allow_comments - 1

committed to CVS HEAD and backported to de-carbon-8-5 branch in git repo

das added on 2009-07-16 00:07:39:
I believe [ttk::style theme use] was just not backported to 8.5, I'll replace it with [wm windowingsystem] on 8.5 (which is slightly incorrect but most users won't change the default theme anyway in the demo)

hobbs added on 2009-07-15 22:26:04:
Point 4 is not correct.  The 'ttk::style theme use' should be correct in 8.6, but may or may not have been backported to 8.5.  However, that command does not return 0/1, it will error, so the alternative is definitely not right.

wordtech added on 2009-07-15 20:46:04:
1. Modern notebook appearance works correctly.
2. ttk::treeview arrows/header work as expected with up and down arrows.
3. Changes to ttk::treeview work correctly with updates in Tablelist widget to draw headers with "selected" state with arrow added at script level by Tablelist.
4. One minor update to mclist.tcl. Line 115, "if {[ttk::style theme use] eq 'aqua'"} causes an error: the "style theme use" command is looking for the name of a theme. Changing this line to 
     if {[ttk::style theme use aqua] == 0} {
gets the demo working correctly. Please update the diff. 

With the final adjustment to mclist.tcl, this is ready to commit.

das added on 2009-07-15 10:00:00:

File Added - 335086: ttkMacOSXTheme-ModernTabs.diff

das added on 2009-07-15 09:58:59:
revised patch attached, adding the following features:
- ttk:treeview: both "selected" and "alternate" states draw unadorned highlighted treeheaders, except when "user1" state is also set, in which case "selected" draws the header with down arrow and "alternate" the header with up arrow
- mclist demo updated to use the native sort arrow support when aqua theme is active
- modern notebook appearance corrected to vertically center tabs on groupbox. Adjusted internal & external padding of notebook and of tabs to match InterfaceBuilder. Added tabmargins to ensure minimal amount of groupbox is shown next to tabs.

Please verify this works correctly for you, will commit tomorrow if I hear no objections

wordtech added on 2009-07-10 20:59:29:

File Added - 334515: ttkMacOSXTheme.patch

Attachments: