Timeline
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

64 events for the month beginning 2018-09-01 by user wyoung

Following month ↑
2018-09-26
18:45
"New Message" -> "New Thread" in forum. check-in: e11d391711 user: wyoung tags: trunk
18:39
Setup and Admin users that are in the subscriber table were getting email alerts only if they had explicit moderator capabilities set. Those with bare "s" or "a" weren't getting notified. check-in: 1d3dd1d917 user: wyoung tags: trunk
2018-09-22
17:02
Added a check for ns_parserr(), which we currently don't know how to find on OpenBSD. This also fixes a logic error in auto.def which would cause the warning that this feature won't be compiled to not be given. check-in: f99e76324c user: wyoung tags: libbind-ns-alternative
16:55
Removed the "Linux" platform test from the DNS MX stuff in src/smtp.c. You should always test for features, not platforms, and we've now got the feature tests we need to replace this too-broad platform test. check-in: 5358fe9563 user: wyoung tags: libbind-ns-alternative
16:38
Replaced the call to the undocumented ns_name_uncompress() function with dn_expand(), which is documented, at least on OpenBSD, and it's shorter. Then made ns_name_uncompress() and __ns_name_uncompress() fallbacks for this, with suitable autosetup tests for all of it. check-in: d0fb5ac7ca user: wyoung tags: libbind-ns-alternative
06:46
The previous checkin on this branch prevented src/smtp.c from both building and linking because the code previously assumed that it could only build against libresolv for MX lookups and such on Linux, but the checkin gave it enough slack to *attempt* to build on macOS. This checkin prevents that from happening if run on stock macOS, but if you ins... check-in: 4d9970f618 user: wyoung tags: libbind-ns-alternative
05:47
Added autosetup checks for alternative libraries and names for the res_query() and ns_*() functions that module smtp.c previously depended on finding in libresolv/glibc. Checking it in on a branch because it needs multiplatform testing. This version solves the problem originally reported on the forum by Andy Goth, being that the current trunk doe... check-in: ed3b1e4d89 user: wyoung tags: libbind-ns-alternative
00:54
Second attempt at blockquote styling, this time restricting it to forum posts only. (Previous: [2190f86c324d0]) check-in: c285cd0812 user: wyoung tags: trunk
2018-09-21
18:05 Ticket [c4677b052b] Make "help" command smarter to reduce the need for "-a" option status still Open with 6 other changes artifact: 0b6a3cafae user: wyoung
17:56 Ticket [683457aa0f] localtime on server not syncronized. "strange" behaviour in fossil status still Open with 4 other changes artifact: 8c9f5e9594 user: wyoung
17:43 Ticket [c541b6e734] Allow tech notes to have binary attachments, with CLI support status still Open with 6 other changes artifact: 704a99f3bc user: wyoung
01:52
Replaced the "hasOwnProperty" test for CSS transition support in the animated hamburger menu JS code with a better test that not only works on old IE but also on some truly ancient versions of SeaMonkey, Firefox, Chrome, etc. check-in: ee074372e8 user: wyoung tags: trunk
2018-09-20
11:21
Fixed the panel.style.hasOwnProperty() test in the default skin's js.txt so that it will work on IE8 and below. See code comment for rationale. check-in: e54095f9af user: wyoung tags: trunk
2018-09-17
09:47
Wiki markup fixes in the recent edits to the www/forum.wiki doc check-in: 079431525d user: wyoung tags: trunk
09:40
Removed a paragraph stranded by the email docs reorg several checkins ago. check-in: ba35b5ff31 user: wyoung tags: trunk
09:33
Fixed a typo check-in: 692aceed4b user: wyoung tags: trunk
08:20
Added colored shading, more padding, and a thick left border to
elements in the default skin. This is based on some custom styling that Florian Balmer has been doing for quoted text on the forum lately, but the styling is rather different. It affects all such elements, not just those in forum posts, since I couldn't see a good reason...
check-in: 2190f86c32 user: wyoung tags: trunk
02:58
Updated the documentation permuted index to include a grammar fix checked in with the previous checkin. check-in: d8d979fee5 user: wyoung tags: trunk
02:57
Reworked the documentation for email alerts to put all the information in a single document: a) Moved the "quick email setup" material from the forums.wiki document into `alerts.md`; b) linked to that moved material from its original location; c) greatly expanded the material previously present in the `alerts.md` document; c) merged the `emaildesig... check-in: 2ef70be2f7 user: wyoung tags: trunk
2018-09-16
21:14
Replaced the WIP and indefinite future paragraphs in www/alerts.md with definite statements now that we're approaching release. check-in: 05b4082915 user: wyoung tags: trunk
2018-09-15
17:37
Added www/forum.wiki to the documentation index. check-in: 7bd7b2c6c7 user: wyoung tags: trunk
2018-09-12
13:39
Removed the anti-robot defense stand-down call from the default skin's new footer JS: that's handled server-side now with /sitemap?popup=1. check-in: 7d5ff435ff user: wyoung tags: trunk
13:20
Added copyright and license comment to the top of the new skins/default/js.txt file. check-in: 972ae10b30 user: wyoung tags: trunk
12:33
Avoided a divide by 1000 by changing a value formerly specified in floating point seconds to be specified in milliseconds, so we don't need the arithmetic. check-in: 1d5eea6669 user: wyoung tags: trunk
12:32
Moved a single-use variable interpolation inline with its use point. Also improved some comments. check-in: 56db6170e8 user: wyoung tags: trunk
2018-09-10
13:41
Added a guard on the use of CSS transitions so it falls back to a non-animated menu pull down if they appear not to be available on the current browser. Also added a check for the existence of the hamburger menu item in case the skin admin diked it out, and did a few other minor tweaks to the footer JS code. check-in: 5d9a345481 user: wyoung tags: js-hamburger-menu
10:01
Timing tweaks: made "hide borders" hack occur about the same time as the CSS transition finishes, and increased the menu show delay still further to make it work for Firefox. check-in: 7bb68023bd user: wyoung tags: js-hamburger-menu
09:30
Changed hamburger menu drop-down menu from 33% of the screen width to 90%: it works better on small screens, and it allows the sitemap to go multi-column on wider screens. Also added some right-side padding to balance the padding added for
    on the left.
check-in: e76a243da9 user: wyoung tags: js-hamburger-menu
09:27
Removed the
wrapping
    and moved the multicolumn styling applied to it down to the
      , since it is already a block level element, so we don't need a div wrapper on it. And then there's the real reason, which is that we want the multicolumn styling to work on the drop-down hamburger menu version as well.
check-in: 0d391a1ba5 user: wyoung tags: js-hamburger-menu
09:02
Increased the transition delay to make the initial drop-down animation happen in Firefox 62. check-in: 8918a8a80a user: wyoung tags: js-hamburger-menu
08:48
Using CSS transitions to mimic jQuery's slideUp/Down() transitions. This probably restricts browser compatibility still further above the XHR issue noted in the earlier checkin on this branch. According to MDN, we're probably restricted to IE 10+ with this, and maybe not even that due to not using vendor-specific extensions for the transitional br... check-in: 90bd66750d user: wyoung tags: js-hamburger-menu
07:22 Edit [113ba3d9deb2e77d|113ba3d9de]: Edit check-in comment. artifact: bae3c8bf29 user: wyoung
07:20 Edit [d7c43c5aa7761cbc|d7c43c5aa7]: Move to branch js-hamburger-menu. Edit check-in comment. artifact: 486aebbac7 user: wyoung
07:17
Converted JS hamburger button menu code to use standard JS only, no jQuery.

Temporarily lost the animation with this change: I'm checking this in separately to make the difference between this and the jQuery version clearer.

Not sure how portable it is yet; I wouldn't be surprised if it broke on old IE, since we're using xhr.onload instead... check-in: 113ba3d9de user: wyoung tags: js-hamburger-menu

2018-09-09
17:42
Merged in trunk improvements check-in: 96b1a9ca4d user: wyoung tags: js-hamburger-menu
17:41
Reverted [59c7ca0509]: drh says we can't use jQuery. Also, there was a syntax error that sent all hyperlinks to the honeypot in some conditions. check-in: 5a62b395ed user: wyoung tags: js-hamburger-menu
2018-09-06
03:56
The hyperlinks in the hamburger menu drop-down still had the anti-robot defense activated. Defeated it. check-in: 571df2e8b4 user: wyoung tags: js-hamburger-menu
03:56
Converted src/href.js to jQuery as a demonstration: the code's nearly half the size, and it's clearer as a result. check-in: 59c7ca0509 user: wyoung tags: js-hamburger-menu
03:06
Typo fix; patch by jungleboogie in forum post ID 775e4c0771. check-in: c8ef388b28 user: wyoung tags: trunk
2018-09-05
23:46 Edit [e806e5c4df71f2e9|e806e5c4df]: Edit check-in comment. artifact: 3482f20b18 user: wyoung
23:45
Fixed a bug in the onclick handler for the new hamburger button which allowed the browser to follow our empty 'a href="#"' link. For some reason, Chrome only did this sometimes, not always, which lead to me thinking it was some kind of race condition. check-in: e806e5c4df user: wyoung tags: js-hamburger-menu
23:08
Ajaxy animated drop-down menu on clicking a new hamburger button in the default skin, as requested by drh on the forum: https://fossil-scm.org/forum/forumpost/40a18bd742

Initial version uses jQuery loaded from Google Hosted APIs for ease of development. check-in: d7c43c5aa7 user: wyoung tags: js-hamburger-menu

2018-09-04
12:10
Added more info on quoting rules in Tcl/TH1 to the th1.md doc check-in: 30e9ccd59d user: wyoung tags: trunk
11:59
Fixed some grammar and spelling in the th1.md doc. check-in: 40787f5011 user: wyoung tags: trunk
2018-09-03
07:40
Calling db_end_transaction() from the early-exit code paths of setup_skin_admin() to avoid "Transaction started at ./src/skins.c:466 never commits" complaints with some types of Admin -> Skins edits. check-in: 1c0b78b451 user: wyoung tags: trunk
07:06
Merged wrap-run_in_checkout branch down to trunk. check-in: 49e86fe0a8 user: wyoung tags: trunk
06:27
The test harness now skips all tests done in the Fossil source repo checkout directory while there are uncommitted changes because that will affect the behavior of fossil status, fossil diff, etc., which in turn tends to create false positives in test harness code that checks for changes in fossil command output. Closed-Leaf check-in: 78ec683882 user: wyoung tags: wrap-run_in_checkout
06:22
Partially reverted one of the run_in_checkout replacements in test/th1.test: it was inside a foreach loop, which means the test for whether we're inside the Fossil repo checkout was being done 26 times. This is not only inefficient, it spammed the output with "Skipping test blabla..." lines. Now doing a manual check outside the loop and skipping t... check-in: 3cb1b4f0a4 user: wyoung tags: wrap-run_in_checkout
06:19
Fixed a Tcl syntax error checked in with [33efa2fa]. (Yay dynamic languages that run the code even if it's syntactically invalid. P'tui!) check-in: 4315d46462 user: wyoung tags: wrap-run_in_checkout
06:15
The new test_block_in_checkout proc in tester.tcl was not setting the CODE and RESULT global variables when it skipped a test, so there was a chance that a test would end up checking the prior values and throw a false positive. check-in: 2aaee4841e user: wyoung tags: wrap-run_in_checkout
06:13
Fixed a Tcl logic error committed with [33efa2fa]. check-in: 024305978f user: wyoung tags: wrap-run_in_checkout
02:57
Extracted the logic that was in tester.tcl's new outside_fossil_repo proc to the global level which just saves the result to a global variable so the logic doesn't have to be re-run for each test that relies on it. The result doesn't change from one call to the next, as you'd hope for a proc without parameters. check-in: 1a4e87dcc1 user: wyoung tags: wrap-run_in_checkout
00:40
Replaced most of the direct calls to run_in_checkout from within the test suite with one of two wrapper functions that skip those tests when you run "make test" outside a Fossil repository checkout directory, such as from a directory containing an unpacked source release tarball. (The two remaining direct calls to that proc from test/*.test are pr... check-in: 33efa2fa05 user: wyoung tags: wrap-run_in_checkout
00:24
The -quiet flag passed by default to tester.tcl can now be overridden by passing TESTFLAGS to make. Before, there was no way to set -verbose this way because "-quiet -verbose" means the same thing as "-quiet". check-in: 401a4c3d46 user: wyoung tags: trunk
2018-09-02
23:05
Cached the result of "$tcl_platform(platform) eq "windows"" in test/tester.tcl and replaced all of the repetitions of this expression with a test of the variable. check-in: 2e4143aa4b user: wyoung tags: trunk
21:51
Removed a debug message accidentally checked in. check-in: 8eadf4c428 user: wyoung tags: trunk
21:47
Merged tclsh-macos down to trunk. check-in: ee2ffe3599 user: wyoung tags: trunk
21:46
Fixed an incorrect Tcl string comparison checked in with [e449cb09]. Closed-Leaf check-in: c94617b57d user: wyoung tags: tclsh-macos
21:40 Edit [e449cb09c18004ed|e449cb09c1]: Move to branch tclsh-macos. artifact: e94785c23f user: wyoung
21:00
Explained "Why can't we use Jim Tcl for the test suite?" in the auto.def comment above the check for a suitable tclsh version. Basically, I tried it and then documented a few of the resulting failures. check-in: 91eaef6131 user: wyoung tags: tclsh-macos
20:33
After autosetup checks for the existence of tclsh in the PATH, it now checks whether it's at least version 8.6, because macOS is still shipping 8.5, despite it being nearly 6 years old. If we find an old tclsh, try to find the Homebrew tcl-tk package, and use that version instead. This is not a macOS or Homebrew specific change in principle: we c... check-in: e449cb09c1 user: wyoung tags: tclsh-macos
2018-09-01
20:56 Edit [6f87b4af085be3f7|6f87b4af08]: Edit check-in comment. artifact: 27d77bff53 user: wyoung
20:49
Noted the responsive design changes to the default skin in the change log. Expanded on the forum and alerts feature items. Changed all the past-tense verbs to present tense to match the rest of the items and the prevailing style in past change log entries. check-in: 6f87b4af08 user: wyoung tags: trunk
20:19
Added "overflow-y: hidden;" to the CSS for the default skin to prevent some browsers (Chrome, Firefox, and Safari on macOS, at least) from adding a vertical scroll bar to the navbar. This was only necesasry on this skin because of the recently-added "overflow-x: auto" style, which tells the browser to clip or horizontally-scroll the navbar if the ... check-in: e8783b9aa2 user: wyoung tags: trunk
Previous month ↓