Check-in [095333fc60]
Not logged in

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix to previous for the "non-constant format" complaint from some compilers. I can't see what they're yelling about, but this fixes it.
Timelines: family | ancestors | descendants | both | login-on-post
Files: files | file ages | folders
SHA3-256:095333fc603f655af1c65e7159113321184689fdeb41d6dc21a707272de2f112
User & Date: wyoung 2018-11-09 19:11:26
Context
2018-11-09
19:16
Another attempt to fix non-constant format complaint. Closed-Leaf check-in: 725630f3f8 user: wyoung tags: login-on-post
19:11
Fix to previous for the "non-constant format" complaint from some compilers. I can't see what they're yelling about, but this fixes it. check-in: 095333fc60 user: wyoung tags: login-on-post
18:52
The "New Thread" button in /forum is no longer restricted to those with forum write capability: if you lack it, we now send you to the login page instead. Without this, users without the capability to post are left looking in through the window of a building without obvious doors. This change pairs especially nicely with the self-registration ... check-in: cdb7f3b988 user: wyoung tags: login-on-post
Changes

Changes to src/forum.c.

969
970
971
972
973
974
975
976
977
978




979
980
981
982
983
984
985
  login_check_credentials();
  srchFlags = search_restrict(SRCH_FORUM);
  if( !g.perm.RdForum ){
    login_needed(g.anon.RdForum);
    return;
  }
  style_header("Forum");
  style_submenu_element("New Thread", g.perm.WrForum ?
      "%R/forumnew" :
      "%R/login");




  if( g.perm.ModForum && moderation_needed() ){
    style_submenu_element("Moderation Requests", "%R/modreq");
  }
  if( (srchFlags & SRCH_FORUM)!=0 ){
    if( search_screen(SRCH_FORUM, 0) ){
      style_submenu_element("Recent Threads","%R/forum");
      style_footer();







|
|
|
>
>
>
>







969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
  login_check_credentials();
  srchFlags = search_restrict(SRCH_FORUM);
  if( !g.perm.RdForum ){
    login_needed(g.anon.RdForum);
    return;
  }
  style_header("Forum");
  {
    /* 2-step split required by some GCCs, which think this first
     * expression "has non-constant format".  Whatever GCC...
     */
    const char* target = g.perm.WrForum ? "%R/forumnew" : "%R/login";
    style_submenu_element("New Thread", target);
  }
  if( g.perm.ModForum && moderation_needed() ){
    style_submenu_element("Moderation Requests", "%R/modreq");
  }
  if( (srchFlags & SRCH_FORUM)!=0 ){
    if( search_screen(SRCH_FORUM, 0) ){
      style_submenu_element("Recent Threads","%R/forum");
      style_footer();